Re: [PATCH 2/2] perf probe: Remove stale func add_perf_probe_events

[Ravi Bangoria]

Thanks Masami for the review,

On Wednesday 08 March 2017 03:13 PM, Masami Hiramatsu wrote:
> On Wed,  8 Mar 2017 12:29:08 +0530
> Ravi Bangoria  wrote:
>
>> I don't see any user of this function. This function was being copied
>> to tools/perf/builtin-probe.c by commit b02137cc6550 ("perf probe: Move
>> print logic into cmd_probe()"). Since then it has became stale.
> Hmm, I have intended to keep it as an library API, which allows 
> user to add event silently (e.g. adding sdt event in background).

Makes sense. Dropping it.

-Ravi

Re: [PATCH 2/2] perf probe: Remove stale func add_perf_probe_events

[Ravi Bangoria]

Thanks Masami for the review,

On Wednesday 08 March 2017 03:13 PM, Masami Hiramatsu wrote:
> On Wed,  8 Mar 2017 12:29:08 +0530
> Ravi Bangoria  wrote:
>
>> I don't see any user of this function. This function was being copied
>> to tools/perf/builtin-probe.c by commit b02137cc6550 ("perf probe: Move
>> print logic into cmd_probe()"). Since then it has became stale.
> Hmm, I have intended to keep it as an library API, which allows 
> user to add event silently (e.g. adding sdt event in background).

Makes sense. Dropping it.

-Ravi

Re: [PATCH 2/2] perf probe: Remove stale func add_perf_probe_events

[Masami Hiramatsu]

On Wed,  8 Mar 2017 12:29:08 +0530
Ravi Bangoria  wrote:

> I don't see any user of this function. This function was being copied
> to tools/perf/builtin-probe.c by commit b02137cc6550 ("perf probe: Move
> print logic into cmd_probe()"). Since then it has became stale.

Hmm, I have intended to keep it as an library API, which allows 
user to add event silently (e.g. adding sdt event in background).

Thanks,

> 
> Signed-off-by: Ravi Bangoria 
> ---
>  tools/perf/util/probe-event.c | 18 --
>  1 file changed, 18 deletions(-)
> 
> diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
> index 4f9d6ee..9f18204 100644
> --- a/tools/perf/util/probe-event.c
> +++ b/tools/perf/util/probe-event.c
> @@ -3361,24 +3361,6 @@ void cleanup_perf_probe_events(struct perf_probe_event 
> *pevs, int npevs)
>   }
>  }
>  
> -int add_perf_probe_events(struct perf_probe_event *pevs, int npevs)
> -{
> - int ret;
> -
> - ret = init_probe_symbol_maps(pevs->uprobes);
> - if (ret < 0)
> - return ret;
> -
> - ret = convert_perf_probe_events(pevs, npevs);
> - if (ret == 0)
> - ret = apply_perf_probe_events(pevs, npevs);
> -
> - cleanup_perf_probe_events(pevs, npevs);
> -
> - exit_probe_symbol_maps();
> - return ret;
> -}
> -
>  int del_perf_probe_events(struct strfilter *filter)
>  {
>   int ret, ret2, ufd = -1, kfd = -1;
> -- 
> 2.9.3
> 


-- 
Masami Hiramatsu 

Re: [PATCH 2/2] perf probe: Remove stale func add_perf_probe_events

[Masami Hiramatsu]

On Wed,  8 Mar 2017 12:29:08 +0530
Ravi Bangoria  wrote:

> I don't see any user of this function. This function was being copied
> to tools/perf/builtin-probe.c by commit b02137cc6550 ("perf probe: Move
> print logic into cmd_probe()"). Since then it has became stale.

Hmm, I have intended to keep it as an library API, which allows 
user to add event silently (e.g. adding sdt event in background).

Thanks,

> 
> Signed-off-by: Ravi Bangoria 
> ---
>  tools/perf/util/probe-event.c | 18 --
>  1 file changed, 18 deletions(-)
> 
> diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
> index 4f9d6ee..9f18204 100644
> --- a/tools/perf/util/probe-event.c
> +++ b/tools/perf/util/probe-event.c
> @@ -3361,24 +3361,6 @@ void cleanup_perf_probe_events(struct perf_probe_event 
> *pevs, int npevs)
>   }
>  }
>  
> -int add_perf_probe_events(struct perf_probe_event *pevs, int npevs)
> -{
> - int ret;
> -
> - ret = init_probe_symbol_maps(pevs->uprobes);
> - if (ret < 0)
> - return ret;
> -
> - ret = convert_perf_probe_events(pevs, npevs);
> - if (ret == 0)
> - ret = apply_perf_probe_events(pevs, npevs);
> -
> - cleanup_perf_probe_events(pevs, npevs);
> -
> - exit_probe_symbol_maps();
> - return ret;
> -}
> -
>  int del_perf_probe_events(struct strfilter *filter)
>  {
>   int ret, ret2, ufd = -1, kfd = -1;
> -- 
> 2.9.3
> 


-- 
Masami Hiramatsu