Re: [PATCH 2/2] xen/gntdev.c: Convert get_user_pages*() to pin_user_pages*()
On 9/29/20 10:14 PM, Souptick Joarder wrote: > On Tue, Sep 29, 2020 at 6:00 PM wrote: >> >> >> On 9/29/20 8:09 AM, Souptick Joarder wrote: >>> On Fri, Sep 11, 2020 at 8:12 PM wrote: On 9/6/20 2:51 AM, Souptick Joarder wrote: > In 2019, we introduced pin_user_pages*() and now we are converting > get_user_pages*() to the new API as appropriate. [1] & [2] could > be referred for more information. This is case 5 as per document [1]. > > [1] Documentation/core-api/pin_user_pages.rst > > [2] "Explicit pinning of user-space pages": > https://lwn.net/Articles/807108/ > > Signed-off-by: Souptick Joarder > Cc: John Hubbard > Cc: Boris Ostrovsky > Cc: Juergen Gross > Cc: David Vrabel Reviewed-by: Boris Ostrovsky >>> Are these 2 patches queued for 5.10-rc1 ? >> >> >> Yes, I am preparing the branch. (BTW, your second patch appears to have been >> either manually edited or not generated on top of the first patch. Please >> don't do this next time) > > I created it on top of the first one and didn't edit manually. > I was able to apply it in my local repository. > What was the error ? > Patch 1: + if (batch->writeable && !PageDirty(batch->pages[i])) Patch 2: - if(batch->writeable && !PageDirty(batch->pages[i])) This doesn't look to me like usual whitespace damage in-flight. Anyway, this has been applied to for-linus-5.10 -boris
Re: [PATCH 2/2] xen/gntdev.c: Convert get_user_pages*() to pin_user_pages*()
On Tue, Sep 29, 2020 at 6:00 PM wrote: > > > On 9/29/20 8:09 AM, Souptick Joarder wrote: > > On Fri, Sep 11, 2020 at 8:12 PM wrote: > >> > >> On 9/6/20 2:51 AM, Souptick Joarder wrote: > >>> In 2019, we introduced pin_user_pages*() and now we are converting > >>> get_user_pages*() to the new API as appropriate. [1] & [2] could > >>> be referred for more information. This is case 5 as per document [1]. > >>> > >>> [1] Documentation/core-api/pin_user_pages.rst > >>> > >>> [2] "Explicit pinning of user-space pages": > >>> https://lwn.net/Articles/807108/ > >>> > >>> Signed-off-by: Souptick Joarder > >>> Cc: John Hubbard > >>> Cc: Boris Ostrovsky > >>> Cc: Juergen Gross > >>> Cc: David Vrabel > >> > >> Reviewed-by: Boris Ostrovsky > > Are these 2 patches queued for 5.10-rc1 ? > > > Yes, I am preparing the branch. (BTW, your second patch appears to have been > either manually edited or not generated on top of the first patch. Please > don't do this next time) I created it on top of the first one and didn't edit manually. I was able to apply it in my local repository. What was the error ?
Re: [PATCH 2/2] xen/gntdev.c: Convert get_user_pages*() to pin_user_pages*()
On 9/29/20 8:09 AM, Souptick Joarder wrote: > On Fri, Sep 11, 2020 at 8:12 PM wrote: >> >> On 9/6/20 2:51 AM, Souptick Joarder wrote: >>> In 2019, we introduced pin_user_pages*() and now we are converting >>> get_user_pages*() to the new API as appropriate. [1] & [2] could >>> be referred for more information. This is case 5 as per document [1]. >>> >>> [1] Documentation/core-api/pin_user_pages.rst >>> >>> [2] "Explicit pinning of user-space pages": >>> https://lwn.net/Articles/807108/ >>> >>> Signed-off-by: Souptick Joarder >>> Cc: John Hubbard >>> Cc: Boris Ostrovsky >>> Cc: Juergen Gross >>> Cc: David Vrabel >> >> Reviewed-by: Boris Ostrovsky > Are these 2 patches queued for 5.10-rc1 ? Yes, I am preparing the branch. (BTW, your second patch appears to have been either manually edited or not generated on top of the first patch. Please don't do this next time) -boris
Re: [PATCH 2/2] xen/gntdev.c: Convert get_user_pages*() to pin_user_pages*()
On Fri, Sep 11, 2020 at 8:12 PM wrote: > > > On 9/6/20 2:51 AM, Souptick Joarder wrote: > > In 2019, we introduced pin_user_pages*() and now we are converting > > get_user_pages*() to the new API as appropriate. [1] & [2] could > > be referred for more information. This is case 5 as per document [1]. > > > > [1] Documentation/core-api/pin_user_pages.rst > > > > [2] "Explicit pinning of user-space pages": > > https://lwn.net/Articles/807108/ > > > > Signed-off-by: Souptick Joarder > > Cc: John Hubbard > > Cc: Boris Ostrovsky > > Cc: Juergen Gross > > Cc: David Vrabel > > > Reviewed-by: Boris Ostrovsky Are these 2 patches queued for 5.10-rc1 ? > >
Re: [PATCH 2/2] xen/gntdev.c: Convert get_user_pages*() to pin_user_pages*()
On 9/6/20 2:51 AM, Souptick Joarder wrote: > In 2019, we introduced pin_user_pages*() and now we are converting > get_user_pages*() to the new API as appropriate. [1] & [2] could > be referred for more information. This is case 5 as per document [1]. > > [1] Documentation/core-api/pin_user_pages.rst > > [2] "Explicit pinning of user-space pages": > https://lwn.net/Articles/807108/ > > Signed-off-by: Souptick Joarder > Cc: John Hubbard > Cc: Boris Ostrovsky > Cc: Juergen Gross > Cc: David Vrabel Reviewed-by: Boris Ostrovsky
