Re: [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420
Javier, On Wed, Jul 9, 2014 at 10:46 AM, Javier Martinez Canillas wrote: > Hello Doug, > > On Wed, Jul 9, 2014 at 6:01 PM, Doug Anderson wrote: >> Javier, >> >> On Wed, Jul 9, 2014 at 6:03 AM, Javier Martinez Canillas >> wrote: >>> Hello Tushar, >>> >>> On Wed, Jul 9, 2014 at 2:11 PM, Tushar Behera wrote: On 07/09/2014 03:44 PM, Javier Martinez Canillas wrote: > Hello Tushar, > > On Tue, Jul 8, 2014 at 5:00 AM, Tushar Behera wrote: The u-boot version is a little different on my Peach-Pi as compared to the market release version. Not sure if that is making any difference. Peach # version U-Boot 2013.04 (Feb 13 2014 - 16:35:03) for Peach armv7a-cros-linux-gnueabi-gcc.real (4.8.1_cos_gg_feea904_4.8.1-r66) 4.8.x-google 20130905 (prerelease) GNU ld (binutils-2.22_cos_gg_2) 2.22 >>> > > I'm using the same U-Boot version than Kevin (U-Boot 2013.04-gb98ed09) > and on my setup using chained nv-uboot I also need patch 1/3 along > with 2/3 to fix the issue. > >>> Note that I've applied this only from this series so I'm not sure how >>> much the problem can be solved...any updates for 1/3 and 3/3? >>> >>> - Kukjin >> >> Thanks for applying 2/3. I am working on 1/3 to see if we are following >> the right approach to fix Kevin's issue (unfortunately, I am not hitting >> the bug on my board ATM). 3/3 has already been merged through a >> different patchset. >> > > I'm sending as an attachment my complete boot log when booting today's > next (20140709) until it hangs and my u-boot env vars. I hope that > helps. > Would you please check the behaviour after enabling following config options? diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig index e07a227..d6056ab 100644 --- a/arch/arm/configs/exynos_defconfig +++ b/arch/arm/configs/exynos_defconfig @@ -93,6 +93,11 @@ CONFIG_FRAMEBUFFER_CONSOLE=y CONFIG_FONTS=y CONFIG_FONT_7x14=y CONFIG_LOGO=y +CONFIG_SOUND=y +CONFIG_SND=y +CONFIG_SND_SOC=y +CONFIG_SND_SOC_SAMSUNG=y +CONFIG_SND_SOC_SNOW=y CONFIG_USB=y CONFIG_USB_EHCI_HCD=y CONFIG_USB_EHCI_EXYNOS=y @@ -109,6 +114,8 @@ CONFIG_MMC_DW_IDMAC=y CONFIG_MMC_DW_EXYNOS=y CONFIG_RTC_CLASS=y CONFIG_RTC_DRV_S3C=y +CONFIG_DMADEVICES=y +CONFIG_PL330_DMA=y CONFIG_COMMON_CLK_MAX77686=y CONFIG_EXT2_FS=y CONFIG_EXT3_FS=y >>> >>> With those Kconfig options enabled the kernel does not hang anymore so >>> patch 1/3 is not needed in that case. >> >> Just checking: did you happen to confirm whether it's the PL330 / >> DMADEVICES that fixes things or do you actually need the sound stuff? > > Sorry I should had mentioned this before. The DMADEVICES and PL330 > Kconfig are enough to avoid the kernel to hang, the sound config > options are not actually required. OK, makes sense. Possibly the correct fix is just a Kconfig change that somehow enforces that we have these two configs on. -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420
Hello Doug, On Wed, Jul 9, 2014 at 6:01 PM, Doug Anderson wrote: > Javier, > > On Wed, Jul 9, 2014 at 6:03 AM, Javier Martinez Canillas > wrote: >> Hello Tushar, >> >> On Wed, Jul 9, 2014 at 2:11 PM, Tushar Behera wrote: >>> On 07/09/2014 03:44 PM, Javier Martinez Canillas wrote: Hello Tushar, On Tue, Jul 8, 2014 at 5:00 AM, Tushar Behera wrote: >>> >>> The u-boot version is a little different on my Peach-Pi as compared to >>> the market release version. Not sure if that is making any difference. >>> >>> Peach # version >>> >>> U-Boot 2013.04 (Feb 13 2014 - 16:35:03) for Peach >>> armv7a-cros-linux-gnueabi-gcc.real (4.8.1_cos_gg_feea904_4.8.1-r66) >>> 4.8.x-google 20130905 (prerelease) >>> GNU ld (binutils-2.22_cos_gg_2) 2.22 >>> >> I'm using the same U-Boot version than Kevin (U-Boot 2013.04-gb98ed09) and on my setup using chained nv-uboot I also need patch 1/3 along with 2/3 to fix the issue. >> Note that I've applied this only from this series so I'm not sure how >> much the problem can be solved...any updates for 1/3 and 3/3? >> >> - Kukjin > > Thanks for applying 2/3. I am working on 1/3 to see if we are following > the right approach to fix Kevin's issue (unfortunately, I am not hitting > the bug on my board ATM). 3/3 has already been merged through a > different patchset. > I'm sending as an attachment my complete boot log when booting today's next (20140709) until it hangs and my u-boot env vars. I hope that helps. >>> >>> Would you please check the behaviour after enabling following config >>> options? >>> >>> diff --git a/arch/arm/configs/exynos_defconfig >>> b/arch/arm/configs/exynos_defconfig >>> index e07a227..d6056ab 100644 >>> --- a/arch/arm/configs/exynos_defconfig >>> +++ b/arch/arm/configs/exynos_defconfig >>> @@ -93,6 +93,11 @@ CONFIG_FRAMEBUFFER_CONSOLE=y >>> CONFIG_FONTS=y >>> CONFIG_FONT_7x14=y >>> CONFIG_LOGO=y >>> +CONFIG_SOUND=y >>> +CONFIG_SND=y >>> +CONFIG_SND_SOC=y >>> +CONFIG_SND_SOC_SAMSUNG=y >>> +CONFIG_SND_SOC_SNOW=y >>> CONFIG_USB=y >>> CONFIG_USB_EHCI_HCD=y >>> CONFIG_USB_EHCI_EXYNOS=y >>> @@ -109,6 +114,8 @@ CONFIG_MMC_DW_IDMAC=y >>> CONFIG_MMC_DW_EXYNOS=y >>> CONFIG_RTC_CLASS=y >>> CONFIG_RTC_DRV_S3C=y >>> +CONFIG_DMADEVICES=y >>> +CONFIG_PL330_DMA=y >>> CONFIG_COMMON_CLK_MAX77686=y >>> CONFIG_EXT2_FS=y >>> CONFIG_EXT3_FS=y >>> >>> >> >> With those Kconfig options enabled the kernel does not hang anymore so >> patch 1/3 is not needed in that case. > > Just checking: did you happen to confirm whether it's the PL330 / > DMADEVICES that fixes things or do you actually need the sound stuff? Sorry I should had mentioned this before. The DMADEVICES and PL330 Kconfig are enough to avoid the kernel to hang, the sound config options are not actually required. Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420
Javier, On Wed, Jul 9, 2014 at 6:03 AM, Javier Martinez Canillas wrote: > Hello Tushar, > > On Wed, Jul 9, 2014 at 2:11 PM, Tushar Behera wrote: >> On 07/09/2014 03:44 PM, Javier Martinez Canillas wrote: >>> Hello Tushar, >>> >>> On Tue, Jul 8, 2014 at 5:00 AM, Tushar Behera wrote: >> >> The u-boot version is a little different on my Peach-Pi as compared to >> the market release version. Not sure if that is making any difference. >> >> Peach # version >> >> U-Boot 2013.04 (Feb 13 2014 - 16:35:03) for Peach >> armv7a-cros-linux-gnueabi-gcc.real (4.8.1_cos_gg_feea904_4.8.1-r66) >> 4.8.x-google 20130905 (prerelease) >> GNU ld (binutils-2.22_cos_gg_2) 2.22 >> > >>> >>> I'm using the same U-Boot version than Kevin (U-Boot 2013.04-gb98ed09) >>> and on my setup using chained nv-uboot I also need patch 1/3 along >>> with 2/3 to fix the issue. >>> > Note that I've applied this only from this series so I'm not sure how > much the problem can be solved...any updates for 1/3 and 3/3? > > - Kukjin Thanks for applying 2/3. I am working on 1/3 to see if we are following the right approach to fix Kevin's issue (unfortunately, I am not hitting the bug on my board ATM). 3/3 has already been merged through a different patchset. >>> >>> I'm sending as an attachment my complete boot log when booting today's >>> next (20140709) until it hangs and my u-boot env vars. I hope that >>> helps. >>> >> >> Would you please check the behaviour after enabling following config >> options? >> >> diff --git a/arch/arm/configs/exynos_defconfig >> b/arch/arm/configs/exynos_defconfig >> index e07a227..d6056ab 100644 >> --- a/arch/arm/configs/exynos_defconfig >> +++ b/arch/arm/configs/exynos_defconfig >> @@ -93,6 +93,11 @@ CONFIG_FRAMEBUFFER_CONSOLE=y >> CONFIG_FONTS=y >> CONFIG_FONT_7x14=y >> CONFIG_LOGO=y >> +CONFIG_SOUND=y >> +CONFIG_SND=y >> +CONFIG_SND_SOC=y >> +CONFIG_SND_SOC_SAMSUNG=y >> +CONFIG_SND_SOC_SNOW=y >> CONFIG_USB=y >> CONFIG_USB_EHCI_HCD=y >> CONFIG_USB_EHCI_EXYNOS=y >> @@ -109,6 +114,8 @@ CONFIG_MMC_DW_IDMAC=y >> CONFIG_MMC_DW_EXYNOS=y >> CONFIG_RTC_CLASS=y >> CONFIG_RTC_DRV_S3C=y >> +CONFIG_DMADEVICES=y >> +CONFIG_PL330_DMA=y >> CONFIG_COMMON_CLK_MAX77686=y >> CONFIG_EXT2_FS=y >> CONFIG_EXT3_FS=y >> >> > > With those Kconfig options enabled the kernel does not hang anymore so > patch 1/3 is not needed in that case. Just checking: did you happen to confirm whether it's the PL330 / DMADEVICES that fixes things or do you actually need the sound stuff? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420
Hello Tushar, On Wed, Jul 9, 2014 at 2:11 PM, Tushar Behera wrote: > On 07/09/2014 03:44 PM, Javier Martinez Canillas wrote: >> Hello Tushar, >> >> On Tue, Jul 8, 2014 at 5:00 AM, Tushar Behera wrote: > > The u-boot version is a little different on my Peach-Pi as compared to > the market release version. Not sure if that is making any difference. > > Peach # version > > U-Boot 2013.04 (Feb 13 2014 - 16:35:03) for Peach > armv7a-cros-linux-gnueabi-gcc.real (4.8.1_cos_gg_feea904_4.8.1-r66) > 4.8.x-google 20130905 (prerelease) > GNU ld (binutils-2.22_cos_gg_2) 2.22 > >> >> I'm using the same U-Boot version than Kevin (U-Boot 2013.04-gb98ed09) >> and on my setup using chained nv-uboot I also need patch 1/3 along >> with 2/3 to fix the issue. >> Note that I've applied this only from this series so I'm not sure how much the problem can be solved...any updates for 1/3 and 3/3? - Kukjin >>> >>> Thanks for applying 2/3. I am working on 1/3 to see if we are following >>> the right approach to fix Kevin's issue (unfortunately, I am not hitting >>> the bug on my board ATM). 3/3 has already been merged through a >>> different patchset. >>> >> >> I'm sending as an attachment my complete boot log when booting today's >> next (20140709) until it hangs and my u-boot env vars. I hope that >> helps. >> > > Would you please check the behaviour after enabling following config > options? > > diff --git a/arch/arm/configs/exynos_defconfig > b/arch/arm/configs/exynos_defconfig > index e07a227..d6056ab 100644 > --- a/arch/arm/configs/exynos_defconfig > +++ b/arch/arm/configs/exynos_defconfig > @@ -93,6 +93,11 @@ CONFIG_FRAMEBUFFER_CONSOLE=y > CONFIG_FONTS=y > CONFIG_FONT_7x14=y > CONFIG_LOGO=y > +CONFIG_SOUND=y > +CONFIG_SND=y > +CONFIG_SND_SOC=y > +CONFIG_SND_SOC_SAMSUNG=y > +CONFIG_SND_SOC_SNOW=y > CONFIG_USB=y > CONFIG_USB_EHCI_HCD=y > CONFIG_USB_EHCI_EXYNOS=y > @@ -109,6 +114,8 @@ CONFIG_MMC_DW_IDMAC=y > CONFIG_MMC_DW_EXYNOS=y > CONFIG_RTC_CLASS=y > CONFIG_RTC_DRV_S3C=y > +CONFIG_DMADEVICES=y > +CONFIG_PL330_DMA=y > CONFIG_COMMON_CLK_MAX77686=y > CONFIG_EXT2_FS=y > CONFIG_EXT3_FS=y > > With those Kconfig options enabled the kernel does not hang anymore so patch 1/3 is not needed in that case. Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420
On 07/09/2014 03:44 PM, Javier Martinez Canillas wrote: > Hello Tushar, > > On Tue, Jul 8, 2014 at 5:00 AM, Tushar Behera wrote: The u-boot version is a little different on my Peach-Pi as compared to the market release version. Not sure if that is making any difference. Peach # version U-Boot 2013.04 (Feb 13 2014 - 16:35:03) for Peach armv7a-cros-linux-gnueabi-gcc.real (4.8.1_cos_gg_feea904_4.8.1-r66) 4.8.x-google 20130905 (prerelease) GNU ld (binutils-2.22_cos_gg_2) 2.22 >>> > > I'm using the same U-Boot version than Kevin (U-Boot 2013.04-gb98ed09) > and on my setup using chained nv-uboot I also need patch 1/3 along > with 2/3 to fix the issue. > >>> Note that I've applied this only from this series so I'm not sure how >>> much the problem can be solved...any updates for 1/3 and 3/3? >>> >>> - Kukjin >> >> Thanks for applying 2/3. I am working on 1/3 to see if we are following >> the right approach to fix Kevin's issue (unfortunately, I am not hitting >> the bug on my board ATM). 3/3 has already been merged through a >> different patchset. >> > > I'm sending as an attachment my complete boot log when booting today's > next (20140709) until it hangs and my u-boot env vars. I hope that > helps. > Would you please check the behaviour after enabling following config options? diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig index e07a227..d6056ab 100644 --- a/arch/arm/configs/exynos_defconfig +++ b/arch/arm/configs/exynos_defconfig @@ -93,6 +93,11 @@ CONFIG_FRAMEBUFFER_CONSOLE=y CONFIG_FONTS=y CONFIG_FONT_7x14=y CONFIG_LOGO=y +CONFIG_SOUND=y +CONFIG_SND=y +CONFIG_SND_SOC=y +CONFIG_SND_SOC_SAMSUNG=y +CONFIG_SND_SOC_SNOW=y CONFIG_USB=y CONFIG_USB_EHCI_HCD=y CONFIG_USB_EHCI_EXYNOS=y @@ -109,6 +114,8 @@ CONFIG_MMC_DW_IDMAC=y CONFIG_MMC_DW_EXYNOS=y CONFIG_RTC_CLASS=y CONFIG_RTC_DRV_S3C=y +CONFIG_DMADEVICES=y +CONFIG_PL330_DMA=y CONFIG_COMMON_CLK_MAX77686=y CONFIG_EXT2_FS=y CONFIG_EXT3_FS=y >> -- >> Tushar Behera >> -- > > Best regards, > Javier > -- Tushar Behera -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420
Hello Tushar, On Tue, Jul 8, 2014 at 5:00 AM, Tushar Behera wrote: >>> >>> The u-boot version is a little different on my Peach-Pi as compared to >>> the market release version. Not sure if that is making any difference. >>> >>> Peach # version >>> >>> U-Boot 2013.04 (Feb 13 2014 - 16:35:03) for Peach >>> armv7a-cros-linux-gnueabi-gcc.real (4.8.1_cos_gg_feea904_4.8.1-r66) >>> 4.8.x-google 20130905 (prerelease) >>> GNU ld (binutils-2.22_cos_gg_2) 2.22 >>> >> I'm using the same U-Boot version than Kevin (U-Boot 2013.04-gb98ed09) and on my setup using chained nv-uboot I also need patch 1/3 along with 2/3 to fix the issue. >> Note that I've applied this only from this series so I'm not sure how >> much the problem can be solved...any updates for 1/3 and 3/3? >> >> - Kukjin > > Thanks for applying 2/3. I am working on 1/3 to see if we are following > the right approach to fix Kevin's issue (unfortunately, I am not hitting > the bug on my board ATM). 3/3 has already been merged through a > different patchset. > I'm sending as an attachment my complete boot log when booting today's next (20140709) until it hangs and my u-boot env vars. I hope that helps. > -- > Tushar Behera > -- Best regards, Javier boot_log Description: Binary data uboot_env Description: Binary data
Re: [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420
On 07/08/2014 05:04 AM, Kukjin Kim wrote: > On 07/01/14 20:59, Tushar Behera wrote: >> On 06/27/2014 08:18 PM, Kevin Hilman wrote: >>> On Fri, Jun 27, 2014 at 7:18 AM, Kevin Hilman >>> wrote: On Thu, Jun 26, 2014 at 8:38 PM, Tushar Behera wrote: > Would you please provide me the environment setting of your u-boot? > U-boot environment on my board has been over-written, I would like to > set it same as yours and try to reproduce the issue at my end. With > only > 'sound init', I don't seem to hit this issue anymore. Attached is a full boot log using v3.16-rc2 with my patch adding CLK_IGNORE_UNUSED to mau_epll and Doug's aclk66_peric patch. In the boot log, you'll see the output of 'printenv' inside u-boot where the environment is dumped. >>> >>> Oops, I sent you a boot log for the octa board. Here's the one for >>> peach-pi with the same kernel (built with upstream exynos_defconfig) >>> >>> Kevin >>> >> >> The u-boot version is a little different on my Peach-Pi as compared to >> the market release version. Not sure if that is making any difference. >> >> Peach # version >> >> U-Boot 2013.04 (Feb 13 2014 - 16:35:03) for Peach >> armv7a-cros-linux-gnueabi-gcc.real (4.8.1_cos_gg_feea904_4.8.1-r66) >> 4.8.x-google 20130905 (prerelease) >> GNU ld (binutils-2.22_cos_gg_2) 2.22 >> > > Note that I've applied this only from this series so I'm not sure how > much the problem can be solved...any updates for 1/3 and 3/3? > > - Kukjin Thanks for applying 2/3. I am working on 1/3 to see if we are following the right approach to fix Kevin's issue (unfortunately, I am not hitting the bug on my board ATM). 3/3 has already been merged through a different patchset. -- Tushar Behera -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420
On 07/01/14 20:59, Tushar Behera wrote: On 06/27/2014 08:18 PM, Kevin Hilman wrote: On Fri, Jun 27, 2014 at 7:18 AM, Kevin Hilman wrote: On Thu, Jun 26, 2014 at 8:38 PM, Tushar Behera wrote: Would you please provide me the environment setting of your u-boot? U-boot environment on my board has been over-written, I would like to set it same as yours and try to reproduce the issue at my end. With only 'sound init', I don't seem to hit this issue anymore. Attached is a full boot log using v3.16-rc2 with my patch adding CLK_IGNORE_UNUSED to mau_epll and Doug's aclk66_peric patch. In the boot log, you'll see the output of 'printenv' inside u-boot where the environment is dumped. Oops, I sent you a boot log for the octa board. Here's the one for peach-pi with the same kernel (built with upstream exynos_defconfig) Kevin The u-boot version is a little different on my Peach-Pi as compared to the market release version. Not sure if that is making any difference. Peach # version U-Boot 2013.04 (Feb 13 2014 - 16:35:03) for Peach armv7a-cros-linux-gnueabi-gcc.real (4.8.1_cos_gg_feea904_4.8.1-r66) 4.8.x-google 20130905 (prerelease) GNU ld (binutils-2.22_cos_gg_2) 2.22 Note that I've applied this only from this series so I'm not sure how much the problem can be solved...any updates for 1/3 and 3/3? - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420
On 06/27/2014 08:18 PM, Kevin Hilman wrote: > On Fri, Jun 27, 2014 at 7:18 AM, Kevin Hilman wrote: >> On Thu, Jun 26, 2014 at 8:38 PM, Tushar Behera wrote: >> >>> Would you please provide me the environment setting of your u-boot? >>> U-boot environment on my board has been over-written, I would like to >>> set it same as yours and try to reproduce the issue at my end. With only >>> 'sound init', I don't seem to hit this issue anymore. >> >> Attached is a full boot log using v3.16-rc2 with my patch adding >> CLK_IGNORE_UNUSED to mau_epll and Doug's aclk66_peric patch. In the >> boot log, you'll see the output of 'printenv' inside u-boot where the >> environment is dumped. > > Oops, I sent you a boot log for the octa board. Here's the one for > peach-pi with the same kernel (built with upstream exynos_defconfig) > > Kevin > The u-boot version is a little different on my Peach-Pi as compared to the market release version. Not sure if that is making any difference. Peach # version U-Boot 2013.04 (Feb 13 2014 - 16:35:03) for Peach armv7a-cros-linux-gnueabi-gcc.real (4.8.1_cos_gg_feea904_4.8.1-r66) 4.8.x-google 20130905 (prerelease) GNU ld (binutils-2.22_cos_gg_2) 2.22 -- Tushar Behera -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420
On Fri, Jun 27, 2014 at 7:18 AM, Kevin Hilman wrote: > On Thu, Jun 26, 2014 at 8:38 PM, Tushar Behera wrote: > >> Would you please provide me the environment setting of your u-boot? >> U-boot environment on my board has been over-written, I would like to >> set it same as yours and try to reproduce the issue at my end. With only >> 'sound init', I don't seem to hit this issue anymore. > > Attached is a full boot log using v3.16-rc2 with my patch adding > CLK_IGNORE_UNUSED to mau_epll and Doug's aclk66_peric patch. In the > boot log, you'll see the output of 'printenv' inside u-boot where the > environment is dumped. Oops, I sent you a boot log for the octa board. Here's the one for peach-pi with the same kernel (built with upstream exynos_defconfig) Kevin boot-chromebook2.log.gz Description: GNU Zip compressed data
Re: [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420
On Thu, Jun 26, 2014 at 8:38 PM, Tushar Behera wrote: > Would you please provide me the environment setting of your u-boot? > U-boot environment on my board has been over-written, I would like to > set it same as yours and try to reproduce the issue at my end. With only > 'sound init', I don't seem to hit this issue anymore. Attached is a full boot log using v3.16-rc2 with my patch adding CLK_IGNORE_UNUSED to mau_epll and Doug's aclk66_peric patch. In the boot log, you'll see the output of 'printenv' inside u-boot where the environment is dumped. Hope that helps, Kevin boot-octa.log.gz Description: GNU Zip compressed data
Re: [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420
On 06/26/2014 09:38 PM, Kevin Hilman wrote:
> Tushar Behera writes:
>
>> On Thu, Jun 26, 2014 at 4:51 AM, Kevin Hilman wrote:
>>> Doug Anderson writes:
>>>
Tushar,
On Tue, Jun 10, 2014 at 10:32 PM, Tushar Behera
wrote:
> Currently CLK_FOUT_EPLL was set as one of the parents of AUDSS mux.
> As per the user manual, it should be CLK_MAU_EPLL.
>
> The problem surfaced when the bootloader in Peach-pit board set
> the EPLL clock as the parent of AUDSS mux. While booting the kernel,
> we used to get a system hang during late boot if CLK_MAU_EPLL was
> disabled.
>
> Signed-off-by: Tushar Behera
> Signed-off-by: Shaik Ameer Basha
> Reported-by: Kevin Hilman
> ---
> arch/arm/boot/dts/exynos5420.dtsi |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I've tested this myself now as well.
Tested-by: Doug Anderson
>>>
>>> For me, this patch alone (on top of -next) doesn't solve the boot hang.
>>> I still need clk_ignore_unused for a successful boot.
>>>
>>> So, this patch might be correct, but it doesn't prevent a boot hang
>>> using a chain-loaded nv_uboot on peach-pi. There's still another clock
>>> being disabled that causes a hang.
>>>
>>> Kevin
>>
>> Kevin,
>>
>> Can you please check if adding patch 1/3 alongwith patch 2/3 fixes the
>> issue for you?
>
> Yes, using patch 1/3 along with 2/3 fixes the issue.
>
Okay, that adds some more reason to re-investigate patch 1/3.
Kevin,
Would you please provide me the environment setting of your u-boot?
U-boot environment on my board has been over-written, I would like to
set it same as yours and try to reproduce the issue at my end. With only
'sound init', I don't seem to hit this issue anymore.
>> Also can you please confirm that setting CLK_IGNORE_UNUSED flag
>> CLK_MAU_EPLL alone fixes the issue, without any need for
>> clk_ignore_unused in u-boot bootargs?
>
> Yes, I have this patch[1] in my local branch which fixes the issue
> alone, without clk_ignore_unused on the command line.
>
> Kevin
>
>
> [1]
> From ab1627127730ef4507ce96cbf95047d626bbb53f Mon Sep 17 00:00:00 2001
> From: Kevin Hilman
> Date: Thu, 5 Jun 2014 17:12:28 -0700
> Subject: [PATCH] KJH: leave mau_epll enabled
>
> ---
> drivers/clk/samsung/clk-exynos5420.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/samsung/clk-exynos5420.c
> b/drivers/clk/samsung/clk-exynos5420.c
> index 61eccf0dd72f..ed175088ee7e 100644
> --- a/drivers/clk/samsung/clk-exynos5420.c
> +++ b/drivers/clk/samsung/clk-exynos5420.c
> @@ -911,7 +911,7 @@ static struct samsung_gate_clock exynos5x_gate_clks[]
> __initdata = {
> SRC_MASK_TOP2, 24, 0, 0),
>
> GATE(CLK_MAU_EPLL, "mau_epll", "mout_mau_epll_clk",
> - SRC_MASK_TOP7, 20, 0, 0),
> + SRC_MASK_TOP7, 20, CLK_IGNORE_UNUSED, 0),
>
> /* sclk */
> GATE(CLK_SCLK_UART0, "sclk_uart0", "dout_uart0",
>
--
Tushar Behera
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420
Tushar Behera writes:
> On Thu, Jun 26, 2014 at 4:51 AM, Kevin Hilman wrote:
>> Doug Anderson writes:
>>
>>> Tushar,
>>>
>>> On Tue, Jun 10, 2014 at 10:32 PM, Tushar Behera
>>> wrote:
Currently CLK_FOUT_EPLL was set as one of the parents of AUDSS mux.
As per the user manual, it should be CLK_MAU_EPLL.
The problem surfaced when the bootloader in Peach-pit board set
the EPLL clock as the parent of AUDSS mux. While booting the kernel,
we used to get a system hang during late boot if CLK_MAU_EPLL was
disabled.
Signed-off-by: Tushar Behera
Signed-off-by: Shaik Ameer Basha
Reported-by: Kevin Hilman
---
arch/arm/boot/dts/exynos5420.dtsi |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> I've tested this myself now as well.
>>>
>>> Tested-by: Doug Anderson
>>
>> For me, this patch alone (on top of -next) doesn't solve the boot hang.
>> I still need clk_ignore_unused for a successful boot.
>>
>> So, this patch might be correct, but it doesn't prevent a boot hang
>> using a chain-loaded nv_uboot on peach-pi. There's still another clock
>> being disabled that causes a hang.
>>
>> Kevin
>
> Kevin,
>
> Can you please check if adding patch 1/3 alongwith patch 2/3 fixes the
> issue for you?
Yes, using patch 1/3 along with 2/3 fixes the issue.
> Also can you please confirm that setting CLK_IGNORE_UNUSED flag
> CLK_MAU_EPLL alone fixes the issue, without any need for
> clk_ignore_unused in u-boot bootargs?
Yes, I have this patch[1] in my local branch which fixes the issue
alone, without clk_ignore_unused on the command line.
Kevin
[1]
>From ab1627127730ef4507ce96cbf95047d626bbb53f Mon Sep 17 00:00:00 2001
From: Kevin Hilman
Date: Thu, 5 Jun 2014 17:12:28 -0700
Subject: [PATCH] KJH: leave mau_epll enabled
---
drivers/clk/samsung/clk-exynos5420.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/samsung/clk-exynos5420.c
b/drivers/clk/samsung/clk-exynos5420.c
index 61eccf0dd72f..ed175088ee7e 100644
--- a/drivers/clk/samsung/clk-exynos5420.c
+++ b/drivers/clk/samsung/clk-exynos5420.c
@@ -911,7 +911,7 @@ static struct samsung_gate_clock exynos5x_gate_clks[]
__initdata = {
SRC_MASK_TOP2, 24, 0, 0),
GATE(CLK_MAU_EPLL, "mau_epll", "mout_mau_epll_clk",
- SRC_MASK_TOP7, 20, 0, 0),
+ SRC_MASK_TOP7, 20, CLK_IGNORE_UNUSED, 0),
/* sclk */
GATE(CLK_SCLK_UART0, "sclk_uart0", "dout_uart0",
--
1.9.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420
On Thu, Jun 26, 2014 at 4:51 AM, Kevin Hilman wrote: > Doug Anderson writes: > >> Tushar, >> >> On Tue, Jun 10, 2014 at 10:32 PM, Tushar Behera wrote: >>> Currently CLK_FOUT_EPLL was set as one of the parents of AUDSS mux. >>> As per the user manual, it should be CLK_MAU_EPLL. >>> >>> The problem surfaced when the bootloader in Peach-pit board set >>> the EPLL clock as the parent of AUDSS mux. While booting the kernel, >>> we used to get a system hang during late boot if CLK_MAU_EPLL was >>> disabled. >>> >>> Signed-off-by: Tushar Behera >>> Signed-off-by: Shaik Ameer Basha >>> Reported-by: Kevin Hilman >>> --- >>> arch/arm/boot/dts/exynos5420.dtsi |2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> I've tested this myself now as well. >> >> Tested-by: Doug Anderson > > For me, this patch alone (on top of -next) doesn't solve the boot hang. > I still need clk_ignore_unused for a successful boot. > > So, this patch might be correct, but it doesn't prevent a boot hang > using a chain-loaded nv_uboot on peach-pi. There's still another clock > being disabled that causes a hang. > > Kevin Kevin, Can you please check if adding patch 1/3 alongwith patch 2/3 fixes the issue for you? Also can you please confirm that setting CLK_IGNORE_UNUSED flag CLK_MAU_EPLL alone fixes the issue, without any need for clk_ignore_unused in u-boot bootargs? -- Tushar Behera -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420
Doug Anderson writes: > Tushar, > > On Tue, Jun 10, 2014 at 10:32 PM, Tushar Behera wrote: >> Currently CLK_FOUT_EPLL was set as one of the parents of AUDSS mux. >> As per the user manual, it should be CLK_MAU_EPLL. >> >> The problem surfaced when the bootloader in Peach-pit board set >> the EPLL clock as the parent of AUDSS mux. While booting the kernel, >> we used to get a system hang during late boot if CLK_MAU_EPLL was >> disabled. >> >> Signed-off-by: Tushar Behera >> Signed-off-by: Shaik Ameer Basha >> Reported-by: Kevin Hilman >> --- >> arch/arm/boot/dts/exynos5420.dtsi |2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > I've tested this myself now as well. > > Tested-by: Doug Anderson For me, this patch alone (on top of -next) doesn't solve the boot hang. I still need clk_ignore_unused for a successful boot. So, this patch might be correct, but it doesn't prevent a boot hang using a chain-loaded nv_uboot on peach-pi. There's still another clock being disabled that causes a hang. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420
Tushar, On Tue, Jun 10, 2014 at 10:32 PM, Tushar Behera wrote: > Currently CLK_FOUT_EPLL was set as one of the parents of AUDSS mux. > As per the user manual, it should be CLK_MAU_EPLL. > > The problem surfaced when the bootloader in Peach-pit board set > the EPLL clock as the parent of AUDSS mux. While booting the kernel, > we used to get a system hang during late boot if CLK_MAU_EPLL was > disabled. > > Signed-off-by: Tushar Behera > Signed-off-by: Shaik Ameer Basha > Reported-by: Kevin Hilman > --- > arch/arm/boot/dts/exynos5420.dtsi |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I've tested this myself now as well. Tested-by: Doug Anderson -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420
On Mon, Jun 16, 2014 at 4:56 PM, Tushar Behera wrote: > On 06/11/2014 09:28 PM, Javier Martinez Canillas wrote: >> On Wed, Jun 11, 2014 at 7:32 AM, Tushar Behera wrote: >>> Currently CLK_FOUT_EPLL was set as one of the parents of AUDSS mux. >>> As per the user manual, it should be CLK_MAU_EPLL. >>> >>> The problem surfaced when the bootloader in Peach-pit board set >>> the EPLL clock as the parent of AUDSS mux. While booting the kernel, >>> we used to get a system hang during late boot if CLK_MAU_EPLL was >>> disabled. >>> >>> Signed-off-by: Tushar Behera >>> Signed-off-by: Shaik Ameer Basha >>> Reported-by: Kevin Hilman >>> --- >>> arch/arm/boot/dts/exynos5420.dtsi |2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm/boot/dts/exynos5420.dtsi >>> b/arch/arm/boot/dts/exynos5420.dtsi >>> index e385322..79e9119 100644 >>> --- a/arch/arm/boot/dts/exynos5420.dtsi >>> +++ b/arch/arm/boot/dts/exynos5420.dtsi >>> @@ -167,7 +167,7 @@ >>> compatible = "samsung,exynos5420-audss-clock"; >>> reg = <0x0381 0x0C>; >>> #clock-cells = <1>; >>> - clocks = <&clock CLK_FIN_PLL>, <&clock CLK_FOUT_EPLL>, >>> + clocks = <&clock CLK_FIN_PLL>, <&clock CLK_MAU_EPLL>, >>> <&clock CLK_SCLK_MAUDIO0>, <&clock >>> CLK_SCLK_MAUPCM0>; >>> clock-names = "pll_ref", "pll_in", "sclk_audio", >>> "sclk_pcm_in"; >>> }; >>> -- >>> 1.7.9.5 >>> >>> -- >> >> Tested-by: Javier Martinez Canillas >> > > Kukjin, > > Would you please take this patch as a fix for 3.16? > > -- > Tushar Behera Kukjin, Please pick this patch for 3.16. This is an essential fix required for Peach-pit/Peach-pi board. -- Tushar Behera -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420
On 06/11/2014 09:28 PM, Javier Martinez Canillas wrote: > On Wed, Jun 11, 2014 at 7:32 AM, Tushar Behera wrote: >> Currently CLK_FOUT_EPLL was set as one of the parents of AUDSS mux. >> As per the user manual, it should be CLK_MAU_EPLL. >> >> The problem surfaced when the bootloader in Peach-pit board set >> the EPLL clock as the parent of AUDSS mux. While booting the kernel, >> we used to get a system hang during late boot if CLK_MAU_EPLL was >> disabled. >> >> Signed-off-by: Tushar Behera >> Signed-off-by: Shaik Ameer Basha >> Reported-by: Kevin Hilman >> --- >> arch/arm/boot/dts/exynos5420.dtsi |2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/exynos5420.dtsi >> b/arch/arm/boot/dts/exynos5420.dtsi >> index e385322..79e9119 100644 >> --- a/arch/arm/boot/dts/exynos5420.dtsi >> +++ b/arch/arm/boot/dts/exynos5420.dtsi >> @@ -167,7 +167,7 @@ >> compatible = "samsung,exynos5420-audss-clock"; >> reg = <0x0381 0x0C>; >> #clock-cells = <1>; >> - clocks = <&clock CLK_FIN_PLL>, <&clock CLK_FOUT_EPLL>, >> + clocks = <&clock CLK_FIN_PLL>, <&clock CLK_MAU_EPLL>, >> <&clock CLK_SCLK_MAUDIO0>, <&clock >> CLK_SCLK_MAUPCM0>; >> clock-names = "pll_ref", "pll_in", "sclk_audio", >> "sclk_pcm_in"; >> }; >> -- >> 1.7.9.5 >> >> -- > > Tested-by: Javier Martinez Canillas > Kukjin, Would you please take this patch as a fix for 3.16? -- Tushar Behera -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420
On Wed, Jun 11, 2014 at 7:32 AM, Tushar Behera wrote: > Currently CLK_FOUT_EPLL was set as one of the parents of AUDSS mux. > As per the user manual, it should be CLK_MAU_EPLL. > > The problem surfaced when the bootloader in Peach-pit board set > the EPLL clock as the parent of AUDSS mux. While booting the kernel, > we used to get a system hang during late boot if CLK_MAU_EPLL was > disabled. > > Signed-off-by: Tushar Behera > Signed-off-by: Shaik Ameer Basha > Reported-by: Kevin Hilman > --- > arch/arm/boot/dts/exynos5420.dtsi |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/exynos5420.dtsi > b/arch/arm/boot/dts/exynos5420.dtsi > index e385322..79e9119 100644 > --- a/arch/arm/boot/dts/exynos5420.dtsi > +++ b/arch/arm/boot/dts/exynos5420.dtsi > @@ -167,7 +167,7 @@ > compatible = "samsung,exynos5420-audss-clock"; > reg = <0x0381 0x0C>; > #clock-cells = <1>; > - clocks = <&clock CLK_FIN_PLL>, <&clock CLK_FOUT_EPLL>, > + clocks = <&clock CLK_FIN_PLL>, <&clock CLK_MAU_EPLL>, > <&clock CLK_SCLK_MAUDIO0>, <&clock CLK_SCLK_MAUPCM0>; > clock-names = "pll_ref", "pll_in", "sclk_audio", > "sclk_pcm_in"; > }; > -- > 1.7.9.5 > > -- Tested-by: Javier Martinez Canillas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
