Re: [PATCH 2/3] PCI: reimplement P2P bridge 1K I/O windows (Intel P64H2)
On Mon, Jul 9, 2012 at 3:21 PM, Bjorn Helgaas wrote: > What bad things would happen if I just appended your patch to the end > of this series? Would that break bisection in some scenario? Should be ok. it should not break bisection. Don't think sizing is working for 1k before. Thanks Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] PCI: reimplement P2P bridge 1K I/O windows (Intel P64H2)
On Mon, Jul 9, 2012 at 3:43 PM, Yinghai Lu wrote: > On Mon, Jul 9, 2012 at 1:32 PM, Bjorn Helgaas wrote: >> >> Note that the bridge window assignment code, e.g., pbus_size_io(), should >> pay attention to dev->io_window_1k, too, but I didn't fix that. > > Please check attached patch that will fix pbus_size_io. Thanks for posting this again. I had looked for it, but couldn't find it. > You may fold the patch in your patch, or could split your patch to > two. First one > only add io_window_1k, and second one will use io_window_1k. Then could put my > patch between them. What bad things would happen if I just appended your patch to the end of this series? Would that break bisection in some scenario? Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] PCI: reimplement P2P bridge 1K I/O windows (Intel P64H2)
On Mon, Jul 9, 2012 at 1:32 PM, Bjorn Helgaas wrote: > > Note that the bridge window assignment code, e.g., pbus_size_io(), should > pay attention to dev->io_window_1k, too, but I didn't fix that. Please check attached patch that will fix pbus_size_io. You may fold the patch in your patch, or could split your patch to two. First one only add io_window_1k, and second one will use io_window_1k. Then could put my patch between them. Thanks Yinghai io_window_1k.patch Description: Binary data
Re: [PATCH 2/3] PCI: reimplement P2P bridge 1K I/O windows (Intel P64H2)
On Mon, Jul 9, 2012 at 1:32 PM, Bjorn Helgaas bhelg...@google.com wrote: Note that the bridge window assignment code, e.g., pbus_size_io(), should pay attention to dev-io_window_1k, too, but I didn't fix that. Please check attached patch that will fix pbus_size_io. You may fold the patch in your patch, or could split your patch to two. First one only add io_window_1k, and second one will use io_window_1k. Then could put my patch between them. Thanks Yinghai io_window_1k.patch Description: Binary data
Re: [PATCH 2/3] PCI: reimplement P2P bridge 1K I/O windows (Intel P64H2)
On Mon, Jul 9, 2012 at 3:43 PM, Yinghai Lu ying...@kernel.org wrote: On Mon, Jul 9, 2012 at 1:32 PM, Bjorn Helgaas bhelg...@google.com wrote: Note that the bridge window assignment code, e.g., pbus_size_io(), should pay attention to dev-io_window_1k, too, but I didn't fix that. Please check attached patch that will fix pbus_size_io. Thanks for posting this again. I had looked for it, but couldn't find it. You may fold the patch in your patch, or could split your patch to two. First one only add io_window_1k, and second one will use io_window_1k. Then could put my patch between them. What bad things would happen if I just appended your patch to the end of this series? Would that break bisection in some scenario? Bjorn -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] PCI: reimplement P2P bridge 1K I/O windows (Intel P64H2)
On Mon, Jul 9, 2012 at 3:21 PM, Bjorn Helgaas bhelg...@google.com wrote: What bad things would happen if I just appended your patch to the end of this series? Would that break bisection in some scenario? Should be ok. it should not break bisection. Don't think sizing is working for 1k before. Thanks Yinghai -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
