Re: [PATCH 2/3] ata: Add Qualcomm ARM SoC AHCI SATA host controller driver
On Jun 13, 2014, at 9:38 AM, Stanimir Varbanov wrote:
> Hi Kumar,
>
>> +
>> +static struct platform_driver qcom_ahci_driver = {
>> +.probe = qcom_ahci_probe,
>> +.remove = ata_platform_remove_one,
>> +.driver = {
>> +.name = "qcom_ahci_qcom",
>> +.owner = THIS_MODULE,
>> +.of_match_table = qcom_ahci_of_match,
>> +},
>> +};
>> +module_platform_driver(qcom_ahci_driver);
>> +
>> +MODULE_DESCRIPTION("Qualcomm AHCI SATA platform driver");
>> +MODULE_LICENSE("GPL");
>
> "GPL v2" ? Or only GPL is intentional?
should be v2, will fix
>
>> +MODULE_ALIAS("ahci:qcom");
>>
>
> missing MODULE_AUTHOR
>
> --
> regards,
> Stan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
- k
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] ata: Add Qualcomm ARM SoC AHCI SATA host controller driver
Hi Kumar,
> +
> +static struct platform_driver qcom_ahci_driver = {
> + .probe = qcom_ahci_probe,
> + .remove = ata_platform_remove_one,
> + .driver = {
> + .name = "qcom_ahci_qcom",
> + .owner = THIS_MODULE,
> + .of_match_table = qcom_ahci_of_match,
> + },
> +};
> +module_platform_driver(qcom_ahci_driver);
> +
> +MODULE_DESCRIPTION("Qualcomm AHCI SATA platform driver");
> +MODULE_LICENSE("GPL");
"GPL v2" ? Or only GPL is intentional?
> +MODULE_ALIAS("ahci:qcom");
>
missing MODULE_AUTHOR
--
regards,
Stan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] ata: Add Qualcomm ARM SoC AHCI SATA host controller driver
Hi Kumar,
+
+static struct platform_driver qcom_ahci_driver = {
+ .probe = qcom_ahci_probe,
+ .remove = ata_platform_remove_one,
+ .driver = {
+ .name = qcom_ahci_qcom,
+ .owner = THIS_MODULE,
+ .of_match_table = qcom_ahci_of_match,
+ },
+};
+module_platform_driver(qcom_ahci_driver);
+
+MODULE_DESCRIPTION(Qualcomm AHCI SATA platform driver);
+MODULE_LICENSE(GPL);
GPL v2 ? Or only GPL is intentional?
+MODULE_ALIAS(ahci:qcom);
missing MODULE_AUTHOR
--
regards,
Stan
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] ata: Add Qualcomm ARM SoC AHCI SATA host controller driver
On Jun 13, 2014, at 9:38 AM, Stanimir Varbanov svarba...@mm-sol.com wrote:
Hi Kumar,
+
+static struct platform_driver qcom_ahci_driver = {
+.probe = qcom_ahci_probe,
+.remove = ata_platform_remove_one,
+.driver = {
+.name = qcom_ahci_qcom,
+.owner = THIS_MODULE,
+.of_match_table = qcom_ahci_of_match,
+},
+};
+module_platform_driver(qcom_ahci_driver);
+
+MODULE_DESCRIPTION(Qualcomm AHCI SATA platform driver);
+MODULE_LICENSE(GPL);
GPL v2 ? Or only GPL is intentional?
should be v2, will fix
+MODULE_ALIAS(ahci:qcom);
missing MODULE_AUTHOR
--
regards,
Stan
--
To unsubscribe from this list: send the line unsubscribe linux-arm-msm in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
- k
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] ata: Add Qualcomm ARM SoC AHCI SATA host controller driver
On Jun 12, 2014, at 2:50 PM, Stephen Boyd wrote:
> On 06/12/14 12:13, Kumar Gala wrote:
>> +static int qcom_ahci_probe(struct platform_device *pdev)
>> +{
>> +struct ahci_host_priv *hpriv;
>> +struct clk *rxoob_clk;
>> +int rc;
>> +
>> +hpriv = ahci_platform_get_resources(pdev);
>> +if (IS_ERR(hpriv))
>> +return PTR_ERR(hpriv);
>> +
>> +/* Try and set the rxoob clk to 100Mhz */
>> +rxoob_clk = of_clk_get_by_name(pdev->dev.of_node, "rxoob");
>
> Any reason we can't use devm_clk_get() here?
Was trying to avoid the ref cnt of devm_clk_get() as the clk’s are actually
handled in ahci_platform_get_resources/ahci_platform_enable_resources
- k
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] ata: Add Qualcomm ARM SoC AHCI SATA host controller driver
On 06/12/14 12:13, Kumar Gala wrote:
> +static int qcom_ahci_probe(struct platform_device *pdev)
> +{
> + struct ahci_host_priv *hpriv;
> + struct clk *rxoob_clk;
> + int rc;
> +
> + hpriv = ahci_platform_get_resources(pdev);
> + if (IS_ERR(hpriv))
> + return PTR_ERR(hpriv);
> +
> + /* Try and set the rxoob clk to 100Mhz */
> + rxoob_clk = of_clk_get_by_name(pdev->dev.of_node, "rxoob");
Any reason we can't use devm_clk_get() here?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] ata: Add Qualcomm ARM SoC AHCI SATA host controller driver
On 06/12/14 12:13, Kumar Gala wrote:
+static int qcom_ahci_probe(struct platform_device *pdev)
+{
+ struct ahci_host_priv *hpriv;
+ struct clk *rxoob_clk;
+ int rc;
+
+ hpriv = ahci_platform_get_resources(pdev);
+ if (IS_ERR(hpriv))
+ return PTR_ERR(hpriv);
+
+ /* Try and set the rxoob clk to 100Mhz */
+ rxoob_clk = of_clk_get_by_name(pdev-dev.of_node, rxoob);
Any reason we can't use devm_clk_get() here?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] ata: Add Qualcomm ARM SoC AHCI SATA host controller driver
On Jun 12, 2014, at 2:50 PM, Stephen Boyd sb...@codeaurora.org wrote:
On 06/12/14 12:13, Kumar Gala wrote:
+static int qcom_ahci_probe(struct platform_device *pdev)
+{
+struct ahci_host_priv *hpriv;
+struct clk *rxoob_clk;
+int rc;
+
+hpriv = ahci_platform_get_resources(pdev);
+if (IS_ERR(hpriv))
+return PTR_ERR(hpriv);
+
+/* Try and set the rxoob clk to 100Mhz */
+rxoob_clk = of_clk_get_by_name(pdev-dev.of_node, rxoob);
Any reason we can't use devm_clk_get() here?
Was trying to avoid the ref cnt of devm_clk_get() as the clk’s are actually
handled in ahci_platform_get_resources/ahci_platform_enable_resources
- k
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
