Re: [PATCH 2/3] pwm: pwm-tiecap: Add device-tree binding support for da850 SOC
On 3/14/2013 9:14 PM, Peter Korsgaard wrote:
>> "Sekhar" == Sekhar Nori writes:
>
> >> Required properties:
> >> -- compatible: Must be "ti,am33xx-ecap"
> >> +- compatible: Must be "ti,am33xx-ecap" or "ti,da850-ecap"
> >> - #pwm-cells: Should be 3. Number of cells being used to specify PWM
> property.
> >> First cell specifies the per-chip index of the PWM to use, the second
> >> cell is the period in nanoseconds and bit 0 in the third cell is used to
> >> diff --git a/drivers/pwm/pwm-tiecap.c b/drivers/pwm/pwm-tiecap.c
> >> index 22e96e2..e0d96c8 100644
> >> --- a/drivers/pwm/pwm-tiecap.c
> >> +++ b/drivers/pwm/pwm-tiecap.c
> >> @@ -197,6 +197,7 @@ static const struct pwm_ops ecap_pwm_ops = {
> >>
> >> static const struct of_device_id ecap_of_match[] = {
> >> { .compatible = "ti,am33xx-ecap" },
> >> + { .compatible = "ti,da850-ecap" },
> >> {},
>
> Sekhar> You add a new compatible, but don't really show any changes in
> Sekhar> driver in this series. So why can't we simply use
> Sekhar> ti,am33xx-ecap on DA850 too?
>
> Indeed, if the hardware block is identical the dts should simply list:
>
> compatible = "ti,da850-ecap", "ti,am33xx-ecap"
>
> And the driver only bind to ti,am33xx-ecap (unless there ever needs to
> be a da850 specific workarounde.
Okay, so this is to future proof the DA850 DT blob. Makes sense. Thanks!
~Sekhar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] pwm: pwm-tiecap: Add device-tree binding support for da850 SOC
> "Sekhar" == Sekhar Nori writes:
>> Required properties:
>> -- compatible: Must be "ti,am33xx-ecap"
>> +- compatible: Must be "ti,am33xx-ecap" or "ti,da850-ecap"
>> - #pwm-cells: Should be 3. Number of cells being used to specify PWM
>> property.
>> First cell specifies the per-chip index of the PWM to use, the second
>> cell is the period in nanoseconds and bit 0 in the third cell is used to
>> diff --git a/drivers/pwm/pwm-tiecap.c b/drivers/pwm/pwm-tiecap.c
>> index 22e96e2..e0d96c8 100644
>> --- a/drivers/pwm/pwm-tiecap.c
>> +++ b/drivers/pwm/pwm-tiecap.c
>> @@ -197,6 +197,7 @@ static const struct pwm_ops ecap_pwm_ops = {
>>
>> static const struct of_device_id ecap_of_match[] = {
>> { .compatible = "ti,am33xx-ecap" },
>> + { .compatible = "ti,da850-ecap" },
>> {},
Sekhar> You add a new compatible, but don't really show any changes in
Sekhar> driver in this series. So why can't we simply use
Sekhar> ti,am33xx-ecap on DA850 too?
Indeed, if the hardware block is identical the dts should simply list:
compatible = "ti,da850-ecap", "ti,am33xx-ecap"
And the driver only bind to ti,am33xx-ecap (unless there ever needs to
be a da850 specific workarounde.
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 2/3] pwm: pwm-tiecap: Add device-tree binding support for da850 SOC
On Thu, Mar 14, 2013 at 17:13:08, Nori, Sekhar wrote:
> On 3/14/2013 4:02 PM, Philip Avinash wrote:
> > ECAP IP is used in da850 SOC's also. Hence adds ECAP device tree binding
> > support for da850.
> >
> > Cc: Grant Likely
> > Cc: Rob Herring
> > Cc: Rob Landley
> > Signed-off-by: Philip Avinash
> > ---
> > :100644 100644 131e8c1... fcbd3c1... M
> > Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
> > :100644 100644 22e96e2... e0d96c8... M drivers/pwm/pwm-tiecap.c
> > .../devicetree/bindings/pwm/pwm-tiecap.txt |2 +-
> > drivers/pwm/pwm-tiecap.c |1 +
> > 2 files changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
> > b/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
> > index 131e8c1..fcbd3c1 100644
> > --- a/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
> > +++ b/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
> > @@ -1,7 +1,7 @@
> > TI SOC ECAP based APWM controller
> >
> > Required properties:
> > -- compatible: Must be "ti,am33xx-ecap"
> > +- compatible: Must be "ti,am33xx-ecap" or "ti,da850-ecap"
> > - #pwm-cells: Should be 3. Number of cells being used to specify PWM
> > property.
> >First cell specifies the per-chip index of the PWM to use, the second
> >cell is the period in nanoseconds and bit 0 in the third cell is used to
> > diff --git a/drivers/pwm/pwm-tiecap.c b/drivers/pwm/pwm-tiecap.c
> > index 22e96e2..e0d96c8 100644
> > --- a/drivers/pwm/pwm-tiecap.c
> > +++ b/drivers/pwm/pwm-tiecap.c
> > @@ -197,6 +197,7 @@ static const struct pwm_ops ecap_pwm_ops = {
> >
> > static const struct of_device_id ecap_of_match[] = {
> > { .compatible = "ti,am33xx-ecap" },
> > + { .compatible = "ti,da850-ecap" },
> > {},
>
> You add a new compatible, but don't really show any changes in driver in
> this series. So why can't we simply use ti,am33xx-ecap on DA850 too?
Ok it can happily live with ti,am33xx-ecap. Hence this patch and next [1]patch
can be dropped.
1. [PATCH 3/3] pwm: pwm-tiehrpwm: Add device tree binding support for da850 SOC
Thanks
Avinash
>
> Thanks,
> Sekhar
>
Re: [PATCH 2/3] pwm: pwm-tiecap: Add device-tree binding support for da850 SOC
On 3/14/2013 4:02 PM, Philip Avinash wrote:
> ECAP IP is used in da850 SOC's also. Hence adds ECAP device tree binding
> support for da850.
>
> Cc: Grant Likely
> Cc: Rob Herring
> Cc: Rob Landley
> Signed-off-by: Philip Avinash
> ---
> :100644 100644 131e8c1... fcbd3c1... M
> Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
> :100644 100644 22e96e2... e0d96c8... Mdrivers/pwm/pwm-tiecap.c
> .../devicetree/bindings/pwm/pwm-tiecap.txt |2 +-
> drivers/pwm/pwm-tiecap.c |1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
> b/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
> index 131e8c1..fcbd3c1 100644
> --- a/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
> +++ b/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
> @@ -1,7 +1,7 @@
> TI SOC ECAP based APWM controller
>
> Required properties:
> -- compatible: Must be "ti,am33xx-ecap"
> +- compatible: Must be "ti,am33xx-ecap" or "ti,da850-ecap"
> - #pwm-cells: Should be 3. Number of cells being used to specify PWM
> property.
>First cell specifies the per-chip index of the PWM to use, the second
>cell is the period in nanoseconds and bit 0 in the third cell is used to
> diff --git a/drivers/pwm/pwm-tiecap.c b/drivers/pwm/pwm-tiecap.c
> index 22e96e2..e0d96c8 100644
> --- a/drivers/pwm/pwm-tiecap.c
> +++ b/drivers/pwm/pwm-tiecap.c
> @@ -197,6 +197,7 @@ static const struct pwm_ops ecap_pwm_ops = {
>
> static const struct of_device_id ecap_of_match[] = {
> { .compatible = "ti,am33xx-ecap" },
> + { .compatible = "ti,da850-ecap" },
> {},
You add a new compatible, but don't really show any changes in driver in
this series. So why can't we simply use ti,am33xx-ecap on DA850 too?
Thanks,
Sekhar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] pwm: pwm-tiecap: Add device-tree binding support for da850 SOC
On 3/14/2013 4:02 PM, Philip Avinash wrote:
ECAP IP is used in da850 SOC's also. Hence adds ECAP device tree binding
support for da850.
Cc: Grant Likely grant.lik...@secretlab.ca
Cc: Rob Herring rob.herr...@calxeda.com
Cc: Rob Landley r...@landley.net
Signed-off-by: Philip Avinash avinashphi...@ti.com
---
:100644 100644 131e8c1... fcbd3c1... M
Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
:100644 100644 22e96e2... e0d96c8... Mdrivers/pwm/pwm-tiecap.c
.../devicetree/bindings/pwm/pwm-tiecap.txt |2 +-
drivers/pwm/pwm-tiecap.c |1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
b/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
index 131e8c1..fcbd3c1 100644
--- a/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
+++ b/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
@@ -1,7 +1,7 @@
TI SOC ECAP based APWM controller
Required properties:
-- compatible: Must be ti,am33xx-ecap
+- compatible: Must be ti,am33xx-ecap or ti,da850-ecap
- #pwm-cells: Should be 3. Number of cells being used to specify PWM
property.
First cell specifies the per-chip index of the PWM to use, the second
cell is the period in nanoseconds and bit 0 in the third cell is used to
diff --git a/drivers/pwm/pwm-tiecap.c b/drivers/pwm/pwm-tiecap.c
index 22e96e2..e0d96c8 100644
--- a/drivers/pwm/pwm-tiecap.c
+++ b/drivers/pwm/pwm-tiecap.c
@@ -197,6 +197,7 @@ static const struct pwm_ops ecap_pwm_ops = {
static const struct of_device_id ecap_of_match[] = {
{ .compatible = ti,am33xx-ecap },
+ { .compatible = ti,da850-ecap },
{},
You add a new compatible, but don't really show any changes in driver in
this series. So why can't we simply use ti,am33xx-ecap on DA850 too?
Thanks,
Sekhar
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 2/3] pwm: pwm-tiecap: Add device-tree binding support for da850 SOC
On Thu, Mar 14, 2013 at 17:13:08, Nori, Sekhar wrote:
On 3/14/2013 4:02 PM, Philip Avinash wrote:
ECAP IP is used in da850 SOC's also. Hence adds ECAP device tree binding
support for da850.
Cc: Grant Likely grant.lik...@secretlab.ca
Cc: Rob Herring rob.herr...@calxeda.com
Cc: Rob Landley r...@landley.net
Signed-off-by: Philip Avinash avinashphi...@ti.com
---
:100644 100644 131e8c1... fcbd3c1... M
Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
:100644 100644 22e96e2... e0d96c8... M drivers/pwm/pwm-tiecap.c
.../devicetree/bindings/pwm/pwm-tiecap.txt |2 +-
drivers/pwm/pwm-tiecap.c |1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
b/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
index 131e8c1..fcbd3c1 100644
--- a/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
+++ b/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
@@ -1,7 +1,7 @@
TI SOC ECAP based APWM controller
Required properties:
-- compatible: Must be ti,am33xx-ecap
+- compatible: Must be ti,am33xx-ecap or ti,da850-ecap
- #pwm-cells: Should be 3. Number of cells being used to specify PWM
property.
First cell specifies the per-chip index of the PWM to use, the second
cell is the period in nanoseconds and bit 0 in the third cell is used to
diff --git a/drivers/pwm/pwm-tiecap.c b/drivers/pwm/pwm-tiecap.c
index 22e96e2..e0d96c8 100644
--- a/drivers/pwm/pwm-tiecap.c
+++ b/drivers/pwm/pwm-tiecap.c
@@ -197,6 +197,7 @@ static const struct pwm_ops ecap_pwm_ops = {
static const struct of_device_id ecap_of_match[] = {
{ .compatible = ti,am33xx-ecap },
+ { .compatible = ti,da850-ecap },
{},
You add a new compatible, but don't really show any changes in driver in
this series. So why can't we simply use ti,am33xx-ecap on DA850 too?
Ok it can happily live with ti,am33xx-ecap. Hence this patch and next [1]patch
can be dropped.
1. [PATCH 3/3] pwm: pwm-tiehrpwm: Add device tree binding support for da850 SOC
Thanks
Avinash
Thanks,
Sekhar
Re: [PATCH 2/3] pwm: pwm-tiecap: Add device-tree binding support for da850 SOC
Sekhar == Sekhar Nori nsek...@ti.com writes:
Required properties:
-- compatible: Must be ti,am33xx-ecap
+- compatible: Must be ti,am33xx-ecap or ti,da850-ecap
- #pwm-cells: Should be 3. Number of cells being used to specify PWM
property.
First cell specifies the per-chip index of the PWM to use, the second
cell is the period in nanoseconds and bit 0 in the third cell is used to
diff --git a/drivers/pwm/pwm-tiecap.c b/drivers/pwm/pwm-tiecap.c
index 22e96e2..e0d96c8 100644
--- a/drivers/pwm/pwm-tiecap.c
+++ b/drivers/pwm/pwm-tiecap.c
@@ -197,6 +197,7 @@ static const struct pwm_ops ecap_pwm_ops = {
static const struct of_device_id ecap_of_match[] = {
{ .compatible = ti,am33xx-ecap },
+ { .compatible = ti,da850-ecap },
{},
Sekhar You add a new compatible, but don't really show any changes in
Sekhar driver in this series. So why can't we simply use
Sekhar ti,am33xx-ecap on DA850 too?
Indeed, if the hardware block is identical the dts should simply list:
compatible = ti,da850-ecap, ti,am33xx-ecap
And the driver only bind to ti,am33xx-ecap (unless there ever needs to
be a da850 specific workarounde.
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] pwm: pwm-tiecap: Add device-tree binding support for da850 SOC
On 3/14/2013 9:14 PM, Peter Korsgaard wrote:
Sekhar == Sekhar Nori nsek...@ti.com writes:
Required properties:
-- compatible: Must be ti,am33xx-ecap
+- compatible: Must be ti,am33xx-ecap or ti,da850-ecap
- #pwm-cells: Should be 3. Number of cells being used to specify PWM
property.
First cell specifies the per-chip index of the PWM to use, the second
cell is the period in nanoseconds and bit 0 in the third cell is used to
diff --git a/drivers/pwm/pwm-tiecap.c b/drivers/pwm/pwm-tiecap.c
index 22e96e2..e0d96c8 100644
--- a/drivers/pwm/pwm-tiecap.c
+++ b/drivers/pwm/pwm-tiecap.c
@@ -197,6 +197,7 @@ static const struct pwm_ops ecap_pwm_ops = {
static const struct of_device_id ecap_of_match[] = {
{ .compatible = ti,am33xx-ecap },
+ { .compatible = ti,da850-ecap },
{},
Sekhar You add a new compatible, but don't really show any changes in
Sekhar driver in this series. So why can't we simply use
Sekhar ti,am33xx-ecap on DA850 too?
Indeed, if the hardware block is identical the dts should simply list:
compatible = ti,da850-ecap, ti,am33xx-ecap
And the driver only bind to ti,am33xx-ecap (unless there ever needs to
be a da850 specific workarounde.
Okay, so this is to future proof the DA850 DT blob. Makes sense. Thanks!
~Sekhar
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
