RE: [PATCH 2/4] ARM: EXYNOS: PL330 MDMA1 fix for revision 0 of Exynos4210 SOC
Bartlomiej Zolnierkiewicz wrote: > > > Hmm...above change and adding definition of EXYNOS_PA_S_MDMA1 address > > can fix the problem you commented on EXYNOS4210 Rev0 without others?... > > The problem is affecting only EXYNOS4210 Rev0 and the fix is applied only > for case when soc_is_exynos4210() && samsung_rev() == EXYNOS4210_REV_0, > or did you mean something else? > Yeah, I know. I mean just adding secure mdma1 address is enough for exynos4210 rev0. 8<- @@ -275,6 +275,9 @@ static int __init exynos_dma_init(void) exynos_pdma1_pdata.nr_valid_peri = ARRAY_SIZE(exynos4210_pdma1_peri); exynos_pdma1_pdata.peri_id = exynos4210_pdma1_peri; + + if (samsung_rev() == EXYNOS4210_REV_0) + exynos_mdma1_device.res.start = EXYNOS4_PA_S_MDMA1; } else if (soc_is_exynos4212() || soc_is_exynos4412()) { exynos_pdma0_pdata.nr_valid_peri = ARRAY_SIZE(exynos4212_pdma0_peri); diff --git a/arch/arm/mach-exynos/include/mach/map.h b/arch/arm/mach-exynos/include/mach/map.h index 8480849..0abfe78 100644 --- a/arch/arm/mach-exynos/include/mach/map.h +++ b/arch/arm/mach-exynos/include/mach/map.h @@ -90,6 +90,7 @@ #define EXYNOS4_PA_MDMA0 0x1081 #define EXYNOS4_PA_MDMA1 0x1285 +#define EXYNOS4_PA_S_MDMA1 0x1284 #define EXYNOS4_PA_PDMA0 0x1268 #define EXYNOS4_PA_PDMA1 0x1269 #define EXYNOS5_PA_MDMA0 0x1080 8< Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/4] ARM: EXYNOS: PL330 MDMA1 fix for revision 0 of Exynos4210 SOC
On Thursday 08 November 2012 05:49:47 Kukjin Kim wrote: > Bartlomiej Zolnierkiewicz wrote: > > > > > Hmm...above change and adding definition of EXYNOS_PA_S_MDMA1 address > > > can fix the problem you commented on EXYNOS4210 Rev0 without others?... > > > > The problem is affecting only EXYNOS4210 Rev0 and the fix is applied only > > for case when soc_is_exynos4210() && samsung_rev() == EXYNOS4210_REV_0, > > or did you mean something else? > > > Yeah, I know. I mean just adding secure mdma1 address is enough for > exynos4210 rev0. > > 8<- > @@ -275,6 +275,9 @@ static int __init exynos_dma_init(void) > exynos_pdma1_pdata.nr_valid_peri = > ARRAY_SIZE(exynos4210_pdma1_peri); > exynos_pdma1_pdata.peri_id = exynos4210_pdma1_peri; > + > + if (samsung_rev() == EXYNOS4210_REV_0) > + exynos_mdma1_device.res.start = EXYNOS4_PA_S_MDMA1; > } else if (soc_is_exynos4212() || soc_is_exynos4412()) { > exynos_pdma0_pdata.nr_valid_peri = > ARRAY_SIZE(exynos4212_pdma0_peri); > diff --git a/arch/arm/mach-exynos/include/mach/map.h > b/arch/arm/mach-exynos/include/mach/map.h > index 8480849..0abfe78 100644 > --- a/arch/arm/mach-exynos/include/mach/map.h > +++ b/arch/arm/mach-exynos/include/mach/map.h > @@ -90,6 +90,7 @@ > > #define EXYNOS4_PA_MDMA0 0x1081 > #define EXYNOS4_PA_MDMA1 0x1285 > +#define EXYNOS4_PA_S_MDMA1 0x1284 > #define EXYNOS4_PA_PDMA0 0x1268 > #define EXYNOS4_PA_PDMA1 0x1269 > #define EXYNOS5_PA_MDMA0 0x1080 > 8< Ah, okay. Here is full simplified patch. From: Bartlomiej Zolnierkiewicz Subject: [PATCH v2] ARM: EXYNOS: PL330 MDMA1 fix for revision 0 of Exynos4210 SOC Commit 8214513 ("ARM: EXYNOS: fix address for EXYNOS4 MDMA1") changed EXYNOS specific setup of PL330 DMA engine to use 'non-secure' mdma1 address instead of 'secure' one (from 0x1284 to 0x1285) to fix issue with some Exynos4212 SOCs. Unfortunately it brakes PL330 setup for revision 0 of Exynos4210 SOC (mdma1 device cannot be found at 'non-secure' address): [0.566245] dma-pl330 dma-pl330.2: PERIPH_ID 0x0, PCELL_ID 0x0 ! [0.566278] dma-pl330: probe of dma-pl330.2 failed with error -22 Fix it by using 'secure' mdma1 address on Exynos4210 revision 0 SOC. Reviewed-by: Tomasz Figa Cc: Kukjin Kim Signed-off-by: Bartlomiej Zolnierkiewicz Signed-off-by: Kyungmin Park --- arch/arm/mach-exynos/dma.c |3 +++ arch/arm/mach-exynos/include/mach/map.h |1 + 2 files changed, 4 insertions(+) Index: b/arch/arm/mach-exynos/dma.c === --- a/arch/arm/mach-exynos/dma.c2012-11-07 18:20:36.561743865 +0100 +++ b/arch/arm/mach-exynos/dma.c2012-11-08 10:48:23.445067606 +0100 @@ -275,6 +275,9 @@ static int __init exynos_dma_init(void) exynos_pdma1_pdata.nr_valid_peri = ARRAY_SIZE(exynos4210_pdma1_peri); exynos_pdma1_pdata.peri_id = exynos4210_pdma1_peri; + + if (samsung_rev() == EXYNOS4210_REV_0) + exynos_mdma1_device.res.start = EXYNOS4_PA_S_MDMA1; } else if (soc_is_exynos4212() || soc_is_exynos4412()) { exynos_pdma0_pdata.nr_valid_peri = ARRAY_SIZE(exynos4212_pdma0_peri); Index: b/arch/arm/mach-exynos/include/mach/map.h === --- a/arch/arm/mach-exynos/include/mach/map.h 2012-11-07 18:20:44.801743862 +0100 +++ b/arch/arm/mach-exynos/include/mach/map.h 2012-11-08 10:48:40.597067605 +0100 @@ -92,6 +92,7 @@ #define EXYNOS4_PA_MDMA0 0x1081 #define EXYNOS4_PA_MDMA1 0x1285 +#define EXYNOS4_PA_S_MDMA1 0x1284 #define EXYNOS4_PA_PDMA0 0x1268 #define EXYNOS4_PA_PDMA1 0x1269 #define EXYNOS5_PA_MDMA0 0x1080 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 2/4] ARM: EXYNOS: PL330 MDMA1 fix for revision 0 of Exynos4210 SOC
Bartlomiej Zolnierkiewicz wrote: > > Ah, okay. Here is full simplified patch. > > From: Bartlomiej Zolnierkiewicz > Subject: [PATCH v2] ARM: EXYNOS: PL330 MDMA1 fix for revision 0 of > Exynos4210 SOC > > Commit 8214513 ("ARM: EXYNOS: fix address for EXYNOS4 MDMA1") > changed EXYNOS specific setup of PL330 DMA engine to use 'non-secure' > mdma1 address instead of 'secure' one (from 0x1284 to 0x1285) > to fix issue with some Exynos4212 SOCs. Unfortunately it brakes > PL330 setup for revision 0 of Exynos4210 SOC (mdma1 device cannot > be found at 'non-secure' address): > > [0.566245] dma-pl330 dma-pl330.2: PERIPH_ID 0x0, PCELL_ID 0x0 ! > [0.566278] dma-pl330: probe of dma-pl330.2 failed with error -22 > > Fix it by using 'secure' mdma1 address on Exynos4210 revision 0 SOC. > > Reviewed-by: Tomasz Figa > Cc: Kukjin Kim > Signed-off-by: Bartlomiej Zolnierkiewicz > Signed-off-by: Kyungmin Park > --- > arch/arm/mach-exynos/dma.c |3 +++ > arch/arm/mach-exynos/include/mach/map.h |1 + > 2 files changed, 4 insertions(+) > > Index: b/arch/arm/mach-exynos/dma.c > === > --- a/arch/arm/mach-exynos/dma.c 2012-11-07 18:20:36.561743865 +0100 > +++ b/arch/arm/mach-exynos/dma.c 2012-11-08 10:48:23.445067606 +0100 > @@ -275,6 +275,9 @@ static int __init exynos_dma_init(void) > exynos_pdma1_pdata.nr_valid_peri = > ARRAY_SIZE(exynos4210_pdma1_peri); > exynos_pdma1_pdata.peri_id = exynos4210_pdma1_peri; > + > + if (samsung_rev() == EXYNOS4210_REV_0) > + exynos_mdma1_device.res.start = EXYNOS4_PA_S_MDMA1; > } else if (soc_is_exynos4212() || soc_is_exynos4412()) { > exynos_pdma0_pdata.nr_valid_peri = > ARRAY_SIZE(exynos4212_pdma0_peri); > Index: b/arch/arm/mach-exynos/include/mach/map.h > === > --- a/arch/arm/mach-exynos/include/mach/map.h 2012-11-07 > 18:20:44.801743862 +0100 > +++ b/arch/arm/mach-exynos/include/mach/map.h 2012-11-08 > 10:48:40.597067605 +0100 > @@ -92,6 +92,7 @@ > > #define EXYNOS4_PA_MDMA0 0x1081 > #define EXYNOS4_PA_MDMA1 0x1285 > +#define EXYNOS4_PA_S_MDMA1 0x1284 > #define EXYNOS4_PA_PDMA0 0x1268 > #define EXYNOS4_PA_PDMA1 0x1269 > #define EXYNOS5_PA_MDMA0 0x1080 Looks good to me, and I think, this can be handled separate from this series. Vinod, if you're ok, let me pick this up into Samsung tree. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/4] ARM: EXYNOS: PL330 MDMA1 fix for revision 0 of Exynos4210 SOC
On 10/29/12 10:59, Bartlomiej Zolnierkiewicz wrote: Commit 8214513 ("ARM: EXYNOS: fix address for EXYNOS4 MDMA1") changed EXYNOS specific setup of PL330 DMA engine to use 'non-secure' mdma1 address instead of 'secure' one (from 0x1284 to 0x1285) to fix issue with some Exynos4212 SOCs. Unfortunately it brakes PL330 setup for revision 0 of Exynos4210 SOC (mdma1 device cannot be found at 'non-secure' address): [0.566245] dma-pl330 dma-pl330.2: PERIPH_ID 0x0, PCELL_ID 0x0 ! [0.566278] dma-pl330: probe of dma-pl330.2 failed with error -22 Fix it by using 'secure' mdma1 address on Exynos4210 revision 0 SOC. Cc: Tomasz Figa Cc: Kukjin Kim Signed-off-by: Bartlomiej Zolnierkiewicz Signed-off-by: Kyungmin Park --- arch/arm/mach-exynos/dma.c | 5 - arch/arm/mach-exynos/include/mach/map.h | 3 ++- 2 files changed, 6 insertions(+), 2 deletions(-) [...] + if (samsung_rev() == EXYNOS4210_REV_0) + exynos_mdma1_device.res.start = EXYNOS4_PA_S_MDMA1; Hi Bart, Hmm...above change and adding definition of EXYNOS_PA_S_MDMA1 address can fix the problem you commented on EXYNOS4210 Rev0 without others?... Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/4] ARM: EXYNOS: PL330 MDMA1 fix for revision 0 of Exynos4210 SOC
Hi, On Monday 29 October 2012 18:24:06 Kukjin Kim wrote: > On 10/29/12 10:59, Bartlomiej Zolnierkiewicz wrote: > > Commit 8214513 ("ARM: EXYNOS: fix address for EXYNOS4 MDMA1") > > changed EXYNOS specific setup of PL330 DMA engine to use 'non-secure' > > mdma1 address instead of 'secure' one (from 0x1284 to 0x1285) > > to fix issue with some Exynos4212 SOCs. Unfortunately it brakes > > PL330 setup for revision 0 of Exynos4210 SOC (mdma1 device cannot > > be found at 'non-secure' address): > > > > [0.566245] dma-pl330 dma-pl330.2: PERIPH_ID 0x0, PCELL_ID 0x0 ! > > [0.566278] dma-pl330: probe of dma-pl330.2 failed with error -22 > > > > Fix it by using 'secure' mdma1 address on Exynos4210 revision 0 SOC. > > > > Cc: Tomasz Figa > > Cc: Kukjin Kim > > Signed-off-by: Bartlomiej Zolnierkiewicz > > Signed-off-by: Kyungmin Park > > --- > > arch/arm/mach-exynos/dma.c | 5 - > > arch/arm/mach-exynos/include/mach/map.h | 3 ++- > > 2 files changed, 6 insertions(+), 2 deletions(-) > > [...] > > > + if (samsung_rev() == EXYNOS4210_REV_0) > > + exynos_mdma1_device.res.start = EXYNOS4_PA_S_MDMA1; > > Hi Bart, > > Hmm...above change and adding definition of EXYNOS_PA_S_MDMA1 address > can fix the problem you commented on EXYNOS4210 Rev0 without others?... The problem is affecting only EXYNOS4210 Rev0 and the fix is applied only for case when soc_is_exynos4210() && samsung_rev() == EXYNOS4210_REV_0, or did you mean something else? Best regards, -- Bartlomiej Zolnierkiewicz Samsung Poland R&D Center > Thanks. > > Best regards, > Kgene. > -- > Kukjin Kim , Senior Engineer, > SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 2/4] ARM: EXYNOS: PL330 MDMA1 fix for revision 0 of Exynos4210 SOC
Bartlomiej Zolnierkiewicz wrote: > > From: Bartlomiej Zolnierkiewicz > Subject: [PATCH v2] ARM: EXYNOS: PL330 MDMA1 fix for revision 0 of > Exynos4210 SOC > > Commit 8214513 ("ARM: EXYNOS: fix address for EXYNOS4 MDMA1") > changed EXYNOS specific setup of PL330 DMA engine to use 'non-secure' > mdma1 address instead of 'secure' one (from 0x1284 to 0x1285) > to fix issue with some Exynos4212 SOCs. Unfortunately it brakes > PL330 setup for revision 0 of Exynos4210 SOC (mdma1 device cannot > be found at 'non-secure' address): > > [0.566245] dma-pl330 dma-pl330.2: PERIPH_ID 0x0, PCELL_ID 0x0 ! > [0.566278] dma-pl330: probe of dma-pl330.2 failed with error -22 > > Fix it by using 'secure' mdma1 address on Exynos4210 revision 0 SOC. > > Reviewed-by: Tomasz Figa > Cc: Kukjin Kim > Signed-off-by: Bartlomiej Zolnierkiewicz > Signed-off-by: Kyungmin Park > --- > arch/arm/mach-exynos/dma.c |3 +++ > arch/arm/mach-exynos/include/mach/map.h |1 + > 2 files changed, 4 insertions(+) > > Index: b/arch/arm/mach-exynos/dma.c > === > --- a/arch/arm/mach-exynos/dma.c 2012-11-07 18:20:36.561743865 +0100 > +++ b/arch/arm/mach-exynos/dma.c 2012-11-08 10:48:23.445067606 +0100 > @@ -275,6 +275,9 @@ static int __init exynos_dma_init(void) > exynos_pdma1_pdata.nr_valid_peri = > ARRAY_SIZE(exynos4210_pdma1_peri); > exynos_pdma1_pdata.peri_id = exynos4210_pdma1_peri; > + > + if (samsung_rev() == EXYNOS4210_REV_0) > + exynos_mdma1_device.res.start = EXYNOS4_PA_S_MDMA1; > } else if (soc_is_exynos4212() || soc_is_exynos4412()) { > exynos_pdma0_pdata.nr_valid_peri = > ARRAY_SIZE(exynos4212_pdma0_peri); > Index: b/arch/arm/mach-exynos/include/mach/map.h > === > --- a/arch/arm/mach-exynos/include/mach/map.h 2012-11-07 > 18:20:44.801743862 +0100 > +++ b/arch/arm/mach-exynos/include/mach/map.h 2012-11-08 > 10:48:40.597067605 +0100 > @@ -92,6 +92,7 @@ > > #define EXYNOS4_PA_MDMA0 0x1081 > #define EXYNOS4_PA_MDMA1 0x1285 > +#define EXYNOS4_PA_S_MDMA1 0x1284 > #define EXYNOS4_PA_PDMA0 0x1268 > #define EXYNOS4_PA_PDMA1 0x1269 > #define EXYNOS5_PA_MDMA0 0x1080 Applied, thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/