Re: [PATCH 2/4] ARM: tegra: add connection name for uart clock table
On 12/18/2012 12:05 AM, Laxman Dewangan wrote: > On Tuesday 18 December 2012 03:14 AM, Stephen Warren wrote: >> On 12/17/2012 05:08 AM, Laxman Dewangan wrote: >>> Add connection name "uart-clk" for the uart clock information. >> >> Does the UART receive more than one clock, so that it actually cares >> what the clock connection name is? If not, can we just drop this patch? > > I like to have this patch because: > - In future, I want to also get the name of the clock source and set > parent of uart clock properly. I don't understand that; drivers should not care about the names of clocks; the names will be entirely irrelevant once we get clocks from DT. > - I want to switch the parent clock source dynamically between CLKM and > PLLP to achieve more power optimization i.e. use CLKM wherever possible.. I'd prefer to defer that until after we get clocks from DT. Otherwise, we're just adding more churn to the old clock driver first. It'd be better to just switch to the new clock driver, put all the clocks in DT, and then build on that. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/4] ARM: tegra: add connection name for uart clock table
On 12/18/2012 12:05 AM, Laxman Dewangan wrote: On Tuesday 18 December 2012 03:14 AM, Stephen Warren wrote: On 12/17/2012 05:08 AM, Laxman Dewangan wrote: Add connection name uart-clk for the uart clock information. Does the UART receive more than one clock, so that it actually cares what the clock connection name is? If not, can we just drop this patch? I like to have this patch because: - In future, I want to also get the name of the clock source and set parent of uart clock properly. I don't understand that; drivers should not care about the names of clocks; the names will be entirely irrelevant once we get clocks from DT. - I want to switch the parent clock source dynamically between CLKM and PLLP to achieve more power optimization i.e. use CLKM wherever possible.. I'd prefer to defer that until after we get clocks from DT. Otherwise, we're just adding more churn to the old clock driver first. It'd be better to just switch to the new clock driver, put all the clocks in DT, and then build on that. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/4] ARM: tegra: add connection name for uart clock table
On Tuesday 18 December 2012 03:14 AM, Stephen Warren wrote: On 12/17/2012 05:08 AM, Laxman Dewangan wrote: Add connection name "uart-clk" for the uart clock information. Does the UART receive more than one clock, so that it actually cares what the clock connection name is? If not, can we just drop this patch? I like to have this patch because: - In future, I want to also get the name of the clock source and set parent of uart clock properly. - I want to switch the parent clock source dynamically between CLKM and PLLP to achieve more power optimization i.e. use CLKM wherever possible.. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/4] ARM: tegra: add connection name for uart clock table
On 12/17/2012 05:08 AM, Laxman Dewangan wrote: > Add connection name "uart-clk" for the uart clock information. Does the UART receive more than one clock, so that it actually cares what the clock connection name is? If not, can we just drop this patch? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/4] ARM: tegra: add connection name for uart clock table
On 12/17/2012 05:08 AM, Laxman Dewangan wrote: Add connection name uart-clk for the uart clock information. Does the UART receive more than one clock, so that it actually cares what the clock connection name is? If not, can we just drop this patch? -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/4] ARM: tegra: add connection name for uart clock table
On Tuesday 18 December 2012 03:14 AM, Stephen Warren wrote: On 12/17/2012 05:08 AM, Laxman Dewangan wrote: Add connection name uart-clk for the uart clock information. Does the UART receive more than one clock, so that it actually cares what the clock connection name is? If not, can we just drop this patch? I like to have this patch because: - In future, I want to also get the name of the clock source and set parent of uart clock properly. - I want to switch the parent clock source dynamically between CLKM and PLLP to achieve more power optimization i.e. use CLKM wherever possible.. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
