Re: [PATCH 2/4] hpt366: MWDMA filter for SATA cards
On Saturday 08 September 2007, Sergei Shtylyov wrote:
> Hello, I wrote:
> Sergei Shtylyov wrote:
>
> >The patch was 4/4 of course. :-<
> > Probably I was too esctatic about the code. ;-)
>
> Or rarher me. :-)
>
> >> The Marvell bridge chips used on HighPoint SATA cards do not seem to
> >> support
> >> the MWDMA modes (at least that caould be seen in their so-called
> >> drivers :-),
> >> so the driver needs to account for this -- to achieve this:
>
> >> - add mdma_filter() method from the original patch by Bartlomiej
> >> Zolnierkewicz
> >> with his consent, also adding the method callout to ide_rate_filter();
>
> >> - installed the method for all chips to only return empty mask if a
> >> SATA drive
> >> is detected onHPT372{AN]/374 chips...
>
> >> Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]>
I pushed all your bugfix patches that were in IDE tree to Linus so
(after "the pull") please resync and resend the outstanding patches.
> >> ---
> >> This patch against the current Linus' tree and unfortunately I was
> >> able to only
> >> compile test it since that tree gives MODPOST warning and dies early
> >> on bootup.
> >> Will hopefully try to test if/when I have time... :-)
>
> And it was still the same -- I'd bisected if I had time...
:(
> >> Index: linux-2.6/drivers/ide/pci/hpt366.c
> >> ===
> >> --- linux-2.6.orig/drivers/ide/pci/hpt366.c
> >> +++ linux-2.6/drivers/ide/pci/hpt366.c
> >> @@ -1,5 +1,5 @@
> >> /*
> >> - * linux/drivers/ide/pci/hpt366.cVersion 1.12Aug 25, 2007
> >> + * linux/drivers/ide/pci/hpt366.cVersion 1.13Aug 22, 2007
>
> >Errr... and version shuold Aug 02 -- thought I've fixed that. :-/
>
> Hehe, thanks. Those versions turned to be quite PITA a to keep.
I think we should get rid of these "old-style" versions and convert
all IDE host drivers to use "new-style" versions (DRV_VERSION define
+ MODULE_VERSION(DRV_VERSION)). Any volunteers? :)
Thanks,
Bart
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/4] hpt366: MWDMA filter for SATA cards
On Saturday 08 September 2007, Sergei Shtylyov wrote:
Hello, I wrote:
Sergei Shtylyov wrote:
The patch was 4/4 of course. :-
Probably I was too esctatic about the code. ;-)
Or rarher me. :-)
The Marvell bridge chips used on HighPoint SATA cards do not seem to
support
the MWDMA modes (at least that caould be seen in their so-called
drivers :-),
so the driver needs to account for this -- to achieve this:
- add mdma_filter() method from the original patch by Bartlomiej
Zolnierkewicz
with his consent, also adding the method callout to ide_rate_filter();
- installed the method for all chips to only return empty mask if a
SATA drive
is detected onHPT372{AN]/374 chips...
Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED]
I pushed all your bugfix patches that were in IDE tree to Linus so
(after the pull) please resync and resend the outstanding patches.
---
This patch against the current Linus' tree and unfortunately I was
able to only
compile test it since that tree gives MODPOST warning and dies early
on bootup.
Will hopefully try to test if/when I have time... :-)
And it was still the same -- I'd bisected if I had time...
:(
Index: linux-2.6/drivers/ide/pci/hpt366.c
===
--- linux-2.6.orig/drivers/ide/pci/hpt366.c
+++ linux-2.6/drivers/ide/pci/hpt366.c
@@ -1,5 +1,5 @@
/*
- * linux/drivers/ide/pci/hpt366.cVersion 1.12Aug 25, 2007
+ * linux/drivers/ide/pci/hpt366.cVersion 1.13Aug 22, 2007
Errr... and version shuold Aug 02 -- thought I've fixed that. :-/
Hehe, thanks. Those versions turned to be quite PITA a to keep.
I think we should get rid of these old-style versions and convert
all IDE host drivers to use new-style versions (DRV_VERSION define
+ MODULE_VERSION(DRV_VERSION)). Any volunteers? :)
Thanks,
Bart
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/4] hpt366: MWDMA filter for SATA cards
Hello, I wrote:
Sergei Shtylyov wrote:
The patch was 4/4 of course. :-<
Probably I was too esctatic about the code. ;-)
Or rarher me. :-)
The Marvell bridge chips used on HighPoint SATA cards do not seem to
support
the MWDMA modes (at least that caould be seen in their so-called
drivers :-),
so the driver needs to account for this -- to achieve this:
- add mdma_filter() method from the original patch by Bartlomiej
Zolnierkewicz
with his consent, also adding the method callout to ide_rate_filter();
- installed the method for all chips to only return empty mask if a
SATA drive
is detected onHPT372{AN]/374 chips...
Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]>
---
This patch against the current Linus' tree and unfortunately I was
able to only
compile test it since that tree gives MODPOST warning and dies early
on bootup.
Will hopefully try to test if/when I have time... :-)
And it was still the same -- I'd bisected if I had time...
Index: linux-2.6/drivers/ide/pci/hpt366.c
===
--- linux-2.6.orig/drivers/ide/pci/hpt366.c
+++ linux-2.6/drivers/ide/pci/hpt366.c
@@ -1,5 +1,5 @@
/*
- * linux/drivers/ide/pci/hpt366.cVersion 1.12Aug 25, 2007
+ * linux/drivers/ide/pci/hpt366.cVersion 1.13Aug 22, 2007
Errr... and version shuold Aug 02 -- thought I've fixed that. :-/
Hehe, thanks. Those versions turned to be quite PITA a to keep.
MBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/4] hpt366: MWDMA filter for SATA cards
Hello, I wrote:
Sergei Shtylyov wrote:
The patch was 4/4 of course. :-
Probably I was too esctatic about the code. ;-)
Or rarher me. :-)
The Marvell bridge chips used on HighPoint SATA cards do not seem to
support
the MWDMA modes (at least that caould be seen in their so-called
drivers :-),
so the driver needs to account for this -- to achieve this:
- add mdma_filter() method from the original patch by Bartlomiej
Zolnierkewicz
with his consent, also adding the method callout to ide_rate_filter();
- installed the method for all chips to only return empty mask if a
SATA drive
is detected onHPT372{AN]/374 chips...
Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED]
---
This patch against the current Linus' tree and unfortunately I was
able to only
compile test it since that tree gives MODPOST warning and dies early
on bootup.
Will hopefully try to test if/when I have time... :-)
And it was still the same -- I'd bisected if I had time...
Index: linux-2.6/drivers/ide/pci/hpt366.c
===
--- linux-2.6.orig/drivers/ide/pci/hpt366.c
+++ linux-2.6/drivers/ide/pci/hpt366.c
@@ -1,5 +1,5 @@
/*
- * linux/drivers/ide/pci/hpt366.cVersion 1.12Aug 25, 2007
+ * linux/drivers/ide/pci/hpt366.cVersion 1.13Aug 22, 2007
Errr... and version shuold Aug 02 -- thought I've fixed that. :-/
Hehe, thanks. Those versions turned to be quite PITA a to keep.
MBR, Sergei
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/4] hpt366: MWDMA filter for SATA cards
On Sunday 02 September 2007, Sergei Shtylyov wrote:
> Hello, I wrote:
>
> The patch was 4/4 of course. :-<
> Probably I was too esctatic about the code. ;-)
>
> > The Marvell bridge chips used on HighPoint SATA cards do not seem to support
> > the MWDMA modes (at least that caould be seen in their so-called drivers
> > :-),
> > so the driver needs to account for this -- to achieve this:
>
> > - add mdma_filter() method from the original patch by Bartlomiej
> > Zolnierkewicz
> > with his consent, also adding the method callout to ide_rate_filter();
>
> > - installed the method for all chips to only return empty mask if a SATA
> > drive
> > is detected onHPT372{AN]/374 chips...
>
> > Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]>
>
> > ---
> > This patch against the current Linus' tree and unfortunately I was able to
> > only
> > compile test it since that tree gives MODPOST warning and dies early on
> > bootup.
> > Will hopefully try to test if/when I have time... :-)
>
> > Index: linux-2.6/drivers/ide/pci/hpt366.c
> > ===
> > --- linux-2.6.orig/drivers/ide/pci/hpt366.c
> > +++ linux-2.6/drivers/ide/pci/hpt366.c
> > @@ -1,5 +1,5 @@
> > /*
> > - * linux/drivers/ide/pci/hpt366.c Version 1.12Aug 25, 2007
> > + * linux/drivers/ide/pci/hpt366.c Version 1.13Aug 22, 2007
>
> Errr... and version shuold Aug 02 -- thought I've fixed that. :-/
and we have ATA_MWDMA2 define in _vanilla_ kernel now :)
Bart
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/4] hpt366: MWDMA filter for SATA cards
On Sunday 02 September 2007, Sergei Shtylyov wrote:
Hello, I wrote:
The patch was 4/4 of course. :-
Probably I was too esctatic about the code. ;-)
The Marvell bridge chips used on HighPoint SATA cards do not seem to support
the MWDMA modes (at least that caould be seen in their so-called drivers
:-),
so the driver needs to account for this -- to achieve this:
- add mdma_filter() method from the original patch by Bartlomiej
Zolnierkewicz
with his consent, also adding the method callout to ide_rate_filter();
- installed the method for all chips to only return empty mask if a SATA
drive
is detected onHPT372{AN]/374 chips...
Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED]
---
This patch against the current Linus' tree and unfortunately I was able to
only
compile test it since that tree gives MODPOST warning and dies early on
bootup.
Will hopefully try to test if/when I have time... :-)
Index: linux-2.6/drivers/ide/pci/hpt366.c
===
--- linux-2.6.orig/drivers/ide/pci/hpt366.c
+++ linux-2.6/drivers/ide/pci/hpt366.c
@@ -1,5 +1,5 @@
/*
- * linux/drivers/ide/pci/hpt366.c Version 1.12Aug 25, 2007
+ * linux/drivers/ide/pci/hpt366.c Version 1.13Aug 22, 2007
Errr... and version shuold Aug 02 -- thought I've fixed that. :-/
and we have ATA_MWDMA2 define in _vanilla_ kernel now :)
Bart
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/4] hpt366: MWDMA filter for SATA cards
Hello, I wrote:
The patch was 4/4 of course. :-<
Probably I was too esctatic about the code. ;-)
The Marvell bridge chips used on HighPoint SATA cards do not seem to support
the MWDMA modes (at least that caould be seen in their so-called drivers :-),
so the driver needs to account for this -- to achieve this:
- add mdma_filter() method from the original patch by Bartlomiej Zolnierkewicz
with his consent, also adding the method callout to ide_rate_filter();
- installed the method for all chips to only return empty mask if a SATA drive
is detected onHPT372{AN]/374 chips...
Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]>
---
This patch against the current Linus' tree and unfortunately I was able to only
compile test it since that tree gives MODPOST warning and dies early on bootup.
Will hopefully try to test if/when I have time... :-)
Index: linux-2.6/drivers/ide/pci/hpt366.c
===
--- linux-2.6.orig/drivers/ide/pci/hpt366.c
+++ linux-2.6/drivers/ide/pci/hpt366.c
@@ -1,5 +1,5 @@
/*
- * linux/drivers/ide/pci/hpt366.c Version 1.12Aug 25, 2007
+ * linux/drivers/ide/pci/hpt366.c Version 1.13Aug 22, 2007
Errr... and version shuold Aug 02 -- thought I've fixed that. :-/
MBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/4] hpt366: MWDMA filter for SATA cards
Hello, I wrote:
The patch was 4/4 of course. :-
Probably I was too esctatic about the code. ;-)
The Marvell bridge chips used on HighPoint SATA cards do not seem to support
the MWDMA modes (at least that caould be seen in their so-called drivers :-),
so the driver needs to account for this -- to achieve this:
- add mdma_filter() method from the original patch by Bartlomiej Zolnierkewicz
with his consent, also adding the method callout to ide_rate_filter();
- installed the method for all chips to only return empty mask if a SATA drive
is detected onHPT372{AN]/374 chips...
Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED]
---
This patch against the current Linus' tree and unfortunately I was able to only
compile test it since that tree gives MODPOST warning and dies early on bootup.
Will hopefully try to test if/when I have time... :-)
Index: linux-2.6/drivers/ide/pci/hpt366.c
===
--- linux-2.6.orig/drivers/ide/pci/hpt366.c
+++ linux-2.6/drivers/ide/pci/hpt366.c
@@ -1,5 +1,5 @@
/*
- * linux/drivers/ide/pci/hpt366.c Version 1.12Aug 25, 2007
+ * linux/drivers/ide/pci/hpt366.c Version 1.13Aug 22, 2007
Errr... and version shuold Aug 02 -- thought I've fixed that. :-/
MBR, Sergei
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
