Re: [PATCH 2/5] Kconfig: consolidate the "Kernel hacking menu"
2018-07-02 23:47 GMT+09:00 Christoph Hellwig : > Move the source of lib/Kconfig.debug and arch/$(ARCH)/Kconfig.debug to > the top-level Kconfig. For two architectures that means moving their > arch-specific symbols in that menu into a new arch Kconfig.debug file, > and for a few more creating a dummy file so that we can include it > unconditionally. > > Also move the actual 'Kernel hacking' menu to lib/Kconfig.debug, where > it belongs. > > Signed-off-by: Christoph Hellwig > --- > diff --git a/arch/c6x/Kconfig.debug b/arch/c6x/Kconfig.debug > new file mode 100644 > index ..49edf08813eb > --- /dev/null > +++ b/arch/c6x/Kconfig.debug > @@ -0,0 +1,11 @@ > +# SPDX-License-Identifier: GPL-2.0 > + > +config ACCESS_CHECK > + bool "Check the user pointer address" > + default y > + help > + Usually the pointer transfer from user space is checked to see if > its > + address is in the kernel space. > + > + Say N here to disable that check to improve the performance. > + Just a nit: When I ran 'git am', it complained about a blank line at the end of file. .git/rebase-apply/patch:229: new blank line at EOF. -- Best Regards Masahiro Yamada
Re: [PATCH 2/5] Kconfig: consolidate the "Kernel hacking menu"
2018-07-02 23:47 GMT+09:00 Christoph Hellwig : > Move the source of lib/Kconfig.debug and arch/$(ARCH)/Kconfig.debug to > the top-level Kconfig. For two architectures that means moving their > arch-specific symbols in that menu into a new arch Kconfig.debug file, > and for a few more creating a dummy file so that we can include it > unconditionally. > > Also move the actual 'Kernel hacking' menu to lib/Kconfig.debug, where > it belongs. > > Signed-off-by: Christoph Hellwig > --- > diff --git a/arch/c6x/Kconfig.debug b/arch/c6x/Kconfig.debug > new file mode 100644 > index ..49edf08813eb > --- /dev/null > +++ b/arch/c6x/Kconfig.debug > @@ -0,0 +1,11 @@ > +# SPDX-License-Identifier: GPL-2.0 > + > +config ACCESS_CHECK > + bool "Check the user pointer address" > + default y > + help > + Usually the pointer transfer from user space is checked to see if > its > + address is in the kernel space. > + > + Say N here to disable that check to improve the performance. > + Just a nit: When I ran 'git am', it complained about a blank line at the end of file. .git/rebase-apply/patch:229: new blank line at EOF. -- Best Regards Masahiro Yamada
Re: [PATCH 2/5] Kconfig: consolidate the "Kernel hacking menu"
On 07/02/18 07:47, Christoph Hellwig wrote: > diff --git a/Kconfig b/Kconfig > index 5499b1273ba5..5f580c81d85d 100644 > --- a/Kconfig > +++ b/Kconfig > @@ -32,3 +32,5 @@ source "security/Kconfig" > source "crypto/Kconfig" > > source "lib/Kconfig" > + > +source "lib/Kconfig.debug" Ack having Kernel hacking menu at the end. I've been wanting to do that as well. thanks, -- ~Randy
Re: [PATCH 2/5] Kconfig: consolidate the "Kernel hacking menu"
On 07/02/18 07:47, Christoph Hellwig wrote: > diff --git a/Kconfig b/Kconfig > index 5499b1273ba5..5f580c81d85d 100644 > --- a/Kconfig > +++ b/Kconfig > @@ -32,3 +32,5 @@ source "security/Kconfig" > source "crypto/Kconfig" > > source "lib/Kconfig" > + > +source "lib/Kconfig.debug" Ack having Kernel hacking menu at the end. I've been wanting to do that as well. thanks, -- ~Randy
