Re: [PATCH 2/5] page_migrate: Fix wrong comment in address_space_operations->migratepage()

2013-08-20 Thread Tang Chen 

On 08/20/2013 07:02 PM, Jiri Kosina wrote:

On Thu, 20 Jun 2013, Tang Chen wrote:


There is no parameter "sync" in address_space_operations->migratepage().
It should be mograte_mode. And the comment is for MIGRATE_ASYNC.


I am fixing this typo in changelog :) and applying the series.


Hi Jiri,

Thanks a lot. :)





Signed-off-by: Tang Chen
---
  include/linux/fs.h |4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/fs.h b/include/linux/fs.h
index 43db02e..c1a76ac 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -372,8 +372,8 @@ struct address_space_operations {
int (*get_xip_mem)(struct address_space *, pgoff_t, int,
void **, unsigned long *);
/*
-* migrate the contents of a page to the specified target. If sync
-* is false, it must not block.
+* migrate the contents of a page to the specified target. If
+* migrate_mode is MIGRATE_ASYNC, it must not block.
 */
int (*migratepage) (struct address_space *,
struct page *, struct page *, enum migrate_mode);
--
1.7.1




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 2/5] page_migrate: Fix wrong comment in address_space_operations->migratepage()

2013-08-20 Thread Jiri Kosina 
On Thu, 20 Jun 2013, Tang Chen wrote:

> There is no parameter "sync" in address_space_operations->migratepage().
> It should be mograte_mode. And the comment is for MIGRATE_ASYNC.

I am fixing this typo in changelog :) and applying the series.

> 
> Signed-off-by: Tang Chen 
> ---
>  include/linux/fs.h |4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index 43db02e..c1a76ac 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -372,8 +372,8 @@ struct address_space_operations {
>   int (*get_xip_mem)(struct address_space *, pgoff_t, int,
>   void **, unsigned long *);
>   /*
> -  * migrate the contents of a page to the specified target. If sync
> -  * is false, it must not block.
> +  * migrate the contents of a page to the specified target. If
> +  * migrate_mode is MIGRATE_ASYNC, it must not block.
>*/
>   int (*migratepage) (struct address_space *,
>   struct page *, struct page *, enum migrate_mode);
> -- 
> 1.7.1
> 

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/