Re: [PATCH 2/8] staging: kpc2000: use __func__ in debug messages
On Thu, May 23, 2019 at 02:09:37PM +0200, Simon Sandström wrote:
> On Thu, May 23, 2019 at 01:55:53PM +0200, Greg KH wrote:
> > On Thu, May 23, 2019 at 01:36:07PM +0200, Simon Sandström wrote:
> > > Fixes checkpatch.pl warning "Prefer using '"%s...", __func__' to using
> > > '', this function's name, in a string".
> > >
> > > Signed-off-by: Simon Sandström
> > > ---
> > > drivers/staging/kpc2000/kpc2000/cell_probe.c | 22 +---
> > > 1 file changed, 14 insertions(+), 8 deletions(-)
> > >
> > > diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c
> > > b/drivers/staging/kpc2000/kpc2000/cell_probe.c
> > > index 95bfbe4aae4d..7b850f3e808b 100644
> > > --- a/drivers/staging/kpc2000/kpc2000/cell_probe.c
> > > +++ b/drivers/staging/kpc2000/kpc2000/cell_probe.c
> > > @@ -299,7 +299,8 @@ static int probe_core_uio(unsigned int core_num,
> > > struct kp2000_device *pcard,
> > >
> > > kudev = kzalloc(sizeof(struct kpc_uio_device), GFP_KERNEL);
> > > if (!kudev) {
> > > - dev_err(>pdev->dev, "probe_core_uio: failed to kzalloc
> > > kpc_uio_device\n");
> > > + dev_err(>pdev->dev, "%s: failed to kzalloc
> > > kpc_uio_device\n",
> > > + __func__);
> >
> > kmalloc and friend error messages should just be deleted. Didn't
> > checkpatch say something about that?
> >
> > thanks,
> >
> > greg k-h
>
> Yes sorry, it did. Should I delete this chunk from this patch and add
> another patch to this series that just deletes the message, in v2?
Yes please.
thanks,
greg k-h
Re: [PATCH 2/8] staging: kpc2000: use __func__ in debug messages
On Thu, May 23, 2019 at 01:55:53PM +0200, Greg KH wrote:
> On Thu, May 23, 2019 at 01:36:07PM +0200, Simon Sandström wrote:
> > Fixes checkpatch.pl warning "Prefer using '"%s...", __func__' to using
> > '', this function's name, in a string".
> >
> > Signed-off-by: Simon Sandström
> > ---
> > drivers/staging/kpc2000/kpc2000/cell_probe.c | 22 +---
> > 1 file changed, 14 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c
> > b/drivers/staging/kpc2000/kpc2000/cell_probe.c
> > index 95bfbe4aae4d..7b850f3e808b 100644
> > --- a/drivers/staging/kpc2000/kpc2000/cell_probe.c
> > +++ b/drivers/staging/kpc2000/kpc2000/cell_probe.c
> > @@ -299,7 +299,8 @@ static int probe_core_uio(unsigned int core_num, struct
> > kp2000_device *pcard,
> >
> > kudev = kzalloc(sizeof(struct kpc_uio_device), GFP_KERNEL);
> > if (!kudev) {
> > - dev_err(>pdev->dev, "probe_core_uio: failed to kzalloc
> > kpc_uio_device\n");
> > + dev_err(>pdev->dev, "%s: failed to kzalloc
> > kpc_uio_device\n",
> > + __func__);
>
> kmalloc and friend error messages should just be deleted. Didn't
> checkpatch say something about that?
>
> thanks,
>
> greg k-h
Yes sorry, it did. Should I delete this chunk from this patch and add
another patch to this series that just deletes the message, in v2?
- Simon
Re: [PATCH 2/8] staging: kpc2000: use __func__ in debug messages
On Thu, May 23, 2019 at 01:36:07PM +0200, Simon Sandström wrote:
> Fixes checkpatch.pl warning "Prefer using '"%s...", __func__' to using
> '', this function's name, in a string".
>
> Signed-off-by: Simon Sandström
> ---
> drivers/staging/kpc2000/kpc2000/cell_probe.c | 22 +---
> 1 file changed, 14 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c
> b/drivers/staging/kpc2000/kpc2000/cell_probe.c
> index 95bfbe4aae4d..7b850f3e808b 100644
> --- a/drivers/staging/kpc2000/kpc2000/cell_probe.c
> +++ b/drivers/staging/kpc2000/kpc2000/cell_probe.c
> @@ -299,7 +299,8 @@ static int probe_core_uio(unsigned int core_num, struct
> kp2000_device *pcard,
>
> kudev = kzalloc(sizeof(struct kpc_uio_device), GFP_KERNEL);
> if (!kudev) {
> - dev_err(>pdev->dev, "probe_core_uio: failed to kzalloc
> kpc_uio_device\n");
> + dev_err(>pdev->dev, "%s: failed to kzalloc
> kpc_uio_device\n",
> + __func__);
kmalloc and friend error messages should just be deleted. Didn't
checkpatch say something about that?
thanks,
greg k-h
