Re: [PATCH 2 1/2] coccicheck: Allow the user to give a V= (verbose) argument
On Tue, Jan 29, 2013 at 05:03:37PM +0100, Bernd Schubert wrote:
> Do not run with verbosity on/off depending on the ONLINE variable,
> which gets set with C=1 or C=2, but allow the user to set the
> verbosity using kernel default make V= paramemter.
> Verbosity is off by default now.
On Tue, Jan 29, 2013 at 05:03:42PM +0100, Bernd Schubert wrote:
> On my system one of the tests failed with
> "Fatal error: exception Failure("No OCaml compiler found! Install either
> ocamlopt or ocamlopt.opt")".
>
> Investigating such issues is easier if the executed command line is being
> shown.
I applied both patches to kbuild.git#misc, thanks.
Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2 1/2] coccicheck: Allow the user to give a V= (verbose) argument
On Tue, Jan 29, 2013 at 05:03:37PM +0100, Bernd Schubert wrote: Do not run with verbosity on/off depending on the ONLINE variable, which gets set with C=1 or C=2, but allow the user to set the verbosity using kernel default make V= paramemter. Verbosity is off by default now. On Tue, Jan 29, 2013 at 05:03:42PM +0100, Bernd Schubert wrote: On my system one of the tests failed with Fatal error: exception Failure(No OCaml compiler found! Install either ocamlopt or ocamlopt.opt). Investigating such issues is easier if the executed command line is being shown. I applied both patches to kbuild.git#misc, thanks. Michal -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2 1/2] coccicheck: Allow the user to give a V= (verbose) argument
On Tue, Jan 29, 2013 at 5:03 PM, Bernd Schubert
wrote:
> Do not run with verbosity on/off depending on the ONLINE variable,
> which gets set with C=1 or C=2, but allow the user to set the
> verbosity using kernel default make V= paramemter.
> Verbosity is off by default now.
>
>
> Signed-off-by: Bernd Schubert
> CC: Julia Lawall
> CC: Nicolas Palix
Acked-by: Nicolas Palix
> CC: co...@systeme.lip6.fr
> CC: Michal Marek
> ---
> Documentation/coccinelle.txt |4
> scripts/coccicheck | 11 ++-
> 2 files changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/coccinelle.txt b/Documentation/coccinelle.txt
> index cf44eb6..dffa2d6 100644
> --- a/Documentation/coccinelle.txt
> +++ b/Documentation/coccinelle.txt
> @@ -87,6 +87,10 @@ As any static code analyzer, Coccinelle produces false
> positives. Thus, reports must be carefully checked, and patches
> reviewed.
>
> +To enable verbose messages set the V= variable, for example:
> +
> + make coccicheck MODE=report V=1
> +
>
> Using Coccinelle with a single semantic patch
> ~~~
> diff --git a/scripts/coccicheck b/scripts/coccicheck
> index 1a49d1c..f8f15a2 100755
> --- a/scripts/coccicheck
> +++ b/scripts/coccicheck
> @@ -2,6 +2,15 @@
>
> SPATCH="`which ${SPATCH:=spatch}`"
>
> +# The verbosity may be set by the environmental parameter V=
> +# as for example with 'make V=1 coccicheck'
> +
> +if [ -n "$V" -a "$V" != "0" ]; then
> + VERBOSE=1
> +else
> + VERBOSE=0
> +fi
> +
> if [ "$C" = "1" -o "$C" = "2" ]; then
> ONLINE=1
>
> @@ -55,7 +64,7 @@ coccinelle () {
> #
> #$SPATCH -D $MODE $FLAGS -parse_cocci $COCCI $OPT > /dev/null
>
> -if [ "$ONLINE" = "0" ] ; then
> +if [ $VERBOSE -ne 0 ] ; then
>
> FILE=`echo $COCCI | sed "s|$srctree/||"`
>
>
--
Nicolas Palix
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2 1/2] coccicheck: Allow the user to give a V= (verbose) argument
On Tue, Jan 29, 2013 at 5:03 PM, Bernd Schubert
bernd.schub...@itwm.fraunhofer.de wrote:
Do not run with verbosity on/off depending on the ONLINE variable,
which gets set with C=1 or C=2, but allow the user to set the
verbosity using kernel default make V= paramemter.
Verbosity is off by default now.
Signed-off-by: Bernd Schubert bernd.schub...@itwm.fraunhofer.de
CC: Julia Lawall julia.law...@lip6.fr
CC: Nicolas Palix nicolas.pa...@imag.fr
Acked-by: Nicolas Palix nicolas.pa...@imag.fr
CC: co...@systeme.lip6.fr
CC: Michal Marek mma...@suse.cz
---
Documentation/coccinelle.txt |4
scripts/coccicheck | 11 ++-
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/Documentation/coccinelle.txt b/Documentation/coccinelle.txt
index cf44eb6..dffa2d6 100644
--- a/Documentation/coccinelle.txt
+++ b/Documentation/coccinelle.txt
@@ -87,6 +87,10 @@ As any static code analyzer, Coccinelle produces false
positives. Thus, reports must be carefully checked, and patches
reviewed.
+To enable verbose messages set the V= variable, for example:
+
+ make coccicheck MODE=report V=1
+
Using Coccinelle with a single semantic patch
~~~
diff --git a/scripts/coccicheck b/scripts/coccicheck
index 1a49d1c..f8f15a2 100755
--- a/scripts/coccicheck
+++ b/scripts/coccicheck
@@ -2,6 +2,15 @@
SPATCH=`which ${SPATCH:=spatch}`
+# The verbosity may be set by the environmental parameter V=
+# as for example with 'make V=1 coccicheck'
+
+if [ -n $V -a $V != 0 ]; then
+ VERBOSE=1
+else
+ VERBOSE=0
+fi
+
if [ $C = 1 -o $C = 2 ]; then
ONLINE=1
@@ -55,7 +64,7 @@ coccinelle () {
#
#$SPATCH -D $MODE $FLAGS -parse_cocci $COCCI $OPT /dev/null
-if [ $ONLINE = 0 ] ; then
+if [ $VERBOSE -ne 0 ] ; then
FILE=`echo $COCCI | sed s|$srctree/||`
--
Nicolas Palix
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
