Re: [PATCH 2.6.11-rc2 14/29] ide: remove NULL checking in ide_error()
On Wed, 2 Feb 2005 11:57:28 +0900, Tejun Heo <[EMAIL PROTECTED]> wrote: > > 14_ide_error_remove_NULL_test.patch > > > > In ide_error(), drive cannot be NULL. ide_dump_status() can't > > handle NULL drive. applied, you missed Signed-off-by line - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2.6.11-rc2 14/29] ide: remove NULL checking in ide_error()
On Wed, 2 Feb 2005 11:57:28 +0900, Tejun Heo [EMAIL PROTECTED] wrote: 14_ide_error_remove_NULL_test.patch In ide_error(), drive cannot be NULL. ide_dump_status() can't handle NULL drive. applied, you missed Signed-off-by line - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2.6.11-rc2 14/29] ide: remove NULL checking in ide_error()
> 14_ide_error_remove_NULL_test.patch > > In ide_error(), drive cannot be NULL. ide_dump_status() can't > handle NULL drive. Index: linux-ide-export/drivers/ide/ide-io.c === --- linux-ide-export.orig/drivers/ide/ide-io.c 2005-02-02 10:28:04.465321080 +0900 +++ linux-ide-export/drivers/ide/ide-io.c 2005-02-02 10:28:04.904249864 +0900 @@ -555,7 +555,7 @@ ide_startstop_t ide_error (ide_drive_t * err = ide_dump_status(drive, msg, stat); - if (drive == NULL || (rq = HWGROUP(drive)->rq) == NULL) + if ((rq = HWGROUP(drive)->rq) == NULL) return ide_stopped; /* retry only "normal" I/O: */ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2.6.11-rc2 14/29] ide: remove NULL checking in ide_error()
14_ide_error_remove_NULL_test.patch In ide_error(), drive cannot be NULL. ide_dump_status() can't handle NULL drive. Index: linux-ide-export/drivers/ide/ide-io.c === --- linux-ide-export.orig/drivers/ide/ide-io.c 2005-02-02 10:28:04.465321080 +0900 +++ linux-ide-export/drivers/ide/ide-io.c 2005-02-02 10:28:04.904249864 +0900 @@ -555,7 +555,7 @@ ide_startstop_t ide_error (ide_drive_t * err = ide_dump_status(drive, msg, stat); - if (drive == NULL || (rq = HWGROUP(drive)-rq) == NULL) + if ((rq = HWGROUP(drive)-rq) == NULL) return ide_stopped; /* retry only normal I/O: */ - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
