Re: [PATCH 3/3] arm64: Kconfig: support CONFIG_KASAN_VMALLOC
Hi Andrey, > On Sun, Jan 3, 2021 at 6:13 PM Lecopzer Chen wrote: > > > > Now I have no device to test for HW_TAG, so keep it not selected > > until someone can test this. > > > > Signed-off-by: Lecopzer Chen > > --- > > arch/arm64/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > > index 05e17351e4f3..29ab35aab59e 100644 > > --- a/arch/arm64/Kconfig > > +++ b/arch/arm64/Kconfig > > @@ -136,6 +136,7 @@ config ARM64 > > select HAVE_ARCH_JUMP_LABEL > > select HAVE_ARCH_JUMP_LABEL_RELATIVE > > select HAVE_ARCH_KASAN if !(ARM64_16K_PAGES && ARM64_VA_BITS_48) > > + select HAVE_ARCH_KASAN_VMALLOC if (HAVE_ARCH_KASAN && > > !KASAN_HW_TAGS) > > KASAN_VMALLOC currently "depends on" KASAN_GENERIC. I think we should > either do "HAVE_ARCH_KASAN && KASAN_GENERIC" here as well, or just do > "if HAVE_ARCH_KASAN". Thanks for the correctness, I'll change to the following in V2 patch. "select HAVE_ARCH_KASAN_VMALLOC if HAVE_ARCH_KASAN" Let KASAN_VMALLOC depend on the mode it supports to avoid modifying two places if KASAN_VMALLOC can support other than GENERIC in the future.
Re: [PATCH 3/3] arm64: Kconfig: support CONFIG_KASAN_VMALLOC
On Sun, Jan 3, 2021 at 6:13 PM Lecopzer Chen wrote: > > Now I have no device to test for HW_TAG, so keep it not selected > until someone can test this. > > Signed-off-by: Lecopzer Chen > --- > arch/arm64/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 05e17351e4f3..29ab35aab59e 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -136,6 +136,7 @@ config ARM64 > select HAVE_ARCH_JUMP_LABEL > select HAVE_ARCH_JUMP_LABEL_RELATIVE > select HAVE_ARCH_KASAN if !(ARM64_16K_PAGES && ARM64_VA_BITS_48) > + select HAVE_ARCH_KASAN_VMALLOC if (HAVE_ARCH_KASAN && !KASAN_HW_TAGS) KASAN_VMALLOC currently "depends on" KASAN_GENERIC. I think we should either do "HAVE_ARCH_KASAN && KASAN_GENERIC" here as well, or just do "if HAVE_ARCH_KASAN". > select HAVE_ARCH_KASAN_SW_TAGS if HAVE_ARCH_KASAN > select HAVE_ARCH_KASAN_HW_TAGS if (HAVE_ARCH_KASAN && ARM64_MTE) > select HAVE_ARCH_KGDB > -- > 2.25.1 > > -- > You received this message because you are subscribed to the Google Groups > "kasan-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to kasan-dev+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/kasan-dev/20210103171137.153834-4-lecopzer%40gmail.com.