Re: [PATCH 3/3] drm/amdgpu/display: fix integer arithmetic problem

[Harry Wentland]

On 2017-11-02 07:26 AM, Arnd Bergmann wrote:
> gcc warns about an ambiguous integer calculation:
> 
> drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c: In function 
> 'calculate_bandwidth':
> drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:534:5: error: this 
> decimal constant is unsigned only in ISO C90 [-Werror]
>  data->lb_line_pitch = bw_ceil2(bw_mul(bw_div(bw_frc_to_fixed(2401171875, 
> 1), bw_int_to_fixed(3)), bw_ceil2(data->source_width_in_lb, 
> bw_int_to_fixed(8))), bw_int_to_fixed(48));
>  ^~~~
> 
> Marking the constant as explicitly unsigned makes it work fine everywhere
> without warnings.
> 
> Signed-off-by: Arnd Bergmann 

Thanks for these fixes.

Series is
Reviewed-by: Harry Wentland 

Harry

> ---
>  drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c 
> b/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c
> index 15cbfc400633..4f8a95368ffc 100644
> --- a/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c
> +++ b/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c
> @@ -531,7 +531,7 @@ static void calculate_bandwidth(
>   }
>   switch (data->lb_bpc[i]) {
>   case 8:
> - data->lb_line_pitch = 
> bw_ceil2(bw_mul(bw_div(bw_frc_to_fixed(2401171875, 1), 
> bw_int_to_fixed(3)), bw_ceil2(data->source_width_in_lb, bw_int_to_fixed(8))), 
> bw_int_to_fixed(48));
> + data->lb_line_pitch = 
> bw_ceil2(bw_mul(bw_div(bw_frc_to_fixed(2401171875ul, 1), 
> bw_int_to_fixed(3)), bw_ceil2(data->source_width_in_lb, bw_int_to_fixed(8))), 
> bw_int_to_fixed(48));
>   break;
>   case 10:
>   data->lb_line_pitch = 
> bw_ceil2(bw_mul(bw_div(bw_frc_to_fixed(300234375, 1000), 
> bw_int_to_fixed(3)), bw_ceil2(data->source_width_in_lb, bw_int_to_fixed(8))), 
> bw_int_to_fixed(48));
> 

Re: [PATCH 3/3] drm/amdgpu/display: fix integer arithmetic problem

[Harry Wentland]

On 2017-11-02 07:26 AM, Arnd Bergmann wrote:
> gcc warns about an ambiguous integer calculation:
> 
> drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c: In function 
> 'calculate_bandwidth':
> drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:534:5: error: this 
> decimal constant is unsigned only in ISO C90 [-Werror]
>  data->lb_line_pitch = bw_ceil2(bw_mul(bw_div(bw_frc_to_fixed(2401171875, 
> 1), bw_int_to_fixed(3)), bw_ceil2(data->source_width_in_lb, 
> bw_int_to_fixed(8))), bw_int_to_fixed(48));
>  ^~~~
> 
> Marking the constant as explicitly unsigned makes it work fine everywhere
> without warnings.
> 
> Signed-off-by: Arnd Bergmann 

Thanks for these fixes.

Series is
Reviewed-by: Harry Wentland 

Harry

> ---
>  drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c 
> b/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c
> index 15cbfc400633..4f8a95368ffc 100644
> --- a/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c
> +++ b/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c
> @@ -531,7 +531,7 @@ static void calculate_bandwidth(
>   }
>   switch (data->lb_bpc[i]) {
>   case 8:
> - data->lb_line_pitch = 
> bw_ceil2(bw_mul(bw_div(bw_frc_to_fixed(2401171875, 1), 
> bw_int_to_fixed(3)), bw_ceil2(data->source_width_in_lb, bw_int_to_fixed(8))), 
> bw_int_to_fixed(48));
> + data->lb_line_pitch = 
> bw_ceil2(bw_mul(bw_div(bw_frc_to_fixed(2401171875ul, 1), 
> bw_int_to_fixed(3)), bw_ceil2(data->source_width_in_lb, bw_int_to_fixed(8))), 
> bw_int_to_fixed(48));
>   break;
>   case 10:
>   data->lb_line_pitch = 
> bw_ceil2(bw_mul(bw_div(bw_frc_to_fixed(300234375, 1000), 
> bw_int_to_fixed(3)), bw_ceil2(data->source_width_in_lb, bw_int_to_fixed(8))), 
> bw_int_to_fixed(48));
>