Re: [PATCH 3/3] lib: Update LZ4 compressor module based on LZ4 v1.7.2.

[Sven Schmidt]

On 12/22/2016 06:31 PM, Greg KH wrote:
>On Wed, Dec 21, 2016 at 09:04:02PM +0100, Sven Schmidt wrote:
>> On 12/20/2016 08:52 PM, Joe Perches wrote:
>> > On Tue, 2016-12-20 at 19:53 +0100, Sven Schmidt wrote:
>> >> This patch updates LZ4 kernel module to LZ4 v1.7.2 by Yann Collet.
>> >> The kernel module is inspired by the previous work by Chanho Min.
>> >> The updated LZ4 module will not break existing code since there were alias
>> >> methods added to ensure backwards compatibility.
>> >
>> >[]
>> >
>> >> diff --git a/include/linux/lz4.h b/include/linux/lz4.h
>> > []
>> >> @@ -1,87 +1,218 @@
>> >>  #ifndef __LZ4_H__
>> >>  #define __LZ4_H__
>> >> +
>> >>  /*
>> >>   * LZ4 Kernel Interface
>> >>   *
>> >> - * Copyright (C) 2013, LG Electronics, Kyungsik Lee 
>> >> 
>> >> + * Copyright (C) 2016, Sven Schmidt <4ssch...@informatik.uni-hamburg.de>
>> >
>> > Deleting copyright notices is poor form and shouldn't be done.
>> >
>> > I didn't look at the rest
>> >
>>
>> Thanks Joe for your time. If you would take a look at the rest, you may 
>> notice
>> that I changed almost the whole file. That's why I also changed the 
>> copyright note.
>> If you think I should keep the original note, I will do that.
>
>You have to, please consult a lawyer if you have questions about
>copyright issues.  Or better yet, there's a free presentation/course
>online about copyright on the linuxfoundation.org website somewhere that
>should answer all of your questions here.  I recommend taking a few
>minutes and going through that.
>
>thanks,
>
>greg k-h
>

Will do, thanks Greg!

Re: [PATCH 3/3] lib: Update LZ4 compressor module based on LZ4 v1.7.2.

[Sven Schmidt]

On 12/22/2016 06:31 PM, Greg KH wrote:
>On Wed, Dec 21, 2016 at 09:04:02PM +0100, Sven Schmidt wrote:
>> On 12/20/2016 08:52 PM, Joe Perches wrote:
>> > On Tue, 2016-12-20 at 19:53 +0100, Sven Schmidt wrote:
>> >> This patch updates LZ4 kernel module to LZ4 v1.7.2 by Yann Collet.
>> >> The kernel module is inspired by the previous work by Chanho Min.
>> >> The updated LZ4 module will not break existing code since there were alias
>> >> methods added to ensure backwards compatibility.
>> >
>> >[]
>> >
>> >> diff --git a/include/linux/lz4.h b/include/linux/lz4.h
>> > []
>> >> @@ -1,87 +1,218 @@
>> >>  #ifndef __LZ4_H__
>> >>  #define __LZ4_H__
>> >> +
>> >>  /*
>> >>   * LZ4 Kernel Interface
>> >>   *
>> >> - * Copyright (C) 2013, LG Electronics, Kyungsik Lee 
>> >> 
>> >> + * Copyright (C) 2016, Sven Schmidt <4ssch...@informatik.uni-hamburg.de>
>> >
>> > Deleting copyright notices is poor form and shouldn't be done.
>> >
>> > I didn't look at the rest
>> >
>>
>> Thanks Joe for your time. If you would take a look at the rest, you may 
>> notice
>> that I changed almost the whole file. That's why I also changed the 
>> copyright note.
>> If you think I should keep the original note, I will do that.
>
>You have to, please consult a lawyer if you have questions about
>copyright issues.  Or better yet, there's a free presentation/course
>online about copyright on the linuxfoundation.org website somewhere that
>should answer all of your questions here.  I recommend taking a few
>minutes and going through that.
>
>thanks,
>
>greg k-h
>

Will do, thanks Greg!

Re: [PATCH 3/3] lib: Update LZ4 compressor module based on LZ4 v1.7.2.

[Greg KH]

On Wed, Dec 21, 2016 at 09:04:02PM +0100, Sven Schmidt wrote:
> On 12/20/2016 08:52 PM, Joe Perches wrote:
> > On Tue, 2016-12-20 at 19:53 +0100, Sven Schmidt wrote:
> >> This patch updates LZ4 kernel module to LZ4 v1.7.2 by Yann Collet.
> >> The kernel module is inspired by the previous work by Chanho Min.
> >> The updated LZ4 module will not break existing code since there were alias
> >> methods added to ensure backwards compatibility.
> >
> >[]
> >
> >> diff --git a/include/linux/lz4.h b/include/linux/lz4.h
> > []
> >> @@ -1,87 +1,218 @@
> >>  #ifndef __LZ4_H__
> >>  #define __LZ4_H__
> >> +
> >>  /*
> >>   * LZ4 Kernel Interface
> >>   *
> >> - * Copyright (C) 2013, LG Electronics, Kyungsik Lee 
> >> + * Copyright (C) 2016, Sven Schmidt <4ssch...@informatik.uni-hamburg.de>
> >
> > Deleting copyright notices is poor form and shouldn't be done.
> >
> > I didn't look at the rest
> >
> 
> Thanks Joe for your time. If you would take a look at the rest, you may notice
> that I changed almost the whole file. That's why I also changed the copyright 
> note.
> If you think I should keep the original note, I will do that.

You have to, please consult a lawyer if you have questions about
copyright issues.  Or better yet, there's a free presentation/course
online about copyright on the linuxfoundation.org website somewhere that
should answer all of your questions here.  I recommend taking a few
minutes and going through that.

thanks,

greg k-h

Re: [PATCH 3/3] lib: Update LZ4 compressor module based on LZ4 v1.7.2.

[Greg KH]

On Wed, Dec 21, 2016 at 09:04:02PM +0100, Sven Schmidt wrote:
> On 12/20/2016 08:52 PM, Joe Perches wrote:
> > On Tue, 2016-12-20 at 19:53 +0100, Sven Schmidt wrote:
> >> This patch updates LZ4 kernel module to LZ4 v1.7.2 by Yann Collet.
> >> The kernel module is inspired by the previous work by Chanho Min.
> >> The updated LZ4 module will not break existing code since there were alias
> >> methods added to ensure backwards compatibility.
> >
> >[]
> >
> >> diff --git a/include/linux/lz4.h b/include/linux/lz4.h
> > []
> >> @@ -1,87 +1,218 @@
> >>  #ifndef __LZ4_H__
> >>  #define __LZ4_H__
> >> +
> >>  /*
> >>   * LZ4 Kernel Interface
> >>   *
> >> - * Copyright (C) 2013, LG Electronics, Kyungsik Lee 
> >> + * Copyright (C) 2016, Sven Schmidt <4ssch...@informatik.uni-hamburg.de>
> >
> > Deleting copyright notices is poor form and shouldn't be done.
> >
> > I didn't look at the rest
> >
> 
> Thanks Joe for your time. If you would take a look at the rest, you may notice
> that I changed almost the whole file. That's why I also changed the copyright 
> note.
> If you think I should keep the original note, I will do that.

You have to, please consult a lawyer if you have questions about
copyright issues.  Or better yet, there's a free presentation/course
online about copyright on the linuxfoundation.org website somewhere that
should answer all of your questions here.  I recommend taking a few
minutes and going through that.

thanks,

greg k-h

Re: [PATCH 3/3] lib: Update LZ4 compressor module based on LZ4 v1.7.2.

[Sven Schmidt]

On 12/20/2016 08:52 PM, Joe Perches wrote:
> On Tue, 2016-12-20 at 19:53 +0100, Sven Schmidt wrote:
>> This patch updates LZ4 kernel module to LZ4 v1.7.2 by Yann Collet.
>> The kernel module is inspired by the previous work by Chanho Min.
>> The updated LZ4 module will not break existing code since there were alias
>> methods added to ensure backwards compatibility.
>
>[]
>
>> diff --git a/include/linux/lz4.h b/include/linux/lz4.h
> []
>> @@ -1,87 +1,218 @@
>>  #ifndef __LZ4_H__
>>  #define __LZ4_H__
>> +
>>  /*
>>   * LZ4 Kernel Interface
>>   *
>> - * Copyright (C) 2013, LG Electronics, Kyungsik Lee 
>> + * Copyright (C) 2016, Sven Schmidt <4ssch...@informatik.uni-hamburg.de>
>
> Deleting copyright notices is poor form and shouldn't be done.
>
> I didn't look at the rest
>

Thanks Joe for your time. If you would take a look at the rest, you may notice
that I changed almost the whole file. That's why I also changed the copyright 
note.
If you think I should keep the original note, I will do that.

What I did change:
- I included additional information stating that the file is based on Yann 
Collets
original header file (especially in matters of the function comments)

Sven

Re: [PATCH 3/3] lib: Update LZ4 compressor module based on LZ4 v1.7.2.

[Sven Schmidt]

On 12/20/2016 08:52 PM, Joe Perches wrote:
> On Tue, 2016-12-20 at 19:53 +0100, Sven Schmidt wrote:
>> This patch updates LZ4 kernel module to LZ4 v1.7.2 by Yann Collet.
>> The kernel module is inspired by the previous work by Chanho Min.
>> The updated LZ4 module will not break existing code since there were alias
>> methods added to ensure backwards compatibility.
>
>[]
>
>> diff --git a/include/linux/lz4.h b/include/linux/lz4.h
> []
>> @@ -1,87 +1,218 @@
>>  #ifndef __LZ4_H__
>>  #define __LZ4_H__
>> +
>>  /*
>>   * LZ4 Kernel Interface
>>   *
>> - * Copyright (C) 2013, LG Electronics, Kyungsik Lee 
>> + * Copyright (C) 2016, Sven Schmidt <4ssch...@informatik.uni-hamburg.de>
>
> Deleting copyright notices is poor form and shouldn't be done.
>
> I didn't look at the rest
>

Thanks Joe for your time. If you would take a look at the rest, you may notice
that I changed almost the whole file. That's why I also changed the copyright 
note.
If you think I should keep the original note, I will do that.

What I did change:
- I included additional information stating that the file is based on Yann 
Collets
original header file (especially in matters of the function comments)

Sven

Re: [PATCH 3/3] lib: Update LZ4 compressor module based on LZ4 v1.7.2.

[kbuild test robot]

Hi Sven,

[auto build test ERROR on linus/master]
[also build test ERROR on next-20161221]
[cannot apply to v4.9]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Sven-Schmidt/Update-LZ4-compressor-module/20161221-130109
config: x86_64-randconfig-r0-12211341 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64 

All errors (new ones prefixed by >>):

   In file included from /usr/lib/gcc/x86_64-linux-gnu/6/include/stdint.h:11:0,
from 
arch/x86/boot/compressed/../../../../lib/lz4/lz4defs.h:60,
from 
arch/x86/boot/compressed/../../../../lib/lz4/lz4_decompress.c:36,
from 
arch/x86/boot/compressed/../../../../lib/decompress_unlz4.c:13,
from arch/x86/boot/compressed/misc.c:75:
>> /usr/lib/gcc/x86_64-linux-gnu/6/include/stdint-gcc.h:43:24: error: 
>> conflicting types for 'int64_t'
typedef __INT64_TYPE__ int64_t;
   ^~~
   In file included from include/uapi/linux/screen_info.h:4:0,
from include/linux/screen_info.h:4,
from arch/x86/boot/compressed/misc.h:15,
from arch/x86/boot/compressed/misc.c:14:
   include/linux/types.h:113:17: note: previous declaration of 'int64_t' was 
here
typedef  __s64  int64_t;
^~~
   In file included from /usr/lib/gcc/x86_64-linux-gnu/6/include/stdint.h:11:0,
from 
arch/x86/boot/compressed/../../../../lib/lz4/lz4defs.h:60,
from 
arch/x86/boot/compressed/../../../../lib/lz4/lz4_decompress.c:36,
from 
arch/x86/boot/compressed/../../../../lib/decompress_unlz4.c:13,
from arch/x86/boot/compressed/misc.c:75:
>> /usr/lib/gcc/x86_64-linux-gnu/6/include/stdint-gcc.h:55:25: error: 
>> conflicting types for 'uint64_t'
typedef __UINT64_TYPE__ uint64_t;
^~~~
   In file included from include/uapi/linux/screen_info.h:4:0,
from include/linux/screen_info.h:4,
from arch/x86/boot/compressed/misc.h:15,
from arch/x86/boot/compressed/misc.c:14:
   include/linux/types.h:111:17: note: previous declaration of 'uint64_t' was 
here
typedef  __u64  uint64_t;
^~~~

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

Re: [PATCH 3/3] lib: Update LZ4 compressor module based on LZ4 v1.7.2.

[kbuild test robot]

Hi Sven,

[auto build test ERROR on linus/master]
[also build test ERROR on next-20161221]
[cannot apply to v4.9]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Sven-Schmidt/Update-LZ4-compressor-module/20161221-130109
config: x86_64-randconfig-r0-12211341 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64 

All errors (new ones prefixed by >>):

   In file included from /usr/lib/gcc/x86_64-linux-gnu/6/include/stdint.h:11:0,
from 
arch/x86/boot/compressed/../../../../lib/lz4/lz4defs.h:60,
from 
arch/x86/boot/compressed/../../../../lib/lz4/lz4_decompress.c:36,
from 
arch/x86/boot/compressed/../../../../lib/decompress_unlz4.c:13,
from arch/x86/boot/compressed/misc.c:75:
>> /usr/lib/gcc/x86_64-linux-gnu/6/include/stdint-gcc.h:43:24: error: 
>> conflicting types for 'int64_t'
typedef __INT64_TYPE__ int64_t;
   ^~~
   In file included from include/uapi/linux/screen_info.h:4:0,
from include/linux/screen_info.h:4,
from arch/x86/boot/compressed/misc.h:15,
from arch/x86/boot/compressed/misc.c:14:
   include/linux/types.h:113:17: note: previous declaration of 'int64_t' was 
here
typedef  __s64  int64_t;
^~~
   In file included from /usr/lib/gcc/x86_64-linux-gnu/6/include/stdint.h:11:0,
from 
arch/x86/boot/compressed/../../../../lib/lz4/lz4defs.h:60,
from 
arch/x86/boot/compressed/../../../../lib/lz4/lz4_decompress.c:36,
from 
arch/x86/boot/compressed/../../../../lib/decompress_unlz4.c:13,
from arch/x86/boot/compressed/misc.c:75:
>> /usr/lib/gcc/x86_64-linux-gnu/6/include/stdint-gcc.h:55:25: error: 
>> conflicting types for 'uint64_t'
typedef __UINT64_TYPE__ uint64_t;
^~~~
   In file included from include/uapi/linux/screen_info.h:4:0,
from include/linux/screen_info.h:4,
from arch/x86/boot/compressed/misc.h:15,
from arch/x86/boot/compressed/misc.c:14:
   include/linux/types.h:111:17: note: previous declaration of 'uint64_t' was 
here
typedef  __u64  uint64_t;
^~~~

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

Re: [PATCH 3/3] lib: Update LZ4 compressor module based on LZ4 v1.7.2.

[Joe Perches]

On Tue, 2016-12-20 at 19:53 +0100, Sven Schmidt wrote:
> This patch updates LZ4 kernel module to LZ4 v1.7.2 by Yann Collet.
> The kernel module is inspired by the previous work by Chanho Min.
> The updated LZ4 module will not break existing code since there were alias
> methods added to ensure backwards compatibility.

[]

> diff --git a/include/linux/lz4.h b/include/linux/lz4.h
[]
> @@ -1,87 +1,218 @@
>  #ifndef __LZ4_H__
>  #define __LZ4_H__
> +
>  /*
>   * LZ4 Kernel Interface
>   *
> - * Copyright (C) 2013, LG Electronics, Kyungsik Lee 
> + * Copyright (C) 2016, Sven Schmidt <4ssch...@informatik.uni-hamburg.de>

Deleting copyright notices is poor form and shouldn't be done.

I didn't look at the rest

Re: [PATCH 3/3] lib: Update LZ4 compressor module based on LZ4 v1.7.2.

[Joe Perches]

On Tue, 2016-12-20 at 19:53 +0100, Sven Schmidt wrote:
> This patch updates LZ4 kernel module to LZ4 v1.7.2 by Yann Collet.
> The kernel module is inspired by the previous work by Chanho Min.
> The updated LZ4 module will not break existing code since there were alias
> methods added to ensure backwards compatibility.

[]

> diff --git a/include/linux/lz4.h b/include/linux/lz4.h
[]
> @@ -1,87 +1,218 @@
>  #ifndef __LZ4_H__
>  #define __LZ4_H__
> +
>  /*
>   * LZ4 Kernel Interface
>   *
> - * Copyright (C) 2013, LG Electronics, Kyungsik Lee 
> + * Copyright (C) 2016, Sven Schmidt <4ssch...@informatik.uni-hamburg.de>

Deleting copyright notices is poor form and shouldn't be done.

I didn't look at the rest