Re: [PATCH 3/3] riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver
On Mon, Jul 22, 2019 at 02:48:40PM -0700, Paul Walmsley wrote: > On Fri, 19 Jul 2019, Yash Shah wrote: > > > DT node for SiFive FU540-C000 GEMGXL Ethernet controller driver added > > > > Signed-off-by: Yash Shah > > Thanks, queuing this one for v5.3-rc with Andrew's suggested change to > change phy1 to phy0. > > Am assuming patches 1 and 2 will go in via -net. I don't think that has happened. Rob
Re: [PATCH 3/3] riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver
On Fri, 19 Jul 2019, Yash Shah wrote: > DT node for SiFive FU540-C000 GEMGXL Ethernet controller driver added > > Signed-off-by: Yash Shah Thanks, queuing this one for v5.3-rc with Andrew's suggested change to change phy1 to phy0. Am assuming patches 1 and 2 will go in via -net. - Paul
Re: [PATCH 3/3] riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver
Hello Andrew,
On Fri, Jul 19, 2019 at 6:57 PM Andrew Lunn wrote:
>
> On Fri, Jul 19, 2019 at 05:23:45PM +0530, Sagar Kadam wrote:
> > > + {
> > > + status = "okay";
> > > + phy-mode = "gmii";
> > > + phy-handle = <>;
> > > + phy1: ethernet-phy@0 {
> > > + reg = <0>;
> > > + };
>
> Hi Sagar
>
> Is there a good reason to call it phy1? Is there a phy0?
>
Sorry for the delayed response.
There is a single phy, so yes phy0 is a better name.
Thank you for pointing this out.
Thanks & Regards,
Sagar Kadam
> Thanks
>
>Andrew
>
> ___
> linux-riscv mailing list
> linux-ri...@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
Re: [PATCH 3/3] riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver
On Fri, Jul 19, 2019 at 05:23:45PM +0530, Sagar Kadam wrote:
> > + {
> > + status = "okay";
> > + phy-mode = "gmii";
> > + phy-handle = <>;
> > + phy1: ethernet-phy@0 {
> > + reg = <0>;
> > + };
Hi Sagar
Is there a good reason to call it phy1? Is there a phy0?
Thanks
Andrew
Re: [PATCH 3/3] riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver
The series looks good to me.
Reviewed-by: Sagar Kadam
On Fri, Jul 19, 2019 at 4:41 PM Yash Shah wrote:
>
> DT node for SiFive FU540-C000 GEMGXL Ethernet controller driver added
>
> Signed-off-by: Yash Shah
> ---
> arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 15 +++
> arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 9 +
> 2 files changed, 24 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi
> b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi
> index cc73522..588669f0 100644
> --- a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi
> +++ b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi
> @@ -231,5 +231,20 @@
> #size-cells = <0>;
> status = "disabled";
> };
> + eth0: ethernet@1009 {
> + compatible = "sifive,fu540-c000-gem";
> + interrupt-parent = <>;
> + interrupts = <53>;
> + reg = <0x0 0x1009 0x0 0x2000
> + 0x0 0x100a 0x0 0x1000>;
> + local-mac-address = [00 00 00 00 00 00];
> + clock-names = "pclk", "hclk";
> + clocks = < PRCI_CLK_GEMGXLPLL>,
> +< PRCI_CLK_GEMGXLPLL>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
> +
> };
> };
> diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
> b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
> index 0b55c53..85c17a7 100644
> --- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
> +++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
> @@ -76,3 +76,12 @@
> disable-wp;
> };
> };
> +
> + {
> + status = "okay";
> + phy-mode = "gmii";
> + phy-handle = <>;
> + phy1: ethernet-phy@0 {
> + reg = <0>;
> + };
> +};
> --
> 1.9.1
>
>
> ___
> linux-riscv mailing list
> linux-ri...@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
