Re: [PATCH 3/4] mfd: arizona: Switch to using clock driver for 32k clock
On Wed, Jan 06, 2016 at 12:19:56AM +0800, kbuild test robot wrote: > Hi Charles, > > [auto build test WARNING on clk/clk-next] > [also build test WARNING on v4.4-rc8 next-20160105] > [if your patch is applied to the wrong git tree, please drop us a note to > help improving the system] > > url: > https://github.com/0day-ci/linux/commits/Charles-Keepax/extcon-arizona-Remove-enable-disable-of-32k-clock/20160105-234658 > base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next > config: x86_64-randconfig-x013-01041832 (attached as .config) > reproduce: > # save the attached .config to linux build tree > make ARCH=x86_64 > > All warnings (new ones prefixed by >>): > > warning: (MFD_ARIZONA) selects COMMON_CLK_ARIZONA which has unmet direct > dependencies (COMMON_CLK && MFD_ARIZONA) Apologies this is caused by the select I put in the MFD Kconfig, since it doesn't really make much sense to build the MFD without the clock driver. But I think probably the simplest solution is just to drop that, otherwise we start kicking off all sorts of exciting circular dependencies that Kconfig doesn't like. Its not necessarily a sensible config to use but at least it will all build fine. I will send a version 2 with the other small comment fixed up as well. Thanks, Charles -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 3/4] mfd: arizona: Switch to using clock driver for 32k clock
On Wed, Jan 06, 2016 at 12:19:56AM +0800, kbuild test robot wrote: > Hi Charles, > > [auto build test WARNING on clk/clk-next] > [also build test WARNING on v4.4-rc8 next-20160105] > [if your patch is applied to the wrong git tree, please drop us a note to > help improving the system] > > url: > https://github.com/0day-ci/linux/commits/Charles-Keepax/extcon-arizona-Remove-enable-disable-of-32k-clock/20160105-234658 > base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next > config: x86_64-randconfig-x013-01041832 (attached as .config) > reproduce: > # save the attached .config to linux build tree > make ARCH=x86_64 > > All warnings (new ones prefixed by >>): > > warning: (MFD_ARIZONA) selects COMMON_CLK_ARIZONA which has unmet direct > dependencies (COMMON_CLK && MFD_ARIZONA) Apologies this is caused by the select I put in the MFD Kconfig, since it doesn't really make much sense to build the MFD without the clock driver. But I think probably the simplest solution is just to drop that, otherwise we start kicking off all sorts of exciting circular dependencies that Kconfig doesn't like. Its not necessarily a sensible config to use but at least it will all build fine. I will send a version 2 with the other small comment fixed up as well. Thanks, Charles -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 3/4] mfd: arizona: Switch to using clock driver for 32k clock
Hi Charles, [auto build test ERROR on clk/clk-next] [also build test ERROR on v4.4-rc8 next-20160105] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Charles-Keepax/extcon-arizona-Remove-enable-disable-of-32k-clock/20160105-234658 base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next config: i386-randconfig-s1-201601 (attached as .config) reproduce: # save the attached .config to linux build tree make ARCH=i386 All error/warnings (new ones prefixed by >>): >> drivers/clk/clk-arizona.c:31:16: error: field 'clk32k_hw' has incomplete type struct clk_hw clk32k_hw; ^ In file included from include/asm-generic/bug.h:13:0, from arch/x86/include/asm/bug.h:35, from include/linux/bug.h:4, from include/linux/mmdebug.h:4, from include/linux/gfp.h:4, from include/linux/slab.h:14, from include/asm-generic/clkdev.h:16, from arch/x86/include/generated/asm/clkdev.h:1, from include/linux/clkdev.h:15, from drivers/clk/clk-arizona.c:14: drivers/clk/clk-arizona.c: In function 'clk32k_to_arizona_clk': include/linux/kernel.h:813:48: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types] const typeof( ((type *)0)->member ) *__mptr = (ptr); \ ^ >> drivers/clk/clk-arizona.c:37:9: note: in expansion of macro 'container_of' return container_of(hw, struct arizona_clk, clk32k_hw); ^ drivers/clk/clk-arizona.c: At top level: >> drivers/clk/clk-arizona.c:77:21: error: variable 'arizona_32k_ops' has >> initializer but incomplete type static const struct clk_ops arizona_32k_ops = { ^ >> drivers/clk/clk-arizona.c:78:2: error: unknown field 'prepare' specified in >> initializer .prepare = arizona_32k_enable, ^ >> drivers/clk/clk-arizona.c:78:13: warning: excess elements in struct >> initializer .prepare = arizona_32k_enable, ^ drivers/clk/clk-arizona.c:78:13: note: (near initialization for 'arizona_32k_ops') >> drivers/clk/clk-arizona.c:79:2: error: unknown field 'unprepare' specified >> in initializer .unprepare = arizona_32k_disable, ^ drivers/clk/clk-arizona.c:79:15: warning: excess elements in struct initializer .unprepare = arizona_32k_disable, ^ drivers/clk/clk-arizona.c:79:15: note: (near initialization for 'arizona_32k_ops') drivers/clk/clk-arizona.c: In function 'arizona_clk_of_get_pdata': >> drivers/clk/clk-arizona.c:98:35: error: implicit declaration of function >> '__clk_get_name' [-Werror=implicit-function-declaration] arizona->pdata.clk32k_parent = __clk_get_name(mclk); ^ >> drivers/clk/clk-arizona.c:98:33: warning: assignment makes pointer from >> integer without a cast [-Wint-conversion] arizona->pdata.clk32k_parent = __clk_get_name(mclk); ^ drivers/clk/clk-arizona.c: In function 'arizona_clk_probe': >> drivers/clk/clk-arizona.c:113:9: error: variable 'clk32k_init' has >> initializer but incomplete type struct clk_init_data clk32k_init = { ^ >> drivers/clk/clk-arizona.c:114:3: error: unknown field 'name' specified in >> initializer .name = "arizona-32k", ^ drivers/clk/clk-arizona.c:114:11: warning: excess elements in struct initializer .name = "arizona-32k", ^ drivers/clk/clk-arizona.c:114:11: note: (near initialization for 'clk32k_init') >> drivers/clk/clk-arizona.c:115:3: error: unknown field 'ops' specified in >> initializer .ops = _32k_ops, ^ drivers/clk/clk-arizona.c:115:10: warning: excess elements in struct initializer .ops = _32k_ops, ^ drivers/clk/clk-arizona.c:115:10: note: (near initialization for 'clk32k_init') >> drivers/clk/clk-arizona.c:113:23: error: storage size of 'clk32k_init' isn't >> known struct clk_init_data clk32k_init = { ^ >> drivers/clk/clk-arizona.c:154:24: error: 'CLK_IS_ROOT' undeclared (first use >> in this function) clk32k_init.flags |= CLK_IS_ROOT; ^ drivers/clk/clk-arizona.c:154:24: note: each undeclared identifier is reported only once for each function it appears in >> drivers/clk/clk-arizona.c:158:20: error: implicit declaration of function >> 'devm_clk_register' [-Werror=implicit-function-declaration] clkdata->clk32k = devm_clk_register(>dev, >clk32k_hw); ^ >> drivers/clk/clk-arizona.c:113:23: warning: unused variable 'clk32k_init' >> [-Wunused-variable] struct clk_init_data clk32k_init = { ^ cc1:
Re: [PATCH 3/4] mfd: arizona: Switch to using clock driver for 32k clock
Hi Charles, [auto build test WARNING on clk/clk-next] [also build test WARNING on v4.4-rc8 next-20160105] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Charles-Keepax/extcon-arizona-Remove-enable-disable-of-32k-clock/20160105-234658 base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next config: x86_64-randconfig-x013-01041832 (attached as .config) reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All warnings (new ones prefixed by >>): warning: (MFD_ARIZONA) selects COMMON_CLK_ARIZONA which has unmet direct dependencies (COMMON_CLK && MFD_ARIZONA) --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: Binary data
Re: [PATCH 3/4] mfd: arizona: Switch to using clock driver for 32k clock
Hi Charles, [auto build test WARNING on clk/clk-next] [also build test WARNING on v4.4-rc8 next-20160105] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Charles-Keepax/extcon-arizona-Remove-enable-disable-of-32k-clock/20160105-234658 base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next config: x86_64-randconfig-x013-01041832 (attached as .config) reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All warnings (new ones prefixed by >>): warning: (MFD_ARIZONA) selects COMMON_CLK_ARIZONA which has unmet direct dependencies (COMMON_CLK && MFD_ARIZONA) --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: Binary data
Re: [PATCH 3/4] mfd: arizona: Switch to using clock driver for 32k clock
Hi Charles, [auto build test ERROR on clk/clk-next] [also build test ERROR on v4.4-rc8 next-20160105] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Charles-Keepax/extcon-arizona-Remove-enable-disable-of-32k-clock/20160105-234658 base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next config: i386-randconfig-s1-201601 (attached as .config) reproduce: # save the attached .config to linux build tree make ARCH=i386 All error/warnings (new ones prefixed by >>): >> drivers/clk/clk-arizona.c:31:16: error: field 'clk32k_hw' has incomplete type struct clk_hw clk32k_hw; ^ In file included from include/asm-generic/bug.h:13:0, from arch/x86/include/asm/bug.h:35, from include/linux/bug.h:4, from include/linux/mmdebug.h:4, from include/linux/gfp.h:4, from include/linux/slab.h:14, from include/asm-generic/clkdev.h:16, from arch/x86/include/generated/asm/clkdev.h:1, from include/linux/clkdev.h:15, from drivers/clk/clk-arizona.c:14: drivers/clk/clk-arizona.c: In function 'clk32k_to_arizona_clk': include/linux/kernel.h:813:48: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types] const typeof( ((type *)0)->member ) *__mptr = (ptr); \ ^ >> drivers/clk/clk-arizona.c:37:9: note: in expansion of macro 'container_of' return container_of(hw, struct arizona_clk, clk32k_hw); ^ drivers/clk/clk-arizona.c: At top level: >> drivers/clk/clk-arizona.c:77:21: error: variable 'arizona_32k_ops' has >> initializer but incomplete type static const struct clk_ops arizona_32k_ops = { ^ >> drivers/clk/clk-arizona.c:78:2: error: unknown field 'prepare' specified in >> initializer .prepare = arizona_32k_enable, ^ >> drivers/clk/clk-arizona.c:78:13: warning: excess elements in struct >> initializer .prepare = arizona_32k_enable, ^ drivers/clk/clk-arizona.c:78:13: note: (near initialization for 'arizona_32k_ops') >> drivers/clk/clk-arizona.c:79:2: error: unknown field 'unprepare' specified >> in initializer .unprepare = arizona_32k_disable, ^ drivers/clk/clk-arizona.c:79:15: warning: excess elements in struct initializer .unprepare = arizona_32k_disable, ^ drivers/clk/clk-arizona.c:79:15: note: (near initialization for 'arizona_32k_ops') drivers/clk/clk-arizona.c: In function 'arizona_clk_of_get_pdata': >> drivers/clk/clk-arizona.c:98:35: error: implicit declaration of function >> '__clk_get_name' [-Werror=implicit-function-declaration] arizona->pdata.clk32k_parent = __clk_get_name(mclk); ^ >> drivers/clk/clk-arizona.c:98:33: warning: assignment makes pointer from >> integer without a cast [-Wint-conversion] arizona->pdata.clk32k_parent = __clk_get_name(mclk); ^ drivers/clk/clk-arizona.c: In function 'arizona_clk_probe': >> drivers/clk/clk-arizona.c:113:9: error: variable 'clk32k_init' has >> initializer but incomplete type struct clk_init_data clk32k_init = { ^ >> drivers/clk/clk-arizona.c:114:3: error: unknown field 'name' specified in >> initializer .name = "arizona-32k", ^ drivers/clk/clk-arizona.c:114:11: warning: excess elements in struct initializer .name = "arizona-32k", ^ drivers/clk/clk-arizona.c:114:11: note: (near initialization for 'clk32k_init') >> drivers/clk/clk-arizona.c:115:3: error: unknown field 'ops' specified in >> initializer .ops = _32k_ops, ^ drivers/clk/clk-arizona.c:115:10: warning: excess elements in struct initializer .ops = _32k_ops, ^ drivers/clk/clk-arizona.c:115:10: note: (near initialization for 'clk32k_init') >> drivers/clk/clk-arizona.c:113:23: error: storage size of 'clk32k_init' isn't >> known struct clk_init_data clk32k_init = { ^ >> drivers/clk/clk-arizona.c:154:24: error: 'CLK_IS_ROOT' undeclared (first use >> in this function) clk32k_init.flags |= CLK_IS_ROOT; ^ drivers/clk/clk-arizona.c:154:24: note: each undeclared identifier is reported only once for each function it appears in >> drivers/clk/clk-arizona.c:158:20: error: implicit declaration of function >> 'devm_clk_register' [-Werror=implicit-function-declaration] clkdata->clk32k = devm_clk_register(>dev, >clk32k_hw); ^ >> drivers/clk/clk-arizona.c:113:23: warning: unused variable 'clk32k_init' >> [-Wunused-variable] struct clk_init_data clk32k_init = { ^ cc1: