Re: [PATCH 3/4] staging: rtl8188eu: osdep_intf.h and usb_intf.c
>> > Same comments as the previous ones, please redo all of these patches. >> > >> Should all the alterations be in one big single patch, insted of small ones? > > Your first version broke the build if we applied only the first patch. > That's not allowed. I now understand that, thank you. > Also the new rtw_sys_remove_one() function isn't called. I was confused > by it as well. It doesn't "remove one", it removes everything. The function it's not new, I just converted it from the proc to defugfs, It can be renamed. > Do we need to support llseek? Probably not... I'll check it. > How have you tested this? Have you tested module unloading? Yes, I've tested it several times and unloaded without issues. Thank you for your comments, Best Regards, Miguel Oliveira -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 3/4] staging: rtl8188eu: osdep_intf.h and usb_intf.c
On Sat, Aug 30, 2014 at 11:22:56PM +0200, Miguel Oliveira wrote: > > Same comments as the previous ones, please redo all of these patches. > > > Should all the alterations be in one big single patch, insted of small ones? Your first version broke the build if we applied only the first patch. That's not allowed. Also the new rtw_sys_remove_one() function isn't called. I was confused by it as well. It doesn't "remove one", it removes everything. Do we need to support llseek? How have you tested this? Have you tested module unloading? regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 3/4] staging: rtl8188eu: osdep_intf.h and usb_intf.c
On Sat, Aug 30, 2014 at 11:22:56PM +0200, Miguel Oliveira wrote: Same comments as the previous ones, please redo all of these patches. Should all the alterations be in one big single patch, insted of small ones? Your first version broke the build if we applied only the first patch. That's not allowed. Also the new rtw_sys_remove_one() function isn't called. I was confused by it as well. It doesn't remove one, it removes everything. Do we need to support llseek? How have you tested this? Have you tested module unloading? regards, dan carpenter -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 3/4] staging: rtl8188eu: osdep_intf.h and usb_intf.c
Same comments as the previous ones, please redo all of these patches. Should all the alterations be in one big single patch, insted of small ones? Your first version broke the build if we applied only the first patch. That's not allowed. I now understand that, thank you. Also the new rtw_sys_remove_one() function isn't called. I was confused by it as well. It doesn't remove one, it removes everything. The function it's not new, I just converted it from the proc to defugfs, It can be renamed. Do we need to support llseek? Probably not... I'll check it. How have you tested this? Have you tested module unloading? Yes, I've tested it several times and unloaded without issues. Thank you for your comments, Best Regards, Miguel Oliveira -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 3/4] staging: rtl8188eu: osdep_intf.h and usb_intf.c
On Sat, Aug 30, 2014 at 11:22:56PM +0200, Miguel Oliveira wrote: > > Same comments as the previous ones, please redo all of these patches. > > > Should all the alterations be in one big single patch, insted of small ones? I don't know, I don't remember what this patch even contained given that it was 100+ patches ago in my review queue and I have the short term memory of a squirrel. Please fix up and resend and I'll be glad to review it then. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 3/4] staging: rtl8188eu: osdep_intf.h and usb_intf.c
> Same comments as the previous ones, please redo all of these patches. > Should all the alterations be in one big single patch, insted of small ones? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 3/4] staging: rtl8188eu: osdep_intf.h and usb_intf.c
On Fri, Aug 22, 2014 at 11:33:37AM +0100, Miguel Oliveira wrote: > Convert all rtw_proc_xxx references to rtw_sys_xxx in files > include/osdep_intf.h and os_dep/usb_intf.c Same comments as the previous ones, please redo all of these patches. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 3/4] staging: rtl8188eu: osdep_intf.h and usb_intf.c
On Fri, Aug 22, 2014 at 11:33:37AM +0100, Miguel Oliveira wrote: Convert all rtw_proc_xxx references to rtw_sys_xxx in files include/osdep_intf.h and os_dep/usb_intf.c Same comments as the previous ones, please redo all of these patches. greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 3/4] staging: rtl8188eu: osdep_intf.h and usb_intf.c
Same comments as the previous ones, please redo all of these patches. Should all the alterations be in one big single patch, insted of small ones? -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 3/4] staging: rtl8188eu: osdep_intf.h and usb_intf.c
On Sat, Aug 30, 2014 at 11:22:56PM +0200, Miguel Oliveira wrote: Same comments as the previous ones, please redo all of these patches. Should all the alterations be in one big single patch, insted of small ones? I don't know, I don't remember what this patch even contained given that it was 100+ patches ago in my review queue and I have the short term memory of a squirrel. Please fix up and resend and I'll be glad to review it then. thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
