Re: [PATCH 3/9] arm64: dts: qcom: sc7280: Add device tree node for LLCC
Quoting Sai Prakash Ranjan (2021-02-27 05:58:25) > On 2021-02-27 00:15, Stephen Boyd wrote: > > Quoting Sai Prakash Ranjan (2021-02-26 00:04:27) > >> On 2021-02-26 01:07, Stephen Boyd wrote: > >> > Quoting Sai Prakash Ranjan (2021-02-25 01:30:19) > >> >> Add a DT node for Last level cache (aka. system cache) > >> >> controller which provides control over the last level > >> >> cache present on SC7280 SoC. > >> >> > >> >> Signed-off-by: Sai Prakash Ranjan > >> >> --- > >> > > >> > Reviewed-by: Stephen Boyd > >> > > >> > Should add system-cache-controller to the devicetree spec. Or just use > >> > cache-controller for the node name. > >> > >> This was as per discussion in [1][2] where dt-schema throws an error > >> since it expects cache-level to be associated with cache-controller. > >> > > > > Ah right. Can you add system-cache-controller to the dt spec? > > Sure, I'll add it. Hopefully that won't have to block this change? > Because I might need some time to get permissions to add it there. > Doesn't block it for me.
Re: [PATCH 3/9] arm64: dts: qcom: sc7280: Add device tree node for LLCC
On 2021-02-27 00:15, Stephen Boyd wrote: Quoting Sai Prakash Ranjan (2021-02-26 00:04:27) On 2021-02-26 01:07, Stephen Boyd wrote: > Quoting Sai Prakash Ranjan (2021-02-25 01:30:19) >> Add a DT node for Last level cache (aka. system cache) >> controller which provides control over the last level >> cache present on SC7280 SoC. >> >> Signed-off-by: Sai Prakash Ranjan >> --- > > Reviewed-by: Stephen Boyd > > Should add system-cache-controller to the devicetree spec. Or just use > cache-controller for the node name. This was as per discussion in [1][2] where dt-schema throws an error since it expects cache-level to be associated with cache-controller. Ah right. Can you add system-cache-controller to the dt spec? Sure, I'll add it. Hopefully that won't have to block this change? Because I might need some time to get permissions to add it there. Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
Re: [PATCH 3/9] arm64: dts: qcom: sc7280: Add device tree node for LLCC
Quoting Sai Prakash Ranjan (2021-02-26 00:04:27) > On 2021-02-26 01:07, Stephen Boyd wrote: > > Quoting Sai Prakash Ranjan (2021-02-25 01:30:19) > >> Add a DT node for Last level cache (aka. system cache) > >> controller which provides control over the last level > >> cache present on SC7280 SoC. > >> > >> Signed-off-by: Sai Prakash Ranjan > >> --- > > > > Reviewed-by: Stephen Boyd > > > > Should add system-cache-controller to the devicetree spec. Or just use > > cache-controller for the node name. > > This was as per discussion in [1][2] where dt-schema throws an error > since it expects cache-level to be associated with cache-controller. > Ah right. Can you add system-cache-controller to the dt spec?
Re: [PATCH 3/9] arm64: dts: qcom: sc7280: Add device tree node for LLCC
On 2021-02-26 01:07, Stephen Boyd wrote: Quoting Sai Prakash Ranjan (2021-02-25 01:30:19) Add a DT node for Last level cache (aka. system cache) controller which provides control over the last level cache present on SC7280 SoC. Signed-off-by: Sai Prakash Ranjan --- Reviewed-by: Stephen Boyd Should add system-cache-controller to the devicetree spec. Or just use cache-controller for the node name. This was as per discussion in [1][2] where dt-schema throws an error since it expects cache-level to be associated with cache-controller. [1] https://lore.kernel.org/lkml/5dcd8588.1c69fb81.2528a.3...@mx.google.com/ [2] https://lore.kernel.org/lkml/cover.1573814758.git.saiprakash.ran...@codeaurora.org/ Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
Re: [PATCH 3/9] arm64: dts: qcom: sc7280: Add device tree node for LLCC
Quoting Sai Prakash Ranjan (2021-02-25 01:30:19) > Add a DT node for Last level cache (aka. system cache) > controller which provides control over the last level > cache present on SC7280 SoC. > > Signed-off-by: Sai Prakash Ranjan > --- Reviewed-by: Stephen Boyd Should add system-cache-controller to the devicetree spec. Or just use cache-controller for the node name.
