Re: [PATCH 4/13] cxgb3 - use immediate data for offload Tx

2007-08-14 Thread Divy Le Ray

Jeff Garzik wrote:


Divy Le Ray wrote:
> From: Divy Le Ray <[EMAIL PROTECTED]>
>
> Send small TX_DATA work requests as immediate data even when
> there are fragments.
>
> Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]>
> ---
>
>  drivers/net/cxgb3/sge.c |   17 +++--
>  1 files changed, 11 insertions(+), 6 deletions(-)

needs additional explanation.  don't just describe the new post-change
behavior, describe why this change is needed.


It's an optimization avoiding doing multiple DMAs for small fragmented 
packets.
The driver already implements this optimization for small contiguous 
packets.


Divy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 4/13] cxgb3 - use immediate data for offload Tx

2007-08-14 Thread Divy Le Ray

Jeff Garzik wrote:


Divy Le Ray wrote:
 From: Divy Le Ray [EMAIL PROTECTED]

 Send small TX_DATA work requests as immediate data even when
 there are fragments.

 Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
 ---

  drivers/net/cxgb3/sge.c |   17 +++--
  1 files changed, 11 insertions(+), 6 deletions(-)

needs additional explanation.  don't just describe the new post-change
behavior, describe why this change is needed.


It's an optimization avoiding doing multiple DMAs for small fragmented 
packets.
The driver already implements this optimization for small contiguous 
packets.


Divy
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 4/13] cxgb3 - use immediate data for offload Tx

2007-08-13 Thread Jeff Garzik

Divy Le Ray wrote:

From: Divy Le Ray <[EMAIL PROTECTED]>

Send small TX_DATA work requests as immediate data even when
there are fragments.

Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]>
---

 drivers/net/cxgb3/sge.c |   17 +++--
 1 files changed, 11 insertions(+), 6 deletions(-)


needs additional explanation.  don't just describe the new post-change 
behavior, describe why this change is needed.



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 4/13] cxgb3 - use immediate data for offload Tx

2007-08-13 Thread Jeff Garzik

Divy Le Ray wrote:

From: Divy Le Ray [EMAIL PROTECTED]

Send small TX_DATA work requests as immediate data even when
there are fragments.

Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---

 drivers/net/cxgb3/sge.c |   17 +++--
 1 files changed, 11 insertions(+), 6 deletions(-)


needs additional explanation.  don't just describe the new post-change 
behavior, describe why this change is needed.



-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/