Re: [PATCH 4/4 v2] mv643xx_eth: convert to use the Marvell Orion MDIO driver
Dear Florian Fainelli, On Fri, 15 Mar 2013 12:07:12 +0100, Florian Fainelli wrote: > Thanks to the help of Andrew Lunn, there is at least two known issues > with this patch version: > > - we need to move up the mvmdio line in > drivers/net/ethernet/marvell/Makefile to make sure that configs having > both mvmdio and mv643xx_eth built-in get the probing order right I don't think it's the right way of fixing the problem. If there is no dependency on the two devices through the device model (i.e they don't have a parent->child relationship), then the mv643xx_eth driver should probably return -EPROBE_DEFER when it can't find its PHY so that its ->probe() operation gets called once again by the kernel when other drivers (including mvmdio) have been probed. Best regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 4/4 v2] mv643xx_eth: convert to use the Marvell Orion MDIO driver
Le 03/14/13 19:08, Florian Fainelli a écrit : This patch converts the Marvell MV643XX ethernet driver to use the Marvell Orion MDIO driver. As a result, PowerPC and ARM platforms registering the Marvell MV643XX ethernet driver are also updated to register a Marvell Orion MDIO driver. This driver voluntarily overlaps with the Marvell Ethernet shared registers because it will use a subset of this shared register (shared_base + 0x4 - shared_base + 0x84). The Ethernet driver is also updated to look up for a PHY device using the Orion MDIO bus driver. Thanks to the help of Andrew Lunn, there is at least two known issues with this patch version: - we need to move up the mvmdio line in drivers/net/ethernet/marvell/Makefile to make sure that configs having both mvmdio and mv643xx_eth built-in get the probing order right - the bus name used by mv643xx_eth is not the right now (orion-mdio.0 vs expected orion-mdio) so the PHY device will not be found during phy_connect() I will fix these two issues in the next version of the patchset. -- Florian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
