Re: [PATCH 4/8 v2] ARM OMAP2+ GPMC: fix debug output alignment
On 24/02/15 22:05, Robert ABEL wrote: > GPMC debug output is aligned to 10 characters for field names. > However, some fields have bigger names, screwing up the alignment. > Consequently, alignment was changed to longest field name (17 chars) for now. > > Signed-off-by: Robert ABEL Acked-by: Roger Quadros cheers, -roger > --- > drivers/memory/omap-gpmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c > index 78b78a64..b5c8305 100644 > --- a/drivers/memory/omap-gpmc.c > +++ b/drivers/memory/omap-gpmc.c > @@ -482,7 +482,7 @@ static int set_gpmc_timing_reg(int cs, int reg, int > st_bit, int end_bit, > l = gpmc_cs_read_reg(cs, reg); > #ifdef DEBUG > printk(KERN_INFO > - "GPMC CS%d: %-10s: %3d ticks, %3lu ns (was %3i ticks) %3d ns\n", > + "GPMC CS%d: %-17s: %3d ticks, %3lu ns (was %3i ticks) %3d ns\n", > cs, name, ticks, gpmc_get_fclk_period() * ticks / 1000, > (l >> st_bit) & mask, time); > #endif > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 4/8 v2] ARM OMAP2+ GPMC: fix debug output alignment
On 24/02/15 22:05, Robert ABEL wrote: GPMC debug output is aligned to 10 characters for field names. However, some fields have bigger names, screwing up the alignment. Consequently, alignment was changed to longest field name (17 chars) for now. Signed-off-by: Robert ABEL ra...@cit-ec.uni-bielefeld.de Acked-by: Roger Quadros rog...@ti.com cheers, -roger --- drivers/memory/omap-gpmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c index 78b78a64..b5c8305 100644 --- a/drivers/memory/omap-gpmc.c +++ b/drivers/memory/omap-gpmc.c @@ -482,7 +482,7 @@ static int set_gpmc_timing_reg(int cs, int reg, int st_bit, int end_bit, l = gpmc_cs_read_reg(cs, reg); #ifdef DEBUG printk(KERN_INFO - GPMC CS%d: %-10s: %3d ticks, %3lu ns (was %3i ticks) %3d ns\n, + GPMC CS%d: %-17s: %3d ticks, %3lu ns (was %3i ticks) %3d ns\n, cs, name, ticks, gpmc_get_fclk_period() * ticks / 1000, (l st_bit) mask, time); #endif -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
