Re: [PATCH 4.20 000/111] 4.20.4-stable review
On Tue, Jan 22, 2019 at 11:24:25AM -0800, Guenter Roeck wrote: > On Mon, Jan 21, 2019 at 02:41:54PM +0100, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.20.4 release. > > There are 111 patches in this series, all will be posted as a response > > to this one. If anyone has any issues with these being applied, please > > let me know. > > > > Responses should be made by Wed Jan 23 12:23:56 UTC 2019. > > Anything received after that time might be too late. > > > Build results: > total: 159 pass: 159 fail: 0 > Qemu test results: > total: 343 pass: 343 fail: 0 Thanks for testing all of these and letting me know. greg k-h
Re: [PATCH 4.20 000/111] 4.20.4-stable review
On Tue, Jan 22, 2019 at 03:25:58PM -0700, shuah wrote: > On 1/21/19 6:41 AM, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.20.4 release. > > There are 111 patches in this series, all will be posted as a response > > to this one. If anyone has any issues with these being applied, please > > let me know. > > > > Responses should be made by Wed Jan 23 12:23:56 UTC 2019. > > Anything received after that time might be too late. > > > > The whole patch series can be found in one patch at: > > > > https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.20.4-rc1.gz > > or in the git tree and branch at: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > > linux-4.20.y > > and the diffstat can be found below. > > > > thanks, > > > > greg k-h > > > > Compiled and booted on my test system. No dmesg regressions. Thanks for testing all of these and letting me know. greg k-h
Re: [PATCH 4.20 000/111] 4.20.4-stable review
On 1/21/19 6:41 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.20.4 release. There are 111 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed Jan 23 12:23:56 UTC 2019. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.20.4-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.20.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah
Re: [PATCH 4.20 000/111] 4.20.4-stable review
On Mon, Jan 21, 2019 at 02:41:54PM +0100, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.20.4 release. > There are 111 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses should be made by Wed Jan 23 12:23:56 UTC 2019. > Anything received after that time might be too late. > Build results: total: 159 pass: 159 fail: 0 Qemu test results: total: 343 pass: 343 fail: 0 Guenter
Re: [PATCH 4.20 000/111] 4.20.4-stable review
On Tue, Jan 22, 2019 at 07:03:28PM +0530, Naresh Kamboju wrote: > On Mon, 21 Jan 2019 at 19:16, Greg Kroah-Hartman > wrote: > > > > This is the start of the stable review cycle for the 4.20.4 release. > > There are 111 patches in this series, all will be posted as a response > > to this one. If anyone has any issues with these being applied, please > > let me know. > > > > Responses should be made by Wed Jan 23 12:23:56 UTC 2019. > > Anything received after that time might be too late. > > > > The whole patch series can be found in one patch at: > > > > https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.20.4-rc1.gz > > or in the git tree and branch at: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > > linux-4.20.y > > and the diffstat can be found below. > > > > thanks, > > > > greg k-h > > > > Results from Linaro’s test farm. > No regressions on arm64, arm, x86_64, and i386. Thanks for testing all of these and letting me know. greg k-h
Re: [PATCH 4.20 000/111] 4.20.4-stable review
On Mon, 21 Jan 2019 at 19:16, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.20.4 release. > There are 111 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses should be made by Wed Jan 23 12:23:56 UTC 2019. > Anything received after that time might be too late. > > The whole patch series can be found in one patch at: > > https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.20.4-rc1.gz > or in the git tree and branch at: > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > linux-4.20.y > and the diffstat can be found below. > > thanks, > > greg k-h > Results from Linaro’s test farm. No regressions on arm64, arm, x86_64, and i386. Summary kernel: 4.20.4-rc1 git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git git branch: linux-4.20.y git commit: 67648eb553fb944194c327026f4be4632dce710d git describe: v4.20.3-114-g67648eb553fb Test details: https://qa-reports.linaro.org/lkft/linux-stable-rc-4.20-oe/build/v4.20.3-114-g67648eb553fb No regressions (compared to build v4.20.3) No fixes (compared to build v4.20.3) Ran 20503 total tests in the following environments and test suites. Environments -- - dragonboard-410c - arm64 - hi6220-hikey - arm64 - i386 - juno-r2 - arm64 - qemu_arm - qemu_arm64 - qemu_i386 - qemu_x86_64 - x15 - arm - x86_64 Test Suites --- * boot * install-android-platform-tools-r2600 * kselftest * libhugetlbfs * ltp-cap_bounds-tests * ltp-containers-tests * ltp-cpuhotplug-tests * ltp-cve-tests * ltp-fcntl-locktests-tests * ltp-filecaps-tests * ltp-fs_bind-tests * ltp-fs_perms_simple-tests * ltp-fsx-tests * ltp-hugetlb-tests * ltp-io-tests * ltp-ipc-tests * ltp-math-tests * ltp-nptl-tests * ltp-pty-tests * ltp-sched-tests * ltp-securebits-tests * ltp-syscalls-tests * ltp-timers-tests * spectre-meltdown-checker-test * ltp-fs-tests * ltp-open-posix-tests * kselftest-vsyscall-mode-native * kselftest-vsyscall-mode-none -- Linaro LKFT https://lkft.linaro.org
Re: [PATCH 4.20 000/111] 4.20.4-stable review
From: Greg KH Date: Mon, 21 Jan 2019 20:21:48 +0100 > Subject: [PATCH] stable-kernel-rules.rst: add link to networking patch queue > > The networking maintainer keeps a public list of the patches being > queued up for the next round of stable releases. Be sure to check there > before asking for a patch to be applied so that you do not waste > people's time. > > Signed-off-by: Greg Kroah-Hartman Acked-by: David S. Miller
Re: [PATCH 4.20 000/111] 4.20.4-stable review
On Mon, Jan 21, 2019 at 7:48 PM David Miller wrote: > > From: Ian Kumlien > Date: Mon, 21 Jan 2019 16:38:11 +0100 > > > Hi David, > > > > could we have your blessing to add the following patch to -stable for > > 4.20.4: > > commit 41d1c8839e5f8cb781cc635f12791decee8271b7 > > Author: Paolo Abeni > > Date: Tue Jan 8 18:45:05 2019 +0100 > > > > net: clear skb->tstamp in bridge forwarding path > > It is already in my -stable queue: > > https://patchwork.ozlabs.org/bundle/davem/stable/?series=&submitter=&state=*&q=&archive= > > I honestly don't know why I bother putting forth such an effort to publish > what is in my -stable queue if people don't bother checking it. :-( Sorry, I will check it in the future, the patch from Greg would highlight it as well! I was really hoping that this was pushed to -stable already, which is why I sent my initial mail. I haven't really followed kernel policies that closely since 2.5 or something =/
Re: [PATCH 4.20 000/111] 4.20.4-stable review
On Mon, Jan 21, 2019 at 10:48:24AM -0800, David Miller wrote: > From: Ian Kumlien > Date: Mon, 21 Jan 2019 16:38:11 +0100 > > > Hi David, > > > > could we have your blessing to add the following patch to -stable for > > 4.20.4: > > commit 41d1c8839e5f8cb781cc635f12791decee8271b7 > > Author: Paolo Abeni > > Date: Tue Jan 8 18:45:05 2019 +0100 > > > > net: clear skb->tstamp in bridge forwarding path > > It is already in my -stable queue: > > https://patchwork.ozlabs.org/bundle/davem/stable/?series=&submitter=&state=*&q=&archive= > > I honestly don't know why I bother putting forth such an effort to publish > what is in my -stable queue if people don't bother checking it. :-( We should add a link to it in the stable_rules.rst file so that more people know to check it. Something like the patch below? thanks, greg k-h -- Subject: [PATCH] stable-kernel-rules.rst: add link to networking patch queue The networking maintainer keeps a public list of the patches being queued up for the next round of stable releases. Be sure to check there before asking for a patch to be applied so that you do not waste people's time. Signed-off-by: Greg Kroah-Hartman diff --git a/Documentation/process/stable-kernel-rules.rst b/Documentation/process/stable-kernel-rules.rst index 0de6f6145cc6..7ba8cd567f84 100644 --- a/Documentation/process/stable-kernel-rules.rst +++ b/Documentation/process/stable-kernel-rules.rst @@ -38,6 +38,9 @@ Procedure for submitting patches to the -stable tree - If the patch covers files in net/ or drivers/net please follow netdev stable submission guidelines as described in :ref:`Documentation/networking/netdev-FAQ.rst ` + after first checking the stable networking queue at + https://patchwork.ozlabs.org/bundle/davem/stable/?series=&submitter=&state=*&q=&archive= + to ensure the requested patch is not already queued up. - Security patches should not be handled (solely) by the -stable review process but should follow the procedures in :ref:`Documentation/admin-guide/security-bugs.rst `.
Re: [PATCH 4.20 000/111] 4.20.4-stable review
From: Ian Kumlien Date: Mon, 21 Jan 2019 16:38:11 +0100 > Hi David, > > could we have your blessing to add the following patch to -stable for 4.20.4: > commit 41d1c8839e5f8cb781cc635f12791decee8271b7 > Author: Paolo Abeni > Date: Tue Jan 8 18:45:05 2019 +0100 > > net: clear skb->tstamp in bridge forwarding path It is already in my -stable queue: https://patchwork.ozlabs.org/bundle/davem/stable/?series=&submitter=&state=*&q=&archive= I honestly don't know why I bother putting forth such an effort to publish what is in my -stable queue if people don't bother checking it. :-(
Re: [PATCH 4.20 000/111] 4.20.4-stable review
Hi David,
could we have your blessing to add the following patch to -stable for 4.20.4:
commit 41d1c8839e5f8cb781cc635f12791decee8271b7
Author: Paolo Abeni
Date: Tue Jan 8 18:45:05 2019 +0100
net: clear skb->tstamp in bridge forwarding path
Matteo reported forwarding issues inside the linux bridge,
if the enslaved interfaces use the fq qdisc.
Similar to commit 8203e2d844d3 ("net: clear skb->tstamp in
forwarding paths"), we need to clear the tstamp field in
the bridge forwarding path.
Fixes: 80b14dee2bea ("net: Add a new socket option for a future
transmit time.")
Fixes: fb420d5d91c1 ("tcp/fq: move back to CLOCK_MONOTONIC")
Reported-and-tested-by: Matteo Croce
Signed-off-by: Paolo Abeni
Acked-by: Nikolay Aleksandrov
Acked-by: Roopa Prabhu
Reviewed-by: Eric Dumazet
Signed-off-by: David S. Miller
---
Also, do you keep your -stable queue somewhere where I can see it?
It feels like I'm stepping on toes, adding overhead and such, which is
not what i want...
On Mon, Jan 21, 2019 at 4:10 PM Greg KH wrote:
> On Mon, Jan 21, 2019 at 03:56:24PM +0100, Ian Kumlien wrote:
> > On Mon, Jan 21, 2019 at 3:47 PM Greg KH wrote:
> > > On Mon, Jan 21, 2019 at 03:44:24PM +0100, Ian Kumlien wrote:
> > > > Hi,
> > > >
> > > > IMHO you are missing: 41d1c8839e5f8cb781cc635f12791decee8271b7
> > > >
> > > > Which should be marked for stable, it fixes:
> > > > https://bugzilla.kernel.org/show_bug.cgi?id=202235
> > >
> > > The networking maintainer handles sending those patches to me. It
> > > wasn't part of the last set of patches, so perhaps it will be in the
> > > next one?
> >
> > I thought it would be in the next one after it's in the rc but perhaps
> > not...
> >
> > I suspected that it could have been a slip up, since:
> > https://marc.info/?l=linux-netdev&m=154726015506044&w=2
> >
> > And i know that there are people waiting for it ;)
>
> Well, ask David and if he says I can queue it up now, I'll be glad to do
> so.
>
> thanks,
>
> greg k-h
Re: [PATCH 4.20 000/111] 4.20.4-stable review
On Mon, Jan 21, 2019 at 03:56:24PM +0100, Ian Kumlien wrote: > On Mon, Jan 21, 2019 at 3:47 PM Greg KH wrote: > > > > On Mon, Jan 21, 2019 at 03:44:24PM +0100, Ian Kumlien wrote: > > > Hi, > > > > > > IMHO you are missing: 41d1c8839e5f8cb781cc635f12791decee8271b7 > > > > > > Which should be marked for stable, it fixes: > > > https://bugzilla.kernel.org/show_bug.cgi?id=202235 > > > > The networking maintainer handles sending those patches to me. It > > wasn't part of the last set of patches, so perhaps it will be in the > > next one? > > I thought it would be in the next one after it's in the rc but perhaps not... > > I suspected that it could have been a slip up, since: > https://marc.info/?l=linux-netdev&m=154726015506044&w=2 > > And i know that there are people waiting for it ;) Well, ask David and if he says I can queue it up now, I'll be glad to do so. thanks, greg k-h
Re: [PATCH 4.20 000/111] 4.20.4-stable review
On Mon, Jan 21, 2019 at 3:47 PM Greg KH wrote: > > On Mon, Jan 21, 2019 at 03:44:24PM +0100, Ian Kumlien wrote: > > Hi, > > > > IMHO you are missing: 41d1c8839e5f8cb781cc635f12791decee8271b7 > > > > Which should be marked for stable, it fixes: > > https://bugzilla.kernel.org/show_bug.cgi?id=202235 > > The networking maintainer handles sending those patches to me. It > wasn't part of the last set of patches, so perhaps it will be in the > next one? I thought it would be in the next one after it's in the rc but perhaps not... I suspected that it could have been a slip up, since: https://marc.info/?l=linux-netdev&m=154726015506044&w=2 And i know that there are people waiting for it ;) > Please see: > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > for how to do this properly. > > thanks, > > greg k-h
Re: [PATCH 4.20 000/111] 4.20.4-stable review
On Mon, Jan 21, 2019 at 03:44:24PM +0100, Ian Kumlien wrote: > Hi, > > IMHO you are missing: 41d1c8839e5f8cb781cc635f12791decee8271b7 > > Which should be marked for stable, it fixes: > https://bugzilla.kernel.org/show_bug.cgi?id=202235 The networking maintainer handles sending those patches to me. It wasn't part of the last set of patches, so perhaps it will be in the next one? Please see: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly. thanks, greg k-h
Re: [PATCH 4.20 000/111] 4.20.4-stable review
Hi, IMHO you are missing: 41d1c8839e5f8cb781cc635f12791decee8271b7 Which should be marked for stable, it fixes: https://bugzilla.kernel.org/show_bug.cgi?id=202235
