Re: [PATCH 4.9 003/116] rtlwifi: Fix enter/exit power_save

[Greg Kroah-Hartman]

On Fri, Jan 13, 2017 at 08:42:03AM +0200, Kalle Valo wrote:
> Greg Kroah-Hartman  writes:
> 
> > On Tue, Jan 10, 2017 at 10:51:56PM +0100, Willy Tarreau wrote:
> >> On Tue, Jan 10, 2017 at 03:23:27PM -0600, l...@pengaru.com wrote:
> >> > On Tue, Jan 10, 2017 at 09:40:24PM +0100, Greg Kroah-Hartman wrote:
> >> > > On Tue, Jan 10, 2017 at 08:40:28PM +0300, Dmitry Osipenko wrote:
> >> > > > Hello, this patch causes a kernel panic with the rtl8192cu driver.
> >> > > 
> >> > > Ick, not good!  Does this cause a problem in Linus's tree as well?
> >> > > 
> >> > 
> >> > http://lkml.iu.edu/hypermail/linux/kernel/1701.1/00228.html
> >> 
> >> OK the pending patch is here and not yet upstream :
> >> 
> >> http://marc.info/?l=linux-wireless=148234081512703=2
> >> 
> >> It fixes ba9f93f82aba (patch 3/116) so better postpone it until
> >> the patch above gets merged.
> >
> > Yes, I've reverted this now and will wait for this fixup to hit Linus's
> > tree.  Larry, can you remind me to include the original patch in the
> > stable tree when this fixup is merged?
> 
> Linus pulled it now:
> 
> commit 60f59ce0278557f7896d5158ae6d12a4855a72cc
> Author: Larry Finger 
> Date:   Wed Dec 21 11:18:55 2016 -0600
> 
> rtlwifi: rtl_usb: Fix missing entry in USB driver's private data
> 
> These drivers need to be able to reference "struct ieee80211_hw"
> from
> the driver's private data, and vice versa. The USB driver failed to
> store the address of ieee80211_hw in the private data. Although this
> bug has been present for a long time, it was not exposed until
> commit ba9f93f82aba ("rtlwifi: Fix enter/exit power_save").
> 
> Fixes: ba9f93f82aba ("rtlwifi: Fix enter/exit power_save")
> Signed-off-by: Larry Finger 
> Signed-off-by: Kalle Valo 

Thanks will queue these two up now.

greg k-h

Re: [PATCH 4.9 003/116] rtlwifi: Fix enter/exit power_save

[Greg Kroah-Hartman]

On Fri, Jan 13, 2017 at 08:42:03AM +0200, Kalle Valo wrote:
> Greg Kroah-Hartman  writes:
> 
> > On Tue, Jan 10, 2017 at 10:51:56PM +0100, Willy Tarreau wrote:
> >> On Tue, Jan 10, 2017 at 03:23:27PM -0600, l...@pengaru.com wrote:
> >> > On Tue, Jan 10, 2017 at 09:40:24PM +0100, Greg Kroah-Hartman wrote:
> >> > > On Tue, Jan 10, 2017 at 08:40:28PM +0300, Dmitry Osipenko wrote:
> >> > > > Hello, this patch causes a kernel panic with the rtl8192cu driver.
> >> > > 
> >> > > Ick, not good!  Does this cause a problem in Linus's tree as well?
> >> > > 
> >> > 
> >> > http://lkml.iu.edu/hypermail/linux/kernel/1701.1/00228.html
> >> 
> >> OK the pending patch is here and not yet upstream :
> >> 
> >> http://marc.info/?l=linux-wireless=148234081512703=2
> >> 
> >> It fixes ba9f93f82aba (patch 3/116) so better postpone it until
> >> the patch above gets merged.
> >
> > Yes, I've reverted this now and will wait for this fixup to hit Linus's
> > tree.  Larry, can you remind me to include the original patch in the
> > stable tree when this fixup is merged?
> 
> Linus pulled it now:
> 
> commit 60f59ce0278557f7896d5158ae6d12a4855a72cc
> Author: Larry Finger 
> Date:   Wed Dec 21 11:18:55 2016 -0600
> 
> rtlwifi: rtl_usb: Fix missing entry in USB driver's private data
> 
> These drivers need to be able to reference "struct ieee80211_hw"
> from
> the driver's private data, and vice versa. The USB driver failed to
> store the address of ieee80211_hw in the private data. Although this
> bug has been present for a long time, it was not exposed until
> commit ba9f93f82aba ("rtlwifi: Fix enter/exit power_save").
> 
> Fixes: ba9f93f82aba ("rtlwifi: Fix enter/exit power_save")
> Signed-off-by: Larry Finger 
> Signed-off-by: Kalle Valo 

Thanks will queue these two up now.

greg k-h

Re: [PATCH 4.9 003/116] rtlwifi: Fix enter/exit power_save

[Kalle Valo]

Greg Kroah-Hartman  writes:

> On Tue, Jan 10, 2017 at 10:51:56PM +0100, Willy Tarreau wrote:
>> On Tue, Jan 10, 2017 at 03:23:27PM -0600, l...@pengaru.com wrote:
>> > On Tue, Jan 10, 2017 at 09:40:24PM +0100, Greg Kroah-Hartman wrote:
>> > > On Tue, Jan 10, 2017 at 08:40:28PM +0300, Dmitry Osipenko wrote:
>> > > > Hello, this patch causes a kernel panic with the rtl8192cu driver.
>> > > 
>> > > Ick, not good!  Does this cause a problem in Linus's tree as well?
>> > > 
>> > 
>> > http://lkml.iu.edu/hypermail/linux/kernel/1701.1/00228.html
>> 
>> OK the pending patch is here and not yet upstream :
>> 
>> http://marc.info/?l=linux-wireless=148234081512703=2
>> 
>> It fixes ba9f93f82aba (patch 3/116) so better postpone it until
>> the patch above gets merged.
>
> Yes, I've reverted this now and will wait for this fixup to hit Linus's
> tree.  Larry, can you remind me to include the original patch in the
> stable tree when this fixup is merged?

Linus pulled it now:

commit 60f59ce0278557f7896d5158ae6d12a4855a72cc
Author: Larry Finger 
Date:   Wed Dec 21 11:18:55 2016 -0600

rtlwifi: rtl_usb: Fix missing entry in USB driver's private data

These drivers need to be able to reference "struct ieee80211_hw"
from
the driver's private data, and vice versa. The USB driver failed to
store the address of ieee80211_hw in the private data. Although this
bug has been present for a long time, it was not exposed until
commit ba9f93f82aba ("rtlwifi: Fix enter/exit power_save").

Fixes: ba9f93f82aba ("rtlwifi: Fix enter/exit power_save")
Signed-off-by: Larry Finger 
Signed-off-by: Kalle Valo 

-- 
Kalle Valo

Re: [PATCH 4.9 003/116] rtlwifi: Fix enter/exit power_save

[Kalle Valo]

Greg Kroah-Hartman  writes:

> On Tue, Jan 10, 2017 at 10:51:56PM +0100, Willy Tarreau wrote:
>> On Tue, Jan 10, 2017 at 03:23:27PM -0600, l...@pengaru.com wrote:
>> > On Tue, Jan 10, 2017 at 09:40:24PM +0100, Greg Kroah-Hartman wrote:
>> > > On Tue, Jan 10, 2017 at 08:40:28PM +0300, Dmitry Osipenko wrote:
>> > > > Hello, this patch causes a kernel panic with the rtl8192cu driver.
>> > > 
>> > > Ick, not good!  Does this cause a problem in Linus's tree as well?
>> > > 
>> > 
>> > http://lkml.iu.edu/hypermail/linux/kernel/1701.1/00228.html
>> 
>> OK the pending patch is here and not yet upstream :
>> 
>> http://marc.info/?l=linux-wireless=148234081512703=2
>> 
>> It fixes ba9f93f82aba (patch 3/116) so better postpone it until
>> the patch above gets merged.
>
> Yes, I've reverted this now and will wait for this fixup to hit Linus's
> tree.  Larry, can you remind me to include the original patch in the
> stable tree when this fixup is merged?

Linus pulled it now:

commit 60f59ce0278557f7896d5158ae6d12a4855a72cc
Author: Larry Finger 
Date:   Wed Dec 21 11:18:55 2016 -0600

rtlwifi: rtl_usb: Fix missing entry in USB driver's private data

These drivers need to be able to reference "struct ieee80211_hw"
from
the driver's private data, and vice versa. The USB driver failed to
store the address of ieee80211_hw in the private data. Although this
bug has been present for a long time, it was not exposed until
commit ba9f93f82aba ("rtlwifi: Fix enter/exit power_save").

Fixes: ba9f93f82aba ("rtlwifi: Fix enter/exit power_save")
Signed-off-by: Larry Finger 
Signed-off-by: Kalle Valo 

-- 
Kalle Valo

Re: [PATCH 4.9 003/116] rtlwifi: Fix enter/exit power_save

[Dmitry Osipenko]

On 12.01.2017 10:32, Greg Kroah-Hartman wrote:
> On Tue, Jan 10, 2017 at 10:51:56PM +0100, Willy Tarreau wrote:
>> On Tue, Jan 10, 2017 at 03:23:27PM -0600, l...@pengaru.com wrote:
>>> On Tue, Jan 10, 2017 at 09:40:24PM +0100, Greg Kroah-Hartman wrote:
 On Tue, Jan 10, 2017 at 08:40:28PM +0300, Dmitry Osipenko wrote:
> Hello, this patch causes a kernel panic with the rtl8192cu driver.

 Ick, not good!  Does this cause a problem in Linus's tree as well?

>>>
>>> http://lkml.iu.edu/hypermail/linux/kernel/1701.1/00228.html
>>
>> OK the pending patch is here and not yet upstream :
>>
>> http://marc.info/?l=linux-wireless=148234081512703=2
>>
>> It fixes ba9f93f82aba (patch 3/116) so better postpone it until
>> the patch above gets merged.
> 
> Yes, I've reverted this now and will wait for this fixup to hit Linus's
> tree.  Larry, can you remind me to include the original patch in the
> stable tree when this fixup is merged?
> 

Thanks a lot for taking an action.

-- 
Dmitry

Re: [PATCH 4.9 003/116] rtlwifi: Fix enter/exit power_save

[Dmitry Osipenko]

On 12.01.2017 10:32, Greg Kroah-Hartman wrote:
> On Tue, Jan 10, 2017 at 10:51:56PM +0100, Willy Tarreau wrote:
>> On Tue, Jan 10, 2017 at 03:23:27PM -0600, l...@pengaru.com wrote:
>>> On Tue, Jan 10, 2017 at 09:40:24PM +0100, Greg Kroah-Hartman wrote:
 On Tue, Jan 10, 2017 at 08:40:28PM +0300, Dmitry Osipenko wrote:
> Hello, this patch causes a kernel panic with the rtl8192cu driver.

 Ick, not good!  Does this cause a problem in Linus's tree as well?

>>>
>>> http://lkml.iu.edu/hypermail/linux/kernel/1701.1/00228.html
>>
>> OK the pending patch is here and not yet upstream :
>>
>> http://marc.info/?l=linux-wireless=148234081512703=2
>>
>> It fixes ba9f93f82aba (patch 3/116) so better postpone it until
>> the patch above gets merged.
> 
> Yes, I've reverted this now and will wait for this fixup to hit Linus's
> tree.  Larry, can you remind me to include the original patch in the
> stable tree when this fixup is merged?
> 

Thanks a lot for taking an action.

-- 
Dmitry

Re: [PATCH 4.9 003/116] rtlwifi: Fix enter/exit power_save

[Dmitry Osipenko]

On 11.01.2017 04:53, Larry Finger wrote:
> On 01/10/2017 11:40 AM, Dmitry Osipenko wrote:
>> Hello, this patch causes a kernel panic with the rtl8192cu driver.
>>



> 
> The fix is being merged into mainline. The reference is
> http://marc.info/?l=linux-wireless=148234081512703=2.

That indeed fixes the issue, thanks!

-- 
Dmitry

Re: [PATCH 4.9 003/116] rtlwifi: Fix enter/exit power_save

[Dmitry Osipenko]

On 11.01.2017 04:53, Larry Finger wrote:
> On 01/10/2017 11:40 AM, Dmitry Osipenko wrote:
>> Hello, this patch causes a kernel panic with the rtl8192cu driver.
>>



> 
> The fix is being merged into mainline. The reference is
> http://marc.info/?l=linux-wireless=148234081512703=2.

That indeed fixes the issue, thanks!

-- 
Dmitry

Re: [PATCH 4.9 003/116] rtlwifi: Fix enter/exit power_save

[Greg Kroah-Hartman]

On Tue, Jan 10, 2017 at 10:51:56PM +0100, Willy Tarreau wrote:
> On Tue, Jan 10, 2017 at 03:23:27PM -0600, l...@pengaru.com wrote:
> > On Tue, Jan 10, 2017 at 09:40:24PM +0100, Greg Kroah-Hartman wrote:
> > > On Tue, Jan 10, 2017 at 08:40:28PM +0300, Dmitry Osipenko wrote:
> > > > Hello, this patch causes a kernel panic with the rtl8192cu driver.
> > > 
> > > Ick, not good!  Does this cause a problem in Linus's tree as well?
> > > 
> > 
> > http://lkml.iu.edu/hypermail/linux/kernel/1701.1/00228.html
> 
> OK the pending patch is here and not yet upstream :
> 
> http://marc.info/?l=linux-wireless=148234081512703=2
> 
> It fixes ba9f93f82aba (patch 3/116) so better postpone it until
> the patch above gets merged.

Yes, I've reverted this now and will wait for this fixup to hit Linus's
tree.  Larry, can you remind me to include the original patch in the
stable tree when this fixup is merged?

thanks,

greg k-h

Re: [PATCH 4.9 003/116] rtlwifi: Fix enter/exit power_save

[Greg Kroah-Hartman]

On Tue, Jan 10, 2017 at 10:51:56PM +0100, Willy Tarreau wrote:
> On Tue, Jan 10, 2017 at 03:23:27PM -0600, l...@pengaru.com wrote:
> > On Tue, Jan 10, 2017 at 09:40:24PM +0100, Greg Kroah-Hartman wrote:
> > > On Tue, Jan 10, 2017 at 08:40:28PM +0300, Dmitry Osipenko wrote:
> > > > Hello, this patch causes a kernel panic with the rtl8192cu driver.
> > > 
> > > Ick, not good!  Does this cause a problem in Linus's tree as well?
> > > 
> > 
> > http://lkml.iu.edu/hypermail/linux/kernel/1701.1/00228.html
> 
> OK the pending patch is here and not yet upstream :
> 
> http://marc.info/?l=linux-wireless=148234081512703=2
> 
> It fixes ba9f93f82aba (patch 3/116) so better postpone it until
> the patch above gets merged.

Yes, I've reverted this now and will wait for this fixup to hit Linus's
tree.  Larry, can you remind me to include the original patch in the
stable tree when this fixup is merged?

thanks,

greg k-h

Re: [PATCH 4.9 003/116] rtlwifi: Fix enter/exit power_save

[Larry Finger]

On 01/10/2017 02:40 PM, Greg Kroah-Hartman wrote:

On Tue, Jan 10, 2017 at 08:40:28PM +0300, Dmitry Osipenko wrote:

Hello, this patch causes a kernel panic with the rtl8192cu driver.


Ick, not good!  Does this cause a problem in Linus's tree as well?


Yes, but he is aware that the pacth exists and has asked the wireless maintainer 
about it. It went to DaveM today.


Larry

Re: [PATCH 4.9 003/116] rtlwifi: Fix enter/exit power_save

[Larry Finger]

On 01/10/2017 02:40 PM, Greg Kroah-Hartman wrote:

On Tue, Jan 10, 2017 at 08:40:28PM +0300, Dmitry Osipenko wrote:

Hello, this patch causes a kernel panic with the rtl8192cu driver.


Ick, not good!  Does this cause a problem in Linus's tree as well?


Yes, but he is aware that the pacth exists and has asked the wireless maintainer 
about it. It went to DaveM today.


Larry

Re: [PATCH 4.9 003/116] rtlwifi: Fix enter/exit power_save

[Larry Finger]

On 01/10/2017 11:40 AM, Dmitry Osipenko wrote:

Hello, this patch causes a kernel panic with the rtl8192cu driver.

<6>[   20.847025] IPv6: ADDRCONF(NETDEV_CHANGE): wlan0: link becomes ready
<1>[   21.699551] BUG: unable to handle kernel NULL pointer dereference at
0048
<1>[   21.699626] IP: [] rtl_lps_leave+0x13/0x40 [rtlwifi]
<4>[   21.699681] PGD 20cf47067
<4>[   21.699702] PUD 20cf42067
<4>[   21.699725] PMD 0
<4>[   21.699732]
<4>[   21.699759] Oops:  [#1] PREEMPT SMP
<4>[   21.699794] Modules linked in: rtl8192cu rtl_usb rtl8192c_common rtlwifi
snd_hda_codec_realtek snd_hda_codec_generic snd_hda_intel snd_hda_codec
snd_hwdep snd_hda_core dm_mod thermal
<4>[   21.699985] CPU: 0 PID: 2656 Comm: ntpdate Not tainted 4.9.2 #1
<4>[   21.700036] Hardware name: Gigabyte Technology Co., Ltd. To be filled by
O.E.M./Z77-DS3H, BIOS F11a 11/13/2013
<4>[   21.700118] task: 9ce2509ca4c0 task.stack: a41003eac000
<4>[   21.700168] RIP: 0010:[]  []
rtl_lps_leave+0x13/0x40 [rtlwifi]
<4>[   21.700250] RSP: 0018:a41003eaf520  EFLAGS: 00010206
<4>[   21.700296] RAX: 8802 RBX: 9ce251371420 RCX: 
9ce254ff4640
<4>[   21.700356] RDX: 0806 RSI: 9ce25137afb8 RDI: 

<4>[   21.700416] RBP: 9ce25137afb8 R08: c0382d00 R09: 
9ce254e38c31
<4>[   21.700475] R10:  R11: 9ce251370700 R12: 

<4>[   21.700535] R13:  R14: 9ce251371420 R15: 
9ce254e38c00
<4>[   21.700595] FS:  7f22f6da8700() GS:9ce25f20()
knlGS:
<4>[   21.700662] CS:  0010 DS:  ES:  CR0: 80050033
<4>[   21.700711] CR2: 0048 CR3: 00020cf65000 CR4: 
001406f0
<4>[   21.700770] Stack:
<4>[   21.700790]  c0375088 0008 9ce251370700
0001
<4>[   21.700867]  c03751c7 0100 a41003eaf618
9ce252b5a800
<4>[   21.700944]   9ce251371420 
9ce254e38c00
<4>[   21.701021] Call Trace:
<4>[   21.701048]  [] ? setup_arp_tx.isra.20+0x48/0x60 
[rtlwifi]
<4>[   21.701110]  [] ? rtl_is_special_data+0x127/0x210 
[rtlwifi]
<4>[   21.701171]  [] ? rtl_get_rate+0x97/0x210 [rtlwifi]
<4>[   21.701228]  [] ? rate_control_get_rate+0xb6/0x140
<4>[   21.701283]  [] ? ieee80211_tx_h_rate_ctrl+0x1e0/0x3f0
<4>[   21.701340]  [] ? invoke_tx_handlers_early+0x222/0x5a0
<4>[   21.701397]  [] ? ieee80211_tx+0x6e/0x130
<4>[   21.701446]  [] ? 
__ieee80211_subif_start_xmit+0x4d1/0x9d0
<4>[   21.701506]  [] ? nf_conntrack_tuple_taken+0x1c4/0x1d0
<4>[   21.701565]  [] ? get_unique_tuple+0xe9/0x510
<4>[   21.701617]  [] ? ieee80211_subif_start_xmit+0xc/0x10
<4>[   21.701675]  [] ? dev_hard_start_xmit+0x9a/0x210
<4>[   21.701729]  [] ? sch_direct_xmit+0xd6/0x1a0
<4>[   21.701780]  [] ? __dev_queue_xmit+0x422/0x620
<4>[   21.701832]  [] ? arp_xmit+0x9f/0xb0
<4>[   21.701878]  [] ? arp_create+0x250/0x250
<4>[   21.701926]  [] ? arp_solicit+0xee/0x240
<4>[   21.701974]  [] ? mod_timer+0x1ad/0x360
<4>[   21.702022]  [] ? neigh_probe+0x42/0x60
<4>[   21.702071]  [] ? __neigh_event_send+0x1e2/0x230
<4>[   21.702124]  [] ? neigh_resolve_output+0x120/0x1b0
<4>[   21.702179]  [] ? ip_finish_output2+0x127/0x300
<4>[   21.702231]  [] ? ip_output+0x64/0x100
<4>[   21.702277]  [] ?
__ip_flush_pending_frames.isra.46+0x80/0x80
<4>[   21.702339]  [] ? ip_send_skb+0x15/0x40
<4>[   21.702386]  [] ? udp_send_skb+0x15f/0x240
<4>[   21.702436]  [] ? udp_sendmsg+0x2b6/0x840
<4>[   21.702485]  [] ? __local_bh_enable_ip+0x8a/0x90
<4>[   21.702538]  [] ? ip_finish_output2+0x13a/0x300
<4>[   21.702592]  [] ? rw_copy_check_uvector+0x53/0x110
<4>[   21.702648]  [] ? import_iovec+0x27/0xc0
<4>[   21.702698]  [] ? ___sys_sendmsg+0x111/0x2a0
<4>[   21.702749]  [] ? poll_select_copy_remaining+0x130/0x130
<4>[   21.702808]  [] ? udp_sendmsg+0x2c5/0x840
<4>[   21.702857]  [] ? __ip_dev_find+0x111/0x130
<4>[   21.702908]  [] ? __ip_route_output_key_hash+0x2c5/0x870
<4>[   21.702968]  [] ? __sys_sendmmsg+0x89/0x160
<4>[   21.703018]  [] ? SYSC_connect+0x50/0xa0
<4>[   21.703066]  [] ? sock_alloc_file+0x9a/0x110
<4>[   21.703119]  [] ? SyS_sendmmsg+0xe/0x20
<4>[   21.703166]  [] ? entry_SYSCALL_64_fastpath+0x1a/0xa9
<4>[   21.703222] Code: 05 e9 32 ff ff ff e9 2d fe ff ff 0f 1f 00 66 2e 0f 1f 84
00 00 00 00 00 0f 1f 44 00 00 65 8b 05 24 f4 c8 3f a9 00 ff 1f 00 74 23 <48> 8b
57 48 bf 40 00 00 00 48 8b 35 3d ba b7 da c6 82 ad a2 00
<1>[   21.709488] RIP  [] rtl_lps_leave+0x13/0x40 [rtlwifi]
<4>[   21.712533]  RSP 
<4>[   21.715589] CR2: 0048
<4>[   21.735721] ---[ end trace f6ce402401b0b86a ]---


4.9-stable review patch.  If anyone has any objections, please let me know.

--

From: Larry Finger 

commit ba9f93f82abafe2552eac942ebb11c2df4f8dd7f upstream.

In commit a5ffbe0a1993 ("rtlwifi: Fix scheduling while atomic bug") and
commit a269913c52ad ("rtlwifi: Rework 

Re: [PATCH 4.9 003/116] rtlwifi: Fix enter/exit power_save

[Larry Finger]

On 01/10/2017 11:40 AM, Dmitry Osipenko wrote:

Hello, this patch causes a kernel panic with the rtl8192cu driver.

<6>[   20.847025] IPv6: ADDRCONF(NETDEV_CHANGE): wlan0: link becomes ready
<1>[   21.699551] BUG: unable to handle kernel NULL pointer dereference at
0048
<1>[   21.699626] IP: [] rtl_lps_leave+0x13/0x40 [rtlwifi]
<4>[   21.699681] PGD 20cf47067
<4>[   21.699702] PUD 20cf42067
<4>[   21.699725] PMD 0
<4>[   21.699732]
<4>[   21.699759] Oops:  [#1] PREEMPT SMP
<4>[   21.699794] Modules linked in: rtl8192cu rtl_usb rtl8192c_common rtlwifi
snd_hda_codec_realtek snd_hda_codec_generic snd_hda_intel snd_hda_codec
snd_hwdep snd_hda_core dm_mod thermal
<4>[   21.699985] CPU: 0 PID: 2656 Comm: ntpdate Not tainted 4.9.2 #1
<4>[   21.700036] Hardware name: Gigabyte Technology Co., Ltd. To be filled by
O.E.M./Z77-DS3H, BIOS F11a 11/13/2013
<4>[   21.700118] task: 9ce2509ca4c0 task.stack: a41003eac000
<4>[   21.700168] RIP: 0010:[]  []
rtl_lps_leave+0x13/0x40 [rtlwifi]
<4>[   21.700250] RSP: 0018:a41003eaf520  EFLAGS: 00010206
<4>[   21.700296] RAX: 8802 RBX: 9ce251371420 RCX: 
9ce254ff4640
<4>[   21.700356] RDX: 0806 RSI: 9ce25137afb8 RDI: 

<4>[   21.700416] RBP: 9ce25137afb8 R08: c0382d00 R09: 
9ce254e38c31
<4>[   21.700475] R10:  R11: 9ce251370700 R12: 

<4>[   21.700535] R13:  R14: 9ce251371420 R15: 
9ce254e38c00
<4>[   21.700595] FS:  7f22f6da8700() GS:9ce25f20()
knlGS:
<4>[   21.700662] CS:  0010 DS:  ES:  CR0: 80050033
<4>[   21.700711] CR2: 0048 CR3: 00020cf65000 CR4: 
001406f0
<4>[   21.700770] Stack:
<4>[   21.700790]  c0375088 0008 9ce251370700
0001
<4>[   21.700867]  c03751c7 0100 a41003eaf618
9ce252b5a800
<4>[   21.700944]   9ce251371420 
9ce254e38c00
<4>[   21.701021] Call Trace:
<4>[   21.701048]  [] ? setup_arp_tx.isra.20+0x48/0x60 
[rtlwifi]
<4>[   21.701110]  [] ? rtl_is_special_data+0x127/0x210 
[rtlwifi]
<4>[   21.701171]  [] ? rtl_get_rate+0x97/0x210 [rtlwifi]
<4>[   21.701228]  [] ? rate_control_get_rate+0xb6/0x140
<4>[   21.701283]  [] ? ieee80211_tx_h_rate_ctrl+0x1e0/0x3f0
<4>[   21.701340]  [] ? invoke_tx_handlers_early+0x222/0x5a0
<4>[   21.701397]  [] ? ieee80211_tx+0x6e/0x130
<4>[   21.701446]  [] ? 
__ieee80211_subif_start_xmit+0x4d1/0x9d0
<4>[   21.701506]  [] ? nf_conntrack_tuple_taken+0x1c4/0x1d0
<4>[   21.701565]  [] ? get_unique_tuple+0xe9/0x510
<4>[   21.701617]  [] ? ieee80211_subif_start_xmit+0xc/0x10
<4>[   21.701675]  [] ? dev_hard_start_xmit+0x9a/0x210
<4>[   21.701729]  [] ? sch_direct_xmit+0xd6/0x1a0
<4>[   21.701780]  [] ? __dev_queue_xmit+0x422/0x620
<4>[   21.701832]  [] ? arp_xmit+0x9f/0xb0
<4>[   21.701878]  [] ? arp_create+0x250/0x250
<4>[   21.701926]  [] ? arp_solicit+0xee/0x240
<4>[   21.701974]  [] ? mod_timer+0x1ad/0x360
<4>[   21.702022]  [] ? neigh_probe+0x42/0x60
<4>[   21.702071]  [] ? __neigh_event_send+0x1e2/0x230
<4>[   21.702124]  [] ? neigh_resolve_output+0x120/0x1b0
<4>[   21.702179]  [] ? ip_finish_output2+0x127/0x300
<4>[   21.702231]  [] ? ip_output+0x64/0x100
<4>[   21.702277]  [] ?
__ip_flush_pending_frames.isra.46+0x80/0x80
<4>[   21.702339]  [] ? ip_send_skb+0x15/0x40
<4>[   21.702386]  [] ? udp_send_skb+0x15f/0x240
<4>[   21.702436]  [] ? udp_sendmsg+0x2b6/0x840
<4>[   21.702485]  [] ? __local_bh_enable_ip+0x8a/0x90
<4>[   21.702538]  [] ? ip_finish_output2+0x13a/0x300
<4>[   21.702592]  [] ? rw_copy_check_uvector+0x53/0x110
<4>[   21.702648]  [] ? import_iovec+0x27/0xc0
<4>[   21.702698]  [] ? ___sys_sendmsg+0x111/0x2a0
<4>[   21.702749]  [] ? poll_select_copy_remaining+0x130/0x130
<4>[   21.702808]  [] ? udp_sendmsg+0x2c5/0x840
<4>[   21.702857]  [] ? __ip_dev_find+0x111/0x130
<4>[   21.702908]  [] ? __ip_route_output_key_hash+0x2c5/0x870
<4>[   21.702968]  [] ? __sys_sendmmsg+0x89/0x160
<4>[   21.703018]  [] ? SYSC_connect+0x50/0xa0
<4>[   21.703066]  [] ? sock_alloc_file+0x9a/0x110
<4>[   21.703119]  [] ? SyS_sendmmsg+0xe/0x20
<4>[   21.703166]  [] ? entry_SYSCALL_64_fastpath+0x1a/0xa9
<4>[   21.703222] Code: 05 e9 32 ff ff ff e9 2d fe ff ff 0f 1f 00 66 2e 0f 1f 84
00 00 00 00 00 0f 1f 44 00 00 65 8b 05 24 f4 c8 3f a9 00 ff 1f 00 74 23 <48> 8b
57 48 bf 40 00 00 00 48 8b 35 3d ba b7 da c6 82 ad a2 00
<1>[   21.709488] RIP  [] rtl_lps_leave+0x13/0x40 [rtlwifi]
<4>[   21.712533]  RSP 
<4>[   21.715589] CR2: 0048
<4>[   21.735721] ---[ end trace f6ce402401b0b86a ]---


4.9-stable review patch.  If anyone has any objections, please let me know.

--

From: Larry Finger 

commit ba9f93f82abafe2552eac942ebb11c2df4f8dd7f upstream.

In commit a5ffbe0a1993 ("rtlwifi: Fix scheduling while atomic bug") and
commit a269913c52ad ("rtlwifi: Rework rtl_lps_leave() and rtl_lps_enter()
to 

Re: [PATCH 4.9 003/116] rtlwifi: Fix enter/exit power_save

[Willy Tarreau]

On Tue, Jan 10, 2017 at 03:23:27PM -0600, l...@pengaru.com wrote:
> On Tue, Jan 10, 2017 at 09:40:24PM +0100, Greg Kroah-Hartman wrote:
> > On Tue, Jan 10, 2017 at 08:40:28PM +0300, Dmitry Osipenko wrote:
> > > Hello, this patch causes a kernel panic with the rtl8192cu driver.
> > 
> > Ick, not good!  Does this cause a problem in Linus's tree as well?
> > 
> 
> http://lkml.iu.edu/hypermail/linux/kernel/1701.1/00228.html

OK the pending patch is here and not yet upstream :

http://marc.info/?l=linux-wireless=148234081512703=2

It fixes ba9f93f82aba (patch 3/116) so better postpone it until
the patch above gets merged.

Willy

Re: [PATCH 4.9 003/116] rtlwifi: Fix enter/exit power_save

[Willy Tarreau]

On Tue, Jan 10, 2017 at 03:23:27PM -0600, l...@pengaru.com wrote:
> On Tue, Jan 10, 2017 at 09:40:24PM +0100, Greg Kroah-Hartman wrote:
> > On Tue, Jan 10, 2017 at 08:40:28PM +0300, Dmitry Osipenko wrote:
> > > Hello, this patch causes a kernel panic with the rtl8192cu driver.
> > 
> > Ick, not good!  Does this cause a problem in Linus's tree as well?
> > 
> 
> http://lkml.iu.edu/hypermail/linux/kernel/1701.1/00228.html

OK the pending patch is here and not yet upstream :

http://marc.info/?l=linux-wireless=148234081512703=2

It fixes ba9f93f82aba (patch 3/116) so better postpone it until
the patch above gets merged.

Willy

Re: [PATCH 4.9 003/116] rtlwifi: Fix enter/exit power_save

[lkml]

On Tue, Jan 10, 2017 at 09:40:24PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Jan 10, 2017 at 08:40:28PM +0300, Dmitry Osipenko wrote:
> > Hello, this patch causes a kernel panic with the rtl8192cu driver.
> 
> Ick, not good!  Does this cause a problem in Linus's tree as well?
> 

http://lkml.iu.edu/hypermail/linux/kernel/1701.1/00228.html

Re: [PATCH 4.9 003/116] rtlwifi: Fix enter/exit power_save

[lkml]

On Tue, Jan 10, 2017 at 09:40:24PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Jan 10, 2017 at 08:40:28PM +0300, Dmitry Osipenko wrote:
> > Hello, this patch causes a kernel panic with the rtl8192cu driver.
> 
> Ick, not good!  Does this cause a problem in Linus's tree as well?
> 

http://lkml.iu.edu/hypermail/linux/kernel/1701.1/00228.html

Re: [PATCH 4.9 003/116] rtlwifi: Fix enter/exit power_save

[Greg Kroah-Hartman]

On Tue, Jan 10, 2017 at 08:40:28PM +0300, Dmitry Osipenko wrote:
> Hello, this patch causes a kernel panic with the rtl8192cu driver.

Ick, not good!  Does this cause a problem in Linus's tree as well?

thanks,

greg k-h

> 
> <6>[   20.847025] IPv6: ADDRCONF(NETDEV_CHANGE): wlan0: link becomes ready
> <1>[   21.699551] BUG: unable to handle kernel NULL pointer dereference at
> 0048
> <1>[   21.699626] IP: [] rtl_lps_leave+0x13/0x40 [rtlwifi]
> <4>[   21.699681] PGD 20cf47067
> <4>[   21.699702] PUD 20cf42067
> <4>[   21.699725] PMD 0
> <4>[   21.699732]
> <4>[   21.699759] Oops:  [#1] PREEMPT SMP
> <4>[   21.699794] Modules linked in: rtl8192cu rtl_usb rtl8192c_common rtlwifi
> snd_hda_codec_realtek snd_hda_codec_generic snd_hda_intel snd_hda_codec
> snd_hwdep snd_hda_core dm_mod thermal
> <4>[   21.699985] CPU: 0 PID: 2656 Comm: ntpdate Not tainted 4.9.2 #1
> <4>[   21.700036] Hardware name: Gigabyte Technology Co., Ltd. To be filled by
> O.E.M./Z77-DS3H, BIOS F11a 11/13/2013
> <4>[   21.700118] task: 9ce2509ca4c0 task.stack: a41003eac000
> <4>[   21.700168] RIP: 0010:[]  []
> rtl_lps_leave+0x13/0x40 [rtlwifi]
> <4>[   21.700250] RSP: 0018:a41003eaf520  EFLAGS: 00010206
> <4>[   21.700296] RAX: 8802 RBX: 9ce251371420 RCX: 
> 9ce254ff4640
> <4>[   21.700356] RDX: 0806 RSI: 9ce25137afb8 RDI: 
> 
> <4>[   21.700416] RBP: 9ce25137afb8 R08: c0382d00 R09: 
> 9ce254e38c31
> <4>[   21.700475] R10:  R11: 9ce251370700 R12: 
> 
> <4>[   21.700535] R13:  R14: 9ce251371420 R15: 
> 9ce254e38c00
> <4>[   21.700595] FS:  7f22f6da8700() GS:9ce25f20()
> knlGS:
> <4>[   21.700662] CS:  0010 DS:  ES:  CR0: 80050033
> <4>[   21.700711] CR2: 0048 CR3: 00020cf65000 CR4: 
> 001406f0
> <4>[   21.700770] Stack:
> <4>[   21.700790]  c0375088 0008 9ce251370700
> 0001
> <4>[   21.700867]  c03751c7 0100 a41003eaf618
> 9ce252b5a800
> <4>[   21.700944]   9ce251371420 
> 9ce254e38c00
> <4>[   21.701021] Call Trace:
> <4>[   21.701048]  [] ? setup_arp_tx.isra.20+0x48/0x60 
> [rtlwifi]
> <4>[   21.701110]  [] ? rtl_is_special_data+0x127/0x210 
> [rtlwifi]
> <4>[   21.701171]  [] ? rtl_get_rate+0x97/0x210 [rtlwifi]
> <4>[   21.701228]  [] ? rate_control_get_rate+0xb6/0x140
> <4>[   21.701283]  [] ? ieee80211_tx_h_rate_ctrl+0x1e0/0x3f0
> <4>[   21.701340]  [] ? invoke_tx_handlers_early+0x222/0x5a0
> <4>[   21.701397]  [] ? ieee80211_tx+0x6e/0x130
> <4>[   21.701446]  [] ? 
> __ieee80211_subif_start_xmit+0x4d1/0x9d0
> <4>[   21.701506]  [] ? nf_conntrack_tuple_taken+0x1c4/0x1d0
> <4>[   21.701565]  [] ? get_unique_tuple+0xe9/0x510
> <4>[   21.701617]  [] ? ieee80211_subif_start_xmit+0xc/0x10
> <4>[   21.701675]  [] ? dev_hard_start_xmit+0x9a/0x210
> <4>[   21.701729]  [] ? sch_direct_xmit+0xd6/0x1a0
> <4>[   21.701780]  [] ? __dev_queue_xmit+0x422/0x620
> <4>[   21.701832]  [] ? arp_xmit+0x9f/0xb0
> <4>[   21.701878]  [] ? arp_create+0x250/0x250
> <4>[   21.701926]  [] ? arp_solicit+0xee/0x240
> <4>[   21.701974]  [] ? mod_timer+0x1ad/0x360
> <4>[   21.702022]  [] ? neigh_probe+0x42/0x60
> <4>[   21.702071]  [] ? __neigh_event_send+0x1e2/0x230
> <4>[   21.702124]  [] ? neigh_resolve_output+0x120/0x1b0
> <4>[   21.702179]  [] ? ip_finish_output2+0x127/0x300
> <4>[   21.702231]  [] ? ip_output+0x64/0x100
> <4>[   21.702277]  [] ?
> __ip_flush_pending_frames.isra.46+0x80/0x80
> <4>[   21.702339]  [] ? ip_send_skb+0x15/0x40
> <4>[   21.702386]  [] ? udp_send_skb+0x15f/0x240
> <4>[   21.702436]  [] ? udp_sendmsg+0x2b6/0x840
> <4>[   21.702485]  [] ? __local_bh_enable_ip+0x8a/0x90
> <4>[   21.702538]  [] ? ip_finish_output2+0x13a/0x300
> <4>[   21.702592]  [] ? rw_copy_check_uvector+0x53/0x110
> <4>[   21.702648]  [] ? import_iovec+0x27/0xc0
> <4>[   21.702698]  [] ? ___sys_sendmsg+0x111/0x2a0
> <4>[   21.702749]  [] ? 
> poll_select_copy_remaining+0x130/0x130
> <4>[   21.702808]  [] ? udp_sendmsg+0x2c5/0x840
> <4>[   21.702857]  [] ? __ip_dev_find+0x111/0x130
> <4>[   21.702908]  [] ? 
> __ip_route_output_key_hash+0x2c5/0x870
> <4>[   21.702968]  [] ? __sys_sendmmsg+0x89/0x160
> <4>[   21.703018]  [] ? SYSC_connect+0x50/0xa0
> <4>[   21.703066]  [] ? sock_alloc_file+0x9a/0x110
> <4>[   21.703119]  [] ? SyS_sendmmsg+0xe/0x20
> <4>[   21.703166]  [] ? entry_SYSCALL_64_fastpath+0x1a/0xa9
> <4>[   21.703222] Code: 05 e9 32 ff ff ff e9 2d fe ff ff 0f 1f 00 66 2e 0f 1f 
> 84
> 00 00 00 00 00 0f 1f 44 00 00 65 8b 05 24 f4 c8 3f a9 00 ff 1f 00 74 23 <48> 
> 8b
> 57 48 bf 40 00 00 00 48 8b 35 3d ba b7 da c6 82 ad a2 00
> <1>[   21.709488] RIP  [] rtl_lps_leave+0x13/0x40 [rtlwifi]
> <4>[   21.712533]  RSP 
> <4>[   21.715589] CR2: 0048
> <4>[   21.735721] ---[ end trace f6ce402401b0b86a ]---
> 
> > 4.9-stable 

Re: [PATCH 4.9 003/116] rtlwifi: Fix enter/exit power_save

[Greg Kroah-Hartman]

On Tue, Jan 10, 2017 at 08:40:28PM +0300, Dmitry Osipenko wrote:
> Hello, this patch causes a kernel panic with the rtl8192cu driver.

Ick, not good!  Does this cause a problem in Linus's tree as well?

thanks,

greg k-h

> 
> <6>[   20.847025] IPv6: ADDRCONF(NETDEV_CHANGE): wlan0: link becomes ready
> <1>[   21.699551] BUG: unable to handle kernel NULL pointer dereference at
> 0048
> <1>[   21.699626] IP: [] rtl_lps_leave+0x13/0x40 [rtlwifi]
> <4>[   21.699681] PGD 20cf47067
> <4>[   21.699702] PUD 20cf42067
> <4>[   21.699725] PMD 0
> <4>[   21.699732]
> <4>[   21.699759] Oops:  [#1] PREEMPT SMP
> <4>[   21.699794] Modules linked in: rtl8192cu rtl_usb rtl8192c_common rtlwifi
> snd_hda_codec_realtek snd_hda_codec_generic snd_hda_intel snd_hda_codec
> snd_hwdep snd_hda_core dm_mod thermal
> <4>[   21.699985] CPU: 0 PID: 2656 Comm: ntpdate Not tainted 4.9.2 #1
> <4>[   21.700036] Hardware name: Gigabyte Technology Co., Ltd. To be filled by
> O.E.M./Z77-DS3H, BIOS F11a 11/13/2013
> <4>[   21.700118] task: 9ce2509ca4c0 task.stack: a41003eac000
> <4>[   21.700168] RIP: 0010:[]  []
> rtl_lps_leave+0x13/0x40 [rtlwifi]
> <4>[   21.700250] RSP: 0018:a41003eaf520  EFLAGS: 00010206
> <4>[   21.700296] RAX: 8802 RBX: 9ce251371420 RCX: 
> 9ce254ff4640
> <4>[   21.700356] RDX: 0806 RSI: 9ce25137afb8 RDI: 
> 
> <4>[   21.700416] RBP: 9ce25137afb8 R08: c0382d00 R09: 
> 9ce254e38c31
> <4>[   21.700475] R10:  R11: 9ce251370700 R12: 
> 
> <4>[   21.700535] R13:  R14: 9ce251371420 R15: 
> 9ce254e38c00
> <4>[   21.700595] FS:  7f22f6da8700() GS:9ce25f20()
> knlGS:
> <4>[   21.700662] CS:  0010 DS:  ES:  CR0: 80050033
> <4>[   21.700711] CR2: 0048 CR3: 00020cf65000 CR4: 
> 001406f0
> <4>[   21.700770] Stack:
> <4>[   21.700790]  c0375088 0008 9ce251370700
> 0001
> <4>[   21.700867]  c03751c7 0100 a41003eaf618
> 9ce252b5a800
> <4>[   21.700944]   9ce251371420 
> 9ce254e38c00
> <4>[   21.701021] Call Trace:
> <4>[   21.701048]  [] ? setup_arp_tx.isra.20+0x48/0x60 
> [rtlwifi]
> <4>[   21.701110]  [] ? rtl_is_special_data+0x127/0x210 
> [rtlwifi]
> <4>[   21.701171]  [] ? rtl_get_rate+0x97/0x210 [rtlwifi]
> <4>[   21.701228]  [] ? rate_control_get_rate+0xb6/0x140
> <4>[   21.701283]  [] ? ieee80211_tx_h_rate_ctrl+0x1e0/0x3f0
> <4>[   21.701340]  [] ? invoke_tx_handlers_early+0x222/0x5a0
> <4>[   21.701397]  [] ? ieee80211_tx+0x6e/0x130
> <4>[   21.701446]  [] ? 
> __ieee80211_subif_start_xmit+0x4d1/0x9d0
> <4>[   21.701506]  [] ? nf_conntrack_tuple_taken+0x1c4/0x1d0
> <4>[   21.701565]  [] ? get_unique_tuple+0xe9/0x510
> <4>[   21.701617]  [] ? ieee80211_subif_start_xmit+0xc/0x10
> <4>[   21.701675]  [] ? dev_hard_start_xmit+0x9a/0x210
> <4>[   21.701729]  [] ? sch_direct_xmit+0xd6/0x1a0
> <4>[   21.701780]  [] ? __dev_queue_xmit+0x422/0x620
> <4>[   21.701832]  [] ? arp_xmit+0x9f/0xb0
> <4>[   21.701878]  [] ? arp_create+0x250/0x250
> <4>[   21.701926]  [] ? arp_solicit+0xee/0x240
> <4>[   21.701974]  [] ? mod_timer+0x1ad/0x360
> <4>[   21.702022]  [] ? neigh_probe+0x42/0x60
> <4>[   21.702071]  [] ? __neigh_event_send+0x1e2/0x230
> <4>[   21.702124]  [] ? neigh_resolve_output+0x120/0x1b0
> <4>[   21.702179]  [] ? ip_finish_output2+0x127/0x300
> <4>[   21.702231]  [] ? ip_output+0x64/0x100
> <4>[   21.702277]  [] ?
> __ip_flush_pending_frames.isra.46+0x80/0x80
> <4>[   21.702339]  [] ? ip_send_skb+0x15/0x40
> <4>[   21.702386]  [] ? udp_send_skb+0x15f/0x240
> <4>[   21.702436]  [] ? udp_sendmsg+0x2b6/0x840
> <4>[   21.702485]  [] ? __local_bh_enable_ip+0x8a/0x90
> <4>[   21.702538]  [] ? ip_finish_output2+0x13a/0x300
> <4>[   21.702592]  [] ? rw_copy_check_uvector+0x53/0x110
> <4>[   21.702648]  [] ? import_iovec+0x27/0xc0
> <4>[   21.702698]  [] ? ___sys_sendmsg+0x111/0x2a0
> <4>[   21.702749]  [] ? 
> poll_select_copy_remaining+0x130/0x130
> <4>[   21.702808]  [] ? udp_sendmsg+0x2c5/0x840
> <4>[   21.702857]  [] ? __ip_dev_find+0x111/0x130
> <4>[   21.702908]  [] ? 
> __ip_route_output_key_hash+0x2c5/0x870
> <4>[   21.702968]  [] ? __sys_sendmmsg+0x89/0x160
> <4>[   21.703018]  [] ? SYSC_connect+0x50/0xa0
> <4>[   21.703066]  [] ? sock_alloc_file+0x9a/0x110
> <4>[   21.703119]  [] ? SyS_sendmmsg+0xe/0x20
> <4>[   21.703166]  [] ? entry_SYSCALL_64_fastpath+0x1a/0xa9
> <4>[   21.703222] Code: 05 e9 32 ff ff ff e9 2d fe ff ff 0f 1f 00 66 2e 0f 1f 
> 84
> 00 00 00 00 00 0f 1f 44 00 00 65 8b 05 24 f4 c8 3f a9 00 ff 1f 00 74 23 <48> 
> 8b
> 57 48 bf 40 00 00 00 48 8b 35 3d ba b7 da c6 82 ad a2 00
> <1>[   21.709488] RIP  [] rtl_lps_leave+0x13/0x40 [rtlwifi]
> <4>[   21.712533]  RSP 
> <4>[   21.715589] CR2: 0048
> <4>[   21.735721] ---[ end trace f6ce402401b0b86a ]---
> 
> > 4.9-stable 

Re: [PATCH 4.9 003/116] rtlwifi: Fix enter/exit power_save

[Dmitry Osipenko]

Hello, this patch causes a kernel panic with the rtl8192cu driver.

<6>[   20.847025] IPv6: ADDRCONF(NETDEV_CHANGE): wlan0: link becomes ready
<1>[   21.699551] BUG: unable to handle kernel NULL pointer dereference at
0048
<1>[   21.699626] IP: [] rtl_lps_leave+0x13/0x40 [rtlwifi]
<4>[   21.699681] PGD 20cf47067
<4>[   21.699702] PUD 20cf42067
<4>[   21.699725] PMD 0
<4>[   21.699732]
<4>[   21.699759] Oops:  [#1] PREEMPT SMP
<4>[   21.699794] Modules linked in: rtl8192cu rtl_usb rtl8192c_common rtlwifi
snd_hda_codec_realtek snd_hda_codec_generic snd_hda_intel snd_hda_codec
snd_hwdep snd_hda_core dm_mod thermal
<4>[   21.699985] CPU: 0 PID: 2656 Comm: ntpdate Not tainted 4.9.2 #1
<4>[   21.700036] Hardware name: Gigabyte Technology Co., Ltd. To be filled by
O.E.M./Z77-DS3H, BIOS F11a 11/13/2013
<4>[   21.700118] task: 9ce2509ca4c0 task.stack: a41003eac000
<4>[   21.700168] RIP: 0010:[]  []
rtl_lps_leave+0x13/0x40 [rtlwifi]
<4>[   21.700250] RSP: 0018:a41003eaf520  EFLAGS: 00010206
<4>[   21.700296] RAX: 8802 RBX: 9ce251371420 RCX: 
9ce254ff4640
<4>[   21.700356] RDX: 0806 RSI: 9ce25137afb8 RDI: 

<4>[   21.700416] RBP: 9ce25137afb8 R08: c0382d00 R09: 
9ce254e38c31
<4>[   21.700475] R10:  R11: 9ce251370700 R12: 

<4>[   21.700535] R13:  R14: 9ce251371420 R15: 
9ce254e38c00
<4>[   21.700595] FS:  7f22f6da8700() GS:9ce25f20()
knlGS:
<4>[   21.700662] CS:  0010 DS:  ES:  CR0: 80050033
<4>[   21.700711] CR2: 0048 CR3: 00020cf65000 CR4: 
001406f0
<4>[   21.700770] Stack:
<4>[   21.700790]  c0375088 0008 9ce251370700
0001
<4>[   21.700867]  c03751c7 0100 a41003eaf618
9ce252b5a800
<4>[   21.700944]   9ce251371420 
9ce254e38c00
<4>[   21.701021] Call Trace:
<4>[   21.701048]  [] ? setup_arp_tx.isra.20+0x48/0x60 
[rtlwifi]
<4>[   21.701110]  [] ? rtl_is_special_data+0x127/0x210 
[rtlwifi]
<4>[   21.701171]  [] ? rtl_get_rate+0x97/0x210 [rtlwifi]
<4>[   21.701228]  [] ? rate_control_get_rate+0xb6/0x140
<4>[   21.701283]  [] ? ieee80211_tx_h_rate_ctrl+0x1e0/0x3f0
<4>[   21.701340]  [] ? invoke_tx_handlers_early+0x222/0x5a0
<4>[   21.701397]  [] ? ieee80211_tx+0x6e/0x130
<4>[   21.701446]  [] ? 
__ieee80211_subif_start_xmit+0x4d1/0x9d0
<4>[   21.701506]  [] ? nf_conntrack_tuple_taken+0x1c4/0x1d0
<4>[   21.701565]  [] ? get_unique_tuple+0xe9/0x510
<4>[   21.701617]  [] ? ieee80211_subif_start_xmit+0xc/0x10
<4>[   21.701675]  [] ? dev_hard_start_xmit+0x9a/0x210
<4>[   21.701729]  [] ? sch_direct_xmit+0xd6/0x1a0
<4>[   21.701780]  [] ? __dev_queue_xmit+0x422/0x620
<4>[   21.701832]  [] ? arp_xmit+0x9f/0xb0
<4>[   21.701878]  [] ? arp_create+0x250/0x250
<4>[   21.701926]  [] ? arp_solicit+0xee/0x240
<4>[   21.701974]  [] ? mod_timer+0x1ad/0x360
<4>[   21.702022]  [] ? neigh_probe+0x42/0x60
<4>[   21.702071]  [] ? __neigh_event_send+0x1e2/0x230
<4>[   21.702124]  [] ? neigh_resolve_output+0x120/0x1b0
<4>[   21.702179]  [] ? ip_finish_output2+0x127/0x300
<4>[   21.702231]  [] ? ip_output+0x64/0x100
<4>[   21.702277]  [] ?
__ip_flush_pending_frames.isra.46+0x80/0x80
<4>[   21.702339]  [] ? ip_send_skb+0x15/0x40
<4>[   21.702386]  [] ? udp_send_skb+0x15f/0x240
<4>[   21.702436]  [] ? udp_sendmsg+0x2b6/0x840
<4>[   21.702485]  [] ? __local_bh_enable_ip+0x8a/0x90
<4>[   21.702538]  [] ? ip_finish_output2+0x13a/0x300
<4>[   21.702592]  [] ? rw_copy_check_uvector+0x53/0x110
<4>[   21.702648]  [] ? import_iovec+0x27/0xc0
<4>[   21.702698]  [] ? ___sys_sendmsg+0x111/0x2a0
<4>[   21.702749]  [] ? poll_select_copy_remaining+0x130/0x130
<4>[   21.702808]  [] ? udp_sendmsg+0x2c5/0x840
<4>[   21.702857]  [] ? __ip_dev_find+0x111/0x130
<4>[   21.702908]  [] ? __ip_route_output_key_hash+0x2c5/0x870
<4>[   21.702968]  [] ? __sys_sendmmsg+0x89/0x160
<4>[   21.703018]  [] ? SYSC_connect+0x50/0xa0
<4>[   21.703066]  [] ? sock_alloc_file+0x9a/0x110
<4>[   21.703119]  [] ? SyS_sendmmsg+0xe/0x20
<4>[   21.703166]  [] ? entry_SYSCALL_64_fastpath+0x1a/0xa9
<4>[   21.703222] Code: 05 e9 32 ff ff ff e9 2d fe ff ff 0f 1f 00 66 2e 0f 1f 84
00 00 00 00 00 0f 1f 44 00 00 65 8b 05 24 f4 c8 3f a9 00 ff 1f 00 74 23 <48> 8b
57 48 bf 40 00 00 00 48 8b 35 3d ba b7 da c6 82 ad a2 00
<1>[   21.709488] RIP  [] rtl_lps_leave+0x13/0x40 [rtlwifi]
<4>[   21.712533]  RSP 
<4>[   21.715589] CR2: 0048
<4>[   21.735721] ---[ end trace f6ce402401b0b86a ]---

> 4.9-stable review patch.  If anyone has any objections, please let me know.
> 
> --
> 
> From: Larry Finger 
> 
> commit ba9f93f82abafe2552eac942ebb11c2df4f8dd7f upstream.
> 
> In commit a5ffbe0a1993 ("rtlwifi: Fix scheduling while atomic bug") and
> commit a269913c52ad ("rtlwifi: Rework rtl_lps_leave() and rtl_lps_enter()
> to use 

Re: [PATCH 4.9 003/116] rtlwifi: Fix enter/exit power_save

[Dmitry Osipenko]

Hello, this patch causes a kernel panic with the rtl8192cu driver.

<6>[   20.847025] IPv6: ADDRCONF(NETDEV_CHANGE): wlan0: link becomes ready
<1>[   21.699551] BUG: unable to handle kernel NULL pointer dereference at
0048
<1>[   21.699626] IP: [] rtl_lps_leave+0x13/0x40 [rtlwifi]
<4>[   21.699681] PGD 20cf47067
<4>[   21.699702] PUD 20cf42067
<4>[   21.699725] PMD 0
<4>[   21.699732]
<4>[   21.699759] Oops:  [#1] PREEMPT SMP
<4>[   21.699794] Modules linked in: rtl8192cu rtl_usb rtl8192c_common rtlwifi
snd_hda_codec_realtek snd_hda_codec_generic snd_hda_intel snd_hda_codec
snd_hwdep snd_hda_core dm_mod thermal
<4>[   21.699985] CPU: 0 PID: 2656 Comm: ntpdate Not tainted 4.9.2 #1
<4>[   21.700036] Hardware name: Gigabyte Technology Co., Ltd. To be filled by
O.E.M./Z77-DS3H, BIOS F11a 11/13/2013
<4>[   21.700118] task: 9ce2509ca4c0 task.stack: a41003eac000
<4>[   21.700168] RIP: 0010:[]  []
rtl_lps_leave+0x13/0x40 [rtlwifi]
<4>[   21.700250] RSP: 0018:a41003eaf520  EFLAGS: 00010206
<4>[   21.700296] RAX: 8802 RBX: 9ce251371420 RCX: 
9ce254ff4640
<4>[   21.700356] RDX: 0806 RSI: 9ce25137afb8 RDI: 

<4>[   21.700416] RBP: 9ce25137afb8 R08: c0382d00 R09: 
9ce254e38c31
<4>[   21.700475] R10:  R11: 9ce251370700 R12: 

<4>[   21.700535] R13:  R14: 9ce251371420 R15: 
9ce254e38c00
<4>[   21.700595] FS:  7f22f6da8700() GS:9ce25f20()
knlGS:
<4>[   21.700662] CS:  0010 DS:  ES:  CR0: 80050033
<4>[   21.700711] CR2: 0048 CR3: 00020cf65000 CR4: 
001406f0
<4>[   21.700770] Stack:
<4>[   21.700790]  c0375088 0008 9ce251370700
0001
<4>[   21.700867]  c03751c7 0100 a41003eaf618
9ce252b5a800
<4>[   21.700944]   9ce251371420 
9ce254e38c00
<4>[   21.701021] Call Trace:
<4>[   21.701048]  [] ? setup_arp_tx.isra.20+0x48/0x60 
[rtlwifi]
<4>[   21.701110]  [] ? rtl_is_special_data+0x127/0x210 
[rtlwifi]
<4>[   21.701171]  [] ? rtl_get_rate+0x97/0x210 [rtlwifi]
<4>[   21.701228]  [] ? rate_control_get_rate+0xb6/0x140
<4>[   21.701283]  [] ? ieee80211_tx_h_rate_ctrl+0x1e0/0x3f0
<4>[   21.701340]  [] ? invoke_tx_handlers_early+0x222/0x5a0
<4>[   21.701397]  [] ? ieee80211_tx+0x6e/0x130
<4>[   21.701446]  [] ? 
__ieee80211_subif_start_xmit+0x4d1/0x9d0
<4>[   21.701506]  [] ? nf_conntrack_tuple_taken+0x1c4/0x1d0
<4>[   21.701565]  [] ? get_unique_tuple+0xe9/0x510
<4>[   21.701617]  [] ? ieee80211_subif_start_xmit+0xc/0x10
<4>[   21.701675]  [] ? dev_hard_start_xmit+0x9a/0x210
<4>[   21.701729]  [] ? sch_direct_xmit+0xd6/0x1a0
<4>[   21.701780]  [] ? __dev_queue_xmit+0x422/0x620
<4>[   21.701832]  [] ? arp_xmit+0x9f/0xb0
<4>[   21.701878]  [] ? arp_create+0x250/0x250
<4>[   21.701926]  [] ? arp_solicit+0xee/0x240
<4>[   21.701974]  [] ? mod_timer+0x1ad/0x360
<4>[   21.702022]  [] ? neigh_probe+0x42/0x60
<4>[   21.702071]  [] ? __neigh_event_send+0x1e2/0x230
<4>[   21.702124]  [] ? neigh_resolve_output+0x120/0x1b0
<4>[   21.702179]  [] ? ip_finish_output2+0x127/0x300
<4>[   21.702231]  [] ? ip_output+0x64/0x100
<4>[   21.702277]  [] ?
__ip_flush_pending_frames.isra.46+0x80/0x80
<4>[   21.702339]  [] ? ip_send_skb+0x15/0x40
<4>[   21.702386]  [] ? udp_send_skb+0x15f/0x240
<4>[   21.702436]  [] ? udp_sendmsg+0x2b6/0x840
<4>[   21.702485]  [] ? __local_bh_enable_ip+0x8a/0x90
<4>[   21.702538]  [] ? ip_finish_output2+0x13a/0x300
<4>[   21.702592]  [] ? rw_copy_check_uvector+0x53/0x110
<4>[   21.702648]  [] ? import_iovec+0x27/0xc0
<4>[   21.702698]  [] ? ___sys_sendmsg+0x111/0x2a0
<4>[   21.702749]  [] ? poll_select_copy_remaining+0x130/0x130
<4>[   21.702808]  [] ? udp_sendmsg+0x2c5/0x840
<4>[   21.702857]  [] ? __ip_dev_find+0x111/0x130
<4>[   21.702908]  [] ? __ip_route_output_key_hash+0x2c5/0x870
<4>[   21.702968]  [] ? __sys_sendmmsg+0x89/0x160
<4>[   21.703018]  [] ? SYSC_connect+0x50/0xa0
<4>[   21.703066]  [] ? sock_alloc_file+0x9a/0x110
<4>[   21.703119]  [] ? SyS_sendmmsg+0xe/0x20
<4>[   21.703166]  [] ? entry_SYSCALL_64_fastpath+0x1a/0xa9
<4>[   21.703222] Code: 05 e9 32 ff ff ff e9 2d fe ff ff 0f 1f 00 66 2e 0f 1f 84
00 00 00 00 00 0f 1f 44 00 00 65 8b 05 24 f4 c8 3f a9 00 ff 1f 00 74 23 <48> 8b
57 48 bf 40 00 00 00 48 8b 35 3d ba b7 da c6 82 ad a2 00
<1>[   21.709488] RIP  [] rtl_lps_leave+0x13/0x40 [rtlwifi]
<4>[   21.712533]  RSP 
<4>[   21.715589] CR2: 0048
<4>[   21.735721] ---[ end trace f6ce402401b0b86a ]---

> 4.9-stable review patch.  If anyone has any objections, please let me know.
> 
> --
> 
> From: Larry Finger 
> 
> commit ba9f93f82abafe2552eac942ebb11c2df4f8dd7f upstream.
> 
> In commit a5ffbe0a1993 ("rtlwifi: Fix scheduling while atomic bug") and
> commit a269913c52ad ("rtlwifi: Rework rtl_lps_leave() and rtl_lps_enter()
> to use work queue"), an error was