Re: [PATCH 5/8] perf tools: Catch event names from command line
On 20.08.12 19:42:47, Jiri Olsa wrote: > I like the idea of multiple states in parser, > but parse tests fails: > > [jolsa@krava perf]$ ./perf test -vvv parse > 5: parse events tests: > --- start --- > running test 0 'syscalls:sys_enter_open' > running test 1 'syscalls:*' > running test 2 'r1a' > running test 3 '1:1' > running test 4 'instructions' > running test 5 'cycles/period=10,config2/' > running test 6 'faults' > running test 7 'L1-dcache-load-miss' > running test 8 'mem:0' > running test 9 'mem:0:x' > running test 10 'mem:0:r' > running test 11 'mem:0:w' > running test 12 'syscalls:sys_enter_open:k' > running test 13 'syscalls:*:u' > running test 14 'r1a:kp' > running test 15 '1:1:hp' > running test 16 'instructions:h' > running test 17 'faults:u' > running test 18 'L1-dcache-load-miss:kp' > running test 19 'mem:0:u' > FAILED util/parse-events-test.c:309 wrong name > end > parse events tests: FAILED! Right, I need to updated the test cases. Have patches ready for this. -Robert -- Advanced Micro Devices, Inc. Operating System Research Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 5/8] perf tools: Catch event names from command line
On Thu, Aug 16, 2012 at 09:10:21PM +0200, Robert Richter wrote: > Use command line string provided by the -e option to name events. This > way we get unique events names that also support pmu event syntax > (//). No need to reconstruct the name > anymore from its attributes. We use the event_desc of the header to > store the name in the perf.data header. Thus it is also available for > perf report. > > Implemented by putting the parser in different states to parse events > or configs. I like the idea of multiple states in parser, but parse tests fails: [jolsa@krava perf]$ ./perf test -vvv parse 5: parse events tests: --- start --- running test 0 'syscalls:sys_enter_open' running test 1 'syscalls:*' running test 2 'r1a' running test 3 '1:1' running test 4 'instructions' running test 5 'cycles/period=10,config2/' running test 6 'faults' running test 7 'L1-dcache-load-miss' running test 8 'mem:0' running test 9 'mem:0:x' running test 10 'mem:0:r' running test 11 'mem:0:w' running test 12 'syscalls:sys_enter_open:k' running test 13 'syscalls:*:u' running test 14 'r1a:kp' running test 15 '1:1:hp' running test 16 'instructions:h' running test 17 'faults:u' running test 18 'L1-dcache-load-miss:kp' running test 19 'mem:0:u' FAILED util/parse-events-test.c:309 wrong name end parse events tests: FAILED! jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
