Re: [PATCH 50/57] power: ab8500-chargalg: update battery health on safety timer exp
On Tue, Sep 25, 2012 at 10:12:47AM -0600, mathieu.poir...@linaro.org wrote:
> From: Hakan Berg
>
> When the charging safety timer is elapsed the battery health is shown as
> "Good".
> This is misleading and also hard to distingiush problems reported on "phone
> discharges although charger is attached".
>
> When safety timer elapses that is an indication of a fault in the battery of
> some kind. Hence report as POWER_SUPPLY_HEALTH_UNSPEC_FAILURE.
>
> Signed-off-by: Hakan Berg
> Signed-off-by: Mathieu Poirier
> Reviewed-by: Arun MURTHY
> Reviewed-by: Karl KOMIEROWSKI
> ---
> drivers/power/abx500_chargalg.c |4
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/power/abx500_chargalg.c b/drivers/power/abx500_chargalg.c
> index 4db0ef0..1df238f 100644
> --- a/drivers/power/abx500_chargalg.c
> +++ b/drivers/power/abx500_chargalg.c
> @@ -1711,6 +1711,10 @@ static int abx500_chargalg_get_property(struct
> power_supply *psy,
> val->intval = POWER_SUPPLY_HEALTH_COLD;
> else
> val->intval = POWER_SUPPLY_HEALTH_OVERHEAT;
> + } else if (di->charge_state == STATE_SAFETY_TIMER_EXPIRED ||
> + di->charge_state ==
> + STATE_SAFETY_TIMER_EXPIRED_INIT) {
Wrong indentation, no need to wrap lines. (You could align to
di->change_state, and thus it'll look prettier and there still wouldn't
need for line wrapping.)
> + val->intval = POWER_SUPPLY_HEALTH_UNSPEC_FAILURE;
> } else {
> val->intval = POWER_SUPPLY_HEALTH_GOOD;
> }
> --
> 1.7.5.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 50/57] power: ab8500-chargalg: update battery health on safety timer exp
On Tue, Sep 25, 2012 at 10:12:47AM -0600, mathieu.poir...@linaro.org wrote:
From: Hakan Berg hakan.b...@stericsson.com
When the charging safety timer is elapsed the battery health is shown as
Good.
This is misleading and also hard to distingiush problems reported on phone
discharges although charger is attached.
When safety timer elapses that is an indication of a fault in the battery of
some kind. Hence report as POWER_SUPPLY_HEALTH_UNSPEC_FAILURE.
Signed-off-by: Hakan Berg hakan.b...@stericsson.com
Signed-off-by: Mathieu Poirier mathieu.poir...@linaro.org
Reviewed-by: Arun MURTHY arun.mur...@stericsson.com
Reviewed-by: Karl KOMIEROWSKI karl.komierow...@stericsson.com
---
drivers/power/abx500_chargalg.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/power/abx500_chargalg.c b/drivers/power/abx500_chargalg.c
index 4db0ef0..1df238f 100644
--- a/drivers/power/abx500_chargalg.c
+++ b/drivers/power/abx500_chargalg.c
@@ -1711,6 +1711,10 @@ static int abx500_chargalg_get_property(struct
power_supply *psy,
val-intval = POWER_SUPPLY_HEALTH_COLD;
else
val-intval = POWER_SUPPLY_HEALTH_OVERHEAT;
+ } else if (di-charge_state == STATE_SAFETY_TIMER_EXPIRED ||
+ di-charge_state ==
+ STATE_SAFETY_TIMER_EXPIRED_INIT) {
Wrong indentation, no need to wrap lines. (You could align to
di-change_state, and thus it'll look prettier and there still wouldn't
need for line wrapping.)
+ val-intval = POWER_SUPPLY_HEALTH_UNSPEC_FAILURE;
} else {
val-intval = POWER_SUPPLY_HEALTH_GOOD;
}
--
1.7.5.4
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
