Re: [PATCH 6/8] Kconfig: cleanup input menu
Hi, On Fri, 4 Feb 2005, Dmitry Torokhov wrote: > The "generic input layer" submenu is comparable to SCSI or ALSA and > has similar menu structure with userland interfaces on top and drivers > below them. Hardware ports (serio, gameport) "live" outside of generic > input layer and are shown there so they are easier to find. That's an implementation detail you don't really want to let the normal user to know. It's already bad enough that simple keyboard support requires to select two config options. bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/8] Kconfig: cleanup input menu
On Sun, Jan 30, 2005 at 04:45:35PM +0100, Roman Zippel wrote: > Hi, > > On Sat, 29 Jan 2005, Dmitry Torokhov wrote: > > > Ok, what about making some submenus to manage number of options, like in > > the patch below? > > I'd rather move it to the bottom and the menus had no dependencies. > Below is an alternative patch, which does a rather complete cleanup. Applied. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/8] Kconfig: cleanup input menu
On Fri, 4 Feb 2005 15:13:31 +0100 (CET), Roman Zippel <[EMAIL PROTECTED]> wrote: > Hi, > > On Fri, 4 Feb 2005, Vojtech Pavlik wrote: > > > > When I go into a menu I explore option and submenus from top to bottom. > > > So I will see PS/2 or serial, and will go there and select what I need. > > > Then I will see that generic input layer is also needed for keyboard > > > and go there. > > > > > > If generic layer is first one I select options I think are needed I could > > > skip over the HW I/O ports thinking that I already selected everything I > > > need as far as keyboard/mouse goes. > > > > > > Does this make any sense? > > > > Dmitry, will you make a patch that has the port options first? If no, > > I'll likely merge Roman's patch. > > I don't think that putting this first is a good idea, compare it to scsi > or alsa, which also have the generic options first and then the lowlevel > drivers. > The "generic input layer" submenu is comparable to SCSI or ALSA and has similar menu structure with userland interfaces on top and drivers below them. Hardware ports (serio, gameport) "live" outside of generic input layer and are shown there so they are easier to find. -- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/8] Kconfig: cleanup input menu
Hi, On Fri, 4 Feb 2005, Vojtech Pavlik wrote: > > When I go into a menu I explore option and submenus from top to bottom. > > So I will see PS/2 or serial, and will go there and select what I need. > > Then I will see that generic input layer is also needed for keyboard > > and go there. > > > > If generic layer is first one I select options I think are needed I could > > skip over the HW I/O ports thinking that I already selected everything I > > need as far as keyboard/mouse goes. > > > > Does this make any sense? > > Dmitry, will you make a patch that has the port options first? If no, > I'll likely merge Roman's patch. I don't think that putting this first is a good idea, compare it to scsi or alsa, which also have the generic options first and then the lowlevel drivers. bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/8] Kconfig: cleanup input menu
On Fri, Feb 04, 2005 at 08:51:41AM -0500, Dmitry Torokhov wrote: > On Fri, 4 Feb 2005 14:14:36 +0100, Vojtech Pavlik <[EMAIL PROTECTED]> wrote: > > On Sun, Jan 30, 2005 at 06:39:37PM -0500, Dmitry Torokhov wrote: > > > On Sunday 30 January 2005 10:45, Roman Zippel wrote: > > > > Hi, > > > > > > > > On Sat, 29 Jan 2005, Dmitry Torokhov wrote: > > > > > > > > > Ok, what about making some submenus to manage number of options, like > > > > > in > > > > > the patch below? > > > > > > > > I'd rather move it to the bottom and the menus had no dependencies. > > > > Below is an alternative patch, which does a rather complete cleanup. > > > > > > This one looks nice. I still think that hardware port support should go > > > first. My argument is: > > > > > > When I go into a menu I explore option and submenus from top to bottom. > > > So I will see PS/2 or serial, and will go there and select what I need. > > > Then I will see that generic input layer is also needed for keyboard > > > and go there. > > > > > > If generic layer is first one I select options I think are needed I could > > > skip over the HW I/O ports thinking that I already selected everything I > > > need as far as keyboard/mouse goes. > > > > > > Does this make any sense? > > > > Dmitry, will you make a patch that has the port options first? If no, > > I'll likely merge Roman's patch. > > > > I'd rather make a patch on top of Roman's, if you don't mind. This way > we will reduce merge conflicts (Sam I believe already grabbed Roman's > changes and applied to his tree). No problem with that. Shall I apply Roman's patch then? -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/8] Kconfig: cleanup input menu
On Fri, 4 Feb 2005 14:14:36 +0100, Vojtech Pavlik <[EMAIL PROTECTED]> wrote: > On Sun, Jan 30, 2005 at 06:39:37PM -0500, Dmitry Torokhov wrote: > > On Sunday 30 January 2005 10:45, Roman Zippel wrote: > > > Hi, > > > > > > On Sat, 29 Jan 2005, Dmitry Torokhov wrote: > > > > > > > Ok, what about making some submenus to manage number of options, like in > > > > the patch below? > > > > > > I'd rather move it to the bottom and the menus had no dependencies. > > > Below is an alternative patch, which does a rather complete cleanup. > > > > This one looks nice. I still think that hardware port support should go > > first. My argument is: > > > > When I go into a menu I explore option and submenus from top to bottom. > > So I will see PS/2 or serial, and will go there and select what I need. > > Then I will see that generic input layer is also needed for keyboard > > and go there. > > > > If generic layer is first one I select options I think are needed I could > > skip over the HW I/O ports thinking that I already selected everything I > > need as far as keyboard/mouse goes. > > > > Does this make any sense? > > Dmitry, will you make a patch that has the port options first? If no, > I'll likely merge Roman's patch. > I'd rather make a patch on top of Roman's, if you don't mind. This way we will reduce merge conflicts (Sam I believe already grabbed Roman's changes and applied to his tree). -- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/8] Kconfig: cleanup input menu
On Sun, Jan 30, 2005 at 06:39:37PM -0500, Dmitry Torokhov wrote: > On Sunday 30 January 2005 10:45, Roman Zippel wrote: > > Hi, > > > > On Sat, 29 Jan 2005, Dmitry Torokhov wrote: > > > > > Ok, what about making some submenus to manage number of options, like in > > > the patch below? > > > > I'd rather move it to the bottom and the menus had no dependencies. > > Below is an alternative patch, which does a rather complete cleanup. > > This one looks nice. I still think that hardware port support should go > first. My argument is: > > When I go into a menu I explore option and submenus from top to bottom. > So I will see PS/2 or serial, and will go there and select what I need. > Then I will see that generic input layer is also needed for keyboard > and go there. > > If generic layer is first one I select options I think are needed I could > skip over the HW I/O ports thinking that I already selected everything I > need as far as keyboard/mouse goes. > > Does this make any sense? Dmitry, will you make a patch that has the port options first? If no, I'll likely merge Roman's patch. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/8] Kconfig: cleanup input menu
On Sun, Jan 30, 2005 at 06:39:37PM -0500, Dmitry Torokhov wrote: On Sunday 30 January 2005 10:45, Roman Zippel wrote: Hi, On Sat, 29 Jan 2005, Dmitry Torokhov wrote: Ok, what about making some submenus to manage number of options, like in the patch below? I'd rather move it to the bottom and the menus had no dependencies. Below is an alternative patch, which does a rather complete cleanup. This one looks nice. I still think that hardware port support should go first. My argument is: When I go into a menu I explore option and submenus from top to bottom. So I will see PS/2 or serial, and will go there and select what I need. Then I will see that generic input layer is also needed for keyboard and go there. If generic layer is first one I select options I think are needed I could skip over the HW I/O ports thinking that I already selected everything I need as far as keyboard/mouse goes. Does this make any sense? Dmitry, will you make a patch that has the port options first? If no, I'll likely merge Roman's patch. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/8] Kconfig: cleanup input menu
On Fri, 4 Feb 2005 14:14:36 +0100, Vojtech Pavlik [EMAIL PROTECTED] wrote: On Sun, Jan 30, 2005 at 06:39:37PM -0500, Dmitry Torokhov wrote: On Sunday 30 January 2005 10:45, Roman Zippel wrote: Hi, On Sat, 29 Jan 2005, Dmitry Torokhov wrote: Ok, what about making some submenus to manage number of options, like in the patch below? I'd rather move it to the bottom and the menus had no dependencies. Below is an alternative patch, which does a rather complete cleanup. This one looks nice. I still think that hardware port support should go first. My argument is: When I go into a menu I explore option and submenus from top to bottom. So I will see PS/2 or serial, and will go there and select what I need. Then I will see that generic input layer is also needed for keyboard and go there. If generic layer is first one I select options I think are needed I could skip over the HW I/O ports thinking that I already selected everything I need as far as keyboard/mouse goes. Does this make any sense? Dmitry, will you make a patch that has the port options first? If no, I'll likely merge Roman's patch. I'd rather make a patch on top of Roman's, if you don't mind. This way we will reduce merge conflicts (Sam I believe already grabbed Roman's changes and applied to his tree). -- Dmitry - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/8] Kconfig: cleanup input menu
On Fri, Feb 04, 2005 at 08:51:41AM -0500, Dmitry Torokhov wrote: On Fri, 4 Feb 2005 14:14:36 +0100, Vojtech Pavlik [EMAIL PROTECTED] wrote: On Sun, Jan 30, 2005 at 06:39:37PM -0500, Dmitry Torokhov wrote: On Sunday 30 January 2005 10:45, Roman Zippel wrote: Hi, On Sat, 29 Jan 2005, Dmitry Torokhov wrote: Ok, what about making some submenus to manage number of options, like in the patch below? I'd rather move it to the bottom and the menus had no dependencies. Below is an alternative patch, which does a rather complete cleanup. This one looks nice. I still think that hardware port support should go first. My argument is: When I go into a menu I explore option and submenus from top to bottom. So I will see PS/2 or serial, and will go there and select what I need. Then I will see that generic input layer is also needed for keyboard and go there. If generic layer is first one I select options I think are needed I could skip over the HW I/O ports thinking that I already selected everything I need as far as keyboard/mouse goes. Does this make any sense? Dmitry, will you make a patch that has the port options first? If no, I'll likely merge Roman's patch. I'd rather make a patch on top of Roman's, if you don't mind. This way we will reduce merge conflicts (Sam I believe already grabbed Roman's changes and applied to his tree). No problem with that. Shall I apply Roman's patch then? -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/8] Kconfig: cleanup input menu
Hi, On Fri, 4 Feb 2005, Vojtech Pavlik wrote: When I go into a menu I explore option and submenus from top to bottom. So I will see PS/2 or serial, and will go there and select what I need. Then I will see that generic input layer is also needed for keyboard and go there. If generic layer is first one I select options I think are needed I could skip over the HW I/O ports thinking that I already selected everything I need as far as keyboard/mouse goes. Does this make any sense? Dmitry, will you make a patch that has the port options first? If no, I'll likely merge Roman's patch. I don't think that putting this first is a good idea, compare it to scsi or alsa, which also have the generic options first and then the lowlevel drivers. bye, Roman - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/8] Kconfig: cleanup input menu
On Fri, 4 Feb 2005 15:13:31 +0100 (CET), Roman Zippel [EMAIL PROTECTED] wrote: Hi, On Fri, 4 Feb 2005, Vojtech Pavlik wrote: When I go into a menu I explore option and submenus from top to bottom. So I will see PS/2 or serial, and will go there and select what I need. Then I will see that generic input layer is also needed for keyboard and go there. If generic layer is first one I select options I think are needed I could skip over the HW I/O ports thinking that I already selected everything I need as far as keyboard/mouse goes. Does this make any sense? Dmitry, will you make a patch that has the port options first? If no, I'll likely merge Roman's patch. I don't think that putting this first is a good idea, compare it to scsi or alsa, which also have the generic options first and then the lowlevel drivers. The generic input layer submenu is comparable to SCSI or ALSA and has similar menu structure with userland interfaces on top and drivers below them. Hardware ports (serio, gameport) live outside of generic input layer and are shown there so they are easier to find. -- Dmitry - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/8] Kconfig: cleanup input menu
On Sun, Jan 30, 2005 at 04:45:35PM +0100, Roman Zippel wrote: Hi, On Sat, 29 Jan 2005, Dmitry Torokhov wrote: Ok, what about making some submenus to manage number of options, like in the patch below? I'd rather move it to the bottom and the menus had no dependencies. Below is an alternative patch, which does a rather complete cleanup. Applied. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/8] Kconfig: cleanup input menu
Hi, On Fri, 4 Feb 2005, Dmitry Torokhov wrote: The generic input layer submenu is comparable to SCSI or ALSA and has similar menu structure with userland interfaces on top and drivers below them. Hardware ports (serio, gameport) live outside of generic input layer and are shown there so they are easier to find. That's an implementation detail you don't really want to let the normal user to know. It's already bad enough that simple keyboard support requires to select two config options. bye, Roman - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/8] Kconfig: cleanup input menu
On Sunday 30 January 2005 10:45, Roman Zippel wrote: > Hi, > > On Sat, 29 Jan 2005, Dmitry Torokhov wrote: > > > Ok, what about making some submenus to manage number of options, like in > > the patch below? > > I'd rather move it to the bottom and the menus had no dependencies. > Below is an alternative patch, which does a rather complete cleanup. This one looks nice. I still think that hardware port support should go first. My argument is: When I go into a menu I explore option and submenus from top to bottom. So I will see PS/2 or serial, and will go there and select what I need. Then I will see that generic input layer is also needed for keyboard and go there. If generic layer is first one I select options I think are needed I could skip over the HW I/O ports thinking that I already selected everything I need as far as keyboard/mouse goes. Does this make any sense? -- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/8] Kconfig: cleanup input menu
Hi, On Sat, 29 Jan 2005, Dmitry Torokhov wrote: > Ok, what about making some submenus to manage number of options, like in > the patch below? I'd rather move it to the bottom and the menus had no dependencies. Below is an alternative patch, which does a rather complete cleanup. bye, Roman --- Kconfig | 25 + gameport/Kconfig| 48 ++-- joystick/Kconfig| 44 keyboard/Kconfig| 16 +++- misc/Kconfig| 15 --- mouse/Kconfig | 23 +++ serio/Kconfig | 29 ++--- touchscreen/Kconfig |9 + 8 files changed, 100 insertions(+), 109 deletions(-) Index: linux-2.6.11/drivers/input/keyboard/Kconfig === --- linux-2.6.11.orig/drivers/input/keyboard/Kconfig2005-01-30 15:43:04.069685134 +0100 +++ linux-2.6.11/drivers/input/keyboard/Kconfig 2005-01-30 16:33:35.137048741 +0100 @@ -1,20 +1,20 @@ # # Input core configuration # -config INPUT_KEYBOARD +menuconfig INPUT_KEYBOARD bool "Keyboards" if EMBEDDED || !X86 default y - depends on INPUT help Say Y here, and a list of supported keyboards will be displayed. This option doesn't affect the kernel. If unsure, say Y. +if INPUT_KEYBOARD + config KEYBOARD_ATKBD tristate "AT keyboard support" if !PC default y - depends on INPUT && INPUT_KEYBOARD select SERIO select SERIO_LIBPS2 select SERIO_I8042 if PC @@ -32,7 +32,6 @@ config KEYBOARD_ATKBD config KEYBOARD_SUNKBD tristate "Sun Type 4 and Type 5 keyboard support" - depends on INPUT && INPUT_KEYBOARD select SERIO help Say Y here if you want to use a Sun Type 4 or Type 5 keyboard, @@ -44,7 +43,6 @@ config KEYBOARD_SUNKBD config KEYBOARD_LKKBD tristate "DECstation/VAXstation LK201/LK401 keyboard support" - depends on INPUT && INPUT_KEYBOARD select SERIO help Say Y here if you want to use a LK201 or LK401 style serial @@ -57,7 +55,6 @@ config KEYBOARD_LKKBD config KEYBOARD_XTKBD tristate "XT Keyboard support" - depends on INPUT && INPUT_KEYBOARD select SERIO help Say Y here if you want to use the old IBM PC/XT keyboard (or @@ -70,7 +67,6 @@ config KEYBOARD_XTKBD config KEYBOARD_NEWTON tristate "Newton keyboard" - depends on INPUT && INPUT_KEYBOARD select SERIO help Say Y here if you have a Newton keyboard on a serial port. @@ -80,7 +76,7 @@ config KEYBOARD_NEWTON config KEYBOARD_MAPLE tristate "Maple bus keyboard support" - depends on SH_DREAMCAST && INPUT && INPUT_KEYBOARD && MAPLE + depends on SH_DREAMCAST && MAPLE help Say Y here if you have a DreamCast console running Linux and have a keyboard attached to its Maple bus. @@ -90,10 +86,12 @@ config KEYBOARD_MAPLE config KEYBOARD_AMIGA tristate "Amiga keyboard" - depends on AMIGA && INPUT && INPUT_KEYBOARD + depends on AMIGA help Say Y here if you are running Linux on any AMIGA and have a keyboard attached. To compile this driver as a module, choose M here: the module will be called amikbd. + +endif Index: linux-2.6.11/drivers/input/serio/Kconfig === --- linux-2.6.11.orig/drivers/input/serio/Kconfig 2005-01-30 15:43:04.069685134 +0100 +++ linux-2.6.11/drivers/input/serio/Kconfig2005-01-30 16:29:01.445229130 +0100 @@ -2,11 +2,11 @@ # Input core configuration # config SERIO - tristate "Serial i/o support" if EMBEDDED || !X86 + tristate "Serial I/O support" if EMBEDDED || !X86 default y ---help--- Say Yes here if you have any input device that uses serial I/O to - communicate with the system. This includes the + communicate with the system. This includes the * standard AT keyboard and PS/2 mouse * as well as serial mice, Sun keyboards, some joysticks and 6dof devices and more. @@ -16,10 +16,11 @@ config SERIO To compile this driver as a module, choose M here: the module will be called serio. +if SERIO + config SERIO_I8042 tristate "i8042 PC Keyboard controller" if EMBEDDED || !X86 default y - select SERIO depends on !PARISC && (!ARM || ARCH_SHARK || FOOTBRIDGE_HOST) && !M68K ---help--- i8042 is the chip over which the standard AT keyboard and PS/2 @@ -34,7 +35,6 @@ config SERIO_I8042 config SERIO_SERPORT tristate "Serial port line discipline" default y - depends on SERIO ---help---
Re: [PATCH 6/8] Kconfig: cleanup input menu
On Sunday 30 January 2005 10:45, Roman Zippel wrote: Hi, On Sat, 29 Jan 2005, Dmitry Torokhov wrote: Ok, what about making some submenus to manage number of options, like in the patch below? I'd rather move it to the bottom and the menus had no dependencies. Below is an alternative patch, which does a rather complete cleanup. This one looks nice. I still think that hardware port support should go first. My argument is: When I go into a menu I explore option and submenus from top to bottom. So I will see PS/2 or serial, and will go there and select what I need. Then I will see that generic input layer is also needed for keyboard and go there. If generic layer is first one I select options I think are needed I could skip over the HW I/O ports thinking that I already selected everything I need as far as keyboard/mouse goes. Does this make any sense? -- Dmitry - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/8] Kconfig: cleanup input menu
On Saturday 29 January 2005 22:22, Roman Zippel wrote: > Hi, > > On Sat, 29 Jan 2005, Dmitry Torokhov wrote: > > > Well, with the current Kconfig I can de-select INPUT and still select > > serio and serio_raw and access my AUX port via /dev/psaux. I don't know > > if anyone would really do it, but why not? > > > > Btw, what was the point of your patch? > > See the subject. The current input Kconfig menu is already quite complex > for a lot of people, we don't have to confuse them further with a chaotic > menu structure. I only did the minimal fixes to get it into proper shape > with an acceptable compromise. Feel free to take it from here to also make > it technically correct. > Ok, what about making some submenus to manage number of options, like in the patch below? -- Dmitry = drivers/input/Kconfig 1.8 vs edited = --- 1.8/drivers/input/Kconfig 2005-01-15 17:31:06 -05:00 +++ edited/drivers/input/Kconfig2005-01-29 22:53:30 -05:00 @@ -4,8 +4,14 @@ menu "Input device support" +comment "Hardware I/O ports" + +source "drivers/input/serio/Kconfig" + +source "drivers/input/gameport/Kconfig" + config INPUT - tristate "Input devices (needed for keyboard, mouse, ...)" if EMBEDDED + tristate "Generic input layer (needed for keyboard, mouse, ...)" if EMBEDDED default y ---help--- Say Y here if you have any input device (mouse, keyboard, tablet, @@ -23,6 +29,7 @@ module will be called input. comment "Userland interfaces" + depends on INPUT config INPUT_MOUSEDEV tristate "Mouse interface" if EMBEDDED @@ -134,13 +141,8 @@ To compile this driver as a module, choose M here: the module will be called evbug. -comment "Input I/O drivers" - -source "drivers/input/gameport/Kconfig" - -source "drivers/input/serio/Kconfig" - comment "Input Device Drivers" + depends on INPUT source "drivers/input/keyboard/Kconfig" = drivers/input/gameport/Kconfig 1.5 vs edited = --- 1.5/drivers/input/gameport/Kconfig 2005-01-08 00:43:50 -05:00 +++ edited/drivers/input/gameport/Kconfig 2005-01-29 22:50:38 -05:00 @@ -1,6 +1,8 @@ # # Gameport configuration # +menu "Gameport support" + config GAMEPORT tristate "Gameport support" ---help--- @@ -88,3 +90,4 @@ tristate "Crystal SoundFusion gameport support" depends on GAMEPORT +endmenu = drivers/input/joystick/Kconfig 1.10 vs edited = --- 1.10/drivers/input/joystick/Kconfig 2005-01-27 02:13:43 -05:00 +++ edited/drivers/input/joystick/Kconfig 2005-01-29 22:59:51 -05:00 @@ -1,6 +1,8 @@ # # Joystick driver configuration # +menu "Joysticks" + config INPUT_JOYSTICK bool "Joysticks" depends on INPUT @@ -258,3 +260,4 @@ To compile this driver as a module, choose M here: the module will be called joydump. +endmenu = drivers/input/keyboard/Kconfig 1.15 vs edited = --- 1.15/drivers/input/keyboard/Kconfig 2004-09-22 01:48:17 -05:00 +++ edited/drivers/input/keyboard/Kconfig 2005-01-29 22:59:34 -05:00 @@ -1,6 +1,8 @@ # # Input core configuration # +menu "Keyboards" + config INPUT_KEYBOARD bool "Keyboards" if EMBEDDED || !X86 default y @@ -97,3 +99,5 @@ To compile this driver as a module, choose M here: the module will be called amikbd. + +endmenu = drivers/input/misc/Kconfig 1.11 vs edited = --- 1.11/drivers/input/misc/Kconfig 2005-01-15 17:31:06 -05:00 +++ edited/drivers/input/misc/Kconfig 2005-01-29 23:04:17 -05:00 @@ -1,6 +1,8 @@ # # Input misc drivers configuration # +menu "Miscellaneous devices" + config INPUT_MISC bool "Misc" depends on INPUT @@ -49,3 +51,4 @@ To compile this driver as a module, choose M here: the module will be called uinput. +endmenu = drivers/input/mouse/Kconfig 1.21 vs edited = --- 1.21/drivers/input/mouse/Kconfig2005-01-15 17:31:06 -05:00 +++ edited/drivers/input/mouse/Kconfig 2005-01-29 23:01:25 -05:00 @@ -1,6 +1,8 @@ # # Mouse driver configuration # +menu "Mice" + config INPUT_MOUSE bool "Mice" default y @@ -129,3 +131,4 @@ described in the source file). This driver also works with the digitizer (VSXXX-AB) DEC produced. +endmenu = drivers/input/serio/Kconfig 1.21 vs edited = --- 1.21/drivers/input/serio/Kconfig2005-01-04 11:16:51 -05:00 +++ edited/drivers/input/serio/Kconfig 2005-01-29 22:48:56 -05:00 @@ -1,12 +1,14 @@ # # Input core configuration # +menu "PS/2 and serial port support" + config SERIO - tristate "Serial i/o support" if EMBEDDED || !X86 + tristate "Serial I/O support" if EMBEDDED || !X86 default y ---help--- Say Yes here if you have any input device that uses serial I/O to - communicate with the system. This includes the + communicate with the system. This includes the
Re: [PATCH 6/8] Kconfig: cleanup input menu
Hi, On Sat, 29 Jan 2005, Dmitry Torokhov wrote: > Well, with the current Kconfig I can de-select INPUT and still select > serio and serio_raw and access my AUX port via /dev/psaux. I don't know > if anyone would really do it, but why not? > > Btw, what was the point of your patch? See the subject. The current input Kconfig menu is already quite complex for a lot of people, we don't have to confuse them further with a chaotic menu structure. I only did the minimal fixes to get it into proper shape with an acceptable compromise. Feel free to take it from here to also make it technically correct. bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/8] Kconfig: cleanup input menu
On Saturday 29 January 2005 20:16, Roman Zippel wrote: > Hi, > > On Sat, 29 Jan 2005, Dmitry Torokhov wrote: > > > > That's fine, but why is it in the input menu? How do you suggest to make > > > it selectable without selecting input and without messing the menu > > > structure? > > > > Well, probably split input into sections, one of the options would be > > something like "Generic Input Layer" and have evdev, mousedev, etc > > depend on it. serio will not depend on it... nor will gameport as > > I can see someone wanting gameport_raw. > > That's not the point of my patch. Feel free to restructure the input menu, > if you need help you can ask me, but is there any practically relevant > reason, that serio_raw must not depend on INPUT right now? > Well, with the current Kconfig I can de-select INPUT and still select serio and serio_raw and access my AUX port via /dev/psaux. I don't know if anyone would really do it, but why not? Btw, what was the point of your patch? -- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/8] Kconfig: cleanup input menu
Hi, On Sat, 29 Jan 2005, Dmitry Torokhov wrote: > > That's fine, but why is it in the input menu? How do you suggest to make > > it selectable without selecting input and without messing the menu > > structure? > > Well, probably split input into sections, one of the options would be > something like "Generic Input Layer" and have evdev, mousedev, etc > depend on it. serio will not depend on it... nor will gameport as > I can see someone wanting gameport_raw. That's not the point of my patch. Feel free to restructure the input menu, if you need help you can ask me, but is there any practically relevant reason, that serio_raw must not depend on INPUT right now? bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/8] Kconfig: cleanup input menu
On Saturday 29 January 2005 18:56, Roman Zippel wrote: > Hi, > > On Sat, 29 Jan 2005, Dmitry Torokhov wrote: > > > I can assure you that serio_raw driver _does not_ use input system - it is > > implementation of pre 2.6 /dev/psaux interface giving you access to raw AUX > > data. It was written so we can still use PS/2 devices for which we don't > > have > > proper in-kernel driver but have working userspace solution. It completely > > bypasses input layer. > > That's fine, but why is it in the input menu? How do you suggest to make > it selectable without selecting input and without messing the menu > structure? > Well, probably split input into sections, one of the options would be something like "Generic Input Layer" and have evdev, mousedev, etc depend on it. serio will not depend on it... nor will gameport as I can see someone wanting gameport_raw. -- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/8] Kconfig: cleanup input menu
Hi, On Sat, 29 Jan 2005, Dmitry Torokhov wrote: > I can assure you that serio_raw driver _does not_ use input system - it is > implementation of pre 2.6 /dev/psaux interface giving you access to raw AUX > data. It was written so we can still use PS/2 devices for which we don't have > proper in-kernel driver but have working userspace solution. It completely > bypasses input layer. That's fine, but why is it in the input menu? How do you suggest to make it selectable without selecting input and without messing the menu structure? bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/8] Kconfig: cleanup input menu
On Saturday 29 January 2005 18:20, Roman Zippel wrote: > Hi, > > On Sat, 29 Jan 2005, Dmitry Torokhov wrote: > > > On Saturday 29 January 2005 17:20, Roman Zippel wrote: > > > --- linux-2.6.11.orig/drivers/input/serio/KconfigÂÂÂ2005-01-29 > > > 22:50:43.404946203 +0100 > > > +++ linux-2.6.11/drivers/input/serio/Kconfig2005-01-29 > > > 22:56:42.549085439 +0100 > > > @@ -3,6 +3,7 @@ > > > Â# > > > Âconfig SERIO > > > tristate "Serial i/o support" if EMBEDDED || !X86 > > > +ÂÂÂdepends on INPUT > > > > > > > > serio_raw works fine without INPUT. > > All current serio users depend on INPUT, it's maybe not a strict > dependency, but it pretty much needs INPUT anyway to be usable, so I don't > see the problem. > The alternative is to move it completely out of the input menu, if it's > really that important for the user being able to select it without input. > I can assure you that serio_raw driver _does not_ use input system - it is implementation of pre 2.6 /dev/psaux interface giving you access to raw AUX data. It was written so we can still use PS/2 devices for which we don't have proper in-kernel driver but have working userspace solution. It completely bypasses input layer. -- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/8] Kconfig: cleanup input menu
Hi, On Sat, 29 Jan 2005, Dmitry Torokhov wrote: > On Saturday 29 January 2005 17:20, Roman Zippel wrote: > > --- linux-2.6.11.orig/drivers/input/serio/Kconfig 2005-01-29 > > 22:50:43.404946203 +0100 > > +++ linux-2.6.11/drivers/input/serio/Kconfig2005-01-29 > > 22:56:42.549085439 +0100 > > @@ -3,6 +3,7 @@ > > # > > config SERIO > > tristate "Serial i/o support" if EMBEDDED || !X86 > > + depends on INPUT > > > > serio_raw works fine without INPUT. All current serio users depend on INPUT, it's maybe not a strict dependency, but it pretty much needs INPUT anyway to be usable, so I don't see the problem. The alternative is to move it completely out of the input menu, if it's really that important for the user being able to select it without input. bye, Roman
Re: [PATCH 6/8] Kconfig: cleanup input menu
On Saturday 29 January 2005 17:20, Roman Zippel wrote: > --- linux-2.6.11.orig/drivers/input/serio/Kconfig 2005-01-29 > 22:50:43.404946203 +0100 > +++ linux-2.6.11/drivers/input/serio/Kconfig2005-01-29 22:56:42.549085439 > +0100 > @@ -3,6 +3,7 @@ > # > config SERIO > tristate "Serial i/o support" if EMBEDDED || !X86 > + depends on INPUT serio_raw works fine without INPUT. -- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/8] Kconfig: cleanup input menu
On Saturday 29 January 2005 17:20, Roman Zippel wrote: --- linux-2.6.11.orig/drivers/input/serio/Kconfig 2005-01-29 22:50:43.404946203 +0100 +++ linux-2.6.11/drivers/input/serio/Kconfig2005-01-29 22:56:42.549085439 +0100 @@ -3,6 +3,7 @@ # config SERIO tristate Serial i/o support if EMBEDDED || !X86 + depends on INPUT serio_raw works fine without INPUT. -- Dmitry - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/8] Kconfig: cleanup input menu
Hi, On Sat, 29 Jan 2005, Dmitry Torokhov wrote: On Saturday 29 January 2005 17:20, Roman Zippel wrote: --- linux-2.6.11.orig/drivers/input/serio/Kconfig 2005-01-29 22:50:43.404946203 +0100 +++ linux-2.6.11/drivers/input/serio/Kconfig2005-01-29 22:56:42.549085439 +0100 @@ -3,6 +3,7 @@ # config SERIO tristate Serial i/o support if EMBEDDED || !X86 + depends on INPUT serio_raw works fine without INPUT. All current serio users depend on INPUT, it's maybe not a strict dependency, but it pretty much needs INPUT anyway to be usable, so I don't see the problem. The alternative is to move it completely out of the input menu, if it's really that important for the user being able to select it without input. bye, Roman
Re: [PATCH 6/8] Kconfig: cleanup input menu
On Saturday 29 January 2005 18:20, Roman Zippel wrote: Hi, On Sat, 29 Jan 2005, Dmitry Torokhov wrote: On Saturday 29 January 2005 17:20, Roman Zippel wrote: --- linux-2.6.11.orig/drivers/input/serio/Kconfig2005-01-29 22:50:43.404946203 +0100 +++ linux-2.6.11/drivers/input/serio/Kconfig2005-01-29 22:56:42.549085439 +0100 @@ -3,6 +3,7 @@ # config SERIO tristate Serial i/o support if EMBEDDED || !X86 +depends on INPUT serio_raw works fine without INPUT. All current serio users depend on INPUT, it's maybe not a strict dependency, but it pretty much needs INPUT anyway to be usable, so I don't see the problem. The alternative is to move it completely out of the input menu, if it's really that important for the user being able to select it without input. I can assure you that serio_raw driver _does not_ use input system - it is implementation of pre 2.6 /dev/psaux interface giving you access to raw AUX data. It was written so we can still use PS/2 devices for which we don't have proper in-kernel driver but have working userspace solution. It completely bypasses input layer. -- Dmitry - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/8] Kconfig: cleanup input menu
Hi, On Sat, 29 Jan 2005, Dmitry Torokhov wrote: I can assure you that serio_raw driver _does not_ use input system - it is implementation of pre 2.6 /dev/psaux interface giving you access to raw AUX data. It was written so we can still use PS/2 devices for which we don't have proper in-kernel driver but have working userspace solution. It completely bypasses input layer. That's fine, but why is it in the input menu? How do you suggest to make it selectable without selecting input and without messing the menu structure? bye, Roman - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/8] Kconfig: cleanup input menu
On Saturday 29 January 2005 18:56, Roman Zippel wrote: Hi, On Sat, 29 Jan 2005, Dmitry Torokhov wrote: I can assure you that serio_raw driver _does not_ use input system - it is implementation of pre 2.6 /dev/psaux interface giving you access to raw AUX data. It was written so we can still use PS/2 devices for which we don't have proper in-kernel driver but have working userspace solution. It completely bypasses input layer. That's fine, but why is it in the input menu? How do you suggest to make it selectable without selecting input and without messing the menu structure? Well, probably split input into sections, one of the options would be something like Generic Input Layer and have evdev, mousedev, etc depend on it. serio will not depend on it... nor will gameport as I can see someone wanting gameport_raw. -- Dmitry - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/8] Kconfig: cleanup input menu
Hi, On Sat, 29 Jan 2005, Dmitry Torokhov wrote: That's fine, but why is it in the input menu? How do you suggest to make it selectable without selecting input and without messing the menu structure? Well, probably split input into sections, one of the options would be something like Generic Input Layer and have evdev, mousedev, etc depend on it. serio will not depend on it... nor will gameport as I can see someone wanting gameport_raw. That's not the point of my patch. Feel free to restructure the input menu, if you need help you can ask me, but is there any practically relevant reason, that serio_raw must not depend on INPUT right now? bye, Roman - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/8] Kconfig: cleanup input menu
On Saturday 29 January 2005 20:16, Roman Zippel wrote: Hi, On Sat, 29 Jan 2005, Dmitry Torokhov wrote: That's fine, but why is it in the input menu? How do you suggest to make it selectable without selecting input and without messing the menu structure? Well, probably split input into sections, one of the options would be something like Generic Input Layer and have evdev, mousedev, etc depend on it. serio will not depend on it... nor will gameport as I can see someone wanting gameport_raw. That's not the point of my patch. Feel free to restructure the input menu, if you need help you can ask me, but is there any practically relevant reason, that serio_raw must not depend on INPUT right now? Well, with the current Kconfig I can de-select INPUT and still select serio and serio_raw and access my AUX port via /dev/psaux. I don't know if anyone would really do it, but why not? Btw, what was the point of your patch? -- Dmitry - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/8] Kconfig: cleanup input menu
Hi, On Sat, 29 Jan 2005, Dmitry Torokhov wrote: Well, with the current Kconfig I can de-select INPUT and still select serio and serio_raw and access my AUX port via /dev/psaux. I don't know if anyone would really do it, but why not? Btw, what was the point of your patch? See the subject. The current input Kconfig menu is already quite complex for a lot of people, we don't have to confuse them further with a chaotic menu structure. I only did the minimal fixes to get it into proper shape with an acceptable compromise. Feel free to take it from here to also make it technically correct. bye, Roman - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/8] Kconfig: cleanup input menu
On Saturday 29 January 2005 22:22, Roman Zippel wrote: Hi, On Sat, 29 Jan 2005, Dmitry Torokhov wrote: Well, with the current Kconfig I can de-select INPUT and still select serio and serio_raw and access my AUX port via /dev/psaux. I don't know if anyone would really do it, but why not? Btw, what was the point of your patch? See the subject. The current input Kconfig menu is already quite complex for a lot of people, we don't have to confuse them further with a chaotic menu structure. I only did the minimal fixes to get it into proper shape with an acceptable compromise. Feel free to take it from here to also make it technically correct. Ok, what about making some submenus to manage number of options, like in the patch below? -- Dmitry = drivers/input/Kconfig 1.8 vs edited = --- 1.8/drivers/input/Kconfig 2005-01-15 17:31:06 -05:00 +++ edited/drivers/input/Kconfig2005-01-29 22:53:30 -05:00 @@ -4,8 +4,14 @@ menu Input device support +comment Hardware I/O ports + +source drivers/input/serio/Kconfig + +source drivers/input/gameport/Kconfig + config INPUT - tristate Input devices (needed for keyboard, mouse, ...) if EMBEDDED + tristate Generic input layer (needed for keyboard, mouse, ...) if EMBEDDED default y ---help--- Say Y here if you have any input device (mouse, keyboard, tablet, @@ -23,6 +29,7 @@ module will be called input. comment Userland interfaces + depends on INPUT config INPUT_MOUSEDEV tristate Mouse interface if EMBEDDED @@ -134,13 +141,8 @@ To compile this driver as a module, choose M here: the module will be called evbug. -comment Input I/O drivers - -source drivers/input/gameport/Kconfig - -source drivers/input/serio/Kconfig - comment Input Device Drivers + depends on INPUT source drivers/input/keyboard/Kconfig = drivers/input/gameport/Kconfig 1.5 vs edited = --- 1.5/drivers/input/gameport/Kconfig 2005-01-08 00:43:50 -05:00 +++ edited/drivers/input/gameport/Kconfig 2005-01-29 22:50:38 -05:00 @@ -1,6 +1,8 @@ # # Gameport configuration # +menu Gameport support + config GAMEPORT tristate Gameport support ---help--- @@ -88,3 +90,4 @@ tristate Crystal SoundFusion gameport support depends on GAMEPORT +endmenu = drivers/input/joystick/Kconfig 1.10 vs edited = --- 1.10/drivers/input/joystick/Kconfig 2005-01-27 02:13:43 -05:00 +++ edited/drivers/input/joystick/Kconfig 2005-01-29 22:59:51 -05:00 @@ -1,6 +1,8 @@ # # Joystick driver configuration # +menu Joysticks + config INPUT_JOYSTICK bool Joysticks depends on INPUT @@ -258,3 +260,4 @@ To compile this driver as a module, choose M here: the module will be called joydump. +endmenu = drivers/input/keyboard/Kconfig 1.15 vs edited = --- 1.15/drivers/input/keyboard/Kconfig 2004-09-22 01:48:17 -05:00 +++ edited/drivers/input/keyboard/Kconfig 2005-01-29 22:59:34 -05:00 @@ -1,6 +1,8 @@ # # Input core configuration # +menu Keyboards + config INPUT_KEYBOARD bool Keyboards if EMBEDDED || !X86 default y @@ -97,3 +99,5 @@ To compile this driver as a module, choose M here: the module will be called amikbd. + +endmenu = drivers/input/misc/Kconfig 1.11 vs edited = --- 1.11/drivers/input/misc/Kconfig 2005-01-15 17:31:06 -05:00 +++ edited/drivers/input/misc/Kconfig 2005-01-29 23:04:17 -05:00 @@ -1,6 +1,8 @@ # # Input misc drivers configuration # +menu Miscellaneous devices + config INPUT_MISC bool Misc depends on INPUT @@ -49,3 +51,4 @@ To compile this driver as a module, choose M here: the module will be called uinput. +endmenu = drivers/input/mouse/Kconfig 1.21 vs edited = --- 1.21/drivers/input/mouse/Kconfig2005-01-15 17:31:06 -05:00 +++ edited/drivers/input/mouse/Kconfig 2005-01-29 23:01:25 -05:00 @@ -1,6 +1,8 @@ # # Mouse driver configuration # +menu Mice + config INPUT_MOUSE bool Mice default y @@ -129,3 +131,4 @@ described in the source file). This driver also works with the digitizer (VSXXX-AB) DEC produced. +endmenu = drivers/input/serio/Kconfig 1.21 vs edited = --- 1.21/drivers/input/serio/Kconfig2005-01-04 11:16:51 -05:00 +++ edited/drivers/input/serio/Kconfig 2005-01-29 22:48:56 -05:00 @@ -1,12 +1,14 @@ # # Input core configuration # +menu PS/2 and serial port support + config SERIO - tristate Serial i/o support if EMBEDDED || !X86 + tristate Serial I/O support if EMBEDDED || !X86 default y ---help--- Say Yes here if you have any input device that uses serial I/O to - communicate with the system. This includes the + communicate with the system. This includes the * standard AT keyboard and PS/2 mouse * as well as serial mice,
