Re: [PATCH 6/9] T10: Move opencoded contants to common header

2017-04-19 Thread Martin K. Petersen 
Dmitry Monakhov  writes:

Dmitry,

> diff --git a/include/linux/t10-pi.h b/include/linux/t10-pi.h
> index 9fba9dd..f892442 100644
> --- a/include/linux/t10-pi.h
> +++ b/include/linux/t10-pi.h
> @@ -33,6 +33,8 @@ struct t10_pi_tuple {
>   __be32 ref_tag; /* Target LBA or indirect LBA */
>  };
>  
> +#define T10_APP_ESCAPE cpu_to_be16(0x)
> +#define T10_REF_ESCAPE cpu_to_be32(0x)

T10 just means SCSI and does not imply protection information. Please
make these T10_PI_{REF,APP}_ESCAPE (ideally in an enum).

-- 
Martin K. Petersen  Oracle Linux Engineering

Re: [PATCH 6/9] T10: Move opencoded contants to common header

2017-04-19 Thread Martin K. Petersen 
Dmitry Monakhov  writes:

Dmitry,

> diff --git a/include/linux/t10-pi.h b/include/linux/t10-pi.h
> index 9fba9dd..f892442 100644
> --- a/include/linux/t10-pi.h
> +++ b/include/linux/t10-pi.h
> @@ -33,6 +33,8 @@ struct t10_pi_tuple {
>   __be32 ref_tag; /* Target LBA or indirect LBA */
>  };
>  
> +#define T10_APP_ESCAPE cpu_to_be16(0x)
> +#define T10_REF_ESCAPE cpu_to_be32(0x)

T10 just means SCSI and does not imply protection information. Please
make these T10_PI_{REF,APP}_ESCAPE (ideally in an enum).

-- 
Martin K. Petersen  Oracle Linux Engineering

Re: [PATCH 6/9] T10: Move opencoded contants to common header

2017-04-06 Thread Christoph Hellwig 
Looks good,

Reviewed-by: Christoph Hellwig

Re: [PATCH 6/9] T10: Move opencoded contants to common header

2017-04-06 Thread Christoph Hellwig 
Looks good,

Reviewed-by: Christoph Hellwig

Re: [PATCH 6/9] T10: Move opencoded contants to common header

2017-04-05 Thread Hannes Reinecke 
On 04/04/2017 08:56 PM, Dmitry Monakhov wrote:
> Signed-off-by: Dmitry Monakhov 
> ---
>  block/t10-pi.c   | 9 +++--
>  drivers/scsi/lpfc/lpfc_scsi.c| 5 +++--
>  drivers/scsi/qla2xxx/qla_isr.c   | 8 
>  drivers/target/target_core_sbc.c | 2 +-
>  include/linux/t10-pi.h   | 2 ++
>  5 files changed, 13 insertions(+), 13 deletions(-)
> 
Reviewed-by: Hannes Reinecke 

Cheers,

Hannes
-- 
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de   +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)

Re: [PATCH 6/9] T10: Move opencoded contants to common header

2017-04-05 Thread Hannes Reinecke 
On 04/04/2017 08:56 PM, Dmitry Monakhov wrote:
> Signed-off-by: Dmitry Monakhov 
> ---
>  block/t10-pi.c   | 9 +++--
>  drivers/scsi/lpfc/lpfc_scsi.c| 5 +++--
>  drivers/scsi/qla2xxx/qla_isr.c   | 8 
>  drivers/target/target_core_sbc.c | 2 +-
>  include/linux/t10-pi.h   | 2 ++
>  5 files changed, 13 insertions(+), 13 deletions(-)
> 
Reviewed-by: Hannes Reinecke 

Cheers,

Hannes
-- 
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de   +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)