Re: [PATCH 6/9] docs: kvm: devices/arm-vgic-v3: enhance KVM_DEV_ARM_VGIC_CTRL_INIT doc
Hi Alexandru, On 1/12/21 4:39 PM, Alexandru Elisei wrote: > Hi Eric, > > On 12/12/20 6:50 PM, Eric Auger wrote: >> kvm_arch_vcpu_precreate() returns -EBUSY if the vgic is >> already initialized. So let's document that KVM_DEV_ARM_VGIC_CTRL_INIT >> must be called after all vcpu creations. > > Checked and this is indeed the case, > kvm_vm_ioctl_create_vcpu()->kvm_arch_vcpu_precreate() returns -EBUSY is > vgic_initialized() is true. thanks! > >> >> Signed-off-by: Eric Auger >> --- >> Documentation/virt/kvm/devices/arm-vgic-v3.rst | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/virt/kvm/devices/arm-vgic-v3.rst >> b/Documentation/virt/kvm/devices/arm-vgic-v3.rst >> index 5dd3bff51978..322de6aebdec 100644 >> --- a/Documentation/virt/kvm/devices/arm-vgic-v3.rst >> +++ b/Documentation/virt/kvm/devices/arm-vgic-v3.rst >> @@ -228,7 +228,7 @@ Groups: >> >> KVM_DEV_ARM_VGIC_CTRL_INIT >>request the initialization of the VGIC, no additional parameter in >> - kvm_device_attr.addr. >> + kvm_device_attr.addr. Must be called after all vcpu creations. > > Nitpick here: the document writes VCPU with all caps. This also sounds a bit > weird, I think something like "Must be called after all VCPUs have been > created" > is clearer. I took your suggestion. Thanks Eric > > Thanks, > Alex >> KVM_DEV_ARM_VGIC_SAVE_PENDING_TABLES >>save all LPI pending bits into guest RAM pending tables. >> >
Re: [PATCH 6/9] docs: kvm: devices/arm-vgic-v3: enhance KVM_DEV_ARM_VGIC_CTRL_INIT doc
Hi Eric, On 12/12/20 6:50 PM, Eric Auger wrote: > kvm_arch_vcpu_precreate() returns -EBUSY if the vgic is > already initialized. So let's document that KVM_DEV_ARM_VGIC_CTRL_INIT > must be called after all vcpu creations. Checked and this is indeed the case, kvm_vm_ioctl_create_vcpu()->kvm_arch_vcpu_precreate() returns -EBUSY is vgic_initialized() is true. > > Signed-off-by: Eric Auger > --- > Documentation/virt/kvm/devices/arm-vgic-v3.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/virt/kvm/devices/arm-vgic-v3.rst > b/Documentation/virt/kvm/devices/arm-vgic-v3.rst > index 5dd3bff51978..322de6aebdec 100644 > --- a/Documentation/virt/kvm/devices/arm-vgic-v3.rst > +++ b/Documentation/virt/kvm/devices/arm-vgic-v3.rst > @@ -228,7 +228,7 @@ Groups: > > KVM_DEV_ARM_VGIC_CTRL_INIT >request the initialization of the VGIC, no additional parameter in > - kvm_device_attr.addr. > + kvm_device_attr.addr. Must be called after all vcpu creations. Nitpick here: the document writes VCPU with all caps. This also sounds a bit weird, I think something like "Must be called after all VCPUs have been created" is clearer. Thanks, Alex > KVM_DEV_ARM_VGIC_SAVE_PENDING_TABLES >save all LPI pending bits into guest RAM pending tables. >
