Re: [PATCH 8/8] pci and yenta: pcibios_bus_to_resource
On Tue, Jul 26, 2005 at 04:50:49PM -0700, Greg KH wrote: > On Tue, Jul 12, 2005 at 12:21:38AM +0200, Dominik Brodowski wrote: > > In yenta_socket, we default to using the resource setting of the CardBus > > bridge. However, this is a PCI-bus-centric view of resources and thus > > needs to be converted to generic resources first. Therefore, add a call > > to pcibios_bus_to_resource() call in between. This function is a mere > > wrapper on x86 and friends, however on some others it already exists, is > > added in this patch (alpha, arm, ppc, ppc64) or still needs to be > > provided (parisc -- where is its pcibios_resource_to_bus() ?). > > > > Signed-off-by: Dominik Brodowski <[EMAIL PROTECTED]> > > Hm, I saw a few different patches here, and some odd complaints. Care > to resend an updated version? AFAICS, Andrew has merged all fixes into this version: http://kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13-rc3/2.6.13-rc3-mm3/broken-out/pci-and-yenta-pcibios_bus_to_resource.patch Thanks, Dominik - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 8/8] pci and yenta: pcibios_bus_to_resource
On Tue, Jul 26, 2005 at 04:50:49PM -0700, Greg KH wrote: On Tue, Jul 12, 2005 at 12:21:38AM +0200, Dominik Brodowski wrote: In yenta_socket, we default to using the resource setting of the CardBus bridge. However, this is a PCI-bus-centric view of resources and thus needs to be converted to generic resources first. Therefore, add a call to pcibios_bus_to_resource() call in between. This function is a mere wrapper on x86 and friends, however on some others it already exists, is added in this patch (alpha, arm, ppc, ppc64) or still needs to be provided (parisc -- where is its pcibios_resource_to_bus() ?). Signed-off-by: Dominik Brodowski [EMAIL PROTECTED] Hm, I saw a few different patches here, and some odd complaints. Care to resend an updated version? AFAICS, Andrew has merged all fixes into this version: http://kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13-rc3/2.6.13-rc3-mm3/broken-out/pci-and-yenta-pcibios_bus_to_resource.patch Thanks, Dominik - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 8/8] pci and yenta: pcibios_bus_to_resource
On Tue, Jul 12, 2005 at 12:21:38AM +0200, Dominik Brodowski wrote: > In yenta_socket, we default to using the resource setting of the CardBus > bridge. However, this is a PCI-bus-centric view of resources and thus > needs to be converted to generic resources first. Therefore, add a call > to pcibios_bus_to_resource() call in between. This function is a mere > wrapper on x86 and friends, however on some others it already exists, is > added in this patch (alpha, arm, ppc, ppc64) or still needs to be > provided (parisc -- where is its pcibios_resource_to_bus() ?). > > Signed-off-by: Dominik Brodowski <[EMAIL PROTECTED]> Hm, I saw a few different patches here, and some odd complaints. Care to resend an updated version? thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 8/8] pci and yenta: pcibios_bus_to_resource
On Tue, Jul 12, 2005 at 12:21:38AM +0200, Dominik Brodowski wrote: In yenta_socket, we default to using the resource setting of the CardBus bridge. However, this is a PCI-bus-centric view of resources and thus needs to be converted to generic resources first. Therefore, add a call to pcibios_bus_to_resource() call in between. This function is a mere wrapper on x86 and friends, however on some others it already exists, is added in this patch (alpha, arm, ppc, ppc64) or still needs to be provided (parisc -- where is its pcibios_resource_to_bus() ?). Signed-off-by: Dominik Brodowski [EMAIL PROTECTED] Hm, I saw a few different patches here, and some odd complaints. Care to resend an updated version? thanks, greg k-h - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] pcibios_bus_to_resource for parisc [Was: Re: [PATCH 8/8] pci and yenta: pcibios_bus_to_resource]
On Sat, Jul 23, 2005 at 09:54:11PM +0200, Dominik Brodowski wrote:
> Oh, yes, I seem to have missed it. Sorry. Does this patch look good?
Yes.
Acked-by: Grant Grundler <[EMAIL PROTECTED]>
I'll commit this to the cvs.parisc-linux.org tree as well.
Willy can let me deal with the collision if it's not trivial
on his next merge.
thanks,
grant
>
>
> Add pcibios_bus_to_resource for parisc.
>
> Signed-off-by: Dominik Brodowski <[EMAIL PROTECTED]>
>
> Index: 2.6.13-rc3-git2/arch/parisc/kernel/pci.c
> ===
> --- 2.6.13-rc3-git2.orig/arch/parisc/kernel/pci.c
> +++ 2.6.13-rc3-git2/arch/parisc/kernel/pci.c
> @@ -255,8 +255,26 @@ void __devinit pcibios_resource_to_bus(s
> pcibios_link_hba_resources(>lmmio_space, bus->resource[1]);
> }
>
> +void pcibios_bus_to_resource(struct pci_dev *dev, struct resource *res,
> + struct pci_bus_region *region)
> +{
> + struct pci_bus *bus = dev->bus;
> + struct pci_hba_data *hba = HBA_DATA(bus->bridge->platform_data);
> +
> + if (res->flags & IORESOURCE_MEM) {
> + res->start = PCI_HOST_ADDR(hba, region->start);
> + res->end = PCI_HOST_ADDR(hba, region->end);
> + }
> +
> + if (res->flags & IORESOURCE_IO) {
> + res->start = region->start;
> + res->end = region->end;
> + }
> +}
> +
> #ifdef CONFIG_HOTPLUG
> EXPORT_SYMBOL(pcibios_resource_to_bus);
> +EXPORT_SYMBOL(pcibios_bus_to_resource);
> #endif
>
> /*
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] pcibios_bus_to_resource for parisc [Was: Re: [PATCH 8/8] pci and yenta: pcibios_bus_to_resource]
On Sat, Jul 23, 2005 at 09:54:11PM +0200, Dominik Brodowski wrote:
Oh, yes, I seem to have missed it. Sorry. Does this patch look good?
Yes.
Acked-by: Grant Grundler [EMAIL PROTECTED]
I'll commit this to the cvs.parisc-linux.org tree as well.
Willy can let me deal with the collision if it's not trivial
on his next merge.
thanks,
grant
Add pcibios_bus_to_resource for parisc.
Signed-off-by: Dominik Brodowski [EMAIL PROTECTED]
Index: 2.6.13-rc3-git2/arch/parisc/kernel/pci.c
===
--- 2.6.13-rc3-git2.orig/arch/parisc/kernel/pci.c
+++ 2.6.13-rc3-git2/arch/parisc/kernel/pci.c
@@ -255,8 +255,26 @@ void __devinit pcibios_resource_to_bus(s
pcibios_link_hba_resources(hba-lmmio_space, bus-resource[1]);
}
+void pcibios_bus_to_resource(struct pci_dev *dev, struct resource *res,
+ struct pci_bus_region *region)
+{
+ struct pci_bus *bus = dev-bus;
+ struct pci_hba_data *hba = HBA_DATA(bus-bridge-platform_data);
+
+ if (res-flags IORESOURCE_MEM) {
+ res-start = PCI_HOST_ADDR(hba, region-start);
+ res-end = PCI_HOST_ADDR(hba, region-end);
+ }
+
+ if (res-flags IORESOURCE_IO) {
+ res-start = region-start;
+ res-end = region-end;
+ }
+}
+
#ifdef CONFIG_HOTPLUG
EXPORT_SYMBOL(pcibios_resource_to_bus);
+EXPORT_SYMBOL(pcibios_bus_to_resource);
#endif
/*
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] pcibios_bus_to_resource for parisc [Was: Re: [PATCH 8/8] pci and yenta: pcibios_bus_to_resource]
On Mon, Jul 18, 2005 at 01:42:16PM -0600, Grant Grundler wrote:
> On Tue, Jul 12, 2005 at 12:21:38AM +0200, Dominik Brodowski wrote:
> > In yenta_socket, we default to using the resource setting of the CardBus
> > bridge. However, this is a PCI-bus-centric view of resources and thus
> > needs to be converted to generic resources first. Therefore, add a call
> > to pcibios_bus_to_resource() call in between. This function is a mere
> > wrapper on x86 and friends, however on some others it already exists, is
> > added in this patch (alpha, arm, ppc, ppc64) or still needs to be
> > provided (parisc -- where is its pcibios_resource_to_bus() ?).
>
> in arch/parisc/kernel/pci.c?
> At least, it seems to be present in the 2.6.13-rc1 tree
> on cvs.parisc-linux.org tree.
Oh, yes, I seem to have missed it. Sorry. Does this patch look good?
Add pcibios_bus_to_resource for parisc.
Signed-off-by: Dominik Brodowski <[EMAIL PROTECTED]>
Index: 2.6.13-rc3-git2/arch/parisc/kernel/pci.c
===
--- 2.6.13-rc3-git2.orig/arch/parisc/kernel/pci.c
+++ 2.6.13-rc3-git2/arch/parisc/kernel/pci.c
@@ -255,8 +255,26 @@ void __devinit pcibios_resource_to_bus(s
pcibios_link_hba_resources(>lmmio_space, bus->resource[1]);
}
+void pcibios_bus_to_resource(struct pci_dev *dev, struct resource *res,
+ struct pci_bus_region *region)
+{
+ struct pci_bus *bus = dev->bus;
+ struct pci_hba_data *hba = HBA_DATA(bus->bridge->platform_data);
+
+ if (res->flags & IORESOURCE_MEM) {
+ res->start = PCI_HOST_ADDR(hba, region->start);
+ res->end = PCI_HOST_ADDR(hba, region->end);
+ }
+
+ if (res->flags & IORESOURCE_IO) {
+ res->start = region->start;
+ res->end = region->end;
+ }
+}
+
#ifdef CONFIG_HOTPLUG
EXPORT_SYMBOL(pcibios_resource_to_bus);
+EXPORT_SYMBOL(pcibios_bus_to_resource);
#endif
/*
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] pcibios_bus_to_resource for parisc [Was: Re: [PATCH 8/8] pci and yenta: pcibios_bus_to_resource]
On Mon, Jul 18, 2005 at 01:42:16PM -0600, Grant Grundler wrote:
On Tue, Jul 12, 2005 at 12:21:38AM +0200, Dominik Brodowski wrote:
In yenta_socket, we default to using the resource setting of the CardBus
bridge. However, this is a PCI-bus-centric view of resources and thus
needs to be converted to generic resources first. Therefore, add a call
to pcibios_bus_to_resource() call in between. This function is a mere
wrapper on x86 and friends, however on some others it already exists, is
added in this patch (alpha, arm, ppc, ppc64) or still needs to be
provided (parisc -- where is its pcibios_resource_to_bus() ?).
in arch/parisc/kernel/pci.c?
At least, it seems to be present in the 2.6.13-rc1 tree
on cvs.parisc-linux.org tree.
Oh, yes, I seem to have missed it. Sorry. Does this patch look good?
Add pcibios_bus_to_resource for parisc.
Signed-off-by: Dominik Brodowski [EMAIL PROTECTED]
Index: 2.6.13-rc3-git2/arch/parisc/kernel/pci.c
===
--- 2.6.13-rc3-git2.orig/arch/parisc/kernel/pci.c
+++ 2.6.13-rc3-git2/arch/parisc/kernel/pci.c
@@ -255,8 +255,26 @@ void __devinit pcibios_resource_to_bus(s
pcibios_link_hba_resources(hba-lmmio_space, bus-resource[1]);
}
+void pcibios_bus_to_resource(struct pci_dev *dev, struct resource *res,
+ struct pci_bus_region *region)
+{
+ struct pci_bus *bus = dev-bus;
+ struct pci_hba_data *hba = HBA_DATA(bus-bridge-platform_data);
+
+ if (res-flags IORESOURCE_MEM) {
+ res-start = PCI_HOST_ADDR(hba, region-start);
+ res-end = PCI_HOST_ADDR(hba, region-end);
+ }
+
+ if (res-flags IORESOURCE_IO) {
+ res-start = region-start;
+ res-end = region-end;
+ }
+}
+
#ifdef CONFIG_HOTPLUG
EXPORT_SYMBOL(pcibios_resource_to_bus);
+EXPORT_SYMBOL(pcibios_bus_to_resource);
#endif
/*
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 8/8] pci and yenta: pcibios_bus_to_resource
On Tue, Jul 12, 2005 at 12:21:38AM +0200, Dominik Brodowski wrote: > In yenta_socket, we default to using the resource setting of the CardBus > bridge. However, this is a PCI-bus-centric view of resources and thus > needs to be converted to generic resources first. Therefore, add a call > to pcibios_bus_to_resource() call in between. This function is a mere > wrapper on x86 and friends, however on some others it already exists, is > added in this patch (alpha, arm, ppc, ppc64) or still needs to be > provided (parisc -- where is its pcibios_resource_to_bus() ?). in arch/parisc/kernel/pci.c? At least, it seems to be present in the 2.6.13-rc1 tree on cvs.parisc-linux.org tree. Arnaldo De Carmelo had add-on pci-pcmcia cards working in his a500 (64-bit w/IOMMU PA-RISC) last year. ISTR a few other people have similar cards working for on B180 workstation (32-bit w/o IOMMU PARISC). grant - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 8/8] pci and yenta: pcibios_bus_to_resource
On Tue, Jul 12, 2005 at 12:21:38AM +0200, Dominik Brodowski wrote: In yenta_socket, we default to using the resource setting of the CardBus bridge. However, this is a PCI-bus-centric view of resources and thus needs to be converted to generic resources first. Therefore, add a call to pcibios_bus_to_resource() call in between. This function is a mere wrapper on x86 and friends, however on some others it already exists, is added in this patch (alpha, arm, ppc, ppc64) or still needs to be provided (parisc -- where is its pcibios_resource_to_bus() ?). in arch/parisc/kernel/pci.c? At least, it seems to be present in the 2.6.13-rc1 tree on cvs.parisc-linux.org tree. Arnaldo De Carmelo had add-on pci-pcmcia cards working in his a500 (64-bit w/IOMMU PA-RISC) last year. ISTR a few other people have similar cards working for on B180 workstation (32-bit w/o IOMMU PARISC). grant - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 8/8] pci and yenta: pcibios_bus_to_resource
On Tue, Jul 12, 2005 at 12:21:38AM +0200, Dominik Brodowski wrote: > --- 2.6.13-rc2-git3.orig/arch/arm/kernel/bios32.c > +++ 2.6.13-rc2-git3/arch/arm/kernel/bios32.c > @@ -447,9 +447,26 @@ pcibios_resource_to_bus(struct pci_dev * > region->end = res->end - offset; > } > > +void __devinit > +pcibios_bus_to_resource(struct pci_dev *dev, struct resource *res, >... > EXPORT_SYMBOL(pcibios_fixup_bus); > EXPORT_SYMBOL(pcibios_resource_to_bus); > +EXPORT_SYMBOL(pcibios_bus_to_resources); Please look carefully at the above change. I'd appreciate it if this could be fixed. 8) Thanks. -- Russell King Linux kernel2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 8/8] pci and yenta: pcibios_bus_to_resource
On Tue, Jul 12, 2005 at 12:21:38AM +0200, Dominik Brodowski wrote: --- 2.6.13-rc2-git3.orig/arch/arm/kernel/bios32.c +++ 2.6.13-rc2-git3/arch/arm/kernel/bios32.c @@ -447,9 +447,26 @@ pcibios_resource_to_bus(struct pci_dev * region-end = res-end - offset; } +void __devinit +pcibios_bus_to_resource(struct pci_dev *dev, struct resource *res, ... EXPORT_SYMBOL(pcibios_fixup_bus); EXPORT_SYMBOL(pcibios_resource_to_bus); +EXPORT_SYMBOL(pcibios_bus_to_resources); Please look carefully at the above change. I'd appreciate it if this could be fixed. 8) Thanks. -- Russell King Linux kernel2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
