Re: [PATCH V1 3/3] scsi: ufs: Add sysfs support for ufs provision
On Tue, Jun 05, 2018 at 08:16:50AM +, Stanislav Nijnikov wrote: > Hi Sayali, > > I think that passing an array of values in a string is not proper way > to work with a sysfs entry. There are binary attributes to do such > things. No, don't do that, sysfs is for "one value per file", and binary attributes are for "hardware value pass-through" type stuff. Unless this is "raw" data straight from the hardware, binary does not work, and neither does a normal sysfs file either. So this needs to be reworked please. thanks, greg k-h
Re: [PATCH V1 3/3] scsi: ufs: Add sysfs support for ufs provision
On Tue, Jun 05, 2018 at 08:16:50AM +, Stanislav Nijnikov wrote: > Hi Sayali, > > I think that passing an array of values in a string is not proper way > to work with a sysfs entry. There are binary attributes to do such > things. No, don't do that, sysfs is for "one value per file", and binary attributes are for "hardware value pass-through" type stuff. Unless this is "raw" data straight from the hardware, binary does not work, and neither does a normal sysfs file either. So this needs to be reworked please. thanks, greg k-h
