Re: [PATCH V2 3/3] KVM/Hyper-V/VMX: Add direct tlb flush support

2019-08-15 Thread Tianyu Lan 
Hi Paolo:
  Thanks for your review.

On Wed, Aug 14, 2019 at 9:33 PM Paolo Bonzini  wrote:
>
> On 14/08/19 09:34, lantianyu1...@gmail.com wrote:
> > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
> > index c5da875f19e3..479ad76661e6 100644
> > --- a/include/linux/kvm_host.h
> > +++ b/include/linux/kvm_host.h
> > @@ -500,6 +500,7 @@ struct kvm {
> >   struct srcu_struct srcu;
> >   struct srcu_struct irq_srcu;
> >   pid_t userspace_pid;
> > + struct hv_partition_assist_pg *hv_pa_pg;
> >  };
> >
> >  #define kvm_err(fmt, ...) \
>
> This does not exist on non-x86 architectures.  Please move it to struct
> kvm_arch.
>
Nice catch. Will update in the next version. Thanks.
-- 
Best regards
Tianyu Lan

Re: [PATCH V2 3/3] KVM/Hyper-V/VMX: Add direct tlb flush support

2019-08-14 Thread Paolo Bonzini 
On 14/08/19 09:34, lantianyu1...@gmail.com wrote:
> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
> index c5da875f19e3..479ad76661e6 100644
> --- a/include/linux/kvm_host.h
> +++ b/include/linux/kvm_host.h
> @@ -500,6 +500,7 @@ struct kvm {
>   struct srcu_struct srcu;
>   struct srcu_struct irq_srcu;
>   pid_t userspace_pid;
> + struct hv_partition_assist_pg *hv_pa_pg;
>  };
>  
>  #define kvm_err(fmt, ...) \

This does not exist on non-x86 architectures.  Please move it to struct
kvm_arch.

Paolo