Re: [PATCH V2 6/6] mmc: mmci: replace blksz_datactrlXX by get_datactrl_cfg callback
hi Russell, Ulf On 3/7/19 5:46 PM, Russell King - ARM Linux admin wrote: On Thu, Mar 07, 2019 at 05:39:02PM +0100, Ludovic Barre wrote: - if (data->flags & MMC_DATA_READ) - datactrl |= MCI_DPSM_DIRECTION; Given that this is currently an invariant between all, it doesn't make sense to have a separate public function and combine it into the get_datactrl_cfg() implementations. You may as well leave it in place here, after you call get_datactrl_cfg(). + datactrl = host->ops->get_datactrl_cfg(host); Otherwise, I don't see a problem with this, although it would be nice to avoid the overhead of so many public functions, which could be done by adding them as inline functions in mmci.h To combine your comments (above and https://lkml.org/lkml/2019/3/6/318). I could regroup mmci_dctrl_dir & mmci_dctrl_ddr & mmci_dctrl_sdio in a common function mmci_dctrl_common and call by: -Each get_datactrl_cfg variant -Or in mmci_start_data What do you prefer ? Regards, Ludo
Re: [PATCH V2 6/6] mmc: mmci: replace blksz_datactrlXX by get_datactrl_cfg callback
On Thu, Mar 07, 2019 at 05:39:02PM +0100, Ludovic Barre wrote: > - if (data->flags & MMC_DATA_READ) > - datactrl |= MCI_DPSM_DIRECTION; Given that this is currently an invariant between all, it doesn't make sense to have a separate public function and combine it into the get_datactrl_cfg() implementations. You may as well leave it in place here, after you call get_datactrl_cfg(). > + datactrl = host->ops->get_datactrl_cfg(host); Otherwise, I don't see a problem with this, although it would be nice to avoid the overhead of so many public functions, which could be done by adding them as inline functions in mmci.h -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up
