Re: [PATCH V3 1/5] drivers/fmc: remove unused variable
> Ah, sorry, wrong "changelog". I meant the area that shows up in git > about what this patch does. There's no description of it other than the > Subject line. Yes. Ok, I'll add a longer commit message for V4 of the whole set. Tomorrow (/me leaving now to a client).
Re: [PATCH V3 1/5] drivers/fmc: remove unused variable
On Tue, Jul 18, 2017 at 09:00:29AM +0200, Alessandro Rubini wrote: > > Again, I do not like to take patches without any changelog text at all > > :( > > Sorry, I added this after the "---" line. I thought it was this one the > missing item: > > V3 (Alessandro): fixed From line in patch, added alessandro's acked-by > > V2 (Pat): added Tested-by and incorrect From line > > V1 (Pat): picked from ohwr.org repo, where most fmc users pick from. Ah, sorry, wrong "changelog". I meant the area that shows up in git about what this patch does. There's no description of it other than the Subject line. While this is a simple patch, it is always good to say something like "variable foo was set but never actually used, so it's safe to remove it as the function it called did not change the hardware state" or something like that. thanks, greg k-h
Re: [PATCH V3 1/5] drivers/fmc: remove unused variable
> Again, I do not like to take patches without any changelog text at all > :( Sorry, I added this after the "---" line. I thought it was this one the missing item: V3 (Alessandro): fixed From line in patch, added alessandro's acked-by V2 (Pat): added Tested-by and incorrect From line V1 (Pat): picked from ohwr.org repo, where most fmc users pick from. thanks /alessandro
Re: [PATCH V3 1/5] drivers/fmc: remove unused variable
On Tue, Jul 18, 2017 at 08:32:42AM +0200, Alessandro Rubini wrote: > From: Federico Vaga > > Signed-off-by: Federico Vaga > Tested-by: Pat Riehecky > Acked-by: Alessandro Rubini > --- Again, I do not like to take patches without any changelog text at all :(
