Re: [PATCH V3 21/26] dt-bindings: interrupt-controller: C-SKY APB intc
On Fri, Sep 07, 2018 at 10:13:13AM -0500, Rob Herring wrote:
> On Thu, Sep 6, 2018 at 8:05 AM Arnd Bergmann wrote:
> >
> > On Thu, Sep 6, 2018 at 4:13 AM Guo Ren wrote:
> > >
> > > On Wed, Sep 05, 2018 at 07:43:10PM -0500, Rob Herring wrote:
> > > > On Wed, Sep 5, 2018 at 7:10 AM Guo Ren wrote:
> > > > >
> > > > > Signed-off-by: Guo Ren
> > > > > +
> > > > > + intc: interrupt-controller {
> > > >
> > > > Needs a unit-address.
> > > Ok, change it to:
> > > intc: interrupt-controller@0x0050 {
> >
> > The unit address has no leading 0x or leading zeroes, so
> > interrupt-controller@50
>
> Please build your dts files with W=12 and it will tell you this and
> other errors. And then update any examples based on that.
Got it, thx for the tip.
Guo Ren
Re: [PATCH V3 21/26] dt-bindings: interrupt-controller: C-SKY APB intc
On Fri, Sep 07, 2018 at 10:13:13AM -0500, Rob Herring wrote:
> On Thu, Sep 6, 2018 at 8:05 AM Arnd Bergmann wrote:
> >
> > On Thu, Sep 6, 2018 at 4:13 AM Guo Ren wrote:
> > >
> > > On Wed, Sep 05, 2018 at 07:43:10PM -0500, Rob Herring wrote:
> > > > On Wed, Sep 5, 2018 at 7:10 AM Guo Ren wrote:
> > > > >
> > > > > Signed-off-by: Guo Ren
> > > > > +
> > > > > + intc: interrupt-controller {
> > > >
> > > > Needs a unit-address.
> > > Ok, change it to:
> > > intc: interrupt-controller@0x0050 {
> >
> > The unit address has no leading 0x or leading zeroes, so
> > interrupt-controller@50
>
> Please build your dts files with W=12 and it will tell you this and
> other errors. And then update any examples based on that.
Got it, thx for the tip.
Guo Ren
Re: [PATCH V3 21/26] dt-bindings: interrupt-controller: C-SKY APB intc
On Thu, Sep 6, 2018 at 8:05 AM Arnd Bergmann wrote:
>
> On Thu, Sep 6, 2018 at 4:13 AM Guo Ren wrote:
> >
> > On Wed, Sep 05, 2018 at 07:43:10PM -0500, Rob Herring wrote:
> > > On Wed, Sep 5, 2018 at 7:10 AM Guo Ren wrote:
> > > >
> > > > Signed-off-by: Guo Ren
> > > > +
> > > > + intc: interrupt-controller {
> > >
> > > Needs a unit-address.
> > Ok, change it to:
> > intc: interrupt-controller@0x0050 {
>
> The unit address has no leading 0x or leading zeroes, so
> interrupt-controller@50
Please build your dts files with W=12 and it will tell you this and
other errors. And then update any examples based on that.
Rob
Re: [PATCH V3 21/26] dt-bindings: interrupt-controller: C-SKY APB intc
On Thu, Sep 6, 2018 at 8:05 AM Arnd Bergmann wrote:
>
> On Thu, Sep 6, 2018 at 4:13 AM Guo Ren wrote:
> >
> > On Wed, Sep 05, 2018 at 07:43:10PM -0500, Rob Herring wrote:
> > > On Wed, Sep 5, 2018 at 7:10 AM Guo Ren wrote:
> > > >
> > > > Signed-off-by: Guo Ren
> > > > +
> > > > + intc: interrupt-controller {
> > >
> > > Needs a unit-address.
> > Ok, change it to:
> > intc: interrupt-controller@0x0050 {
>
> The unit address has no leading 0x or leading zeroes, so
> interrupt-controller@50
Please build your dts files with W=12 and it will tell you this and
other errors. And then update any examples based on that.
Rob
Re: [PATCH V3 21/26] dt-bindings: interrupt-controller: C-SKY APB intc
On Thu, Sep 06, 2018 at 03:05:38PM +0200, Arnd Bergmann wrote:
> On Thu, Sep 6, 2018 at 4:13 AM Guo Ren wrote:
> >
> > On Wed, Sep 05, 2018 at 07:43:10PM -0500, Rob Herring wrote:
> > > On Wed, Sep 5, 2018 at 7:10 AM Guo Ren wrote:
> > > >
> > > > Signed-off-by: Guo Ren
> > > > +
> > > > + intc: interrupt-controller {
> > >
> > > Needs a unit-address.
> > Ok, change it to:
> > intc: interrupt-controller@0x0050 {
>
> The unit address has no leading 0x or leading zeroes, so
> interrupt-controller@50
Ok
Guo Ren
Re: [PATCH V3 21/26] dt-bindings: interrupt-controller: C-SKY APB intc
On Thu, Sep 06, 2018 at 03:05:38PM +0200, Arnd Bergmann wrote:
> On Thu, Sep 6, 2018 at 4:13 AM Guo Ren wrote:
> >
> > On Wed, Sep 05, 2018 at 07:43:10PM -0500, Rob Herring wrote:
> > > On Wed, Sep 5, 2018 at 7:10 AM Guo Ren wrote:
> > > >
> > > > Signed-off-by: Guo Ren
> > > > +
> > > > + intc: interrupt-controller {
> > >
> > > Needs a unit-address.
> > Ok, change it to:
> > intc: interrupt-controller@0x0050 {
>
> The unit address has no leading 0x or leading zeroes, so
> interrupt-controller@50
Ok
Guo Ren
Re: [PATCH V3 21/26] dt-bindings: interrupt-controller: C-SKY APB intc
On Thu, Sep 6, 2018 at 4:13 AM Guo Ren wrote:
>
> On Wed, Sep 05, 2018 at 07:43:10PM -0500, Rob Herring wrote:
> > On Wed, Sep 5, 2018 at 7:10 AM Guo Ren wrote:
> > >
> > > Signed-off-by: Guo Ren
> > > +
> > > + intc: interrupt-controller {
> >
> > Needs a unit-address.
> Ok, change it to:
> intc: interrupt-controller@0x0050 {
The unit address has no leading 0x or leading zeroes, so
interrupt-controller@50
Arnd
Re: [PATCH V3 21/26] dt-bindings: interrupt-controller: C-SKY APB intc
On Thu, Sep 6, 2018 at 4:13 AM Guo Ren wrote:
>
> On Wed, Sep 05, 2018 at 07:43:10PM -0500, Rob Herring wrote:
> > On Wed, Sep 5, 2018 at 7:10 AM Guo Ren wrote:
> > >
> > > Signed-off-by: Guo Ren
> > > +
> > > + intc: interrupt-controller {
> >
> > Needs a unit-address.
> Ok, change it to:
> intc: interrupt-controller@0x0050 {
The unit address has no leading 0x or leading zeroes, so
interrupt-controller@50
Arnd
Re: [PATCH V3 21/26] dt-bindings: interrupt-controller: C-SKY APB intc
On Wed, Sep 05, 2018 at 07:43:10PM -0500, Rob Herring wrote:
> On Wed, Sep 5, 2018 at 7:10 AM Guo Ren wrote:
> >
> > Signed-off-by: Guo Ren
> > ---
> > .../interrupt-controller/csky,apb-intc.txt | 45
> > ++
> > 1 file changed, 45 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/interrupt-controller/csky,apb-intc.txt
> >
> > diff --git
> > a/Documentation/devicetree/bindings/interrupt-controller/csky,apb-intc.txt
> > b/Documentation/devicetree/bindings/interrupt-controller/csky,apb-intc.txt
> > new file mode 100644
> > index 000..faa482c
> > --- /dev/null
> > +++
> > b/Documentation/devicetree/bindings/interrupt-controller/csky,apb-intc.txt
> > @@ -0,0 +1,45 @@
> > +==
> > +C-SKY APB Interrupt Controller
> > +==
> > +
> > +C-SKY APB Interrupt Controller is a simple soc interrupt controller
> > +on the apb bus and we only use it as root irq controller.
> > +
> > + - csky,apb-intc is used in a lot of csky fpgas and socs, it support 64
> > irq nums.
> > + - csky,dual-apb-intc consists of 2 apb-intc and 128 irq nums supported.
>
> Can't this be described in DT as 2 csky,apb-intc nodes?
In detail, dual-apb-intc is not the same as two apb-intc, so I still want to
name them
separately, so I will keep this and it is clearer.
> > +- compatible
> > +Usage: required
> > +Value type:
> > +Definition: must be "csky,apb-intc"
> > + "csky,dual-apb-intc"
> > + "csky,gx6605s-intc"
> > +- interrupt-cells
>
> #interrupt-cells
Yes, I forgot #.
- #interrupt-cells
> > +Usage: required
> > +Value type:
> > +Definition: must be <1>
>
> No edge or level configuration?
No, also no support in hardware.
> > +
> > + intc: interrupt-controller {
>
> Needs a unit-address.
Ok, change it to:
intc: interrupt-controller@0x0050 {
Guo Ren
Re: [PATCH V3 21/26] dt-bindings: interrupt-controller: C-SKY APB intc
On Wed, Sep 05, 2018 at 07:43:10PM -0500, Rob Herring wrote:
> On Wed, Sep 5, 2018 at 7:10 AM Guo Ren wrote:
> >
> > Signed-off-by: Guo Ren
> > ---
> > .../interrupt-controller/csky,apb-intc.txt | 45
> > ++
> > 1 file changed, 45 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/interrupt-controller/csky,apb-intc.txt
> >
> > diff --git
> > a/Documentation/devicetree/bindings/interrupt-controller/csky,apb-intc.txt
> > b/Documentation/devicetree/bindings/interrupt-controller/csky,apb-intc.txt
> > new file mode 100644
> > index 000..faa482c
> > --- /dev/null
> > +++
> > b/Documentation/devicetree/bindings/interrupt-controller/csky,apb-intc.txt
> > @@ -0,0 +1,45 @@
> > +==
> > +C-SKY APB Interrupt Controller
> > +==
> > +
> > +C-SKY APB Interrupt Controller is a simple soc interrupt controller
> > +on the apb bus and we only use it as root irq controller.
> > +
> > + - csky,apb-intc is used in a lot of csky fpgas and socs, it support 64
> > irq nums.
> > + - csky,dual-apb-intc consists of 2 apb-intc and 128 irq nums supported.
>
> Can't this be described in DT as 2 csky,apb-intc nodes?
In detail, dual-apb-intc is not the same as two apb-intc, so I still want to
name them
separately, so I will keep this and it is clearer.
> > +- compatible
> > +Usage: required
> > +Value type:
> > +Definition: must be "csky,apb-intc"
> > + "csky,dual-apb-intc"
> > + "csky,gx6605s-intc"
> > +- interrupt-cells
>
> #interrupt-cells
Yes, I forgot #.
- #interrupt-cells
> > +Usage: required
> > +Value type:
> > +Definition: must be <1>
>
> No edge or level configuration?
No, also no support in hardware.
> > +
> > + intc: interrupt-controller {
>
> Needs a unit-address.
Ok, change it to:
intc: interrupt-controller@0x0050 {
Guo Ren
Re: [PATCH V3 21/26] dt-bindings: interrupt-controller: C-SKY APB intc
On Wed, Sep 5, 2018 at 7:10 AM Guo Ren wrote:
>
> Signed-off-by: Guo Ren
> ---
> .../interrupt-controller/csky,apb-intc.txt | 45
> ++
> 1 file changed, 45 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/interrupt-controller/csky,apb-intc.txt
>
> diff --git
> a/Documentation/devicetree/bindings/interrupt-controller/csky,apb-intc.txt
> b/Documentation/devicetree/bindings/interrupt-controller/csky,apb-intc.txt
> new file mode 100644
> index 000..faa482c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/csky,apb-intc.txt
> @@ -0,0 +1,45 @@
> +==
> +C-SKY APB Interrupt Controller
> +==
> +
> +C-SKY APB Interrupt Controller is a simple soc interrupt controller
> +on the apb bus and we only use it as root irq controller.
> +
> + - csky,apb-intc is used in a lot of csky fpgas and socs, it support 64 irq
> nums.
> + - csky,dual-apb-intc consists of 2 apb-intc and 128 irq nums supported.
Can't this be described in DT as 2 csky,apb-intc nodes?
> + - csky,gx6605s-intc is gx6605s soc internal irq interrupt controller, 64
> irq nums.
> +
> +=
> +intc node bindings definition
> +=
> +
> +Description: Describes APB interrupt controller
> +
> +PROPERTIES
> +
> +- compatible
> +Usage: required
> +Value type:
> +Definition: must be "csky,apb-intc"
> + "csky,dual-apb-intc"
> + "csky,gx6605s-intc"
> +- interrupt-cells
#interrupt-cells
> +Usage: required
> +Value type:
> +Definition: must be <1>
No edge or level configuration?
> + - reg
> + Usage: required
> + Value type:
> +Definition: in soc from cpu view
> +- interrupt-controller:
> +Usage: required
> +
> +Examples:
> +-
> +
> + intc: interrupt-controller {
Needs a unit-address.
> + compatible = "csky,apb-intc";
> + #interrupt-cells = <1>;
> + reg = <0x0050 0x400>;
> + interrupt-controller;
> + };
> --
> 2.7.4
>
Re: [PATCH V3 21/26] dt-bindings: interrupt-controller: C-SKY APB intc
On Wed, Sep 5, 2018 at 7:10 AM Guo Ren wrote:
>
> Signed-off-by: Guo Ren
> ---
> .../interrupt-controller/csky,apb-intc.txt | 45
> ++
> 1 file changed, 45 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/interrupt-controller/csky,apb-intc.txt
>
> diff --git
> a/Documentation/devicetree/bindings/interrupt-controller/csky,apb-intc.txt
> b/Documentation/devicetree/bindings/interrupt-controller/csky,apb-intc.txt
> new file mode 100644
> index 000..faa482c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/csky,apb-intc.txt
> @@ -0,0 +1,45 @@
> +==
> +C-SKY APB Interrupt Controller
> +==
> +
> +C-SKY APB Interrupt Controller is a simple soc interrupt controller
> +on the apb bus and we only use it as root irq controller.
> +
> + - csky,apb-intc is used in a lot of csky fpgas and socs, it support 64 irq
> nums.
> + - csky,dual-apb-intc consists of 2 apb-intc and 128 irq nums supported.
Can't this be described in DT as 2 csky,apb-intc nodes?
> + - csky,gx6605s-intc is gx6605s soc internal irq interrupt controller, 64
> irq nums.
> +
> +=
> +intc node bindings definition
> +=
> +
> +Description: Describes APB interrupt controller
> +
> +PROPERTIES
> +
> +- compatible
> +Usage: required
> +Value type:
> +Definition: must be "csky,apb-intc"
> + "csky,dual-apb-intc"
> + "csky,gx6605s-intc"
> +- interrupt-cells
#interrupt-cells
> +Usage: required
> +Value type:
> +Definition: must be <1>
No edge or level configuration?
> + - reg
> + Usage: required
> + Value type:
> +Definition: in soc from cpu view
> +- interrupt-controller:
> +Usage: required
> +
> +Examples:
> +-
> +
> + intc: interrupt-controller {
Needs a unit-address.
> + compatible = "csky,apb-intc";
> + #interrupt-cells = <1>;
> + reg = <0x0050 0x400>;
> + interrupt-controller;
> + };
> --
> 2.7.4
>
