Re: [PATCH V6 0/4] x86/resctrl: Enable user to view and select thread throttling mode
Hi Borislav, On 5/20/2020 11:35 AM, Borislav Petkov wrote: > On Wed, May 20, 2020 at 10:32:02AM -0700, Reinette Chatre wrote: > >> It seems inappropriate that I have the title of maintainer and not be >> able to have patches considered for inclusion during an entire release >> cycle. > > Well, we try very hard to be fair when looking at patchsets. In your > case, I already took a patchset from you this cycle and there are other > patchsets waiting for a lot longer than yours - even patchsets from your > colleagues at Intel. > > So I understand that you think it might be inappropriate but please try > to understand it also from our standpoint in that we try to round-robin > between everyone as fair as possible. I understand now. Thank you very much. > > So I will try to look at yours in the next days but I cannot promise you > anything. Please don't. That would be unfair to everybody waiting longer then me as well set a bad precedent. Reinette
Re: [PATCH V6 0/4] x86/resctrl: Enable user to view and select thread throttling mode
On Wed, May 20, 2020 at 10:32:02AM -0700, Reinette Chatre wrote: > I was told that these enhancements really needed to get into v5.8, > otherwise the OSV intercepts will be much further out. Certainly not of > concern to you and not your problem, I am just answering your question > as an explanation for my goal for inclusion into v5.8. I believe under "OSV" fall distros too and I, with my distro hat on, can tell you that at least for us, SUSE, it suffices if the patches are in a maintainer tree on their way upstream to start backporting them. Which means, if they get queued in tip after 5.8 releases, that would be like a couple of weeks later. Dunno if the other OSVs you work with have such relaxed requirements - just pointing out that if they do, a couple of weeks later is not a whole cycle later. > It seems inappropriate that I have the title of maintainer and not be > able to have patches considered for inclusion during an entire release > cycle. Well, we try very hard to be fair when looking at patchsets. In your case, I already took a patchset from you this cycle and there are other patchsets waiting for a lot longer than yours - even patchsets from your colleagues at Intel. So I understand that you think it might be inappropriate but please try to understand it also from our standpoint in that we try to round-robin between everyone as fair as possible. So I will try to look at yours in the next days but I cannot promise you anything. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette
Re: [PATCH V6 0/4] x86/resctrl: Enable user to view and select thread throttling mode
Hi Borislav, On 5/20/2020 12:11 AM, Borislav Petkov wrote: > On Tue, May 19, 2020 at 03:13:59PM -0700, Reinette Chatre wrote: >> I am very sorry. I was hoping that this series could be considered for >> inclusion into v5.8 and submitted it seven weeks ago because of that. >> The recent feedback addressed seemed to be the final few small comments >> needed to be ready for inclusion and I was afraid that waiting long to >> address this would cause me to miss opportunity to be considered for >> inclusion since we are already at rc6. > > That's understandable but does it really matter when it goes in? If not > in 5.8, then 5.9. I.e., there's always a next kernel. > > So why the hurry? > I was told that these enhancements really needed to get into v5.8, otherwise the OSV intercepts will be much further out. Certainly not of concern to you and not your problem, I am just answering your question as an explanation for my goal for inclusion into v5.8. It seems inappropriate that I have the title of maintainer and not be able to have patches considered for inclusion during an entire release cycle. I completely understand that you are under tremendous load and expect that you have an incredible amount of things demanding your attention. I was wrong to expect a higher level of visibility of these patches and I am sorry that I spammed you with this patchset. Reinette
Re: [PATCH V6 0/4] x86/resctrl: Enable user to view and select thread throttling mode
On Tue, May 19, 2020 at 03:13:59PM -0700, Reinette Chatre wrote: > I am very sorry. I was hoping that this series could be considered for > inclusion into v5.8 and submitted it seven weeks ago because of that. > The recent feedback addressed seemed to be the final few small comments > needed to be ready for inclusion and I was afraid that waiting long to > address this would cause me to miss opportunity to be considered for > inclusion since we are already at rc6. That's understandable but does it really matter when it goes in? If not in 5.8, then 5.9. I.e., there's always a next kernel. So why the hurry? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette
Re: [PATCH V6 0/4] x86/resctrl: Enable user to view and select thread throttling mode
Hi Borislav, On 5/19/2020 2:35 PM, Borislav Petkov wrote: > On Tue, May 19, 2020 at 02:28:27PM -0700, Reinette Chatre wrote: >> V5 upstream submission available from: >> https://lore.kernel.org/lkml/cover.1589844108.git.reinette.cha...@intel.com > > Is there any chance for not spamming us with this patchset almost every > day? > > From Documentation/process/submitting-patches.rst: > > "Wait for a minimum of one week before resubmitting or pinging reviewers > - possibly longer during busy times like merge windows." > I am very sorry. I was hoping that this series could be considered for inclusion into v5.8 and submitted it seven weeks ago because of that. The recent feedback addressed seemed to be the final few small comments needed to be ready for inclusion and I was afraid that waiting long to address this would cause me to miss opportunity to be considered for inclusion since we are already at rc6. Reinette
Re: [PATCH V6 0/4] x86/resctrl: Enable user to view and select thread throttling mode
On Tue, May 19, 2020 at 02:28:27PM -0700, Reinette Chatre wrote: > V5 upstream submission available from: > https://lore.kernel.org/lkml/cover.1589844108.git.reinette.cha...@intel.com Is there any chance for not spamming us with this patchset almost every day? >From Documentation/process/submitting-patches.rst: "Wait for a minimum of one week before resubmitting or pinging reviewers - possibly longer during busy times like merge windows." Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette
