Re: [PATCH bpf v2 1/2] bpf: support PTR_TO_MEM{,_OR_NULL} register spilling

2021-01-13 Thread Alexei Starovoitov
On Wed, Jan 13, 2021 at 2:29 PM KP Singh  wrote:
>
> On Wed, Jan 13, 2021 at 6:38 AM Gilad Reti  wrote:
> >
> > Add support for pointer to mem register spilling, to allow the verifier
> > to track pointers to valid memory addresses. Such pointers are returned
> > for example by a successful call of the bpf_ringbuf_reserve helper.
> >
> > The patch was partially contributed by CyberArk Software, Inc.
> >
> > Fixes: 457f44363a88 ("bpf: Implement BPF ring buffer and verifier support 
> > for it")
> > Suggested-by: Yonghong Song 
> > Signed-off-by: Gilad Reti 
>
> Acked-by: KP Singh 

It's a border line feature vs fix.
Since the patch is trivial and it addresses a real problem I've
applied to the bpf tree.
Thanks!


Re: [PATCH bpf v2 1/2] bpf: support PTR_TO_MEM{,_OR_NULL} register spilling

2021-01-13 Thread KP Singh
On Wed, Jan 13, 2021 at 6:38 AM Gilad Reti  wrote:
>
> Add support for pointer to mem register spilling, to allow the verifier
> to track pointers to valid memory addresses. Such pointers are returned
> for example by a successful call of the bpf_ringbuf_reserve helper.
>
> The patch was partially contributed by CyberArk Software, Inc.
>
> Fixes: 457f44363a88 ("bpf: Implement BPF ring buffer and verifier support for 
> it")
> Suggested-by: Yonghong Song 
> Signed-off-by: Gilad Reti 

Acked-by: KP Singh