Re: [PATCH linux] objtool: fix pkg-config query in case of cross-compilation
Am Donnerstag, 11. April 2019, 11:26:12 CEST schrieb Nicolas Dichtel: > Le 11/04/2019 à 10:52, Rolf Eike Beer a écrit : > > Am Donnerstag, 11. April 2019, 10:39:40 CEST schrieb Nicolas Dichtel: > >> In case of cross-compilation, there may be two pkg-config tools, one for > >> the host and one for the target. Enable to override the default name. > >> > >> Fixes: 056d28d135bc ("objtool: Query pkg-config for libelf location") > >> Signed-off-by: Nicolas Dichtel > > > > If you do that, you have to fix a lot of other places, too. This starts in > > scripts/kconfig/ and also includes e.g. tools/testing/. > > > > Usually you have pkg-config for host and ${target_platform}-pkg-config for > > the > My use case was for buildroot, which define pkg-config and host-pkgconf. In > fact, I've just seen that a buildroot patch was accepted for this problem: > https://patchwork.ozlabs.org/patch/1081379/ I agree that it makes sense to have both host and target pkg-config configurable. But IMHO that must happen in a central place (i.e. ./Makefile), and it has to be used everywhere. Currently PKG_CONFIG is defined at multiple places, sometimes host, sometimes target, and often pkg-config is called directly, also mixing both usages. So, IMHO, if you want to fix this: fix it once and for all in the whole kernel, not just one place. What I have introduced was just the same as kconfig is using to find the dependencies for some of the *config variants, so this usecase would break for you anyway, although I don't think anyone in buildroot will notice this. Eike -- Rolf Eike Beer, emlix GmbH, http://www.emlix.com Fon +49 551 30664-0, Fax +49 551 30664-11 Gothaer Platz 3, 37083 Göttingen, Germany Sitz der Gesellschaft: Göttingen, Amtsgericht Göttingen HR B 3160 Geschäftsführung: Heike Jordan, Dr. Uwe Kracke – Ust-IdNr.: DE 205 198 055 emlix - smart embedded open source signature.asc Description: This is a digitally signed message part.
Re: [PATCH linux] objtool: fix pkg-config query in case of cross-compilation
Le 11/04/2019 à 10:52, Rolf Eike Beer a écrit : > Am Donnerstag, 11. April 2019, 10:39:40 CEST schrieb Nicolas Dichtel: >> In case of cross-compilation, there may be two pkg-config tools, one for >> the host and one for the target. Enable to override the default name. >> >> Fixes: 056d28d135bc ("objtool: Query pkg-config for libelf location") >> Signed-off-by: Nicolas Dichtel > > If you do that, you have to fix a lot of other places, too. This starts in > scripts/kconfig/ and also includes e.g. tools/testing/. > > Usually you have pkg-config for host and ${target_platform}-pkg-config for > the My use case was for buildroot, which define pkg-config and host-pkgconf. In fact, I've just seen that a buildroot patch was accepted for this problem: https://patchwork.ozlabs.org/patch/1081379/ Regards, Nicolas
Re: [PATCH linux] objtool: fix pkg-config query in case of cross-compilation
Am Donnerstag, 11. April 2019, 10:39:40 CEST schrieb Nicolas Dichtel: > In case of cross-compilation, there may be two pkg-config tools, one for > the host and one for the target. Enable to override the default name. > > Fixes: 056d28d135bc ("objtool: Query pkg-config for libelf location") > Signed-off-by: Nicolas Dichtel If you do that, you have to fix a lot of other places, too. This starts in scripts/kconfig/ and also includes e.g. tools/testing/. Usually you have pkg-config for host and ${target_platform}-pkg-config for the target, and the PKG_CONFIG variable for the target, usually initialized to $ (CROSS_COMPILE)pkg-config. I have sent a bunch of patches to replace the usage of plain pkg-config at several places with the cross-aware version, but sadly a lot of them have not been picked up. It break cross-building tests basically all the time. One example is here: https://marc.info/?l=linux-acpi&m=153544231529066&w=2 For me it looks like you are trying to go into the wrong direction. Greetings, Eike -- Rolf Eike Beer, emlix GmbH, http://www.emlix.com Fon +49 551 30664-0, Fax +49 551 30664-11 Gothaer Platz 3, 37083 Göttingen, Germany Sitz der Gesellschaft: Göttingen, Amtsgericht Göttingen HR B 3160 Geschäftsführung: Heike Jordan, Dr. Uwe Kracke – Ust-IdNr.: DE 205 198 055 emlix - smart embedded open source signature.asc Description: This is a digitally signed message part.