Re: [PATCH net-next 05/24] rxrpc: Provide more refcount helper functions
From: David Howells Date: Tue, 05 Jul 2016 14:12:47 +0100 > Provide refcount helper functions for connections so that the code doesn't > touch conn->usage directly. > > Also provide queueing helper functions so that the queueing of local and > connection objects can be fixed later. > > Signed-off-by: David Howells I don't see anything in this patch dealing with refcount helper functions.
Re: [PATCH net-next 05/24] rxrpc: Provide more refcount helper functions
David Miller wrote: > I don't see anything in this patch dealing with refcount helper functions. Good point. I split that part out and you took it already. Will amend. David
Re: [PATCH net-next 05/24] rxrpc: Provide more refcount helper functions
David Miller wrote: > I don't see anything in this patch dealing with refcount helper functions. I'm amending the patch description to: rxrpc: Provide queuing helper functions Provide queueing helper functions so that the queueing of local and connection objects can be fixed later. The issue is that a ref on the object needs to be passed to the work queue, but the act of queueing the object may fail because the object is already queued. Testing the queuedness of an object before hand doesn't work because there can be a race with someone else trying to queue it. What will have to be done is to adjust the refcount depending on the result of the queue operation. Signed-off-by: David Howells but not changing the patch. David
