Re: [PATCH net-next 1/4] net: phy: broadcom: add exp register access methods without buslock

[Andrew Lunn]

On Sun, May 10, 2020 at 12:37:11AM +0200, Michael Walle wrote:
> Add helper to read and write expansion registers without taking the mdio
> lock.
> 
> Please note, that this changes the semantics of the read and write.
> Before there was no lock between selecting the expansion register and
> the actual read/write. This may lead to access failures if there are
> parallel accesses. Instead take the bus lock during the whole access
> cycle.
> 
> Signed-off-by: Michael Walle 

Reviewed-by: Andrew Lunn 

Andrew

Re: [PATCH net-next 1/4] net: phy: broadcom: add exp register access methods without buslock

[Florian Fainelli]

On 5/9/2020 3:37 PM, Michael Walle wrote:
> Add helper to read and write expansion registers without taking the mdio
> lock.
> 
> Please note, that this changes the semantics of the read and write.
> Before there was no lock between selecting the expansion register and
> the actual read/write. This may lead to access failures if there are
> parallel accesses. Instead take the bus lock during the whole access
> cycle.
> 
> Signed-off-by: Michael Walle 

Reviewed-by: Florian Fainelli 
-- 
Florian