Re: [PATCH net-next v4 05/10] bridge: cfm: Kernel space implementation of CFM. CCM frame TX added.

2020-10-12 Thread henrik.bjoernl...@microchip.com
Thanks for the review.

The 10/09/2020 21:49, Nikolay Aleksandrov wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the 
> content is safe
> 
> On Fri, 2020-10-09 at 14:35 +, Henrik Bjoernlund wrote:
> > This is the second commit of the implementation of the CFM protocol
> > according to 802.1Q section 12.14.
> >
> > Functionality is extended with CCM frame transmission.
> >
> > Interface is extended with these functions:
> > br_cfm_cc_rdi_set()
> > br_cfm_cc_ccm_tx()
> > br_cfm_cc_config_set()
> >
> > A MEP Continuity Check feature can be configured by
> > br_cfm_cc_config_set()
> > The Continuity Check parameters can be configured to be used when
> > transmitting CCM.
> >
> > A MEP can be configured to start or stop transmission of CCM frames by
> > br_cfm_cc_ccm_tx()
> > The CCM will be transmitted for a selected period in seconds.
> > Must call this function before timeout to keep transmission alive.
> >
> > A MEP transmitting CCM can be configured with inserted RDI in PDU by
> > br_cfm_cc_rdi_set()
> >
> > Signed-off-by: Henrik Bjoernlund  
> > Reviewed-by: Horatiu Vultur  
> > ---
> >  include/uapi/linux/cfm_bridge.h |  39 -
> >  net/bridge/br_cfm.c | 284 
> >  net/bridge/br_private_cfm.h |  54 ++
> >  3 files changed, 376 insertions(+), 1 deletion(-)
> >
> 
> Acked-by: Nikolay Aleksandrov 
> 

-- 
/Henrik


Re: [PATCH net-next v4 05/10] bridge: cfm: Kernel space implementation of CFM. CCM frame TX added.

2020-10-09 Thread Nikolay Aleksandrov
On Fri, 2020-10-09 at 14:35 +, Henrik Bjoernlund wrote:
> This is the second commit of the implementation of the CFM protocol
> according to 802.1Q section 12.14.
> 
> Functionality is extended with CCM frame transmission.
> 
> Interface is extended with these functions:
> br_cfm_cc_rdi_set()
> br_cfm_cc_ccm_tx()
> br_cfm_cc_config_set()
> 
> A MEP Continuity Check feature can be configured by
> br_cfm_cc_config_set()
> The Continuity Check parameters can be configured to be used when
> transmitting CCM.
> 
> A MEP can be configured to start or stop transmission of CCM frames by
> br_cfm_cc_ccm_tx()
> The CCM will be transmitted for a selected period in seconds.
> Must call this function before timeout to keep transmission alive.
> 
> A MEP transmitting CCM can be configured with inserted RDI in PDU by
> br_cfm_cc_rdi_set()
> 
> Signed-off-by: Henrik Bjoernlund  
> Reviewed-by: Horatiu Vultur  
> ---
>  include/uapi/linux/cfm_bridge.h |  39 -
>  net/bridge/br_cfm.c | 284 
>  net/bridge/br_private_cfm.h |  54 ++
>  3 files changed, 376 insertions(+), 1 deletion(-)
> 

Acked-by: Nikolay Aleksandrov