Re: [PATCH v1 1/2] dt-bindings: phy: intel-sdxc-phy: Add YAML schema for LGM SDXC PHY
Hi Rob,
Thank you for the review comments.
On 28/8/2019 7:39 PM, Rob Herring wrote:
On Tue, Aug 27, 2019 at 10:47 PM Ramuthevar, Vadivel MuruganX
wrote:
Hi Rob,
On 27/8/2019 8:39 PM, Rob Herring wrote:
On Tue, Aug 27, 2019 at 3:27 AM Ramuthevar,Vadivel MuruganX
wrote:
From: Ramuthevar Vadivel Murugan
Add a YAML schema to use the host controller driver with the
SDXC PHY on Intel's Lightning Mountain SoC.
Signed-off-by: Ramuthevar Vadivel Murugan
---
.../bindings/phy/intel,lgm-sdxc-phy.yaml | 50
++
1 file changed, 50 insertions(+)
create mode 100644
Documentation/devicetree/bindings/phy/intel,lgm-sdxc-phy.yaml
diff --git a/Documentation/devicetree/bindings/phy/intel,lgm-sdxc-phy.yaml
b/Documentation/devicetree/bindings/phy/intel,lgm-sdxc-phy.yaml
new file mode 100644
index ..be05020880bf
--- /dev/null
+++ b/Documentation/devicetree/bindings/phy/intel,lgm-sdxc-phy.yaml
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/phy/intel,lgm-sdxc-phy.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Intel Lightning Mountain(LGM) SDXC PHY Device Tree Bindings
+
+maintainers:
+ - Ramuthevar Vadivel Murugan
+
+description: Binding for SDXC PHY
+
+properties:
+ compatible:
+const: intel,lgm-sdxc-phy
+
+ intel,syscon:
+description: phandle to the sdxc through syscon
+$ref: '/schemas/types.yaml#/definitions/phandle'
+
+ clocks:
+maxItems: 1
+
+ clock-names:
+maxItems: 1
+
+ "#phy-cells":
+const: 0
+
+required:
+ - "#phy-cells"
+ - compatible
+ - intel,syscon
+ - clocks
+ - clock-names
+
+additionalProperties: false
+
+examples:
+ - |
+sdxc_phy: sdxc_phy {
+compatible = "intel,lgm-sdxc-phy";
+intel,syscon = <&sysconf>;
Rather than a phandle, can this be a child node of sysconf? You need a
binding for sysconf first anyways.
intel,syscon is phandle, emmc_phy is not child node of sysconf, access
emmc_phy
register over sysconf so made as reference here.
How do you access the emmc_phy registers? They are part of the sysconf
address space or the sysconf provides some sort of indirect register
access? In case of the former, then emmc_phy should be a child node.
That's actually fairly common.
Agreed!, you are correct. I have created two files one for syscon and
other one is for emmc-phy
Documentation/devicetree/bindings/phy/intel,syscon.yaml
Documentation/devicetree/bindings/phy/intel,lgm-sdxc-phy.yaml
As you said earlier mail, first syscon bindings to be there, sending the
patch as well.
Regards
Vadivel
Rob
Re: [PATCH v1 1/2] dt-bindings: phy: intel-sdxc-phy: Add YAML schema for LGM SDXC PHY
On Tue, Aug 27, 2019 at 10:47 PM Ramuthevar, Vadivel MuruganX
wrote:
>
> Hi Rob,
>
> On 27/8/2019 8:39 PM, Rob Herring wrote:
> > On Tue, Aug 27, 2019 at 3:27 AM Ramuthevar,Vadivel MuruganX
> > wrote:
> >> From: Ramuthevar Vadivel Murugan
> >>
> >>
> >> Add a YAML schema to use the host controller driver with the
> >> SDXC PHY on Intel's Lightning Mountain SoC.
> >>
> >> Signed-off-by: Ramuthevar Vadivel Murugan
> >>
> >> ---
> >> .../bindings/phy/intel,lgm-sdxc-phy.yaml | 50
> >> ++
> >> 1 file changed, 50 insertions(+)
> >> create mode 100644
> >> Documentation/devicetree/bindings/phy/intel,lgm-sdxc-phy.yaml
> >>
> >> diff --git a/Documentation/devicetree/bindings/phy/intel,lgm-sdxc-phy.yaml
> >> b/Documentation/devicetree/bindings/phy/intel,lgm-sdxc-phy.yaml
> >> new file mode 100644
> >> index ..be05020880bf
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/phy/intel,lgm-sdxc-phy.yaml
> >> @@ -0,0 +1,50 @@
> >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> >> +%YAML 1.2
> >> +---
> >> +$id: http://devicetree.org/schemas/phy/intel,lgm-sdxc-phy.yaml#
> >> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> >> +
> >> +title: Intel Lightning Mountain(LGM) SDXC PHY Device Tree Bindings
> >> +
> >> +maintainers:
> >> + - Ramuthevar Vadivel Murugan
> >>
> >> +
> >> +description: Binding for SDXC PHY
> >> +
> >> +properties:
> >> + compatible:
> >> +const: intel,lgm-sdxc-phy
> >> +
> >> + intel,syscon:
> >> +description: phandle to the sdxc through syscon
> >> +$ref: '/schemas/types.yaml#/definitions/phandle'
> >> +
> >> + clocks:
> >> +maxItems: 1
> >> +
> >> + clock-names:
> >> +maxItems: 1
> >> +
> >> + "#phy-cells":
> >> +const: 0
> >> +
> >> +required:
> >> + - "#phy-cells"
> >> + - compatible
> >> + - intel,syscon
> >> + - clocks
> >> + - clock-names
> >> +
> >> +additionalProperties: false
> >> +
> >> +examples:
> >> + - |
> >> +sdxc_phy: sdxc_phy {
> >> +compatible = "intel,lgm-sdxc-phy";
> >> +intel,syscon = <&sysconf>;
> > Rather than a phandle, can this be a child node of sysconf? You need a
> > binding for sysconf first anyways.
> intel,syscon is phandle, emmc_phy is not child node of sysconf, access
> emmc_phy
> register over sysconf so made as reference here.
How do you access the emmc_phy registers? They are part of the sysconf
address space or the sysconf provides some sort of indirect register
access? In case of the former, then emmc_phy should be a child node.
That's actually fairly common.
Rob
Re: [PATCH v1 1/2] dt-bindings: phy: intel-sdxc-phy: Add YAML schema for LGM SDXC PHY
Hi Rob,
On 27/8/2019 8:39 PM, Rob Herring wrote:
On Tue, Aug 27, 2019 at 3:27 AM Ramuthevar,Vadivel MuruganX
wrote:
From: Ramuthevar Vadivel Murugan
Add a YAML schema to use the host controller driver with the
SDXC PHY on Intel's Lightning Mountain SoC.
Signed-off-by: Ramuthevar Vadivel Murugan
---
.../bindings/phy/intel,lgm-sdxc-phy.yaml | 50 ++
1 file changed, 50 insertions(+)
create mode 100644
Documentation/devicetree/bindings/phy/intel,lgm-sdxc-phy.yaml
diff --git a/Documentation/devicetree/bindings/phy/intel,lgm-sdxc-phy.yaml
b/Documentation/devicetree/bindings/phy/intel,lgm-sdxc-phy.yaml
new file mode 100644
index ..be05020880bf
--- /dev/null
+++ b/Documentation/devicetree/bindings/phy/intel,lgm-sdxc-phy.yaml
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/phy/intel,lgm-sdxc-phy.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Intel Lightning Mountain(LGM) SDXC PHY Device Tree Bindings
+
+maintainers:
+ - Ramuthevar Vadivel Murugan
+
+description: Binding for SDXC PHY
+
+properties:
+ compatible:
+const: intel,lgm-sdxc-phy
+
+ intel,syscon:
+description: phandle to the sdxc through syscon
+$ref: '/schemas/types.yaml#/definitions/phandle'
+
+ clocks:
+maxItems: 1
+
+ clock-names:
+maxItems: 1
+
+ "#phy-cells":
+const: 0
+
+required:
+ - "#phy-cells"
+ - compatible
+ - intel,syscon
+ - clocks
+ - clock-names
+
+additionalProperties: false
+
+examples:
+ - |
+sdxc_phy: sdxc_phy {
+compatible = "intel,lgm-sdxc-phy";
+intel,syscon = <&sysconf>;
Rather than a phandle, can this be a child node of sysconf? You need a
binding for sysconf first anyways.
intel,syscon is phandle, emmc_phy is not child node of sysconf, access
emmc_phy
register over sysconf so made as reference here.
Best Regards
Vadivel
+clocks = <&sdxc>;
+clock-names = "sdxcclk";
+#phy-cells = <0>;
+};
+
+...
--
2.11.0
Re: [PATCH v1 1/2] dt-bindings: phy: intel-sdxc-phy: Add YAML schema for LGM SDXC PHY
Hi Rob,
On 27/8/2019 8:39 PM, Rob Herring wrote:
On Tue, Aug 27, 2019 at 3:27 AM Ramuthevar,Vadivel MuruganX
wrote:
From: Ramuthevar Vadivel Murugan
Add a YAML schema to use the host controller driver with the
SDXC PHY on Intel's Lightning Mountain SoC.
Signed-off-by: Ramuthevar Vadivel Murugan
---
.../bindings/phy/intel,lgm-sdxc-phy.yaml | 50 ++
1 file changed, 50 insertions(+)
create mode 100644
Documentation/devicetree/bindings/phy/intel,lgm-sdxc-phy.yaml
diff --git a/Documentation/devicetree/bindings/phy/intel,lgm-sdxc-phy.yaml
b/Documentation/devicetree/bindings/phy/intel,lgm-sdxc-phy.yaml
new file mode 100644
index ..be05020880bf
--- /dev/null
+++ b/Documentation/devicetree/bindings/phy/intel,lgm-sdxc-phy.yaml
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/phy/intel,lgm-sdxc-phy.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Intel Lightning Mountain(LGM) SDXC PHY Device Tree Bindings
+
+maintainers:
+ - Ramuthevar Vadivel Murugan
+
+description: Binding for SDXC PHY
+
+properties:
+ compatible:
+const: intel,lgm-sdxc-phy
+
+ intel,syscon:
+description: phandle to the sdxc through syscon
+$ref: '/schemas/types.yaml#/definitions/phandle'
+
+ clocks:
+maxItems: 1
+
+ clock-names:
+maxItems: 1
+
+ "#phy-cells":
+const: 0
+
+required:
+ - "#phy-cells"
+ - compatible
+ - intel,syscon
+ - clocks
+ - clock-names
+
+additionalProperties: false
+
+examples:
+ - |
+sdxc_phy: sdxc_phy {
+compatible = "intel,lgm-sdxc-phy";
+intel,syscon = <&sysconf>;
Rather than a phandle, can this be a child node of sysconf? You need a
binding for sysconf first anyways.
Thanks a lot! for the review comments, fix it in next submit.
Best Regards
Vadivel
+clocks = <&sdxc>;
+clock-names = "sdxcclk";
+#phy-cells = <0>;
+};
+
+...
--
2.11.0
Re: [PATCH v1 1/2] dt-bindings: phy: intel-sdxc-phy: Add YAML schema for LGM SDXC PHY
On Tue, Aug 27, 2019 at 3:27 AM Ramuthevar,Vadivel MuruganX
wrote:
>
> From: Ramuthevar Vadivel Murugan
>
> Add a YAML schema to use the host controller driver with the
> SDXC PHY on Intel's Lightning Mountain SoC.
>
> Signed-off-by: Ramuthevar Vadivel Murugan
>
> ---
> .../bindings/phy/intel,lgm-sdxc-phy.yaml | 50
> ++
> 1 file changed, 50 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/phy/intel,lgm-sdxc-phy.yaml
>
> diff --git a/Documentation/devicetree/bindings/phy/intel,lgm-sdxc-phy.yaml
> b/Documentation/devicetree/bindings/phy/intel,lgm-sdxc-phy.yaml
> new file mode 100644
> index ..be05020880bf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/intel,lgm-sdxc-phy.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/intel,lgm-sdxc-phy.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Intel Lightning Mountain(LGM) SDXC PHY Device Tree Bindings
> +
> +maintainers:
> + - Ramuthevar Vadivel Murugan
> +
> +description: Binding for SDXC PHY
> +
> +properties:
> + compatible:
> +const: intel,lgm-sdxc-phy
> +
> + intel,syscon:
> +description: phandle to the sdxc through syscon
> +$ref: '/schemas/types.yaml#/definitions/phandle'
> +
> + clocks:
> +maxItems: 1
> +
> + clock-names:
> +maxItems: 1
> +
> + "#phy-cells":
> +const: 0
> +
> +required:
> + - "#phy-cells"
> + - compatible
> + - intel,syscon
> + - clocks
> + - clock-names
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> +sdxc_phy: sdxc_phy {
> +compatible = "intel,lgm-sdxc-phy";
> +intel,syscon = <&sysconf>;
Rather than a phandle, can this be a child node of sysconf? You need a
binding for sysconf first anyways.
> +clocks = <&sdxc>;
> +clock-names = "sdxcclk";
> +#phy-cells = <0>;
> +};
> +
> +...
> --
> 2.11.0
>
