Re: [PATCH v1 1/2] net: phy: Add 100 base-x mode
On Mon, 2021-01-11 at 20:37 +0100, Michał Mirosław wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > pon., 11 sty 2021 o 14:54 Bjarni Jonasson > napisał(a): > > Sparx-5 supports this mode and it is missing in the PHY core. > > > > Signed-off-by: Bjarni Jonasson > > --- > > include/linux/phy.h | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/include/linux/phy.h b/include/linux/phy.h > > index 56563e5e0dc7..dce867222d58 100644 > > --- a/include/linux/phy.h > > +++ b/include/linux/phy.h > > @@ -111,6 +111,7 @@ extern const int phy_10gbit_features_array[1]; > > * @PHY_INTERFACE_MODE_10GBASER: 10G BaseR > > * @PHY_INTERFACE_MODE_USXGMII: Universal Serial 10GE MII > > * @PHY_INTERFACE_MODE_10GKR: 10GBASE-KR - with Clause 73 AN > > + * @PHY_INTERFACE_MODE_100BASEX: 100 BaseX > > * @PHY_INTERFACE_MODE_MAX: Book keeping > > [...] > > This is kernel-internal interface, so maybe the new mode can be > inserted before 1000baseX for easier lookup? > > Best Regards > Michał Mirosław Yes, will do that. -- Bjarni Jonasson Microchip
Re: [PATCH v1 1/2] net: phy: Add 100 base-x mode
On Mon, 2021-01-11 at 16:47 +, Russell King - ARM Linux admin wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > On Mon, Jan 11, 2021 at 02:06:56PM +0100, Bjarni Jonasson wrote: > > Sparx-5 supports this mode and it is missing in the PHY core. > > > > Signed-off-by: Bjarni Jonasson > > Oh, I forgot - please can we have the new PHY mode documented in > Documentation/networking/phy.rst under the "PHY interface modes" > section. Thanks. > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! Will do that. -- Bjarni Jonasson
Re: [PATCH v1 1/2] net: phy: Add 100 base-x mode
pon., 11 sty 2021 o 14:54 Bjarni Jonasson napisał(a): > Sparx-5 supports this mode and it is missing in the PHY core. > > Signed-off-by: Bjarni Jonasson > --- > include/linux/phy.h | 4 > 1 file changed, 4 insertions(+) > > diff --git a/include/linux/phy.h b/include/linux/phy.h > index 56563e5e0dc7..dce867222d58 100644 > --- a/include/linux/phy.h > +++ b/include/linux/phy.h > @@ -111,6 +111,7 @@ extern const int phy_10gbit_features_array[1]; > * @PHY_INTERFACE_MODE_10GBASER: 10G BaseR > * @PHY_INTERFACE_MODE_USXGMII: Universal Serial 10GE MII > * @PHY_INTERFACE_MODE_10GKR: 10GBASE-KR - with Clause 73 AN > + * @PHY_INTERFACE_MODE_100BASEX: 100 BaseX > * @PHY_INTERFACE_MODE_MAX: Book keeping [...] This is kernel-internal interface, so maybe the new mode can be inserted before 1000baseX for easier lookup? Best Regards Michał Mirosław
Re: [PATCH v1 1/2] net: phy: Add 100 base-x mode
On Mon, Jan 11, 2021 at 02:06:56PM +0100, Bjarni Jonasson wrote: > Sparx-5 supports this mode and it is missing in the PHY core. > > Signed-off-by: Bjarni Jonasson Oh, I forgot - please can we have the new PHY mode documented in Documentation/networking/phy.rst under the "PHY interface modes" section. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
Re: [PATCH v1 1/2] net: phy: Add 100 base-x mode
On Mon, Jan 11, 2021 at 02:06:56PM +0100, Bjarni Jonasson wrote: > Sparx-5 supports this mode and it is missing in the PHY core. > > Signed-off-by: Bjarni Jonasson Reviewed-by: Andrew Lunn Andrew
Re: [PATCH v1 1/2] net: phy: Add 100 base-x mode
On Mon, Jan 11, 2021 at 02:06:56PM +0100, Bjarni Jonasson wrote:
> Sparx-5 supports this mode and it is missing in the PHY core.
>
> Signed-off-by: Bjarni Jonasson
Looks good, thanks.
Reviewed-by: Russell King
> ---
> include/linux/phy.h | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index 56563e5e0dc7..dce867222d58 100644
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
> @@ -111,6 +111,7 @@ extern const int phy_10gbit_features_array[1];
> * @PHY_INTERFACE_MODE_10GBASER: 10G BaseR
> * @PHY_INTERFACE_MODE_USXGMII: Universal Serial 10GE MII
> * @PHY_INTERFACE_MODE_10GKR: 10GBASE-KR - with Clause 73 AN
> + * @PHY_INTERFACE_MODE_100BASEX: 100 BaseX
> * @PHY_INTERFACE_MODE_MAX: Book keeping
> *
> * Describes the interface between the MAC and PHY.
> @@ -144,6 +145,7 @@ typedef enum {
> PHY_INTERFACE_MODE_USXGMII,
> /* 10GBASE-KR - with Clause 73 AN */
> PHY_INTERFACE_MODE_10GKR,
> + PHY_INTERFACE_MODE_100BASEX,
> PHY_INTERFACE_MODE_MAX,
> } phy_interface_t;
>
> @@ -217,6 +219,8 @@ static inline const char *phy_modes(phy_interface_t
> interface)
> return "usxgmii";
> case PHY_INTERFACE_MODE_10GKR:
> return "10gbase-kr";
> + case PHY_INTERFACE_MODE_100BASEX:
> + return "100base-x";
> default:
> return "unknown";
> }
> --
> 2.17.1
>
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
