Re: [PATCH v13 2/6] seq_buf: Export seq_buf_printf
On Mon, 15 Jun 2020 14:55:52 +0200 Borislav Petkov wrote: > Can you please resend your patchset once a week like everyone else and > not flood inboxes with it? Boris, Haven't you automated your inbox yet? I have patchwork reading my INBOX and it's smart enough to understand new series, and the old one simply disappears as "superseded". Email is just the wires to our infrastructure. Get with the times man! ;-) -- Steve
Re: [PATCH v13 2/6] seq_buf: Export seq_buf_printf
On Mon, Jun 15, 2020 at 5:56 AM Borislav Petkov wrote: > > On Mon, Jun 15, 2020 at 06:14:03PM +0530, Vaibhav Jain wrote: > > 'seq_buf' provides a very useful abstraction for writing to a string > > buffer without needing to worry about it over-flowing. However even > > though the API has been stable for couple of years now its still not > > exported to kernel loadable modules limiting its usage. > > > > Hence this patch proposes update to 'seq_buf.c' to mark > > seq_buf_printf() which is part of the seq_buf API to be exported to > > kernel loadable GPL modules. This symbol will be used in later parts > > of this patch-set to simplify content creation for a sysfs attribute. > > > > Cc: Piotr Maziarz > > Cc: Cezary Rojewski > > Cc: Christoph Hellwig > > Cc: Steven Rostedt > > Cc: Borislav Petkov > > Acked-by: Steven Rostedt (VMware) > > Signed-off-by: Vaibhav Jain > > --- > > Changelog: > > > > v12..v13: > > * None > > > > v11..v12: > > * None > > Can you please resend your patchset once a week like everyone else and > not flood inboxes with it? Hi Boris, I gave Vaibhav some long shot hope that his series could be included in my libnvdimm pull request for -rc1. Save for a last minute clang report that I misread as a gcc warning, I likely would have included. This spin is looking to address the last of the comments I had and something I would consider for -rc2. So, in this case the resends were requested by me and I'll take the grumbles on Vaibhav's behalf.
Re: [PATCH v13 2/6] seq_buf: Export seq_buf_printf
On Mon, Jun 15, 2020 at 06:14:03PM +0530, Vaibhav Jain wrote: > 'seq_buf' provides a very useful abstraction for writing to a string > buffer without needing to worry about it over-flowing. However even > though the API has been stable for couple of years now its still not > exported to kernel loadable modules limiting its usage. > > Hence this patch proposes update to 'seq_buf.c' to mark > seq_buf_printf() which is part of the seq_buf API to be exported to > kernel loadable GPL modules. This symbol will be used in later parts > of this patch-set to simplify content creation for a sysfs attribute. > > Cc: Piotr Maziarz > Cc: Cezary Rojewski > Cc: Christoph Hellwig > Cc: Steven Rostedt > Cc: Borislav Petkov > Acked-by: Steven Rostedt (VMware) > Signed-off-by: Vaibhav Jain > --- > Changelog: > > v12..v13: > * None > > v11..v12: > * None Can you please resend your patchset once a week like everyone else and not flood inboxes with it? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette
