Re: [PATCH v2] platform/chrome: cros_ec_typec: Fix call to typec_partner_set_pd_revision
On Tue, Feb 02, 2021 at 07:30:06PM +0100, Greg KH wrote:
> On Tue, Feb 02, 2021 at 09:52:13AM -0800, Benson Leung wrote:
> > Hi Greg,
> >
> > On Tue, Feb 2, 2021 at 9:02 AM Greg KH wrote:
> > >
> > > On Tue, Feb 02, 2021 at 08:45:31AM -0800, Benson Leung wrote:
> > > > typec_partner_set_pd_revision returns void now.
> > > >
> > > > Fixes: cefc011f8daf ("platform/chrome: cros_ec_typec: Set Partner PD
> > > > revision from status")
> > > > Signed-off-by: Benson Leung
> > > > ---
> > > > drivers/platform/chrome/cros_ec_typec.c | 6 +-
> > > > 1 file changed, 1 insertion(+), 5 deletions(-)
> > >
> > > What changed from "v1"?
> > >
> >
> > Just the "Fixes" line in the commit message.
>
> That should always go below the --- line, remember, some of us deal with
> hundreds of patches a day :)
>
> I'll go take this...
Thanks so much, Greg!
Benson
>
> thanks,
>
> greg k-h
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.asc
Description: PGP signature
Re: [PATCH v2] platform/chrome: cros_ec_typec: Fix call to typec_partner_set_pd_revision
On Tue, Feb 02, 2021 at 09:52:13AM -0800, Benson Leung wrote:
> Hi Greg,
>
> On Tue, Feb 2, 2021 at 9:02 AM Greg KH wrote:
> >
> > On Tue, Feb 02, 2021 at 08:45:31AM -0800, Benson Leung wrote:
> > > typec_partner_set_pd_revision returns void now.
> > >
> > > Fixes: cefc011f8daf ("platform/chrome: cros_ec_typec: Set Partner PD
> > > revision from status")
> > > Signed-off-by: Benson Leung
> > > ---
> > > drivers/platform/chrome/cros_ec_typec.c | 6 +-
> > > 1 file changed, 1 insertion(+), 5 deletions(-)
> >
> > What changed from "v1"?
> >
>
> Just the "Fixes" line in the commit message.
That should always go below the --- line, remember, some of us deal with
hundreds of patches a day :)
I'll go take this...
thanks,
greg k-h
Re: [PATCH v2] platform/chrome: cros_ec_typec: Fix call to typec_partner_set_pd_revision
Hi Greg,
On Tue, Feb 2, 2021 at 9:02 AM Greg KH wrote:
>
> On Tue, Feb 02, 2021 at 08:45:31AM -0800, Benson Leung wrote:
> > typec_partner_set_pd_revision returns void now.
> >
> > Fixes: cefc011f8daf ("platform/chrome: cros_ec_typec: Set Partner PD
> > revision from status")
> > Signed-off-by: Benson Leung
> > ---
> > drivers/platform/chrome/cros_ec_typec.c | 6 +-
> > 1 file changed, 1 insertion(+), 5 deletions(-)
>
> What changed from "v1"?
>
Just the "Fixes" line in the commit message.
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
Re: [PATCH v2] platform/chrome: cros_ec_typec: Fix call to typec_partner_set_pd_revision
On Tue, Feb 02, 2021 at 08:45:31AM -0800, Benson Leung wrote:
> typec_partner_set_pd_revision returns void now.
>
> Fixes: cefc011f8daf ("platform/chrome: cros_ec_typec: Set Partner PD revision
> from status")
> Signed-off-by: Benson Leung
> ---
> drivers/platform/chrome/cros_ec_typec.c | 6 +-
> 1 file changed, 1 insertion(+), 5 deletions(-)
What changed from "v1"?
