Re: [PATCH v2] staging: olpc_dcon: olpc_dcon_xo_1.c: Switch to the gpio descriptor interface
Hi Nishad,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.19 next-20181102]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Nishad-Kamdar/staging-olpc_dcon-olpc_dcon_xo_1-c-Switch-to-the-gpio-descriptor-interface/20181104-041335
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All error/warnings (new ones prefixed by >>):
>> drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:23:2: error: expected identifier
>> before numeric constant
DCON_IRQ,
^
drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:34:50: error: 'GPIO_ASIS'
undeclared here (not in a function); did you mean 'GPIOD_ASIS'?
[DCON_STAT0] = { .name = "dcon_stat0", .flags = GPIO_ASIS },
^
GPIOD_ASIS
drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:37:3: error: 'DCON_LOAD'
undeclared here (not in a function); did you mean 'DCON_STAT1'?
[DCON_LOAD] = { .name = "dcon_load", .flags = GPIO_ASIS },
^
DCON_STAT1
drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:37:3: error: array index in
initializer not of integer type
drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:37:3: note: (near initialization
for 'gpios_asis')
drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:38:3: error: 'DCON_BLANK'
undeclared here (not in a function); did you mean 'DCON_LOAD'?
[DCON_BLANK] = { .name = "dcon_blank", .flag = GPIO_ASIS },
^~
DCON_LOAD
drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:38:3: error: array index in
initializer not of integer type
drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:38:3: note: (near initialization
for 'gpios_asis')
drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:38:42: error: 'const struct
dcon_gpio' has no member named 'flag'; did you mean 'flags'?
[DCON_BLANK] = { .name = "dcon_blank", .flag = GPIO_ASIS },
^~~~
flags
drivers/staging//olpc_dcon/olpc_dcon_xo_1.c: In function 'dcon_init_xo_1':
drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:47:26: warning: initialization
discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
struct dcon_gpio *pin = _asis[0];
^
drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:50:42: error: dereferencing
pointer to incomplete type 'struct i2c_client'
gpios[i] = devm_gpiod_get(>client->dev, pin[i]->name,
^~
drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:50:42: error: request for member
'dev' in something not a structure or union
drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:50:55: error: invalid type
argument of '->' (have 'struct dcon_gpio')
gpios[i] = devm_gpiod_get(>client->dev, pin[i]->name,
^~
drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:50:55: error: request for member
'name' in something not a structure or union
drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:51:14: error: invalid type
argument of '->' (have 'struct dcon_gpio')
pin[i]->flags);
^~
drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:51:14: error: request for member
'flags' in something not a structure or union
drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:50:29: error: passing argument 1
of 'devm_gpiod_get' from incompatible pointer type
[-Werror=incompatible-pointer-types]
gpios[i] = devm_gpiod_get(>client->dev, pin[i]->name,
^
In file included from drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:14:0:
include/linux/gpio/consumer.h:87:55: note: expected 'struct device *' but
argument is of type 'const struct dcon_gpio (*)[1]'
struct gpio_desc *__must_check devm_gpiod_get(struct device *dev,
^~~
drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:50:49: error: passing argument 2
of 'devm_gpiod_get' from incompatible pointer type
[-Werror=incompatible-pointer-types]
gpios[i] = devm_gpiod_get(>client->dev, pin[i]->name,
^~~
In file included from drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:14:0:
include/linux/gpio/consumer.h:87:55: note: expected 'const char *' but
argument is of type 'const struct dcon_gpio *'
struct gpio_desc *__must_check devm_gpiod_get(struct device *dev,
^~~
drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:51:8: error: incompatible type
for argument 3 of 'devm_gpiod_get'
pin[i]->flags);
Re: [PATCH v2] staging: olpc_dcon: olpc_dcon_xo_1.c: Switch to the gpio descriptor interface
Hi Nishad,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.19 next-20181102]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Nishad-Kamdar/staging-olpc_dcon-olpc_dcon_xo_1-c-Switch-to-the-gpio-descriptor-interface/20181104-041335
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All error/warnings (new ones prefixed by >>):
>> drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:23:2: error: expected identifier
>> before numeric constant
DCON_IRQ,
^
drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:34:50: error: 'GPIO_ASIS'
undeclared here (not in a function); did you mean 'GPIOD_ASIS'?
[DCON_STAT0] = { .name = "dcon_stat0", .flags = GPIO_ASIS },
^
GPIOD_ASIS
drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:37:3: error: 'DCON_LOAD'
undeclared here (not in a function); did you mean 'DCON_STAT1'?
[DCON_LOAD] = { .name = "dcon_load", .flags = GPIO_ASIS },
^
DCON_STAT1
drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:37:3: error: array index in
initializer not of integer type
drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:37:3: note: (near initialization
for 'gpios_asis')
drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:38:3: error: 'DCON_BLANK'
undeclared here (not in a function); did you mean 'DCON_LOAD'?
[DCON_BLANK] = { .name = "dcon_blank", .flag = GPIO_ASIS },
^~
DCON_LOAD
drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:38:3: error: array index in
initializer not of integer type
drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:38:3: note: (near initialization
for 'gpios_asis')
drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:38:42: error: 'const struct
dcon_gpio' has no member named 'flag'; did you mean 'flags'?
[DCON_BLANK] = { .name = "dcon_blank", .flag = GPIO_ASIS },
^~~~
flags
drivers/staging//olpc_dcon/olpc_dcon_xo_1.c: In function 'dcon_init_xo_1':
drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:47:26: warning: initialization
discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
struct dcon_gpio *pin = _asis[0];
^
drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:50:42: error: dereferencing
pointer to incomplete type 'struct i2c_client'
gpios[i] = devm_gpiod_get(>client->dev, pin[i]->name,
^~
drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:50:42: error: request for member
'dev' in something not a structure or union
drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:50:55: error: invalid type
argument of '->' (have 'struct dcon_gpio')
gpios[i] = devm_gpiod_get(>client->dev, pin[i]->name,
^~
drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:50:55: error: request for member
'name' in something not a structure or union
drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:51:14: error: invalid type
argument of '->' (have 'struct dcon_gpio')
pin[i]->flags);
^~
drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:51:14: error: request for member
'flags' in something not a structure or union
drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:50:29: error: passing argument 1
of 'devm_gpiod_get' from incompatible pointer type
[-Werror=incompatible-pointer-types]
gpios[i] = devm_gpiod_get(>client->dev, pin[i]->name,
^
In file included from drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:14:0:
include/linux/gpio/consumer.h:87:55: note: expected 'struct device *' but
argument is of type 'const struct dcon_gpio (*)[1]'
struct gpio_desc *__must_check devm_gpiod_get(struct device *dev,
^~~
drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:50:49: error: passing argument 2
of 'devm_gpiod_get' from incompatible pointer type
[-Werror=incompatible-pointer-types]
gpios[i] = devm_gpiod_get(>client->dev, pin[i]->name,
^~~
In file included from drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:14:0:
include/linux/gpio/consumer.h:87:55: note: expected 'const char *' but
argument is of type 'const struct dcon_gpio *'
struct gpio_desc *__must_check devm_gpiod_get(struct device *dev,
^~~
drivers/staging//olpc_dcon/olpc_dcon_xo_1.c:51:8: error: incompatible type
for argument 3 of 'devm_gpiod_get'
pin[i]->flags);
Re: [PATCH v2] staging: olpc_dcon: olpc_dcon_xo_1.c: Switch to the gpio descriptor interface
Hi Nishad,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.19 next-20181102]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Nishad-Kamdar/staging-olpc_dcon-olpc_dcon_xo_1-c-Switch-to-the-gpio-descriptor-interface/20181104-041335
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All error/warnings (new ones prefixed by >>):
In file included from drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:18:0:
>> drivers/staging/olpc_dcon/olpc_dcon.h:58:33: error: expected identifier
>> before numeric constant
#define DCON_IRQ6
^
>> drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:23:2: note: in expansion of macro
>> 'DCON_IRQ'
DCON_IRQ,
^~~~
>> drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:34:50: error: 'GPIO_ASIS'
>> undeclared here (not in a function); did you mean 'GPIOD_ASIS'?
[DCON_STAT0] = { .name = "dcon_stat0", .flags = GPIO_ASIS },
^
GPIOD_ASIS
>> drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:37:3: error: 'DCON_LOAD'
>> undeclared here (not in a function); did you mean 'DCON_STAT1'?
[DCON_LOAD] = { .name = "dcon_load", .flags = GPIO_ASIS },
^
DCON_STAT1
>> drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:37:3: error: array index in
>> initializer not of integer type
drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:37:3: note: (near initialization
for 'gpios_asis')
>> drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:38:3: error: 'DCON_BLANK'
>> undeclared here (not in a function); did you mean 'DCON_LOAD'?
[DCON_BLANK] = { .name = "dcon_blank", .flag = GPIO_ASIS },
^~
DCON_LOAD
drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:38:3: error: array index in
initializer not of integer type
drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:38:3: note: (near initialization
for 'gpios_asis')
>> drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:38:42: error: 'const struct
>> dcon_gpio' has no member named 'flag'; did you mean 'flags'?
[DCON_BLANK] = { .name = "dcon_blank", .flag = GPIO_ASIS },
^~~~
flags
drivers/staging/olpc_dcon/olpc_dcon_xo_1.c: In function 'dcon_init_xo_1':
>> drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:47:26: warning: initialization
>> discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
struct dcon_gpio *pin = _asis[0];
^
>> drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:50:42: error: dereferencing
>> pointer to incomplete type 'struct i2c_client'
gpios[i] = devm_gpiod_get(>client->dev, pin[i]->name,
^~
>> drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:50:42: error: request for member
>> 'dev' in something not a structure or union
>> drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:50:55: error: invalid type
>> argument of '->' (have 'struct dcon_gpio')
gpios[i] = devm_gpiod_get(>client->dev, pin[i]->name,
^~
>> drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:50:55: error: request for member
>> 'name' in something not a structure or union
drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:51:14: error: invalid type
argument of '->' (have 'struct dcon_gpio')
pin[i]->flags);
^~
>> drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:51:14: error: request for member
>> 'flags' in something not a structure or union
>> drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:50:29: error: passing argument 1
>> of 'devm_gpiod_get' from incompatible pointer type
>> [-Werror=incompatible-pointer-types]
gpios[i] = devm_gpiod_get(>client->dev, pin[i]->name,
^
In file included from drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:14:0:
include/linux/gpio/consumer.h:87:32: note: expected 'struct device *' but
argument is of type 'const struct dcon_gpio (*)[1]'
struct gpio_desc *__must_check devm_gpiod_get(struct device *dev,
^~
drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:50:49: error: passing argument 2
of 'devm_gpiod_get' from incompatible pointer type
[-Werror=incompatible-pointer-types]
gpios[i] = devm_gpiod_get(>client->dev, pin[i]->name,
^~~
In file included from drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:14:0:
include/linux/gpio/consumer.h:87:32: note: expected 'const char *' but
argument is of type 'const struct dcon_gpio *'
struct gpio_desc *__must_check
Re: [PATCH v2] staging: olpc_dcon: olpc_dcon_xo_1.c: Switch to the gpio descriptor interface
Hi Nishad,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.19 next-20181102]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Nishad-Kamdar/staging-olpc_dcon-olpc_dcon_xo_1-c-Switch-to-the-gpio-descriptor-interface/20181104-041335
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All error/warnings (new ones prefixed by >>):
In file included from drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:18:0:
>> drivers/staging/olpc_dcon/olpc_dcon.h:58:33: error: expected identifier
>> before numeric constant
#define DCON_IRQ6
^
>> drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:23:2: note: in expansion of macro
>> 'DCON_IRQ'
DCON_IRQ,
^~~~
>> drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:34:50: error: 'GPIO_ASIS'
>> undeclared here (not in a function); did you mean 'GPIOD_ASIS'?
[DCON_STAT0] = { .name = "dcon_stat0", .flags = GPIO_ASIS },
^
GPIOD_ASIS
>> drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:37:3: error: 'DCON_LOAD'
>> undeclared here (not in a function); did you mean 'DCON_STAT1'?
[DCON_LOAD] = { .name = "dcon_load", .flags = GPIO_ASIS },
^
DCON_STAT1
>> drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:37:3: error: array index in
>> initializer not of integer type
drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:37:3: note: (near initialization
for 'gpios_asis')
>> drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:38:3: error: 'DCON_BLANK'
>> undeclared here (not in a function); did you mean 'DCON_LOAD'?
[DCON_BLANK] = { .name = "dcon_blank", .flag = GPIO_ASIS },
^~
DCON_LOAD
drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:38:3: error: array index in
initializer not of integer type
drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:38:3: note: (near initialization
for 'gpios_asis')
>> drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:38:42: error: 'const struct
>> dcon_gpio' has no member named 'flag'; did you mean 'flags'?
[DCON_BLANK] = { .name = "dcon_blank", .flag = GPIO_ASIS },
^~~~
flags
drivers/staging/olpc_dcon/olpc_dcon_xo_1.c: In function 'dcon_init_xo_1':
>> drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:47:26: warning: initialization
>> discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
struct dcon_gpio *pin = _asis[0];
^
>> drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:50:42: error: dereferencing
>> pointer to incomplete type 'struct i2c_client'
gpios[i] = devm_gpiod_get(>client->dev, pin[i]->name,
^~
>> drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:50:42: error: request for member
>> 'dev' in something not a structure or union
>> drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:50:55: error: invalid type
>> argument of '->' (have 'struct dcon_gpio')
gpios[i] = devm_gpiod_get(>client->dev, pin[i]->name,
^~
>> drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:50:55: error: request for member
>> 'name' in something not a structure or union
drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:51:14: error: invalid type
argument of '->' (have 'struct dcon_gpio')
pin[i]->flags);
^~
>> drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:51:14: error: request for member
>> 'flags' in something not a structure or union
>> drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:50:29: error: passing argument 1
>> of 'devm_gpiod_get' from incompatible pointer type
>> [-Werror=incompatible-pointer-types]
gpios[i] = devm_gpiod_get(>client->dev, pin[i]->name,
^
In file included from drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:14:0:
include/linux/gpio/consumer.h:87:32: note: expected 'struct device *' but
argument is of type 'const struct dcon_gpio (*)[1]'
struct gpio_desc *__must_check devm_gpiod_get(struct device *dev,
^~
drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:50:49: error: passing argument 2
of 'devm_gpiod_get' from incompatible pointer type
[-Werror=incompatible-pointer-types]
gpios[i] = devm_gpiod_get(>client->dev, pin[i]->name,
^~~
In file included from drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:14:0:
include/linux/gpio/consumer.h:87:32: note: expected 'const char *' but
argument is of type 'const struct dcon_gpio *'
struct gpio_desc *__must_check
