Re: [PATCH v2] staging: sbe-2t3e3: Remove code that will never execute
On Thu, Jul 12, 2012 at 11:27:49PM -0300, Marcos Paulo de Souza wrote: > This patch removes all references of "if 0" blocks in the sbe-2t3e3 driver. > > Signed-off-by: Marcos Paulo de Souza > --- > drivers/staging/sbe-2t3e3/2t3e3.h|3 -- > drivers/staging/sbe-2t3e3/cpld.c | 15 - > drivers/staging/sbe-2t3e3/ctrl.c | 19 +++ > drivers/staging/sbe-2t3e3/dc.c | 17 -- > drivers/staging/sbe-2t3e3/exar7250.c | 40 +++ > drivers/staging/sbe-2t3e3/exar7300.c | 17 -- > drivers/staging/sbe-2t3e3/intr.c | 60 > ++ > drivers/staging/sbe-2t3e3/io.c | 21 > 8 files changed, 10 insertions(+), 182 deletions(-) > > diff --git a/drivers/staging/sbe-2t3e3/2t3e3.h > b/drivers/staging/sbe-2t3e3/2t3e3.h > index fe9f086..383f2cf 100644 > --- a/drivers/staging/sbe-2t3e3/2t3e3.h > +++ b/drivers/staging/sbe-2t3e3/2t3e3.h > > Just fix the commit message fo sbr-2t3e3 to sbe-2t3e3. > > @@ -801,9 +801,6 @@ u32 cpld_read(struct channel *sc, u32 reg); Woah, what is that line in the middle of the patch here? That causes git to (rightfully) choke on the patch. Please fix this and resend. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2] staging: sbe-2t3e3: Remove code that will never execute
2012/7/13 Greg KH : > On Thu, Jul 12, 2012 at 11:27:49PM -0300, Marcos Paulo de Souza wrote: >> This patch removes all references of "if 0" blocks in the sbe-2t3e3 driver. >> >> Signed-off-by: Marcos Paulo de Souza >> --- >> drivers/staging/sbe-2t3e3/2t3e3.h|3 -- >> drivers/staging/sbe-2t3e3/cpld.c | 15 - >> drivers/staging/sbe-2t3e3/ctrl.c | 19 +++ >> drivers/staging/sbe-2t3e3/dc.c | 17 -- >> drivers/staging/sbe-2t3e3/exar7250.c | 40 +++ >> drivers/staging/sbe-2t3e3/exar7300.c | 17 -- >> drivers/staging/sbe-2t3e3/intr.c | 60 >> ++ >> drivers/staging/sbe-2t3e3/io.c | 21 >> 8 files changed, 10 insertions(+), 182 deletions(-) > > When sending out a v2 version of a patch (or any version after the > first), please detail what changed between them. The diffstat didn't > look different here, but the patch did. What happened? > > thanks, > > greg k-h Hi greg, I put some info between the commit message and the lines changed: "Just fix the commit message fo sbr-2t3e3 to sbe-2t3e3" So, looking at this now, I forgot to put a "Changes from v1" to identify what was changed. Thanks and sorry for that. -- Att, Marcos Paulo de Souza Acadêmico de Ciencia da Computação - FURB - SC "Uma vida sem desafios é uma vida sem razão" "A life without challenges, is a non reason life" -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2] staging: sbe-2t3e3: Remove code that will never execute
On Thu, Jul 12, 2012 at 11:27:49PM -0300, Marcos Paulo de Souza wrote: > This patch removes all references of "if 0" blocks in the sbe-2t3e3 driver. > > Signed-off-by: Marcos Paulo de Souza > --- > drivers/staging/sbe-2t3e3/2t3e3.h|3 -- > drivers/staging/sbe-2t3e3/cpld.c | 15 - > drivers/staging/sbe-2t3e3/ctrl.c | 19 +++ > drivers/staging/sbe-2t3e3/dc.c | 17 -- > drivers/staging/sbe-2t3e3/exar7250.c | 40 +++ > drivers/staging/sbe-2t3e3/exar7300.c | 17 -- > drivers/staging/sbe-2t3e3/intr.c | 60 > ++ > drivers/staging/sbe-2t3e3/io.c | 21 > 8 files changed, 10 insertions(+), 182 deletions(-) When sending out a v2 version of a patch (or any version after the first), please detail what changed between them. The diffstat didn't look different here, but the patch did. What happened? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
