Re: [PATCH v2 -next] platform/chrome: cros_ec: Make some symbols static
On 30/5/19 19:53, Benson Leung wrote:
> Hello YueHaibing,
>
> On Thu, May 30, 2019 at 04:49:32PM +0800, YueHaibing wrote:
>> Fix sparse warning:
>>
>> drivers/platform/chrome/cros_ec_debugfs.c:256:30: warning: symbol
>> 'cros_ec_console_log_fops' was not declared. Should it be static?
>> drivers/platform/chrome/cros_ec_debugfs.c:265:30: warning: symbol
>> 'cros_ec_pdinfo_fops' was not declared. Should it be static?
>> drivers/platform/chrome/cros_ec_lightbar.c:550:24: warning: symbol
>> 'cros_ec_lightbar_attr_group' was not declared. Should it be static?
>> drivers/platform/chrome/cros_ec_sysfs.c:338:24: warning: symbol
>> 'cros_ec_attr_group' was not declared. Should it be static?
>> drivers/platform/chrome/cros_ec_vbc.c:104:24: warning: symbol
>> 'cros_ec_vbc_attr_group' was not declared. Should it be static?
>> drivers/platform/chrome/cros_ec_lpc.c:408:25: warning: symbol
>> 'cros_ec_lpc_pm_ops' was not declared. Should it be static?
>>
>> Reported-by: Hulk Robot
>> Signed-off-by: YueHaibing
>
> Reviewed-by: Benson Leung
applied for 5.3
Thanks,
Enric
>
>> ---
>> v2: fix patch title
>> ---
>> drivers/platform/chrome/cros_ec_debugfs.c | 4 ++--
>> drivers/platform/chrome/cros_ec_lightbar.c | 2 +-
>> drivers/platform/chrome/cros_ec_lpc.c | 2 +-
>> drivers/platform/chrome/cros_ec_sysfs.c| 2 +-
>> drivers/platform/chrome/cros_ec_vbc.c | 2 +-
>> 5 files changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/platform/chrome/cros_ec_debugfs.c
>> b/drivers/platform/chrome/cros_ec_debugfs.c
>> index 4c2a27f6a6d0..4578eb3e0731 100644
>> --- a/drivers/platform/chrome/cros_ec_debugfs.c
>> +++ b/drivers/platform/chrome/cros_ec_debugfs.c
>> @@ -241,7 +241,7 @@ static ssize_t cros_ec_pdinfo_read(struct file *file,
>> read_buf, p - read_buf);
>> }
>>
>> -const struct file_operations cros_ec_console_log_fops = {
>> +static const struct file_operations cros_ec_console_log_fops = {
>> .owner = THIS_MODULE,
>> .open = cros_ec_console_log_open,
>> .read = cros_ec_console_log_read,
>> @@ -250,7 +250,7 @@ const struct file_operations cros_ec_console_log_fops = {
>> .release = cros_ec_console_log_release,
>> };
>>
>> -const struct file_operations cros_ec_pdinfo_fops = {
>> +static const struct file_operations cros_ec_pdinfo_fops = {
>> .owner = THIS_MODULE,
>> .open = simple_open,
>> .read = cros_ec_pdinfo_read,
>> diff --git a/drivers/platform/chrome/cros_ec_lightbar.c
>> b/drivers/platform/chrome/cros_ec_lightbar.c
>> index d30a6650b0b5..23a82ee4c785 100644
>> --- a/drivers/platform/chrome/cros_ec_lightbar.c
>> +++ b/drivers/platform/chrome/cros_ec_lightbar.c
>> @@ -547,7 +547,7 @@ static struct attribute *__lb_cmds_attrs[] = {
>> NULL,
>> };
>>
>> -struct attribute_group cros_ec_lightbar_attr_group = {
>> +static struct attribute_group cros_ec_lightbar_attr_group = {
>> .name = "lightbar",
>> .attrs = __lb_cmds_attrs,
>> };
>> diff --git a/drivers/platform/chrome/cros_ec_lpc.c
>> b/drivers/platform/chrome/cros_ec_lpc.c
>> index c9c240fbe7c6..aaa21803633a 100644
>> --- a/drivers/platform/chrome/cros_ec_lpc.c
>> +++ b/drivers/platform/chrome/cros_ec_lpc.c
>> @@ -405,7 +405,7 @@ static int cros_ec_lpc_resume(struct device *dev)
>> }
>> #endif
>>
>> -const struct dev_pm_ops cros_ec_lpc_pm_ops = {
>> +static const struct dev_pm_ops cros_ec_lpc_pm_ops = {
>> SET_LATE_SYSTEM_SLEEP_PM_OPS(cros_ec_lpc_suspend, cros_ec_lpc_resume)
>> };
>>
>> diff --git a/drivers/platform/chrome/cros_ec_sysfs.c
>> b/drivers/platform/chrome/cros_ec_sysfs.c
>> index fe0b7614ae1b..3edb237bf8ed 100644
>> --- a/drivers/platform/chrome/cros_ec_sysfs.c
>> +++ b/drivers/platform/chrome/cros_ec_sysfs.c
>> @@ -335,7 +335,7 @@ static umode_t cros_ec_ctrl_visible(struct kobject *kobj,
>> return a->mode;
>> }
>>
>> -struct attribute_group cros_ec_attr_group = {
>> +static struct attribute_group cros_ec_attr_group = {
>> .attrs = __ec_attrs,
>> .is_visible = cros_ec_ctrl_visible,
>> };
>> diff --git a/drivers/platform/chrome/cros_ec_vbc.c
>> b/drivers/platform/chrome/cros_ec_vbc.c
>> index 8392a1ec33a7..2aaefed87eb4 100644
>> --- a/drivers/platform/chrome/cros_ec_vbc.c
>> +++ b/drivers/platform/chrome/cros_ec_vbc.c
>> @@ -101,7 +101,7 @@ static struct bin_attribute *cros_ec_vbc_bin_attrs[] = {
>> NULL
>> };
>>
>> -struct attribute_group cros_ec_vbc_attr_group = {
>> +static struct attribute_group cros_ec_vbc_attr_group = {
>> .name = "vbc",
>> .bin_attrs = cros_ec_vbc_bin_attrs,
>> };
>> --
>> 2.17.1
>>
>>
>
Re: [PATCH v2 -next] platform/chrome: cros_ec: Make some symbols static
Hello YueHaibing,
On Thu, May 30, 2019 at 04:49:32PM +0800, YueHaibing wrote:
> Fix sparse warning:
>
> drivers/platform/chrome/cros_ec_debugfs.c:256:30: warning: symbol
> 'cros_ec_console_log_fops' was not declared. Should it be static?
> drivers/platform/chrome/cros_ec_debugfs.c:265:30: warning: symbol
> 'cros_ec_pdinfo_fops' was not declared. Should it be static?
> drivers/platform/chrome/cros_ec_lightbar.c:550:24: warning: symbol
> 'cros_ec_lightbar_attr_group' was not declared. Should it be static?
> drivers/platform/chrome/cros_ec_sysfs.c:338:24: warning: symbol
> 'cros_ec_attr_group' was not declared. Should it be static?
> drivers/platform/chrome/cros_ec_vbc.c:104:24: warning: symbol
> 'cros_ec_vbc_attr_group' was not declared. Should it be static?
> drivers/platform/chrome/cros_ec_lpc.c:408:25: warning: symbol
> 'cros_ec_lpc_pm_ops' was not declared. Should it be static?
>
> Reported-by: Hulk Robot
> Signed-off-by: YueHaibing
Reviewed-by: Benson Leung
> ---
> v2: fix patch title
> ---
> drivers/platform/chrome/cros_ec_debugfs.c | 4 ++--
> drivers/platform/chrome/cros_ec_lightbar.c | 2 +-
> drivers/platform/chrome/cros_ec_lpc.c | 2 +-
> drivers/platform/chrome/cros_ec_sysfs.c| 2 +-
> drivers/platform/chrome/cros_ec_vbc.c | 2 +-
> 5 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_debugfs.c
> b/drivers/platform/chrome/cros_ec_debugfs.c
> index 4c2a27f6a6d0..4578eb3e0731 100644
> --- a/drivers/platform/chrome/cros_ec_debugfs.c
> +++ b/drivers/platform/chrome/cros_ec_debugfs.c
> @@ -241,7 +241,7 @@ static ssize_t cros_ec_pdinfo_read(struct file *file,
> read_buf, p - read_buf);
> }
>
> -const struct file_operations cros_ec_console_log_fops = {
> +static const struct file_operations cros_ec_console_log_fops = {
> .owner = THIS_MODULE,
> .open = cros_ec_console_log_open,
> .read = cros_ec_console_log_read,
> @@ -250,7 +250,7 @@ const struct file_operations cros_ec_console_log_fops = {
> .release = cros_ec_console_log_release,
> };
>
> -const struct file_operations cros_ec_pdinfo_fops = {
> +static const struct file_operations cros_ec_pdinfo_fops = {
> .owner = THIS_MODULE,
> .open = simple_open,
> .read = cros_ec_pdinfo_read,
> diff --git a/drivers/platform/chrome/cros_ec_lightbar.c
> b/drivers/platform/chrome/cros_ec_lightbar.c
> index d30a6650b0b5..23a82ee4c785 100644
> --- a/drivers/platform/chrome/cros_ec_lightbar.c
> +++ b/drivers/platform/chrome/cros_ec_lightbar.c
> @@ -547,7 +547,7 @@ static struct attribute *__lb_cmds_attrs[] = {
> NULL,
> };
>
> -struct attribute_group cros_ec_lightbar_attr_group = {
> +static struct attribute_group cros_ec_lightbar_attr_group = {
> .name = "lightbar",
> .attrs = __lb_cmds_attrs,
> };
> diff --git a/drivers/platform/chrome/cros_ec_lpc.c
> b/drivers/platform/chrome/cros_ec_lpc.c
> index c9c240fbe7c6..aaa21803633a 100644
> --- a/drivers/platform/chrome/cros_ec_lpc.c
> +++ b/drivers/platform/chrome/cros_ec_lpc.c
> @@ -405,7 +405,7 @@ static int cros_ec_lpc_resume(struct device *dev)
> }
> #endif
>
> -const struct dev_pm_ops cros_ec_lpc_pm_ops = {
> +static const struct dev_pm_ops cros_ec_lpc_pm_ops = {
> SET_LATE_SYSTEM_SLEEP_PM_OPS(cros_ec_lpc_suspend, cros_ec_lpc_resume)
> };
>
> diff --git a/drivers/platform/chrome/cros_ec_sysfs.c
> b/drivers/platform/chrome/cros_ec_sysfs.c
> index fe0b7614ae1b..3edb237bf8ed 100644
> --- a/drivers/platform/chrome/cros_ec_sysfs.c
> +++ b/drivers/platform/chrome/cros_ec_sysfs.c
> @@ -335,7 +335,7 @@ static umode_t cros_ec_ctrl_visible(struct kobject *kobj,
> return a->mode;
> }
>
> -struct attribute_group cros_ec_attr_group = {
> +static struct attribute_group cros_ec_attr_group = {
> .attrs = __ec_attrs,
> .is_visible = cros_ec_ctrl_visible,
> };
> diff --git a/drivers/platform/chrome/cros_ec_vbc.c
> b/drivers/platform/chrome/cros_ec_vbc.c
> index 8392a1ec33a7..2aaefed87eb4 100644
> --- a/drivers/platform/chrome/cros_ec_vbc.c
> +++ b/drivers/platform/chrome/cros_ec_vbc.c
> @@ -101,7 +101,7 @@ static struct bin_attribute *cros_ec_vbc_bin_attrs[] = {
> NULL
> };
>
> -struct attribute_group cros_ec_vbc_attr_group = {
> +static struct attribute_group cros_ec_vbc_attr_group = {
> .name = "vbc",
> .bin_attrs = cros_ec_vbc_bin_attrs,
> };
> --
> 2.17.1
>
>
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.asc
Description: PGP signature
